René's URL Explorer Experiment

Title: Only look up package.json type if module is node16/nodenext or file is in node_modules by andrewbranch · Pull Request #58825 · microsoft/TypeScript · GitHub

Open Graph Title: Only look up package.json type if module is node16/nodenext or file is in node_modules by andrewbranch · Pull Request #58825 · microsoft/TypeScript

X Title: Only look up package.json type if module is node16/nodenext or file is in node_modules by andrewbranch · Pull Request #58825 · microsoft/TypeScript

Description: This walks back the heuristics added to non-Node.js module modes in #57896 a bit, based mostly on feedback in #58663. In 5.5-beta, an explicit package.json "type" or module-format-specific file extension started overriding "module": "commonjs" or "module": "esnext" in tsconfig.json. This impacted both type checking (relevant primarily for imports of node_modules dependencies, but with some effects on local files, e.g. with verbatimModuleSyntax) and emit (relevant for local project source files, if emit was enabled). The feedback in #58663 was that the effects on local files were unwelcome because the emitted files (whether from tsc or another tool) were going to be placed in some other context tsc didn’t know about, so the package.json tsc was finding during compilation shouldn’t be considered during the build. With this PR, we only look up package.json "type" if --module is node16/nodenext (as we’ve always done) or if the file is inside node_modules. Some testing and experimentation is still needed to ensure this doesn’t create inconsistencies with symlinked monorepos. This doesn’t seem to cause inconsistencies with workspaces-style monorepos, because module resolution takes the realpath of files in node_modules before we see if we need to look up a package.json "type". So in a project references example like . └── packages/ ├── app/ │ ├── node_modules/shared ↪︎ │ ├── tsconfig.json │ ├── package.json │ └── index.ts └── shared/ ├── dist/index.d.ts ├── src/index.ts ├── tsconfig.json └── package.json When we build shared/tsconfig.json, we decide that shared/src/index.ts is not inside node_modules. Then, when we build app/tsconfig.json, even though we resolve app/node_modules/shared/dist/index.d.ts, we realpath it to shared/dist/index.d.ts and count it as not inside node_modules. Having this consistency between input and output files regardless of how they’re resolved is what matters most. The caveat is that the realpath and project references logic can cause the type checking of app/tsconfig.json during development to behave differently than it would after publishing/deploying into a situation where app/node_modules/shared is no longer a symlink, but a real node_modules package. Fixes #54752 Fixes #50647

Open Graph Description: This walks back the heuristics added to non-Node.js module modes in #57896 a bit, based mostly on feedback in #58663. In 5.5-beta, an explicit package.json "type" or module-format-specifi...

X Description: This walks back the heuristics added to non-Node.js module modes in #57896 a bit, based mostly on feedback in #58663. In 5.5-beta, an explicit package.json "type" or module-format...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58825

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width