René's URL Explorer Experiment


Title: Correct regular expression flags scanning for non-BMP characters by graphemecluster · Pull Request #58612 · microsoft/TypeScript · GitHub

Open Graph Title: Correct regular expression flags scanning for non-BMP characters by graphemecluster · Pull Request #58612 · microsoft/TypeScript

X Title: Correct regular expression flags scanning for non-BMP characters by graphemecluster · Pull Request #58612 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Correct regular expression flags scanning for non-BMP characters by graphemecluster · Pull Request #58612 · microsoft/TypeScript

Open Graph Description: Per the IsValidRegularExpressionLiteral static semantics in the ECMA262 specification, FlagText should be interpreted in code points, not code units. Cherry picked from #58289@e67692a.

X Description: Per the IsValidRegularExpressionLiteral static semantics in the ECMA262 specification, FlagText should be interpreted in code points, not code units. Cherry picked from #58289@e67692a.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58612

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8dd2e0ed-2ec4-1bc1-418d-10c11def5975
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC188:3BAF11:3E6A757:57C528E:6A5FA574
html-safe-nonceb1805d67ef52cc0211259a77e1da99fb58259aafe76dd67f4ce5136d3d06c2a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTg4OjNCQUYxMTozRTZBNzU3OjU3QzUyOEU6NkE1RkE1NzQiLCJ2aXNpdG9yX2lkIjoiMjQ5NDU4OTI0NDM1NjQwNDU5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb2de5135e02b96a81d18676595d2e5117c536c0bd49bcb12b5e99b5cdc9fd306
hovercard-subject-tagpull_request:1881544437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58612/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58612
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58612
og:image:altPer the IsValidRegularExpressionLiteral static semantics in the ECMA262 specification, FlagText should be interpreted in code points, not code units. Cherry picked from #58289@e67692a.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegraphemecluster
hostnamegithub.com
expected-hostnamegithub.com
None9c6adf27e6bcb2e88a468dcb4a1332a66b2467588c9ff5b1e184c0efab40cdd9
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release95c4970ea4e0a52e841132721d7f22440b51fca9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/58612#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58612
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58612
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/58612
Reloadhttps://github.com/microsoft/TypeScript/pull/58612
Reloadhttps://github.com/microsoft/TypeScript/pull/58612
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 29 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
rbucktonhttps://github.com/rbuckton
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
graphemecluster:regex-non-bmp-flagshttps://github.com/graphemecluster/TypeScript/tree/regex-non-bmp-flags
Conversationhttps://github.com/microsoft/TypeScript/pull/58612
Commits5 (5)https://github.com/microsoft/TypeScript/pull/58612/commits
Checkshttps://github.com/microsoft/TypeScript/pull/58612/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/58612/files
Correct regular expression flags scanning for non-BMP charactershttps://github.com/microsoft/TypeScript/pull/58612#top
rbucktonhttps://github.com/rbuckton
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
graphemecluster:regex-non-bmp-flagshttps://github.com/graphemecluster/TypeScript/tree/regex-non-bmp-flags
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
May 22, 2024https://github.com/microsoft/TypeScript/pull/58612#issue-2309514658
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
IsValidRegularExpressionLiteralhttps://tc39.es/ecma262/#sec-isvalidregularexpressionliteral
FlagTexthttps://tc39.es/ecma262/#sec-static-semantics-flagtext
#58289@e67692ahttps://github.com/microsoft/TypeScript/pull/58289/commits/e67692acb3fdd068b4e577dc9ad9fa350f2e4ca8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
May 22, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2123818239
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
May 22, 2024https://github.com/microsoft/TypeScript/pull/58612#event-12887901038
https://github.com/graphemecluster
Correct flags scanning for non-BMP charactershttps://github.com/microsoft/TypeScript/pull/58612/commits/0725a3a74ebb92701db1942e07e988c34799121d
0725a3ahttps://github.com/microsoft/TypeScript/pull/58612/commits/0725a3a74ebb92701db1942e07e988c34799121d
e67692ahttps://github.com/graphemecluster/TypeScript/commit/e67692acb3fdd068b4e577dc9ad9fa350f2e4ca8
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
force-pushedhttps://github.com/microsoft/TypeScript/compare/ade740e09da36ca37258b0aaa4bcf89988a59080..0725a3a74ebb92701db1942e07e988c34799121d
ade740ehttps://github.com/microsoft/TypeScript/commit/ade740e09da36ca37258b0aaa4bcf89988a59080
0725a3ahttps://github.com/microsoft/TypeScript/commit/0725a3a74ebb92701db1942e07e988c34799121d
Compare https://github.com/microsoft/TypeScript/compare/ade740e09da36ca37258b0aaa4bcf89988a59080..0725a3a74ebb92701db1942e07e988c34799121d
May 22, 2024 04:16https://github.com/microsoft/TypeScript/pull/58612#event-12888020239
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
May 23, 2024 https://github.com/microsoft/TypeScript/pull/58612#ref-pullrequest-2257613817
Improve Recovery of Unterminated Regular Expressions #58289 https://github.com/microsoft/TypeScript/pull/58289
https://github.com/DanielRosenwasser
DanielRosenwasserhttps://github.com/DanielRosenwasser
rbucktonhttps://github.com/rbuckton
May 24, 2024 21:09https://github.com/microsoft/TypeScript/pull/58612#event-12929674853
graphemeclusterhttps://github.com/graphemecluster
May 31, 2024 00:57https://github.com/microsoft/TypeScript/pull/58612#commits-pushed-f91f83f
https://github.com/graphemecluster
Merge branch 'main' into regex-non-bmp-flagshttps://github.com/microsoft/TypeScript/pull/58612/commits/f91f83fe65f8704e291a0d60631d919812b6c6e9
f91f83fhttps://github.com/microsoft/TypeScript/pull/58612/commits/f91f83fe65f8704e291a0d60631d919812b6c6e9
https://github.com/graphemecluster
Optimization: Lookup by CharacterCodeshttps://github.com/microsoft/TypeScript/pull/58612/commits/406468ca6242f9f168c37de22b80351b1eed78b2
406468chttps://github.com/microsoft/TypeScript/pull/58612/commits/406468ca6242f9f168c37de22b80351b1eed78b2
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024 https://github.com/microsoft/TypeScript/pull/58612#pullrequestreview-2091048159
View reviewed changes https://github.com/microsoft/TypeScript/pull/58612/files/406468ca6242f9f168c37de22b80351b1eed78b2
tests/cases/compiler/regularExpressionWithNonBMPFlags.tshttps://github.com/microsoft/TypeScript/pull/58612/files/406468ca6242f9f168c37de22b80351b1eed78b2#diff-6bdf24620afc20703d58b8a96ca868977d13ba83a1b673086c4519aa4648e8db
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024 https://github.com/microsoft/TypeScript/pull/58612#pullrequestreview-2091321087
View reviewed changes https://github.com/microsoft/TypeScript/pull/58612/files
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2142660539
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024 https://github.com/microsoft/TypeScript/pull/58612#pullrequestreview-2091336789
View reviewed changes https://github.com/microsoft/TypeScript/pull/58612/files
rbucktonhttps://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/58612#pullrequestreview-2091336789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/rbuckton
https://github.com/graphemecluster
Add remarks to test case filehttps://github.com/microsoft/TypeScript/pull/58612/commits/723b1d68c6c7409ddac5a9267efee9089324d283
723b1d6https://github.com/microsoft/TypeScript/pull/58612/commits/723b1d68c6c7409ddac5a9267efee9089324d283
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
force-pushedhttps://github.com/microsoft/TypeScript/compare/fc3dd5822a85b550070ebbaa3a6a5571aa06f5bf..723b1d68c6c7409ddac5a9267efee9089324d283
fc3dd58https://github.com/microsoft/TypeScript/commit/fc3dd5822a85b550070ebbaa3a6a5571aa06f5bf
723b1d6https://github.com/microsoft/TypeScript/commit/723b1d68c6c7409ddac5a9267efee9089324d283
Compare https://github.com/microsoft/TypeScript/compare/fc3dd5822a85b550070ebbaa3a6a5571aa06f5bf..723b1d68c6c7409ddac5a9267efee9089324d283
May 31, 2024 18:06https://github.com/microsoft/TypeScript/pull/58612#event-13004203238
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
May 31, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2142762577
#58289https://github.com/microsoft/TypeScript/pull/58289
#58615https://github.com/microsoft/TypeScript/pull/58615
#58613https://github.com/microsoft/TypeScript/pull/58613
#55600https://github.com/microsoft/TypeScript/pull/55600
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2142837793
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
#58289https://github.com/microsoft/TypeScript/pull/58289
#58615https://github.com/microsoft/TypeScript/pull/58615
#58613https://github.com/microsoft/TypeScript/pull/58613
#55600https://github.com/microsoft/TypeScript/pull/55600
#58613https://github.com/microsoft/TypeScript/pull/58613
#58615https://github.com/microsoft/TypeScript/pull/58615
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/graphemecluster
graphemeclusterhttps://github.com/graphemecluster
May 31, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2142877189
This linehttps://github.com/microsoft/TypeScript/pull/58289/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R2521
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
May 31, 2024https://github.com/microsoft/TypeScript/pull/58612#issuecomment-2142891163
This linehttps://github.com/microsoft/TypeScript/pull/58289/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R2521
#58727https://github.com/microsoft/TypeScript/pull/58727
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/graphemecluster
Merge branch 'main' into regex-non-bmp-flagshttps://github.com/microsoft/TypeScript/pull/58612/commits/15783d6bd1229d6614aca5f045ca052064e53ed9
15783d6https://github.com/microsoft/TypeScript/pull/58612/commits/15783d6bd1229d6614aca5f045ca052064e53ed9
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
TypeScript 5.6.0https://github.com/microsoft/TypeScript/milestone/199
Jun 4, 2024https://github.com/microsoft/TypeScript/pull/58612#event-13041671196
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Jun 4, 2024 https://github.com/microsoft/TypeScript/pull/58612#pullrequestreview-2097354715
View reviewed changes https://github.com/microsoft/TypeScript/pull/58612/files/15783d6bd1229d6614aca5f045ca052064e53ed9
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
dc1ffb1https://github.com/microsoft/TypeScript/commit/dc1ffb16485383c439949cf76e229d9fbc43dd92
Jun 4, 2024https://github.com/microsoft/TypeScript/pull/58612#event-13041693729
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/58612#event-20323077187
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58612
https://github.com/rbuckton
rbuckton https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/58612/files/15783d6bd1229d6614aca5f045ca052064e53ed9
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
TypeScript 5.6.0 https://github.com/microsoft/TypeScript/milestone/199
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58612
https://github.com/graphemecluster
https://github.com/typescript-bot
https://github.com/rbuckton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.