René's URL Explorer Experiment


Title: Declaration emit should retain (instead of elide) unresolved computed names by weswigham · Pull Request #58428 · microsoft/TypeScript · GitHub

Open Graph Title: Declaration emit should retain (instead of elide) unresolved computed names by weswigham · Pull Request #58428 · microsoft/TypeScript

X Title: Declaration emit should retain (instead of elide) unresolved computed names by weswigham · Pull Request #58428 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Declaration emit should retain (instead of elide) unresolved computed names by weswigham · Pull Request #58428 · microsoft/TypeScript

Open Graph Description: Historically, if a [name]: whatever didn't resolve, it was elided in a declaration file, even when you wrote it explicitly in a type. This PR changes that behavior to instead copy the name into...

X Description: Historically, if a [name]: whatever didn't resolve, it was elided in a declaration file, even when you wrote it explicitly in a type. This PR changes that behavior to instead copy the name ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:012d5e7a-b456-c9c4-2725-433af3b4154f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4CC:2E5652:32BBD05:40ACDB8:6B01D8E8
html-safe-nonce1a5f10e46c1aa33517bb0cbb717c1c5c19b82d1b5d610bcefc83743bfaa79269
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNENDOjJFNTY1MjozMkJCRDA1OjQwQUNEQjg6NkIwMUQ4RTgiLCJ2aXNpdG9yX2lkIjoiNDUwMzA2ODUyMjA5OTg5MDQwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ba85ff6e265f4ea7004adc29af2fc710abda636c25947d82ca1a35e91f80667
hovercard-subject-tagpull_request:1853881326
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58428/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58428
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58428
og:image:altHistorically, if a [name]: whatever didn't resolve, it was elided in a declaration file, even when you wrote it explicitly in a type. This PR changes that behavior to instead copy the name into...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/58428#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58428
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58428
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/58428
Reloadhttps://github.com/microsoft/TypeScript/pull/58428
Reloadhttps://github.com/microsoft/TypeScript/pull/58428
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:transpile-declaration-preserve-computed-name-in-typehttps://github.com/weswigham/TypeScript/tree/transpile-declaration-preserve-computed-name-in-type
Conversationhttps://github.com/microsoft/TypeScript/pull/58428
Commits8 (8)https://github.com/microsoft/TypeScript/pull/58428/commits
Checkshttps://github.com/microsoft/TypeScript/pull/58428/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/58428/files
Declaration emit should retain (instead of elide) unresolved computed nameshttps://github.com/microsoft/TypeScript/pull/58428#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:transpile-declaration-preserve-computed-name-in-typehttps://github.com/weswigham/TypeScript/tree/transpile-declaration-preserve-computed-name-in-type
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2024https://github.com/microsoft/TypeScript/pull/58428#issue-2278172452
#58423https://github.com/microsoft/TypeScript/issues/58423
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/weswigham
Declaration emit should retain unresolved computed names instead of e…https://github.com/microsoft/TypeScript/pull/58428/commits/8d795343107f0c7f14c59f8eda5ba344ddd6d4bd
8d79534https://github.com/microsoft/TypeScript/pull/58428/commits/8d795343107f0c7f14c59f8eda5ba344ddd6d4bd
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2024https://github.com/microsoft/TypeScript/pull/58428#event-12699502449
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
May 3, 2024https://github.com/microsoft/TypeScript/pull/58428#event-12699502564
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2024 18:40https://github.com/microsoft/TypeScript/pull/58428#commits-pushed-869ef5a
https://github.com/typescript-bot
Update Baselines and/or Applied Lint Fixeshttps://github.com/microsoft/TypeScript/pull/58428/commits/869ef5a35378724d42a2e8f679a216cdc3d64b72
869ef5ahttps://github.com/microsoft/TypeScript/pull/58428/commits/869ef5a35378724d42a2e8f679a216cdc3d64b72
https://github.com/weswigham
Invert checkhttps://github.com/microsoft/TypeScript/pull/58428/commits/19375eee003db8c8dbbb5eda0908a5fd6a6e7615
19375eehttps://github.com/microsoft/TypeScript/pull/58428/commits/19375eee003db8c8dbbb5eda0908a5fd6a6e7615
https://github.com/weswigham
Revise asserthttps://github.com/microsoft/TypeScript/pull/58428/commits/328d7f0729ba08694f7ae2847fb14ab060fce03c
328d7f0https://github.com/microsoft/TypeScript/pull/58428/commits/328d7f0729ba08694f7ae2847fb14ab060fce03c
https://github.com/typescript-bot
Update Baselines and/or Applied Lint Fixeshttps://github.com/microsoft/TypeScript/pull/58428/commits/49cc279cd2d1a13ebb39c48d52dbe87e7b678ab9
49cc279https://github.com/microsoft/TypeScript/pull/58428/commits/49cc279cd2d1a13ebb39c48d52dbe87e7b678ab9
https://github.com/weswigham
Change giant.ts to have a resolvable [p] so declaration emit is not b…https://github.com/microsoft/TypeScript/pull/58428/commits/d59c6650d9f34c28be2294ab3340a6a28765ded5
d59c665https://github.com/microsoft/TypeScript/pull/58428/commits/d59c6650d9f34c28be2294ab3340a6a28765ded5
https://github.com/weswigham
Modify node builder to have the same unresolved computed name retaini…https://github.com/microsoft/TypeScript/pull/58428/commits/02b65ac096f520f2e6080e1dfdfaa8ac6165b264
02b65achttps://github.com/microsoft/TypeScript/pull/58428/commits/02b65ac096f520f2e6080e1dfdfaa8ac6165b264
https://github.com/typescript-bot
Update Baselines and/or Applied Lint Fixeshttps://github.com/microsoft/TypeScript/pull/58428/commits/a2d209e2ba66ef25fb5a8de2ed1bf930bace5550
a2d209ehttps://github.com/microsoft/TypeScript/pull/58428/commits/a2d209e2ba66ef25fb5a8de2ed1bf930bace5550
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 4, 2024 01:00https://github.com/microsoft/TypeScript/pull/58428#event-12702518635
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jake Bailey (jakebailey)https://github.com/jakebailey
May 4, 2024 01:00https://github.com/microsoft/TypeScript/pull/58428#event-12702519557
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 6, 2024https://github.com/microsoft/TypeScript/pull/58428#issuecomment-2097109849
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 7, 2024https://github.com/microsoft/TypeScript/pull/58428#issuecomment-2097142454
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 7, 2024https://github.com/microsoft/TypeScript/pull/58428#issuecomment-2097150982
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 7, 2024 https://github.com/microsoft/TypeScript/pull/58428#pullrequestreview-2041873630
View reviewed changes https://github.com/microsoft/TypeScript/pull/58428/files/a2d209e2ba66ef25fb5a8de2ed1bf930bace5550
Jake Bailey (jakebailey)https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/58428#pullrequestreview-2041873630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
0d3c481https://github.com/microsoft/TypeScript/commit/0d3c48109ddefd7810ace6dfda373fd153b9b53b
May 7, 2024https://github.com/microsoft/TypeScript/pull/58428#event-12728992025
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 7, 2024 12:42https://github.com/microsoft/TypeScript/pull/58428#event-12728993143
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 8, 2024 https://github.com/microsoft/TypeScript/pull/58428#ref-pullrequest-2286048806
Preserve type nodes which resolve to errors in declaration emit output #58475 https://github.com/microsoft/TypeScript/pull/58475
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/58428#event-20323077097
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58428
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/58428/files/a2d209e2ba66ef25fb5a8de2ed1bf930bace5550
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
[transpileDeclaration API][5.5] Type containing enum values is incorrectly emitted https://github.com/microsoft/TypeScript/issues/58423
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58428
https://github.com/weswigham
https://github.com/jakebailey
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.