| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:14ee511d-1f5d-e1e1-a1eb-b1f64e3cc72d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9098:13DA8D:14F2C9:1C85CF:6A62C4B6 |
| html-safe-nonce | 7f1da47a1da53d6fca73b59b362aa5934be08258878f2ced3d52637a5a2de8e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDk4OjEzREE4RDoxNEYyQzk6MUM4NUNGOjZBNjJDNEI2IiwidmlzaXRvcl9pZCI6IjYxNTU5NjE2NDYyOTU3MjkzMzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 522864d669346e4b71000036274dedfbcbee6b506cb811c6f59fa92f36d2be37 |
| hovercard-subject-tag | pull_request:1846659410 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/58366/files |
| twitter:image | https://avatars.githubusercontent.com/u/2932786?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2932786?s=400&v=4 |
| og:image:alt | This is one of the two bigger checker refactors in #58364 - by validating its' perf separately, I can narrow down the perf regression there (and possibly simplify merging it by getting this mer... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | df33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d41cd1bdb290013455c0ac430fa755621733f5eb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/58366/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58366%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58366%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/58366/files |
| Reload | https://github.com/microsoft/TypeScript/pull/58366/files |
| Reload | https://github.com/microsoft/TypeScript/pull/58366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58366/files |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
21
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| weswigham | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| weswigham:alias-marking-for-js-emit-refactor | https://github.com/weswigham/TypeScript/tree/alias-marking-for-js-emit-refactor |
|
Conversation
23
| https://github.com/microsoft/TypeScript/pull/58366 |
|
Commits
15
| https://github.com/microsoft/TypeScript/pull/58366/commits |
|
Checks
0
| https://github.com/microsoft/TypeScript/pull/58366/checks |
|
Files changed
| https://github.com/microsoft/TypeScript/pull/58366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58366/files |
|
Move all js emit alias marking behavior behind a single entrypoint
| https://github.com/microsoft/TypeScript/pull/58366/files#top |
|
Show all changes
15 commits
| https://github.com/microsoft/TypeScript/pull/58366/files |
|
003d816
Move all js emit alias marking behavior behind a single entrypoint
weswigham Apr 29, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/003d816d5f5700821d103679294b333ad2f65406 |
|
362ba1b
Move sub functions into outer closure to avoid unnecessary copying
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/362ba1ba391bf6adbbe35022d90a2089bf1ff5d2 |
|
0cfb443
Remove one checkExpression that we probably dont need
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/0cfb4431bb8b988cf50f6d24fc4856c7f874d82b |
|
e466071
Accept better baseline from reduced expression check, defer/reuse pro…
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/e466071585fbf5d6b4d1fb1d9f660aa59b7bf23c |
|
2fc3875
update comment
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/2fc387517e38149164f2fe27b7df0d4f11f7d79e |
|
e9db2d9
Merge branch 'main' into alias-marking-for-js-emit-refactor
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/e9db2d909771523d820b6d51cae6696873ca5088 |
|
143fabe
Hint the marking process so deep in the compiler context checks needn…
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/143fabe85a885af22db77f25508bebc947faa51a |
|
80aca4c
With hinting and the optional arg, this is probably cachable
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/80aca4c303cd51536cfc0f67cd9966da45359273 |
|
e0b2467
Reorder a bit
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/e0b2467ec3c91a97b62b637fe80d99c1d23a6bab |
|
87f5659
And this one
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/87f565981dd4c55876a0ea22cda2da3a1f59e508 |
|
94317f4
Use getResolvedSymbol since we know left is an Identifier
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/94317f43e5240c953820877536f7975a29743496 |
|
a0553b0
const and hoist
weswigham Apr 30, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/a0553b02f111e64100776350e70790be72027244 |
|
331d1f3
Add early bail on Ambient node flag
weswigham May 1, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/331d1f32fda414ae99dd7becd4989eab16335c7a |
|
25bca5a
Removal of another error from avoiding duplicate work we dont need
weswigham May 1, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/25bca5a03b22e411aba17ce9ee5af9393a0eb539 |
|
380ddf6
Another one
weswigham May 1, 2024
| https://github.com/microsoft/TypeScript/pull/58366/commits/380ddf6f7a731bce2de9a363c8cd5441384abe5e |
|
Clear filters
| https://github.com/microsoft/TypeScript/pull/58366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58366/files |
|
checker.ts
| https://github.com/microsoft/TypeScript/pull/58366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
|
importDeclWithDeclareModifier.errors.txt
| https://github.com/microsoft/TypeScript/pull/58366/files#diff-a1a9f3dab9d2319f702308bb25f6780294e8ef4f6104b55a1a09b12eeebf4131 |
|
moduleImport.errors.txt
| https://github.com/microsoft/TypeScript/pull/58366/files#diff-0b33cf275161609be8d89ecce8406ea23e991e895dd80b3291706ae0fe55e74f |
|
reexportedMissingAlias.errors.txt
| https://github.com/microsoft/TypeScript/pull/58366/files#diff-95b323f6526a08f32aa46517fcb40e3164942dd2df70aa1681d1547f8a56bcb5 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58366/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |