René's URL Explorer Experiment


Title: Move all js emit alias marking behavior behind a single entrypoint by weswigham · Pull Request #58366 · microsoft/TypeScript · GitHub

Open Graph Title: Move all js emit alias marking behavior behind a single entrypoint by weswigham · Pull Request #58366 · microsoft/TypeScript

X Title: Move all js emit alias marking behavior behind a single entrypoint by weswigham · Pull Request #58366 · microsoft/TypeScript

Description: This is one of the two bigger checker refactors in #58364 - by validating its' perf separately, I can narrow down the perf regression there (and possibly simplify merging it by getting this merged separately).

Open Graph Description: This is one of the two bigger checker refactors in #58364 - by validating its' perf separately, I can narrow down the perf regression there (and possibly simplify merging it by getting this mer...

X Description: This is one of the two bigger checker refactors in #58364 - by validating its' perf separately, I can narrow down the perf regression there (and possibly simplify merging it by getting this...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58366

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14ee511d-1f5d-e1e1-a1eb-b1f64e3cc72d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9098:13DA8D:14F2C9:1C85CF:6A62C4B6
html-safe-nonce7f1da47a1da53d6fca73b59b362aa5934be08258878f2ced3d52637a5a2de8e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDk4OjEzREE4RDoxNEYyQzk6MUM4NUNGOjZBNjJDNEI2IiwidmlzaXRvcl9pZCI6IjYxNTU5NjE2NDYyOTU3MjkzMzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac522864d669346e4b71000036274dedfbcbee6b506cb811c6f59fa92f36d2be37
hovercard-subject-tagpull_request:1846659410
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/58366/files
twitter:imagehttps://avatars.githubusercontent.com/u/2932786?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2932786?s=400&v=4
og:image:altThis is one of the two bigger checker refactors in #58364 - by validating its' perf separately, I can narrow down the perf regression there (and possibly simplify merging it by getting this mer...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedf33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released41cd1bdb290013455c0ac430fa755621733f5eb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/58366/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58366%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58366%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/58366/files
Reloadhttps://github.com/microsoft/TypeScript/pull/58366/files
Reloadhttps://github.com/microsoft/TypeScript/pull/58366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58366/files
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 21 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
weswighamhttps://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:alias-marking-for-js-emit-refactorhttps://github.com/weswigham/TypeScript/tree/alias-marking-for-js-emit-refactor
Conversation 23 https://github.com/microsoft/TypeScript/pull/58366
Commits 15 https://github.com/microsoft/TypeScript/pull/58366/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/58366/checks
Files changed https://github.com/microsoft/TypeScript/pull/58366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58366/files
Move all js emit alias marking behavior behind a single entrypoint https://github.com/microsoft/TypeScript/pull/58366/files#top
Show all changes 15 commits https://github.com/microsoft/TypeScript/pull/58366/files
003d816 Move all js emit alias marking behavior behind a single entrypoint weswigham Apr 29, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/003d816d5f5700821d103679294b333ad2f65406
362ba1b Move sub functions into outer closure to avoid unnecessary copying weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/362ba1ba391bf6adbbe35022d90a2089bf1ff5d2
0cfb443 Remove one checkExpression that we probably dont need weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/0cfb4431bb8b988cf50f6d24fc4856c7f874d82b
e466071 Accept better baseline from reduced expression check, defer/reuse pro… weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/e466071585fbf5d6b4d1fb1d9f660aa59b7bf23c
2fc3875 update comment weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/2fc387517e38149164f2fe27b7df0d4f11f7d79e
e9db2d9 Merge branch 'main' into alias-marking-for-js-emit-refactor weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/e9db2d909771523d820b6d51cae6696873ca5088
143fabe Hint the marking process so deep in the compiler context checks needn… weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/143fabe85a885af22db77f25508bebc947faa51a
80aca4c With hinting and the optional arg, this is probably cachable weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/80aca4c303cd51536cfc0f67cd9966da45359273
e0b2467 Reorder a bit weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/e0b2467ec3c91a97b62b637fe80d99c1d23a6bab
87f5659 And this one weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/87f565981dd4c55876a0ea22cda2da3a1f59e508
94317f4 Use getResolvedSymbol since we know left is an Identifier weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/94317f43e5240c953820877536f7975a29743496
a0553b0 const and hoist weswigham Apr 30, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/a0553b02f111e64100776350e70790be72027244
331d1f3 Add early bail on Ambient node flag weswigham May 1, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/331d1f32fda414ae99dd7becd4989eab16335c7a
25bca5a Removal of another error from avoiding duplicate work we dont need weswigham May 1, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/25bca5a03b22e411aba17ce9ee5af9393a0eb539
380ddf6 Another one weswigham May 1, 2024 https://github.com/microsoft/TypeScript/pull/58366/commits/380ddf6f7a731bce2de9a363c8cd5441384abe5e
Clear filters https://github.com/microsoft/TypeScript/pull/58366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58366/files
checker.ts https://github.com/microsoft/TypeScript/pull/58366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
importDeclWithDeclareModifier.errors.txt https://github.com/microsoft/TypeScript/pull/58366/files#diff-a1a9f3dab9d2319f702308bb25f6780294e8ef4f6104b55a1a09b12eeebf4131
moduleImport.errors.txt https://github.com/microsoft/TypeScript/pull/58366/files#diff-0b33cf275161609be8d89ecce8406ea23e991e895dd80b3291706ae0fe55e74f
reexportedMissingAlias.errors.txt https://github.com/microsoft/TypeScript/pull/58366/files#diff-95b323f6526a08f32aa46517fcb40e3164942dd2df70aa1681d1547f8a56bcb5
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58366/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.