| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3de73a71-b434-a5b0-c75f-e37fbbd3b624 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB48:363519:11E6836:1A1BB70:6A608FB8 |
| html-safe-nonce | 676abce89098c382f39c6112022647719cbb47f1112ed6fb79b3e72c42ec8653 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQ4OjM2MzUxOToxMUU2ODM2OjFBMUJCNzA6NkE2MDhGQjgiLCJ2aXNpdG9yX2lkIjoiNDAwNjczODkxNDQ5NzgyNjc0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 03aa2e9b2d8a5cd4f336860effb40d0a46f28fd2733e1b3894dc91c0c93b2fda |
| hovercard-subject-tag | pull_request:1841757448 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58320/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58320 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d327c21349ee0be92377833432c9809b27787a0824dc0030b575e8824e44a992/microsoft/TypeScript/pull/58320 |
| og:image:alt | Follow-up of #58295
This fixes issues like the '}' expected cases given at #58275 (comment). |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | graphemecluster |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0632c7929f76e8db538ffed06ab2fc4c524a012b0888e95d96928690fcc604d |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4f9009410bd92637ba907f71dc7f7af3f0df45aa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/58320#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58320 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58320 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/58320 |
| Reload | https://github.com/microsoft/TypeScript/pull/58320 |
| Reload | https://github.com/microsoft/TypeScript/pull/58320 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
30
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| rbuckton | https://github.com/rbuckton |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| graphemecluster:regex-syntax-check-annexB | https://github.com/graphemecluster/TypeScript/tree/regex-syntax-check-annexB |
| Conversation | https://github.com/microsoft/TypeScript/pull/58320 |
| Commits12 (12) | https://github.com/microsoft/TypeScript/pull/58320/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/58320/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/58320/files |
| Correct Regular Expressions Behavior Related to Annex B | https://github.com/microsoft/TypeScript/pull/58320#top |
| rbuckton | https://github.com/rbuckton |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| graphemecluster:regex-syntax-check-annexB | https://github.com/graphemecluster/TypeScript/tree/regex-syntax-check-annexB |
|
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Apr 25, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issue-2264547146 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| #58295 | https://github.com/microsoft/TypeScript/pull/58295 |
| #58275 (comment) | https://github.com/microsoft/TypeScript/issues/58275#issuecomment-2068174045 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Correct RegExp Behavior Related to Annex B | https://github.com/microsoft/TypeScript/pull/58320/commits/e04943898d938670eb2d71dbc49974b03851d449 |
| e049438 | https://github.com/microsoft/TypeScript/pull/58320/commits/e04943898d938670eb2d71dbc49974b03851d449 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Apr 25, 2024 | https://github.com/microsoft/TypeScript/pull/58320#event-12615878350 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Apr 25, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2078224396 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
Apr 25, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2023659668 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/e04943898d938670eb2d71dbc49974b03851d449 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/e04943898d938670eb2d71dbc49974b03851d449#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| graphemecluster | https://github.com/graphemecluster |
| Apr 25, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1580177296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #58275 (comment) | https://github.com/microsoft/TypeScript/issues/58275#issuecomment-2068174123 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| Apr 27, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1581763065 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| jakebailey | https://github.com/jakebailey |
| May 15, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1602255985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1607235239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Fix Comment | https://github.com/microsoft/TypeScript/pull/58320/commits/358eb301a2158e206b7b7c39d07608669fdf162a |
| 358eb30 | https://github.com/microsoft/TypeScript/pull/58320/commits/358eb301a2158e206b7b7c39d07608669fdf162a |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Apr 26, 2024 | https://github.com/microsoft/TypeScript/pull/58320#event-12616775671 |
| graphemecluster | https://github.com/graphemecluster |
| April 27, 2024 15:21 | https://github.com/microsoft/TypeScript/pull/58320#commits-pushed-8facb0a |
|
| https://github.com/graphemecluster |
| Correct Quantifiability of {1 in Annex B | https://github.com/microsoft/TypeScript/pull/58320/commits/8facb0a78691bc92e1bce34aec287037557b07f0 |
| 8facb0a | https://github.com/microsoft/TypeScript/pull/58320/commits/8facb0a78691bc92e1bce34aec287037557b07f0 |
|
| https://github.com/graphemecluster |
| \c is an Annex B thing | https://github.com/microsoft/TypeScript/pull/58320/commits/f5c0b60edef1216a1e50f75b6c0a62d9ec9d0c71 |
| f5c0b60 | https://github.com/microsoft/TypeScript/pull/58320/commits/f5c0b60edef1216a1e50f75b6c0a62d9ec9d0c71 |
|
| https://github.com/graphemecluster |
| Add Tests | https://github.com/microsoft/TypeScript/pull/58320/commits/cff993f22418041690c1236c163ddf04002a2709 |
| cff993f | https://github.com/microsoft/TypeScript/pull/58320/commits/cff993f22418041690c1236c163ddf04002a2709 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
Apr 27, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2026613912 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/cff993f22418041690c1236c163ddf04002a2709 |
| tests/baselines/reference/regularExpressionAnnexB.errors.txt | https://github.com/microsoft/TypeScript/pull/58320/files/cff993f22418041690c1236c163ddf04002a2709#diff-acc627b6363ca506ff41a6d09f5ba920d5db760a697c299b0bfb73b8144e5693 |
| graphemecluster | https://github.com/graphemecluster |
| Apr 27, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1581764104 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #58295 | https://github.com/microsoft/TypeScript/pull/58295 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
Improve Recovery of Unterminated Regular Expressions
#58289
| https://github.com/microsoft/TypeScript/pull/58289 |
|
Design Meeting Notes, 4/26/2024
#58416
| https://github.com/microsoft/TypeScript/issues/58416 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| rbuckton | https://github.com/rbuckton |
| May 6, 2024 23:02 | https://github.com/microsoft/TypeScript/pull/58320#event-12721392732 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| May 15, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2113459999 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 15, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2113492238 |
| @jakebailey | https://github.com/jakebailey |
| #58339 | https://github.com/microsoft/TypeScript/pull/58339 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| May 16, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2115541762 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/rbuckton |
| Merge from main | https://github.com/microsoft/TypeScript/pull/58320/commits/603c3cf18ce89adab5c35a3275934f3ae9324a2c |
| 603c3cf | https://github.com/microsoft/TypeScript/pull/58320/commits/603c3cf18ce89adab5c35a3275934f3ae9324a2c |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 16, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2061884025 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/603c3cf18ce89adab5c35a3275934f3ae9324a2c |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/603c3cf18ce89adab5c35a3275934f3ae9324a2c#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 16, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1604036981 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1607228546 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1607277147 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/603c3cf18ce89adab5c35a3275934f3ae9324a2c#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 16, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1604046351 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Annex B | https://tc39.es/ecma262/#sec-parsepattern-annexb |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1607224802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #58320 (comment) | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1581764104 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1607269131 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 21, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1609011192 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this kind of mistakes | https://github.com/microsoft/TypeScript/issues/58275#issuecomment-2068174007 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 21, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1609030673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 20, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2121024921 |
| @graphemecluster | https://github.com/graphemecluster |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Apply Suggested Changes | https://github.com/microsoft/TypeScript/pull/58320/commits/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| 2e62d25 | https://github.com/microsoft/TypeScript/pull/58320/commits/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| force-pushed | https://github.com/microsoft/TypeScript/compare/2868bd67f6c925307a46b7dd2ec31e097e85bc0c..2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| 2868bd6 | https://github.com/microsoft/TypeScript/commit/2868bd67f6c925307a46b7dd2ec31e097e85bc0c |
| 2e62d25 | https://github.com/microsoft/TypeScript/commit/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/2868bd67f6c925307a46b7dd2ec31e097e85bc0c..2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| May 22, 2024 03:24 | https://github.com/microsoft/TypeScript/pull/58320#event-12887745557 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 22, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2071187653 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| rbuckton | https://github.com/rbuckton |
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2071187653 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 22, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1609946436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1611143053 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612257742 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612259634 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1613922465 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 22, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1609954041 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 22, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2071377020 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 22, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1610059651 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 22, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2071383445 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| rbuckton | https://github.com/rbuckton |
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2071383445 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| rbuckton | https://github.com/rbuckton |
| May 22, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1610063764 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
May 23, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2074883181 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103 |
| tests/baselines/reference/regularExpressionScanning(target=es5).errors.txt | https://github.com/microsoft/TypeScript/pull/58320/files/2e62d25d1a9c6158379c9b9daea2ed306ecbb103#diff-8bfdb80d40edf46027e8404ed660d32d24a571242aa99611ca16863107b13133 |
| graphemecluster | https://github.com/graphemecluster |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612233199 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612241562 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612248958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this change | https://github.com/microsoft/TypeScript/pull/58295/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R3437-R3439 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 23, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612348780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this change | https://github.com/microsoft/TypeScript/pull/58295/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R3437-R3439 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Apply Suggested Changes | https://github.com/microsoft/TypeScript/pull/58320/commits/ed08ef7df9f178ec73145dab8240469a073f63d2 |
| ed08ef7 | https://github.com/microsoft/TypeScript/pull/58320/commits/ed08ef7df9f178ec73145dab8240469a073f63d2 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| force-pushed | https://github.com/microsoft/TypeScript/compare/04cc2c53ccb1ca2c05aa9b8db808577a87f5b455..ed08ef7df9f178ec73145dab8240469a073f63d2 |
| 04cc2c5 | https://github.com/microsoft/TypeScript/commit/04cc2c53ccb1ca2c05aa9b8db808577a87f5b455 |
| ed08ef7 | https://github.com/microsoft/TypeScript/commit/ed08ef7df9f178ec73145dab8240469a073f63d2 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/04cc2c53ccb1ca2c05aa9b8db808577a87f5b455..ed08ef7df9f178ec73145dab8240469a073f63d2 |
| May 24, 2024 19:33 | https://github.com/microsoft/TypeScript/pull/58320#event-12928936328 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130257687 |
| #58289 | https://github.com/microsoft/TypeScript/pull/58289 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 24, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2077803222 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/ed08ef7df9f178ec73145dab8240469a073f63d2 |
| rbuckton | https://github.com/rbuckton |
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2077803222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| tests/baselines/reference/regularExpressionScanning(target=es2015).errors.txt | https://github.com/microsoft/TypeScript/pull/58320/files/ed08ef7df9f178ec73145dab8240469a073f63d2#diff-9c45d9eff82cb908497cddafedc36b350d8b56b8c3c9bdcfc0b939a6b27d2411 |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1613960293 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1614040070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #58320 (comment) | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1612257742 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130267381 |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130267511 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161934 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130315297 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161929 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130303925 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161932 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130409675 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161933 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130423688 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161931 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130315931 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161930 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130301693 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Merge branch 'main' into regex-syntax-check-annexB | https://github.com/microsoft/TypeScript/pull/58320/commits/8b67d77bd45a01161fb962dee9686c9ab26627e8 |
| 8b67d77 | https://github.com/microsoft/TypeScript/pull/58320/commits/8b67d77bd45a01161fb962dee9686c9ab26627e8 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
May 24, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2077880094 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/ed08ef7df9f178ec73145dab8240469a073f63d2 |
| tests/baselines/reference/regularExpressionScanning(target=es2015).errors.txt | https://github.com/microsoft/TypeScript/pull/58320/files/ed08ef7df9f178ec73145dab8240469a073f63d2#diff-9c45d9eff82cb908497cddafedc36b350d8b56b8c3c9bdcfc0b939a6b27d2411 |
| graphemecluster | https://github.com/graphemecluster |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1613980140 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1613988292 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1614024208 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130301693 |
| @rbuckton | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130303925 |
| @rbuckton | https://github.com/rbuckton |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=161929&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130315297 |
| @rbuckton | https://github.com/rbuckton |
| Download Benchmarks | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161934&view=artifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130315931 |
| @rbuckton | https://github.com/rbuckton |
| puppeteer | https://github.com/GoogleChrome/puppeteer.git |
| packages/puppeteer-core/tsconfig.json | https://github.com/GoogleChrome/puppeteer/blob/d963fcdd80dbcf26fc6e169917ddd18e7a751f4f/packages/puppeteer-core/tsconfig.json |
| packages/puppeteer-core/src/common/util.ts#L333 | https://github.com/GoogleChrome/puppeteer/blob/d963fcdd80dbcf26fc6e169917ddd18e7a751f4f/packages/puppeteer-core/src/common/util.ts#L333 |
| packages/puppeteer-core/src/tsconfig.esm.json | https://github.com/GoogleChrome/puppeteer/blob/d963fcdd80dbcf26fc6e169917ddd18e7a751f4f/packages/puppeteer-core/src/tsconfig.esm.json |
| packages/puppeteer-core/src/common/util.ts#L333 | https://github.com/GoogleChrome/puppeteer/blob/d963fcdd80dbcf26fc6e169917ddd18e7a751f4f/packages/puppeteer-core/src/common/util.ts#L333 |
| packages/puppeteer-core/src/tsconfig.cjs.json | https://github.com/GoogleChrome/puppeteer/blob/d963fcdd80dbcf26fc6e169917ddd18e7a751f4f/packages/puppeteer-core/src/tsconfig.cjs.json |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
| Provide User-Friendly Errors for Decimal Escapes Inside Character Cla… | https://github.com/microsoft/TypeScript/pull/58320/commits/b48f0d0ebf0839bb68a15e9caf57a23ca75ab4e8 |
| b48f0d0 | https://github.com/microsoft/TypeScript/pull/58320/commits/b48f0d0ebf0839bb68a15e9caf57a23ca75ab4e8 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
May 24, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2078081567 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/b48f0d0ebf0839bb68a15e9caf57a23ca75ab4e8 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/58320/files/b48f0d0ebf0839bb68a15e9caf57a23ca75ab4e8#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| graphemecluster | https://github.com/graphemecluster |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1614044407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#discussion_r1614055570 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 24, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2078098290 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/b48f0d0ebf0839bb68a15e9caf57a23ca75ab4e8 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130409675 |
| @rbuckton | https://github.com/rbuckton |
| dotansimha/graphql-code-generator | https://github.com/dotansimha/graphql-code-generator |
| tsconfig.json | https://github.com/dotansimha/graphql-code-generator/blob/21fbf0db2ba7a560aeb0aa52e9b9bf792ac94227/tsconfig.json |
| packages/graphql-codegen-cli/tests/cli-flags.spec.ts#L7 | https://github.com/dotansimha/graphql-code-generator/blob/21fbf0db2ba7a560aeb0aa52e9b9bf792ac94227/packages/graphql-codegen-cli/tests/cli-flags.spec.ts#L7 |
| packages/graphql-codegen-cli/tests/cli-flags.spec.ts#L7 | https://github.com/dotansimha/graphql-code-generator/blob/21fbf0db2ba7a560aeb0aa52e9b9bf792ac94227/packages/graphql-codegen-cli/tests/cli-flags.spec.ts#L7 |
| microsoft/vscode | https://github.com/microsoft/vscode |
| src/tsconfig.tsec.json | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/tsconfig.tsec.json |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/tsconfig.monaco.json | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/tsconfig.monaco.json |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/tsconfig.json | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/tsconfig.json |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| src/vs/editor/common/services/getIconClasses.ts#L126 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/editor/common/services/getIconClasses.ts#L126 |
| src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 | https://github.com/microsoft/vscode/blob/42f3eac3eadbed723ea8b71f49be0040fed3df2c/src/vs/workbench/services/themes/browser/fileIconThemeData.ts#L468 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130411667 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130415733 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130423688 |
| @rbuckton | https://github.com/rbuckton |
| backstage/backstage | https://github.com/backstage/backstage |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| calcom/cal.com | https://github.com/calcom/cal.com |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| May 24, 2024 | https://github.com/microsoft/TypeScript/pull/58320#issuecomment-2130423694 |
| @rbuckton | https://github.com/rbuckton |
| elastic/kibana | https://github.com/elastic/kibana |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=161933&view=artifacts&type=publishedArtifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
| graphemecluster | https://github.com/graphemecluster |
| May 28, 2024 11:31 | https://github.com/microsoft/TypeScript/pull/58320#commits-pushed-c72f92f |
|
| https://github.com/graphemecluster |
| Fix Behavior Related to namedCaptureGroups | https://github.com/microsoft/TypeScript/pull/58320/commits/c72f92faf22238f5498b0242a99c028770cabd31 |
| c72f92f | https://github.com/microsoft/TypeScript/pull/58320/commits/c72f92faf22238f5498b0242a99c028770cabd31 |
|
| https://github.com/graphemecluster |
| Clarify why nested character classes should not be considered in the … | https://github.com/microsoft/TypeScript/pull/58320/commits/70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
| 70a3214 | https://github.com/microsoft/TypeScript/pull/58320/commits/70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| force-pushed | https://github.com/microsoft/TypeScript/compare/fdd97f4fbe287ea45eeb619be2cdc979c490aae1..70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
| fdd97f4 | https://github.com/microsoft/TypeScript/commit/fdd97f4fbe287ea45eeb619be2cdc979c490aae1 |
| 70a3214 | https://github.com/microsoft/TypeScript/commit/70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/fdd97f4fbe287ea45eeb619be2cdc979c490aae1..70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
| May 28, 2024 03:31 | https://github.com/microsoft/TypeScript/pull/58320#event-12951192849 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
|
May 28, 2024
| https://github.com/microsoft/TypeScript/pull/58320#pullrequestreview-2083978660 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58320/files/70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
| https://github.com/rbuckton |
| rbuckton | https://github.com/rbuckton |
| 0cc62c3 | https://github.com/microsoft/TypeScript/commit/0cc62c3007a62edffb9e1751f6aa65266061e162 |
| May 29, 2024 | https://github.com/microsoft/TypeScript/pull/58320#event-12976836960 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/58320#event-20323077082 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58320 |
|
| https://github.com/jakebailey |
|
jakebailey
| https://github.com/jakebailey |
|
| https://github.com/rbuckton |
|
rbuckton
| https://github.com/rbuckton |
|
| https://github.com/microsoft/TypeScript/pull/58320/files/70a321417c5a705e23c037ce0229f6e8a7ce3b58 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58320 |
|
| https://github.com/graphemecluster |
|
| https://github.com/typescript-bot |
|
| https://github.com/jakebailey |
|
| https://github.com/rbuckton |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |