| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3b264d37-27ed-7bb0-3947-bd8ea8efbf38 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEEE:18879D:20ED18C:2D161D4:6A630A76 |
| html-safe-nonce | e7441aac52fcf5b0bd34cbbca584cf5e2f766a1bf35872bef15aa712bcd09041 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUVFOjE4ODc5RDoyMEVEMThDOjJEMTYxRDQ6NkE2MzBBNzYiLCJ2aXNpdG9yX2lkIjoiNTk3MDg0NDk1MjM2MDU4NTg0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ed580b03ecd22503eff69fbc39aef0d7570037bdc15d811109e5f474cb209a85 |
| hovercard-subject-tag | pull_request:1828996116 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58237/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58237 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58237 |
| og:image:alt | fixes #55762
this was already approved by @gabritto and @weswigham and got merged here: #55774 . It was reverted not because it was decided that the change is bad but because it conflicted with ano... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Andarist |
| hostname | github.com |
| expected-hostname | github.com |
| None | b48e7bf0b1945d51f303503b057abf666ce74c3efbe107b413db2bb921c3f012 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9370f37042c29822d6ba7e3f670f0036a0155b21 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/58237#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58237 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58237 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/58237 |
| Reload | https://github.com/microsoft/TypeScript/pull/58237 |
| Reload | https://github.com/microsoft/TypeScript/pull/58237 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
21
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| Andarist | https://github.com/Andarist |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| Andarist:numeric-constraint-mapped-type-with-name-type-take-2 | https://github.com/Andarist/TypeScript/tree/numeric-constraint-mapped-type-with-name-type-take-2 |
| Conversation | https://github.com/microsoft/TypeScript/pull/58237 |
| Commits3 (3) | https://github.com/microsoft/TypeScript/pull/58237/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/58237/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/58237/files |
| Add numeric constraint to type parameter of mapped types with name type and array constraints (take 2) | https://github.com/microsoft/TypeScript/pull/58237#top |
| Andarist | https://github.com/Andarist |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| Andarist:numeric-constraint-mapped-type-with-name-type-take-2 | https://github.com/Andarist/TypeScript/tree/numeric-constraint-mapped-type-with-name-type-take-2 |
|
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
| Apr 18, 2024 | https://github.com/microsoft/TypeScript/pull/58237#issue-2250058073 |
| #55762 | https://github.com/microsoft/TypeScript/issues/55762 |
| @gabritto | https://github.com/gabritto |
| @weswigham | https://github.com/weswigham |
| #55774 | https://github.com/microsoft/TypeScript/pull/55774 |
| #56727 | https://github.com/microsoft/TypeScript/pull/56727 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
|
| https://github.com/Andarist |
| Revert "Revert "Add numeric constraint to type parameter of mapped ty… | https://github.com/microsoft/TypeScript/pull/58237/commits/4a45c4c6faaf3becfe6676c5604711af67d8072a |
| 4a45c4c | https://github.com/microsoft/TypeScript/pull/58237/commits/4a45c4c6faaf3becfe6676c5604711af67d8072a |
| microsoft#57076 | https://github.com/microsoft/TypeScript/pull/57076 |
| 59b6f78 | https://github.com/Andarist/TypeScript/commit/59b6f78c29680f2e7cbd40e008b4b2715bf3559f |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
| Apr 18, 2024 | https://github.com/microsoft/TypeScript/pull/58237#event-12519562032 |
|
| https://github.com/Andarist |
| tweak behavior of tuples with rest elements | https://github.com/microsoft/TypeScript/pull/58237/commits/9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
| 9d854aa | https://github.com/microsoft/TypeScript/pull/58237/commits/9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
| force-pushed | https://github.com/microsoft/TypeScript/compare/568514f149952c091bf0f3922a7a44402dbe6d8c..9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
| 568514f | https://github.com/microsoft/TypeScript/commit/568514f149952c091bf0f3922a7a44402dbe6d8c |
| 9d854aa | https://github.com/microsoft/TypeScript/commit/9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/568514f149952c091bf0f3922a7a44402dbe6d8c..9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
| April 18, 2024 08:22 | https://github.com/microsoft/TypeScript/pull/58237#event-12519572585 |
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
|
Apr 18, 2024
| https://github.com/microsoft/TypeScript/pull/58237#pullrequestreview-2008192300 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/58237/files/9d854aa4ef0a169c81851df7b695c1e1ec2833c4 |
| tests/cases/compiler/mappedTypeTupleConstraintTypeParameterInNameType.ts | https://github.com/microsoft/TypeScript/pull/58237/files/9d854aa4ef0a169c81851df7b695c1e1ec2833c4#diff-8ea96ab6bd669b671ecc96304aaf1b02925e4b01afbb9c638369ca6552830074 |
| Andarist | https://github.com/Andarist |
| Apr 18, 2024 | https://github.com/microsoft/TypeScript/pull/58237#discussion_r1570249981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #55774 | https://github.com/microsoft/TypeScript/pull/55774 |
| #57031 | https://github.com/microsoft/TypeScript/pull/57031 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
|
| https://github.com/Andarist |
| Merge remote-tracking branch 'origin/main' into numeric-constraint-ma… | https://github.com/microsoft/TypeScript/pull/58237/commits/14b9e73c9c7395b6f41c134ec019fb9a72bde821 |
| 14b9e73 | https://github.com/microsoft/TypeScript/pull/58237/commits/14b9e73c9c7395b6f41c134ec019fb9a72bde821 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Apr 18, 2024 | https://github.com/microsoft/TypeScript/pull/58237#issuecomment-2064743496 |
| #57122 | https://github.com/microsoft/TypeScript/pull/57122 |
| #57093 | https://github.com/microsoft/TypeScript/pull/57093 |
| #57093 | https://github.com/microsoft/TypeScript/pull/57093 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
| May 1, 2024 | https://github.com/microsoft/TypeScript/pull/58237#issuecomment-2089187160 |
| @gabritto | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
|
May 1, 2024
| https://github.com/microsoft/TypeScript/pull/58237#ref-issue-1899343101 |
|
Can't remap tuple keys to object keys in mapped types
#55762
| https://github.com/microsoft/TypeScript/issues/55762 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| May 1, 2024 | https://github.com/microsoft/TypeScript/pull/58237#issuecomment-2089259036 |
| @gabritto | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| May 1, 2024 | https://github.com/microsoft/TypeScript/pull/58237#event-12675774366 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/58237#event-20323076988 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58237 |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
Can't remap tuple keys to object keys in mapped types
| https://github.com/microsoft/TypeScript/issues/55762 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/58237 |
|
| https://github.com/Andarist |
|
| https://github.com/gabritto |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |