René's URL Explorer Experiment


Title: Improve diagnostics deduplication by gabritto · Pull Request #58220 · microsoft/TypeScript · GitHub

Open Graph Title: Improve diagnostics deduplication by gabritto · Pull Request #58220 · microsoft/TypeScript

X Title: Improve diagnostics deduplication by gabritto · Pull Request #58220 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve diagnostics deduplication by gabritto · Pull Request #58220 · microsoft/TypeScript

Open Graph Description: Fixes #58207. Before, we only considered two diagnostics the same if everything about them was equal, including the message chain and related information. With this PR, we now consider diagnostics ...

X Description: Fixes #58207. Before, we only considered two diagnostics the same if everything about them was equal, including the message chain and related information. With this PR, we now consider diagnostics ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58220

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9faae2f-d36b-16c8-211f-db9b85341f67
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE866:97D39:2CCE6D:3B2EE1:6B01C0DB
html-safe-nonce681c3bad2dcda6cd5d16ba4035b0780e303714354bb1b7a044f7ec11a0bfcaad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODY2Ojk3RDM5OjJDQ0U2RDozQjJFRTE6NkIwMUMwREIiLCJ2aXNpdG9yX2lkIjoiNjQxOTAyMTE0MjI1ODk3NjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac361439ab2aed6c1de8bcfde96649b8483e323ca9d7c355845dd0422f454bce9d
hovercard-subject-tagpull_request:1826334715
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58220/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58220
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58220
og:image:altFixes #58207. Before, we only considered two diagnostics the same if everything about them was equal, including the message chain and related information. With this PR, we now consider diagnostics ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabritto
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/58220#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58220
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58220
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/58220
Reloadhttps://github.com/microsoft/TypeScript/pull/58220
Reloadhttps://github.com/microsoft/TypeScript/pull/58220
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/issue58207https://github.com/microsoft/TypeScript/tree/gabritto/issue58207
Conversationhttps://github.com/microsoft/TypeScript/pull/58220
Commits5 (5)https://github.com/microsoft/TypeScript/pull/58220/commits
Checkshttps://github.com/microsoft/TypeScript/pull/58220/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/58220/files
Improve diagnostics deduplicationhttps://github.com/microsoft/TypeScript/pull/58220#top
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/issue58207https://github.com/microsoft/TypeScript/tree/gabritto/issue58207
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issue-2247064320
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
#58207https://github.com/microsoft/TypeScript/issues/58207
#58318https://github.com/microsoft/TypeScript/pull/58318
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
April 16, 2024 23:09https://github.com/microsoft/TypeScript/pull/58220#commits-pushed-49a65b1
https://github.com/gabritto
add test for duplicate diagnostichttps://github.com/microsoft/TypeScript/pull/58220/commits/49a65b1fa2c15602abf1a1947711f8c694730e8c
49a65b1https://github.com/microsoft/TypeScript/pull/58220/commits/49a65b1fa2c15602abf1a1947711f8c694730e8c
https://github.com/gabritto
improve diagnostics deduplicationhttps://github.com/microsoft/TypeScript/pull/58220/commits/165869cd11178917f44e4b5d69ff0d2544954fa0
165869chttps://github.com/microsoft/TypeScript/pull/58220/commits/165869cd11178917f44e4b5d69ff0d2544954fa0
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#event-12498480501
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#event-12498480603
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060098996
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060099047
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161262
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060197885
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161260
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060120632
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161259
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161261
👀 Resultshttps://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060134035
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060120632
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060134035
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=161261&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2060197885
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2061903993
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2061904130
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161271
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58220#issuecomment-2061960488
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#issuecomment-2061960488
Jake Bailey (@jakebailey)https://github.com/jakebailey
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=161271&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 17, 2024 https://github.com/microsoft/TypeScript/pull/58220#pullrequestreview-2006947279
View reviewed changes https://github.com/microsoft/TypeScript/pull/58220/files/165869cd11178917f44e4b5d69ff0d2544954fa0
src/compiler/utilitiesPublic.tshttps://github.com/microsoft/TypeScript/pull/58220/files/165869cd11178917f44e4b5d69ff0d2544954fa0#diff-605cd83dbc128129ef69a4dba9b967fbd56d7d1c2d34fc59348cda739f8e8d11
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#discussion_r1569374539
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#discussion_r1569402799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 17, 2024https://github.com/microsoft/TypeScript/pull/58220#discussion_r1569412656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
April 19, 2024 05:53https://github.com/microsoft/TypeScript/pull/58220#commits-pushed-3257850
https://github.com/gabritto
fix comparison; add test; keep deduped and sorted diagnostics upon in…https://github.com/microsoft/TypeScript/pull/58220/commits/3257850f541de0e52536f19a0d6acfdadc2e3acf
3257850https://github.com/microsoft/TypeScript/pull/58220/commits/3257850f541de0e52536f19a0d6acfdadc2e3acf
https://github.com/gabritto
more comparison fixes, more testshttps://github.com/microsoft/TypeScript/pull/58220/commits/35ed28c9f42fad4767dee833fa824968c95d6e16
35ed28chttps://github.com/microsoft/TypeScript/pull/58220/commits/35ed28c9f42fad4767dee833fa824968c95d6e16
https://github.com/gabritto
rename functionshttps://github.com/microsoft/TypeScript/pull/58220/commits/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
ef2eb5chttps://github.com/microsoft/TypeScript/pull/58220/commits/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Apr 25, 2024 https://github.com/microsoft/TypeScript/pull/58220#ref-pullrequest-2264529619
Improve diagnostics deduplication 2 #58318 https://github.com/microsoft/TypeScript/pull/58318
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Wesley Wigham (weswigham)https://github.com/weswigham
April 26, 2024 19:42https://github.com/microsoft/TypeScript/pull/58220#event-12627854290
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Apr 26, 2024 https://github.com/microsoft/TypeScript/pull/58220#pullrequestreview-2025805731
View reviewed changes https://github.com/microsoft/TypeScript/pull/58220/files/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 26, 2024 https://github.com/microsoft/TypeScript/pull/58220#pullrequestreview-2025823434
View reviewed changes https://github.com/microsoft/TypeScript/pull/58220/files/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
ebcb09dhttps://github.com/microsoft/TypeScript/commit/ebcb09d71a0838b4b9be974f9ef1e80fce8888af
Apr 26, 2024https://github.com/microsoft/TypeScript/pull/58220#event-12629053720
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
April 26, 2024 22:44https://github.com/microsoft/TypeScript/pull/58220#event-12629053809
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/58220#event-20323076952
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58220
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/58220/files/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/58220/files/ef2eb5ca1262f783983a2164ba3ad3b19ec5481b
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Duplicate diagnostics https://github.com/microsoft/TypeScript/issues/58207
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58220
https://github.com/gabritto
https://github.com/typescript-bot
https://github.com/jakebailey
https://github.com/weswigham
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.