René's URL Explorer Experiment

Title: Check nearest package.json dependencies for possible package names for specifier candidates by weswigham · Pull Request #58176 · microsoft/TypeScript · GitHub

Open Graph Title: Check nearest package.json dependencies for possible package names for specifier candidates by weswigham · Pull Request #58176 · microsoft/TypeScript

X Title: Check nearest package.json dependencies for possible package names for specifier candidates by weswigham · Pull Request #58176 · microsoft/TypeScript

Description: Implements this comment. I won't say this "fixes" #42873, but it does prevent it from occurring for people in workspaces with appropriately set-up explicit dependencies in their package files, even when they haven't explicitly referenced all of those dependencies in their program. IMO, that's the upper limit of how much we can or should fix that issue - anything further would imply unsafe/unportable specifiers, which I don't want us to generate. I say that, but this could be improved upon: While this leverages the fact that we already lookup all package.json files to make this cheap, this does not look through those package.json dependencies to try and make a deep import, so we'll only discover top-level package imports this way right now. That's a potential improvement that could be built on this.

Open Graph Description: Implements this comment. I won't say this "fixes" #42873, but it does prevent it from occurring for people in workspaces with appropriately set-up explicit dependencies in their packa...

X Description: Implements this comment. I won't say this "fixes" #42873, but it does prevent it from occurring for people in workspaces with appropriately set-up explicit dependencies in...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58176

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width