René's URL Explorer Experiment


Title: Use better context scope for class constructor implementation signatures by weswigham · Pull Request #58168 · microsoft/TypeScript · GitHub

Open Graph Title: Use better context scope for class constructor implementation signatures by weswigham · Pull Request #58168 · microsoft/TypeScript

X Title: Use better context scope for class constructor implementation signatures by weswigham · Pull Request #58168 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Use better context scope for class constructor implementation signatures by weswigham · Pull Request #58168 · microsoft/TypeScript

Open Graph Description: Since those type parameters are reachable anywhere in the body of the class, not just the constructor itself. Honestly, we could always do the getImplementationSignature call, it doesn't have t...

X Description: Since those type parameters are reachable anywhere in the body of the class, not just the constructor itself. Honestly, we could always do the getImplementationSignature call, it doesn't ha...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/58168

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7fd3c7b5-d5a6-ce72-a279-ce97638441fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3BE:E21C4:BD0B8B:FD4D26:6A4EF847
html-safe-nonce5d53ad34fde0ef274e90f517201ffcc958255dc8279d86937b5559f5e15d2cf8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0JFOkUyMUM0OkJEMEI4QjpGRDREMjY6NkE0RUY4NDciLCJ2aXNpdG9yX2lkIjoiMzMyNTY1ODE2MTkzMTU0ODc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0659c548067045e23036c50d0b9ceb13f3c834605395167e414d7829edba6ff7
hovercard-subject-tagpull_request:1820522893
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/58168/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58168
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/58168
og:image:altSince those type parameters are reachable anywhere in the body of the class, not just the constructor itself. Honestly, we could always do the getImplementationSignature call, it doesn't have t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/58168#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58168
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58168
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/58168
Reloadhttps://github.com/microsoft/TypeScript/pull/58168
Reloadhttps://github.com/microsoft/TypeScript/pull/58168
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.5k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 32 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
weswighamhttps://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:inference-instantiation-issuehttps://github.com/weswigham/TypeScript/tree/inference-instantiation-issue
Conversationhttps://github.com/microsoft/TypeScript/pull/58168
Commits2 (2)https://github.com/microsoft/TypeScript/pull/58168/commits
Checkshttps://github.com/microsoft/TypeScript/pull/58168/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/58168/files
Use better context scope for class constructor implementation signatureshttps://github.com/microsoft/TypeScript/pull/58168#top
weswighamhttps://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:inference-instantiation-issuehttps://github.com/weswigham/TypeScript/tree/inference-instantiation-issue
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issue-2240517219
#58074https://github.com/microsoft/TypeScript/issues/58074
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/weswigham
Use better context scope for class constructor implementation signatureshttps://github.com/microsoft/TypeScript/pull/58168/commits/4aa8c2fbcb1e4e0d861094f3001fe6093c7a805c
4aa8c2fhttps://github.com/microsoft/TypeScript/pull/58168/commits/4aa8c2fbcb1e4e0d861094f3001fe6093c7a805c
https://github.com/weswigham
weswighamhttps://github.com/weswigham
jakebaileyhttps://github.com/jakebailey
sandersnhttps://github.com/sandersn
April 12, 2024 16:43https://github.com/microsoft/TypeScript/pull/58168#event-12451880043
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
weswighamhttps://github.com/weswigham
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#event-12451880729
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#event-12451880811
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Apr 12, 2024 https://github.com/microsoft/TypeScript/pull/58168#ref-issue-2225736774
Class infers wrong generic parameter since e1874f3 #58074 https://github.com/microsoft/TypeScript/issues/58074
https://github.com/RyanCavanaugh
RyanCavanaughhttps://github.com/RyanCavanaugh
Apr 12, 2024 https://github.com/microsoft/TypeScript/pull/58168#pullrequestreview-1997927912
View reviewed changes https://github.com/microsoft/TypeScript/pull/58168/files/4aa8c2fbcb1e4e0d861094f3001fe6093c7a805c
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Apr 12, 2024 https://github.com/microsoft/TypeScript/pull/58168#pullrequestreview-1997931786
View reviewed changes https://github.com/microsoft/TypeScript/pull/58168/files/4aa8c2fbcb1e4e0d861094f3001fe6093c7a805c
jakebaileyhttps://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/58168#pullrequestreview-1997931786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052121220
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161174
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161175
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052170749
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161173
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052158704
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161176
👀 Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052176593
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052158704
@jakebaileyhttps://github.com/jakebailey
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=161173&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/MichaelMitchell-at
MichaelMitchell-athttps://github.com/MichaelMitchell-at
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052168677
#58158https://github.com/microsoft/TypeScript/issues/58158
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052170749
@jakebaileyhttps://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052176593
@jakebaileyhttps://github.com/jakebailey
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=161176&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/MichaelMitchell-at
MichaelMitchell-athttps://github.com/MichaelMitchell-at
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052191209
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
@weswighamhttps://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/weswigham
Prefer using the type parameter location itself, if availablehttps://github.com/microsoft/TypeScript/pull/58168/commits/92f45436ce5d38c1db84c957a5e15b0e0edfec87
92f4543https://github.com/microsoft/TypeScript/pull/58168/commits/92f45436ce5d38c1db84c957a5e15b0e0edfec87
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052214549
@MichaelMitchell-athttps://github.com/MichaelMitchell-at
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052214680
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161182
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052430232
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161181
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052246700
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161180
✅ Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052242053
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=161183
👀 Resultshttps://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052253193
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/MichaelMitchell-at
MichaelMitchell-athttps://github.com/MichaelMitchell-at
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052219506
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Apr 12, 2024 https://github.com/microsoft/TypeScript/pull/58168#pullrequestreview-1998133010
View reviewed changes https://github.com/microsoft/TypeScript/pull/58168/files/92f45436ce5d38c1db84c957a5e15b0e0edfec87
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052242053
@weswighamhttps://github.com/weswigham
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=161180&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052246700
@weswighamhttps://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052253193
@weswighamhttps://github.com/weswigham
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=161183&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#issuecomment-2052430232
@weswighamhttps://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/weswigham
weswighamhttps://github.com/weswigham
a9b0d1ehttps://github.com/microsoft/TypeScript/commit/a9b0d1ee53c0b60babd744300bc3a7c07cbb1974
Apr 12, 2024https://github.com/microsoft/TypeScript/pull/58168#event-12453570162
https://github.com/weswigham
weswighamhttps://github.com/weswigham
April 12, 2024 19:52https://github.com/microsoft/TypeScript/pull/58168#event-12453570757
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jan 22, 2025 https://github.com/microsoft/TypeScript/pull/58168#ref-pullrequest-2803972431
Use proper type parameter hosts in JS files #61013 https://github.com/microsoft/TypeScript/pull/61013
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/58168#event-20323076895
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F58168
https://github.com/jakebailey
jakebailey https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/58168/files/92f45436ce5d38c1db84c957a5e15b0e0edfec87
https://github.com/RyanCavanaugh
RyanCavanaugh https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/58168/files/4aa8c2fbcb1e4e0d861094f3001fe6093c7a805c
https://github.com/sandersn
sandersn https://github.com/sandersn
https://github.com/weswigham
weswigham https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Class infers wrong generic parameter since e1874f3 https://github.com/microsoft/TypeScript/issues/58074
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/58168
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/MichaelMitchell-at
https://github.com/jakebailey
https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.