| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5d44b673-ea68-6b16-2365-582ebffb1821 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5BC:A70A9:169501:1E1FC1:6B018689 |
| html-safe-nonce | f4f4addd54453ff940c6f7db0c7b182bf60d8e8d9597541b353e9c0bbeaa39d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUJDOkE3MEE5OjE2OTUwMToxRTFGQzE6NkIwMTg2ODkiLCJ2aXNpdG9yX2lkIjoiMTcyMjIzMjQzNTIzNzgxNTk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6391f55e441914108b362e177236e32718339cdd77a897664351ec5b09891514 |
| hovercard-subject-tag | pull_request:1778711804 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/57838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0b33175bf148d7c380aaeaff318d6249ff5130e0da5ae11b609960f24fb2d268/microsoft/TypeScript/pull/57838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0b33175bf148d7c380aaeaff318d6249ff5130e0da5ae11b609960f24fb2d268/microsoft/TypeScript/pull/57838 |
| og:image:alt | fixes #57827 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Andarist |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/57838#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57838 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57838 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/57838 |
| Reload | https://github.com/microsoft/TypeScript/pull/57838 |
| Reload | https://github.com/microsoft/TypeScript/pull/57838 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| Andarist:fix/apparent-mapped-type-keys-with-unknown-modifier | https://github.com/Andarist/TypeScript/tree/fix/apparent-mapped-type-keys-with-unknown-modifier |
| Conversation | https://github.com/microsoft/TypeScript/pull/57838 |
| Commits10 (10) | https://github.com/microsoft/TypeScript/pull/57838/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/57838/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/57838/files |
| Fixed an issue with apparent mapped type keys | https://github.com/microsoft/TypeScript/pull/57838#top |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| Andarist:fix/apparent-mapped-type-keys-with-unknown-modifier | https://github.com/Andarist/TypeScript/tree/fix/apparent-mapped-type-keys-with-unknown-modifier |
|
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| Mar 18, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issue-2193646676 |
| #57827 | https://github.com/microsoft/TypeScript/issues/57827 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
|
| https://github.com/Andarist |
| Fixed an issue with apparent mapped type keys | https://github.com/microsoft/TypeScript/pull/57838/commits/1a27fd94e27e1235e70ae8b7be763c599a8246ec |
| 1a27fd9 | https://github.com/microsoft/TypeScript/pull/57838/commits/1a27fd94e27e1235e70ae8b7be763c599a8246ec |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Mar 18, 2024 | https://github.com/microsoft/TypeScript/pull/57838#event-12160900161 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Mar 18, 2024 | https://github.com/microsoft/TypeScript/pull/57838#event-12160900380 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
|
Mar 18, 2024
| https://github.com/microsoft/TypeScript/pull/57838#pullrequestreview-1944480227 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/57838/files/1a27fd94e27e1235e70ae8b7be763c599a8246ec |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/57838/files/1a27fd94e27e1235e70ae8b7be763c599a8246ec#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| Mar 18, 2024 | https://github.com/microsoft/TypeScript/pull/57838#discussion_r1529454176 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #56742 | https://github.com/microsoft/TypeScript/pull/56742 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| March 27, 2024 21:04 | https://github.com/microsoft/TypeScript/pull/57838#event-12273194732 |
|
| https://github.com/Andarist |
| Merge remote-tracking branch 'origin/main' into fix/apparent-mapped-t… | https://github.com/microsoft/TypeScript/pull/57838/commits/8d18d2d3dc2c560d532bf563e7972821b685e28c |
| 8d18d2d | https://github.com/microsoft/TypeScript/pull/57838/commits/8d18d2d3dc2c560d532bf563e7972821b685e28c |
| https://github.com/LukeAbby |
| LukeAbby | https://github.com/LukeAbby |
| Nov 24, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2496258932 |
| reproduction | https://www.typescriptlang.org/play/?noErrorTruncation=true#code/CYUwxgNghgTiAEYD2A7AzgF3lMGkwC54BJFFEGUgSwyqgioC8RgAVATwAcQAeAb3hp2mEAFsiHbgBEoGKADEqICMHgBfAHwBuAFA48MAHRCRo3ToxcEpcpRQ06DZmys9Fy4Gg3wAvPD468PAA9MHwAEognNBgVCgA5vAABnEAZhQk9hiSIEnwAO40ABbJUCjsealUAB4gaPAYRQgUMPiGgfAA2gDSIOzwcfAA1n1IqfDuKmgAukSTnj190-Ag1RggKJ7wMnLzPGkZ1NlWGh1BAPzY5WfwRGXsumrmltzwAMpUotEgALIU8bxWLAARgADTwADyADcWlRQN4-BDRDQeECYCDwSN2GNITCYDA4SBvAAyXGw0DmUCQWAIaloeoAfVI6xgKHoOR2UB+SFAEB4bzATVEUG8ASCcVsR0cTBYOQAomsNp4iDYKFL6DKXNx+YKxCKVorNvUAERQY3wS73W5XB46DqheAAQSwEBAUEw8AArPBOK1uDBaHVsHB4HAAI4AVyocGA7XFKBZbIgHNkXJ5ygACn6AIx3cq6eOJ9lWTnc3lZpCcABMedthYoSZTcjLmb9AGZawWBgmG8XpKmWxAK5wACydjpxIvJksD9NDv2e8dqO0vBCRURIGFSChUGHAHgAIXdIFYRSoaHBR7Qvznl+PnPB24Je85CI6SJRH4wh+Pp-PmNGcYrxATl4AAH2GQDth3F9Uw0ADsSA49BxJeBgMHZ4rHgP50RADNYFoehUXBABVBF4FYeBSTFLpum7SDEPgEjsHqBUMBgfQeG6cF8IDRwcIBXphGIpiNA0aZziXTDXkiSNoxYIS0FRciaJ6eisRxVhpgAWkkiiDXWI1-FDN1gFQCB+k6Bl6O6WYbXUC14DoohyDxR5Og08YtOkhBeMIiABJARSRLI3x-A6NTBk8pidL0ujVkMrZZKjGNgrIm5Lniw0kpAOTUr6JTWFOIISsch0-3qZBNgcVBsAgfIoGEFYoXoCNZCDPAGhgCMEAAIwjLAaEEWgIAgQQQDEepwwjAkWDjUqSqtBKlXqdiepuUrLlcigNpKog6IdZ14Fdd0sFQBAcUaOoECSbaYCSepRAjD1epu7okkMCiz3qc6CndRAiiQa8UHgV6wCgZ6EBoAByeo7q6nrQYG+AUCQeBhQwFkCjPQV4F+7EIx9KgwCGBomhWfF8AGVamjgebSpckA8RuRm3J0NQPKgkjpkpcBoBDKqPQZBlgM5IgI3sSMECEUReqQCBdCpfnaVQIWGSfXcWDF+AJaoKXBHYWX5fMScKFSHBrHQOQUDAXhRdTR8YK1uDwqCKyRfvVM7PtuQu3djXYLkOyA+d332ZXLCsyiGkQ+ATkKp-a8KrfIJgIqgyVsyTAylt-YUHSGA0M9uRwQOQvY9fDLsP+PCCMcHhdqCD4vldQKG4Whbyu+5Ivzyc8UfAOo0FgfpQDQTgaAQOANyhOJElRhi0HpjvIWRb9G4W9dNxAp39zT77wQloZUfyFA72vB9oOfUORVBDfSru+-4Hgp+fagDeX5Xq-Nbj1NduKvaA82Z2iVjSRA0B6QURnM2Oc7d3i6mFHfVOxcoBIO-oHVB9owjpwShxBoWFOCwCgKIEAWN+7TXkqofqg0sBmSDKjLARQoAwgaGjV6Otryxg6CRFAkNVB+HuHfbwy0jJMh7KyPsIFZy8h1EKfUqlhZvzsj8KAnBuBajtig7QEVhYVy9kQFRajZSuD0XIbRHRfTRzgKYqARAo6EOsbveO30eCNHPOYoIq5SxzmHLmG0XYvHSNbJWGs-iOiBJgeWdsS47QOlIAwewCQyb93oGgNGVRag0yhvSHq7RVwUXVE4YxrwfAdAgk2NMMiBDVHYIwVmGQ1DgkETaAB5ToGVOUPwbAvUwD1MLo0m0TTyjmK7v3fIHEjGF3ydvQuSROTzD7lNXKKUWDwFSFTNJJCTLulQO0Ok9QKnzAzkZeZSgVCokKZqHIoplw6FAQLCB9RTkeB4Jc5wOQwr3FFB0SGbyWB+L+Ro8CKMIyywoFoEIYQ3gTVEKtNGTCWGdXYVAHW9hdk-OvIC0JgKciPAjq8Qx6icjKTCjRUZ9R+5oE+NEKgVRVmdSuj6JAk48bjFenPbAoMhpQF6mgGaXC3Z0SilBSi-0lrZXqHRLaTMMh9LsvcR4uggA |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| November 24, 2024 23:36 | https://github.com/microsoft/TypeScript/pull/57838#commits-pushed-8c95b0e |
|
| https://github.com/Andarist |
| Merge remote-tracking branch 'origin/main' into fix/apparent-mapped-t… | https://github.com/microsoft/TypeScript/pull/57838/commits/8c95b0ef81ef7fe7eb682e2480a7177686b6cac2 |
| 8c95b0e | https://github.com/microsoft/TypeScript/pull/57838/commits/8c95b0ef81ef7fe7eb682e2480a7177686b6cac2 |
|
| https://github.com/Andarist |
| improve the fix | https://github.com/microsoft/TypeScript/pull/57838/commits/04976bff8e0e58fa00c5ceff8d630586168be098 |
| 04976bf | https://github.com/microsoft/TypeScript/pull/57838/commits/04976bff8e0e58fa00c5ceff8d630586168be098 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508744380 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508744408 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=164242 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508745453 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508745453 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164242/artifacts?artifactName=tgz&fileId=63DB465238EF48184C9FE24AA2B166C04B5AAA3CA7F9AFB4F3F63BF467E24E8402&fileName=/typescript-5.8.0-insiders.20241130.tgz |
| for this build | https://www.typescriptlang.org/play?ts=5.8.0-pr-57838-3 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.8.0-pr-57838-3 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508753944 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508753980 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=164245 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508782390 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=164244 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508760224 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=164243 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508761527 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=164246 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508769702 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508760224 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508761527 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=164243&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508769702 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Download Benchmarks | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=164246&view=artifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
|
Nov 30, 2024
| https://github.com/microsoft/TypeScript/pull/57838#pullrequestreview-2470608031 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/57838/files/04976bff8e0e58fa00c5ceff8d630586168be098 |
| tests/cases/compiler/keyRemappingKeyofResult.ts | https://github.com/microsoft/TypeScript/pull/57838/files/04976bff8e0e58fa00c5ceff8d630586168be098#diff-7c3609bf5fb72f19421a8224f5eb12202338bf245af07570a109eda154b4f092 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/57838/files/04976bff8e0e58fa00c5ceff8d630586168be098#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-2508782390 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| November 30, 2024 15:22 | https://github.com/microsoft/TypeScript/pull/57838#event-15481316872 |
|
| https://github.com/Andarist |
| add extra test case | https://github.com/microsoft/TypeScript/pull/57838/commits/cad532adfb753a6737111526120824443030e30b |
| cad532a | https://github.com/microsoft/TypeScript/pull/57838/commits/cad532adfb753a6737111526120824443030e30b |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| force-pushed | https://github.com/microsoft/TypeScript/compare/2f2b500f4e3a11b83c95492077c957ebcd887903..cad532adfb753a6737111526120824443030e30b |
| 2f2b500 | https://github.com/microsoft/TypeScript/commit/2f2b500f4e3a11b83c95492077c957ebcd887903 |
| cad532a | https://github.com/microsoft/TypeScript/commit/cad532adfb753a6737111526120824443030e30b |
|
Compare
| https://github.com/microsoft/TypeScript/compare/2f2b500f4e3a11b83c95492077c957ebcd887903..cad532adfb753a6737111526120824443030e30b |
| November 30, 2024 15:45 | https://github.com/microsoft/TypeScript/pull/57838#event-15481360769 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
|
Jan 20, 2026
| https://github.com/microsoft/TypeScript/pull/57838#pullrequestreview-3683818891 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/57838/files/cad532adfb753a6737111526120824443030e30b |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/57838/files/cad532adfb753a6737111526120824443030e30b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| January 20, 2026 20:33 | https://github.com/microsoft/TypeScript/pull/57838#commits-pushed-05cc6dd |
|
| https://github.com/Andarist |
| Merge remote-tracking branch 'origin/main' into fix/apparent-mapped-t… | https://github.com/microsoft/TypeScript/pull/57838/commits/05cc6dd3b46a8cc93e53665cc18edfd3955c04c1 |
| 05cc6dd | https://github.com/microsoft/TypeScript/pull/57838/commits/05cc6dd3b46a8cc93e53665cc18edfd3955c04c1 |
|
| https://github.com/Andarist |
| move the fix to getApparentMappedTypeKeys | https://github.com/microsoft/TypeScript/pull/57838/commits/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
| 21f4f7c | https://github.com/microsoft/TypeScript/pull/57838/commits/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| force-pushed | https://github.com/microsoft/TypeScript/compare/cf0355f12b18299dbc92111a5f1eeba9fa15ffc1..21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
| cf0355f | https://github.com/microsoft/TypeScript/commit/cf0355f12b18299dbc92111a5f1eeba9fa15ffc1 |
| 21f4f7c | https://github.com/microsoft/TypeScript/commit/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/cf0355f12b18299dbc92111a5f1eeba9fa15ffc1..21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
| January 20, 2026 19:40 | https://github.com/microsoft/TypeScript/pull/57838#event-22170484601 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774627091 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774627329 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=166941 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774941873 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=166940 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774734199 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=166939 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774710420 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=166942 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774830273 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774710420 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=166939&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774734199 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774830273 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Download Benchmarks | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=166942&view=artifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-3774941873 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
|
Jan 20, 2026
| https://github.com/microsoft/TypeScript/pull/57838#pullrequestreview-3684649681 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/57838/files/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/57838/files/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Jan 20, 2026 | https://github.com/microsoft/TypeScript/pull/57838#discussion_r2710363061 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| Jan 21, 2026 | https://github.com/microsoft/TypeScript/pull/57838#discussion_r2713721983 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| Feb 9, 2026 | https://github.com/microsoft/TypeScript/pull/57838#discussion_r2781838694 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| January 26, 2026 15:58 | https://github.com/microsoft/TypeScript/pull/57838#commits-pushed-fcdaa91 |
|
| https://github.com/Andarist |
| remove getApparentMappedTypeKeys on the source side | https://github.com/microsoft/TypeScript/pull/57838/commits/fcdaa913d5860b20fb73945b3c719db16b116f10 |
| fcdaa91 | https://github.com/microsoft/TypeScript/pull/57838/commits/fcdaa913d5860b20fb73945b3c719db16b116f10 |
|
| https://github.com/Andarist |
| Merge remote-tracking branch 'origin/main' into fix/apparent-mapped-t… | https://github.com/microsoft/TypeScript/pull/57838/commits/81185ac4e65b0eddfde9d495edefcfe17341530f |
| 81185ac | https://github.com/microsoft/TypeScript/pull/57838/commits/81185ac4e65b0eddfde9d495edefcfe17341530f |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| February 9, 2026 10:32 | https://github.com/microsoft/TypeScript/pull/57838#event-22639790084 |
|
| https://github.com/Andarist |
| fix index type constraints on mapped types with name types | https://github.com/microsoft/TypeScript/pull/57838/commits/73d96e1768e7e564d1559cce96351a244575b4b4 |
| 73d96e1 | https://github.com/microsoft/TypeScript/pull/57838/commits/73d96e1768e7e564d1559cce96351a244575b4b4 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
| force-pushed | https://github.com/microsoft/TypeScript/compare/7c571479522d17ca38a5b9c3b13be0350ef5b163..73d96e1768e7e564d1559cce96351a244575b4b4 |
| 7c57147 | https://github.com/microsoft/TypeScript/commit/7c571479522d17ca38a5b9c3b13be0350ef5b163 |
| 73d96e1 | https://github.com/microsoft/TypeScript/commit/73d96e1768e7e564d1559cce96351a244575b4b4 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/7c571479522d17ca38a5b9c3b13be0350ef5b163..73d96e1768e7e564d1559cce96351a244575b4b4 |
| February 9, 2026 13:10 | https://github.com/microsoft/TypeScript/pull/57838#event-22643605301 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/57838#event-23867731441 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| PR Backlog | https://github.com/orgs/microsoft/projects/1252 |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/57838#event-23867752541 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/57838#issuecomment-4121433931 |
| 6.0 out | https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/ |
| final release vehicle for this codebase | https://redirect.github.com/microsoft/TypeScript/issues/62963 |
| post-6.0 patch criteria | https://redirect.github.com/microsoft/TypeScript/issues/62963#issuecomment-4100336368 |
| 6.0 iteration issue | https://redirect.github.com/microsoft/TypeScript/issues/63085 |
| typescript-go repo | https://redirect.github.com/microsoft/TypeScript-go |
| DOM Generator repo | https://redirect.github.com/microsoft/TypeScript-DOM-lib-generator |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
|
Mar 30, 2026
| https://github.com/microsoft/TypeScript/pull/57838#ref-issue-4047047651 |
|
Omit causes function to lose contextual typing
#63225
| https://github.com/microsoft/TypeScript/issues/63225 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57838 |
|
| https://github.com/gabritto |
|
Gabriela Araujo Britto (gabritto)
| https://github.com/gabritto |
|
| https://github.com/microsoft/TypeScript/pull/57838/files/21f4f7ca8577018ccd5ddaf7b3ed0d634bb5e324 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Extract not narrowing type union in mapped type passed as generic
| https://github.com/microsoft/TypeScript/issues/57827 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/57838 |
|
| https://github.com/Andarist |
|
| https://github.com/LukeAbby |
|
| https://github.com/gabritto |
|
| https://github.com/typescript-bot |
|
| https://github.com/weswigham |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |