René's URL Explorer Experiment


Title: Fixed excess and common property checks with `NoInfer` by Andarist · Pull Request #57673 · microsoft/TypeScript · GitHub

Open Graph Title: Fixed excess and common property checks with `NoInfer` by Andarist · Pull Request #57673 · microsoft/TypeScript

X Title: Fixed excess and common property checks with `NoInfer` by Andarist · Pull Request #57673 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fixed excess and common property checks with `NoInfer` by Andarist · Pull Request #57673 · microsoft/TypeScript

Open Graph Description: I figured out that it might be better to handle NoInfer at those levels because there is always a risk that isWeakType/isKnownProperty might get called outside of the checkTypeRelatedTo. However, t...

X Description: I figured out that it might be better to handle NoInfer at those levels because there is always a risk that isWeakType/isKnownProperty might get called outside of the checkTypeRelatedTo. However, t...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/57673

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c667c110-a236-2301-2143-df1a8f22f2da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAB4:1FAE:1B950A:29D552:6B01BEAB
html-safe-nonce743b207006f31043eada6defaa111f1ca31ec8192feab8f0be5f08f9533e66ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUI0OjFGQUU6MUI5NTBBOjI5RDU1Mjo2QjAxQkVBQiIsInZpc2l0b3JfaWQiOiI1NzQ1MDgwNTExODUyODIyMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac49ecafaa9c0eea231a34ea9add3497ef47d23c7c41c2f0e786d114d9808fa816
hovercard-subject-tagpull_request:1760667766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/57673/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/57673
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a67c6e1309b968de88c4876685cbefc372916129176db7f360f6acbd0fc82c5/microsoft/TypeScript/pull/57673
og:image:altI figured out that it might be better to handle NoInfer at those levels because there is always a risk that isWeakType/isKnownProperty might get called outside of the checkTypeRelatedTo. However, t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/57673#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57673
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57673
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/57673
Reloadhttps://github.com/microsoft/TypeScript/pull/57673
Reloadhttps://github.com/microsoft/TypeScript/pull/57673
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/excess-n-common-checks-noinferhttps://github.com/Andarist/TypeScript/tree/fix/excess-n-common-checks-noinfer
Conversationhttps://github.com/microsoft/TypeScript/pull/57673
Commits3 (3)https://github.com/microsoft/TypeScript/pull/57673/commits
Checkshttps://github.com/microsoft/TypeScript/pull/57673/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/57673/files
Fixed excess and common property checks with NoInferhttps://github.com/microsoft/TypeScript/pull/57673#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/excess-n-common-checks-noinferhttps://github.com/Andarist/TypeScript/tree/fix/excess-n-common-checks-noinfer
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 7, 2024https://github.com/microsoft/TypeScript/pull/57673#issue-2173454873
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
#49119https://github.com/microsoft/TypeScript/pull/49119
#50535https://github.com/microsoft/TypeScript/pull/50535
#57697https://github.com/microsoft/TypeScript/issues/57697
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Mar 7, 2024https://github.com/microsoft/TypeScript/pull/57673#event-12039606447
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 7, 2024https://github.com/microsoft/TypeScript/pull/57673#issuecomment-1983142622
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 8, 2024 https://github.com/microsoft/TypeScript/pull/57673#ref-issue-2176516212
Excess and common property checks don't work correctly with NoInfer #57697 https://github.com/microsoft/TypeScript/issues/57697
https://github.com/Andarist
Fixed excess and common property checks with NoInferhttps://github.com/microsoft/TypeScript/pull/57673/commits/bcbd4196adb2becf34eb846060acfef007a23905
bcbd419https://github.com/microsoft/TypeScript/pull/57673/commits/bcbd4196adb2becf34eb846060acfef007a23905
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
force-pushedhttps://github.com/microsoft/TypeScript/compare/aa83f7881973d84e8affa383feb4f423d1d5dc1c..bcbd4196adb2becf34eb846060acfef007a23905
aa83f78https://github.com/microsoft/TypeScript/commit/aa83f7881973d84e8affa383feb4f423d1d5dc1c
bcbd419https://github.com/microsoft/TypeScript/commit/bcbd4196adb2becf34eb846060acfef007a23905
Compare https://github.com/microsoft/TypeScript/compare/aa83f7881973d84e8affa383feb4f423d1d5dc1c..bcbd4196adb2becf34eb846060acfef007a23905
March 8, 2024 19:59https://github.com/microsoft/TypeScript/pull/57673#event-12060052136
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
March 20, 2024 16:50https://github.com/microsoft/TypeScript/pull/57673#event-12188068947
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 20, 2024https://github.com/microsoft/TypeScript/pull/57673#event-12188070007
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 20, 2024 https://github.com/microsoft/TypeScript/pull/57673#pullrequestreview-1949660789
View reviewed changes https://github.com/microsoft/TypeScript/pull/57673/files/bcbd4196adb2becf34eb846060acfef007a23905
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/57673#pullrequestreview-1949660789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/57673/files/bcbd4196adb2becf34eb846060acfef007a23905#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 20, 2024https://github.com/microsoft/TypeScript/pull/57673#discussion_r1532554058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 20, 2024https://github.com/microsoft/TypeScript/pull/57673#discussion_r1532926856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
deeplyNestedMappedTypeshttps://github.com/microsoft/TypeScript/blob/ede8ad84b1b2708a0eea234babd5bbf89fda57b8/tests/cases/compiler/deeplyNestedMappedTypes.ts
conditionalTypeDoesntSpinForeverhttps://github.com/microsoft/TypeScript/blob/ede8ad84b1b2708a0eea234babd5bbf89fda57b8/tests/cases/compiler/conditionalTypeDoesntSpinForever.ts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 20, 2024https://github.com/microsoft/TypeScript/pull/57673#discussion_r1532935057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
Mateusz Burzyński (Andarist)https://github.com/Andarist
March 20, 2024 19:14https://github.com/microsoft/TypeScript/pull/57673#commits-pushed-1b729b9
https://github.com/Andarist
Merge remote-tracking branch 'origin/main' into fix/excess-n-common-c…https://github.com/microsoft/TypeScript/pull/57673/commits/1b729b964675c8586ffa731411e9daf738b44916
1b729b9https://github.com/microsoft/TypeScript/pull/57673/commits/1b729b964675c8586ffa731411e9daf738b44916
https://github.com/Andarist
erase all substitution typeshttps://github.com/microsoft/TypeScript/pull/57673/commits/7ebe1e5787a3d90255371e58b0de2a428cd4f0c7
7ebe1e5https://github.com/microsoft/TypeScript/pull/57673/commits/7ebe1e5787a3d90255371e58b0de2a428cd4f0c7
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
520772ehttps://github.com/microsoft/TypeScript/commit/520772e54e9e26b18d5ba90442474cfe9ad57b1a
Apr 2, 2024https://github.com/microsoft/TypeScript/pull/57673#event-12327567975
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Apr 2, 2024https://github.com/microsoft/TypeScript/pull/57673#issuecomment-2032525298
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Apr 2, 2024 https://github.com/microsoft/TypeScript/pull/57673#ref-pullrequest-2220965154
Fix baselines from recent merge #58037 https://github.com/microsoft/TypeScript/pull/58037
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Apr 2, 2024https://github.com/microsoft/TypeScript/pull/57673#issuecomment-2032624734
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
April 2, 2024 19:03https://github.com/microsoft/TypeScript/pull/57673#event-12330816026
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/57673#event-20323076813
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F57673
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/57673/files/bcbd4196adb2becf34eb846060acfef007a23905
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Excess and common property checks don't work correctly with NoInfer https://github.com/microsoft/TypeScript/issues/57697
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/57673
https://github.com/Andarist
https://github.com/typescript-bot
https://github.com/jakebailey
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.