| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:87858bf7-5c04-1873-39f8-d5b12f32d30a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAC2:1C94F:3E48A6:4F4949:6B01092E |
| html-safe-nonce | 893a46208fb4b4ce0404d9e2ede73aec7a75e7bd1a483c90bcf552a691e17878 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUMyOjFDOTRGOjNFNDhBNjo0RjQ5NDk6NkIwMTA5MkUiLCJ2aXNpdG9yX2lkIjoiMTEyNzA2OTc3MTgyOTkzODQ3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38d38833068d4e3ed34a8a90eca66d8ae9245a4b401ef8c55399633713cc3b6a |
| hovercard-subject-tag | pull_request:1581172836 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/56274/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12b2c8cb4d5487ca968155f7a66b10ac025dfe6d1b190f95bab932c9b596df24/microsoft/TypeScript/pull/56274 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12b2c8cb4d5487ca968155f7a66b10ac025dfe6d1b190f95bab932c9b596df24/microsoft/TypeScript/pull/56274 |
| og:image:alt | Posting as reference for now. Still has build failures. Not ready for review.
Naming is not at all well-thought-out. Names like NodeBase are just what came to mind first.
The most breaking portion ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoshuaKGoldberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/56274#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F56274 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F56274 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/56274 |
| Reload | https://github.com/microsoft/TypeScript/pull/56274 |
| Reload | https://github.com/microsoft/TypeScript/pull/56274 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| JoshuaKGoldberg:node-discriminated-union | https://github.com/JoshuaKGoldberg/TypeScript/tree/node-discriminated-union |
| Conversation | https://github.com/microsoft/TypeScript/pull/56274 |
| Commits1 (1) | https://github.com/microsoft/TypeScript/pull/56274/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/56274/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/56274/files |
| [Reference] feat: switched Node to a discriminated union | https://github.com/microsoft/TypeScript/pull/56274#top |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| JoshuaKGoldberg:node-discriminated-union | https://github.com/JoshuaKGoldberg/TypeScript/tree/node-discriminated-union |
|
| https://github.com/JoshuaKGoldberg |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
| Oct 31, 2023 | https://github.com/microsoft/TypeScript/pull/56274#issue-1970696104 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
|
| https://github.com/JoshuaKGoldberg |
| [Reference] feat: switched Node to a discriminated union | https://github.com/microsoft/TypeScript/pull/56274/commits/0a7bf7887dc28cc19a9346aa9241d2876b6b5c58 |
| 0a7bf78 | https://github.com/microsoft/TypeScript/pull/56274/commits/0a7bf7887dc28cc19a9346aa9241d2876b6b5c58 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Oct 31, 2023 | https://github.com/microsoft/TypeScript/pull/56274#event-10822337163 |
| https://github.com/JoshuaKGoldberg |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
|
Oct 31, 2023
| https://github.com/microsoft/TypeScript/pull/56274#ref-issue-1970698587 |
|
Replace Node interface with discriminated unions
#56275
| https://github.com/microsoft/TypeScript/issues/56275 |
| https://github.com/Jack-Works |
| Jack Works (Jack-Works) | https://github.com/Jack-Works |
| Nov 1, 2023 | https://github.com/microsoft/TypeScript/pull/56274#issuecomment-1788519649 |
| engine262/engine262#215 (comment) | https://github.com/engine262/engine262/pull/215#discussion_r1246023457 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Nov 1, 2023 | https://github.com/microsoft/TypeScript/pull/56274#issuecomment-1788524561 |
| #54148 | https://github.com/microsoft/TypeScript/pull/54148 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
| https://github.com/JoshuaKGoldberg |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
| Nov 2, 2023 | https://github.com/microsoft/TypeScript/pull/56274#issuecomment-1790845307 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
| https://github.com/JoshuaKGoldberg |
| Josh Ghoulberg 👻 (JoshuaKGoldberg) | https://github.com/JoshuaKGoldberg |
| Nov 2, 2023 | https://github.com/microsoft/TypeScript/pull/56274#event-10844873444 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
|
Feb 22, 2024
| https://github.com/microsoft/TypeScript/pull/56274#ref-pullrequest-2147194585 |
|
Infer type predicates from function bodies using control flow analysis
#57465
| https://github.com/microsoft/TypeScript/pull/57465 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/56274#event-20324809687 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F56274 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/56274 |
|
| https://github.com/JoshuaKGoldberg |
|
| https://github.com/Jack-Works |
|
| https://github.com/jakebailey |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |