René's URL Explorer Experiment


Title: Remove `CheckMode.IsForStringLiteralArgumentCompletions` by Andarist · Pull Request #55867 · microsoft/TypeScript · GitHub

Open Graph Title: Remove `CheckMode.IsForStringLiteralArgumentCompletions` by Andarist · Pull Request #55867 · microsoft/TypeScript

X Title: Remove `CheckMode.IsForStringLiteralArgumentCompletions` by Andarist · Pull Request #55867 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Remove `CheckMode.IsForStringLiteralArgumentCompletions` by Andarist · Pull Request #55867 · microsoft/TypeScript

Open Graph Description: It's just an internal refactor. I initially removed this special check mode almost entirely in #53996 . It was brought up in #54121 . I managed to remove it while reviewing this PR (see here) b...

X Description: It's just an internal refactor. I initially removed this special check mode almost entirely in #53996 . It was brought up in #54121 . I managed to remove it while reviewing this PR (see her...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/55867

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c89f7db9-f56e-7f21-daf6-0ec41fbacfdf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC70:842EC:13F3A8F:1AA6625:6B012DBE
html-safe-nonce56a90a14387250d7a1b9da62dfeafead244e07793983eb7185c4db8ee0105072
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzcwOjg0MkVDOjEzRjNBOEY6MUFBNjYyNTo2QjAxMkRCRSIsInZpc2l0b3JfaWQiOiIzODc2NTU3NzM0MjEyMDg3MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0a3ecefbf2533b9f9e06cfa538eabd92c08b057e5bb5e41b761ae5c672ea98b2
hovercard-subject-tagpull_request:1529608061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/55867/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c6fb50c1a85e61c3126994b297340cb3a198e0762f2a780c7f75dac6bcf99035/microsoft/TypeScript/pull/55867
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c6fb50c1a85e61c3126994b297340cb3a198e0762f2a780c7f75dac6bcf99035/microsoft/TypeScript/pull/55867
og:image:altIt's just an internal refactor. I initially removed this special check mode almost entirely in #53996 . It was brought up in #54121 . I managed to remove it while reviewing this PR (see here) b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/55867#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55867
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55867
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/55867
Reloadhttps://github.com/microsoft/TypeScript/pull/55867
Reloadhttps://github.com/microsoft/TypeScript/pull/55867
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests311 (311)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:get-rid-off-for-string-literal-arg-completionshttps://github.com/Andarist/TypeScript/tree/get-rid-off-for-string-literal-arg-completions
Conversationhttps://github.com/microsoft/TypeScript/pull/55867
Commits1 (1)https://github.com/microsoft/TypeScript/pull/55867/commits
Checkshttps://github.com/microsoft/TypeScript/pull/55867/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/55867/files
Remove CheckMode.IsForStringLiteralArgumentCompletionshttps://github.com/microsoft/TypeScript/pull/55867#top
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:get-rid-off-for-string-literal-arg-completionshttps://github.com/Andarist/TypeScript/tree/get-rid-off-for-string-literal-arg-completions
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/55867#issue-1912384766
#53996https://github.com/microsoft/TypeScript/pull/53996
#54121https://github.com/microsoft/TypeScript/pull/54121
herehttps://github.com/microsoft/TypeScript/pull/54121#issuecomment-1704739925
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/Andarist
Remove CheckMode.IsForStringLiteralArgumentCompletionshttps://github.com/microsoft/TypeScript/pull/55867/commits/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
d1477e0https://github.com/microsoft/TypeScript/pull/55867/commits/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/55867#event-10468136201
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1734562602
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 25, 2023 https://github.com/microsoft/TypeScript/pull/55867#pullrequestreview-1643086478
View reviewed changes https://github.com/microsoft/TypeScript/pull/55867/files/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
tests/cases/fourslash/stringCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypes.tshttps://github.com/microsoft/TypeScript/pull/55867/files/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260#diff-13616dfe7e35d3a34aa70b8e355f0780be2b218657e04c8561c3833a44733cd5
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/55867#discussion_r1336454188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#54121https://github.com/microsoft/TypeScript/pull/54121
#54121https://github.com/microsoft/TypeScript/pull/54121
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Sep 26, 2023 https://github.com/microsoft/TypeScript/pull/55867#pullrequestreview-1644913266
View reviewed changes https://github.com/microsoft/TypeScript/pull/55867/files/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
Jake Bailey (jakebailey)https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/55867#pullrequestreview-1644913266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Ron Buckton (rbuckton)https://github.com/rbuckton
September 26, 2023 19:36https://github.com/microsoft/TypeScript/pull/55867#event-10479349329
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391423
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391470
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
d1477e0https://github.com/microsoft/TypeScript/commit/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158016
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391471
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
d1477e0https://github.com/microsoft/TypeScript/commit/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158018
The results are in!https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741540190
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391472
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
d1477e0https://github.com/microsoft/TypeScript/commit/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158019
The results are in!https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741406355
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391473
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
d1477e0https://github.com/microsoft/TypeScript/commit/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158020
The results are in!https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741477069
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741391474
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
d1477e0https://github.com/microsoft/TypeScript/commit/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158017
The results are in!https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741415399
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741393285
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158016/artifacts?artifactName=tgz&fileId=702CF64F8B3FD4165BC45D1E0BFDFF9180E3E10721483ECE39D2EE338AB3500102&fileName=/typescript-5.3.0-insiders.20230929.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.3.0-pr-55867-7
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.3.0-pr-55867-7
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741406355
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741415399
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=158017&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741477069
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#issuecomment-1741540190
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
efc343ahttps://github.com/microsoft/TypeScript/commit/efc343a43813c6c1988254f711f07b6200644694
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55867#event-10516039747
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/55867#event-20419604165
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55867
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/55867/files/d1477e0d5619ef958cb73e9eb7b6b84ec8a44260
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55867
https://github.com/Andarist
https://github.com/typescript-bot
https://github.com/DanielRosenwasser
https://github.com/jakebailey
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.