René's URL Explorer Experiment


Title: Don't track private symbol roots in other files during js declaration emit by weswigham · Pull Request #55390 · microsoft/TypeScript · GitHub

Open Graph Title: Don't track private symbol roots in other files during js declaration emit by weswigham · Pull Request #55390 · microsoft/TypeScript

X Title: Don't track private symbol roots in other files during js declaration emit by weswigham · Pull Request #55390 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Don't track private symbol roots in other files during js declaration emit by weswigham · Pull Request #55390 · microsoft/TypeScript

Open Graph Description: Fixes #55375 The linked issue only repro'd with strict: false and strictNullChecks: true because without those set, we'd reuse input type nodes much more, and not reprint the union type for...

X Description: Fixes #55375 The linked issue only repro'd with strict: false and strictNullChecks: true because without those set, we'd reuse input type nodes much more, and not reprint the union ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/55390

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:03537f68-1580-c020-a521-8fa24a253618
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA96A:240CD1:D61DF0:111AFDC:6B010468
html-safe-noncea18dd100a3281cb05216930d4672a4a28bcc3f5be89af824266f36cd579343cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTZBOjI0MENEMTpENjFERjA6MTExQUZEQzo2QjAxMDQ2OCIsInZpc2l0b3JfaWQiOiIyNjg3MzMyMTgxMDE3MTY2OTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac83b096648b11034798ffe65847df2c0370f6602ffc58615832775d4b69075180
hovercard-subject-tagpull_request:1476645720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/55390/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2afad9c2739a5d9127e8839365cf12e7eed7e0addf5b53c860559c4b02150c6f/microsoft/TypeScript/pull/55390
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2afad9c2739a5d9127e8839365cf12e7eed7e0addf5b53c860559c4b02150c6f/microsoft/TypeScript/pull/55390
og:image:altFixes #55375 The linked issue only repro'd with strict: false and strictNullChecks: true because without those set, we'd reuse input type nodes much more, and not reprint the union type for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/55390#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55390
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55390
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/55390
Reloadhttps://github.com/microsoft/TypeScript/pull/55390
Reloadhttps://github.com/microsoft/TypeScript/pull/55390
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:js-declaration-emit-doesnt-rename-importhttps://github.com/weswigham/TypeScript/tree/js-declaration-emit-doesnt-rename-import
Conversationhttps://github.com/microsoft/TypeScript/pull/55390
Commits1 (1)https://github.com/microsoft/TypeScript/pull/55390/commits
Checkshttps://github.com/microsoft/TypeScript/pull/55390/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/55390/files
Don't track private symbol roots in other files during js declaration emithttps://github.com/microsoft/TypeScript/pull/55390#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:js-declaration-emit-doesnt-rename-importhttps://github.com/weswigham/TypeScript/tree/js-declaration-emit-doesnt-rename-import
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 15, 2023https://github.com/microsoft/TypeScript/pull/55390#issue-1852296880
#55375https://github.com/microsoft/TypeScript/issues/55375
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55390
https://github.com/weswigham
Dont track private symbol roots in other files during js declaration …https://github.com/microsoft/TypeScript/pull/55390/commits/9551067ff21a5bbaca5c8d5e8e5e2c302d791c23
9551067https://github.com/microsoft/TypeScript/pull/55390/commits/9551067ff21a5bbaca5c8d5e8e5e2c302d791c23
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 15, 2023 23:52https://github.com/microsoft/TypeScript/pull/55390#event-10102493036
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 15, 2023https://github.com/microsoft/TypeScript/pull/55390#event-10102493361
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Aug 15, 2023https://github.com/microsoft/TypeScript/pull/55390#event-10102493422
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 16, 2023 https://github.com/microsoft/TypeScript/pull/55390#pullrequestreview-1581404061
View reviewed changes https://github.com/microsoft/TypeScript/pull/55390/files/9551067ff21a5bbaca5c8d5e8e5e2c302d791c23
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
ffec968https://github.com/microsoft/TypeScript/commit/ffec968d796b3aed7f15ef4dec93f7ae89d68352
Aug 16, 2023https://github.com/microsoft/TypeScript/pull/55390#event-10112799149
Marcus Ording (snovader)https://github.com/snovader
Sep 23, 2023 https://github.com/microsoft/TypeScript/pull/55390#ref-commit-5d341ed
https://github.com/weswigham
https://github.com/snovader
Don't track private symbol roots in other files during js declaration…https://github.com/EG-A-S/TypeScript/commit/5d341edb9ca3ba3802014569554f4c58e9e0b23a
5d341edhttps://github.com/EG-A-S/TypeScript/commit/5d341edb9ca3ba3802014569554f4c58e9e0b23a
microsoft#55390https://github.com/microsoft/TypeScript/pull/55390
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/55390#event-20419590141
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55390
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
https://github.com/microsoft/TypeScript/pull/55390/files/9551067ff21a5bbaca5c8d5e8e5e2c302d791c23
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55390
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Invalid type definitions generated when imported classes have same name https://github.com/microsoft/TypeScript/issues/55375
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55390
https://github.com/weswigham
https://github.com/gabritto
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.