René's URL Explorer Experiment


Title: Improve performance of maybe stack in recursiveTypeRelatedTo by jakebailey · Pull Request #55224 · microsoft/TypeScript · GitHub

Open Graph Title: Improve performance of maybe stack in recursiveTypeRelatedTo by jakebailey · Pull Request #55224 · microsoft/TypeScript

X Title: Improve performance of maybe stack in recursiveTypeRelatedTo by jakebailey · Pull Request #55224 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve performance of maybe stack in recursiveTypeRelatedTo by jakebailey · Pull Request #55224 · microsoft/TypeScript

Open Graph Description: For #54939 I did a pprof profile of #54939 and found that a suspicious amount of time was being spent in recursiveTypeRelatedTo directly (self time). The profile didn't really point to anythin...

X Description: For #54939 I did a pprof profile of #54939 and found that a suspicious amount of time was being spent in recursiveTypeRelatedTo directly (self time). The profile didn't really point to any...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/55224

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b9b5a9e5-2123-b967-9506-48b1a3f3f700
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99E0:65478:FA2995:14CF01A:6B010BCC
html-safe-noncef005a35463182efb8d8484b75b05e496c15f5efdffecaabf66f1d062c8f028a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUUwOjY1NDc4OkZBMjk5NToxNENGMDFBOjZCMDEwQkNDIiwidmlzaXRvcl9pZCI6IjUwMTE0MTc2NjQzODg2NjQyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac28b92e1532ed69138cd15199845d4ed5a718bd504dee70217118751315323ecd
hovercard-subject-tagpull_request:1457392904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/55224/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/beccb8e53e9cce21c54c96ffab9199f37587c46c7d2b74687e955ea1f5fea7b2/microsoft/TypeScript/pull/55224
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/beccb8e53e9cce21c54c96ffab9199f37587c46c7d2b74687e955ea1f5fea7b2/microsoft/TypeScript/pull/55224
og:image:altFor #54939 I did a pprof profile of #54939 and found that a suspicious amount of time was being spent in recursiveTypeRelatedTo directly (self time). The profile didn't really point to anythin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/55224#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55224
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55224
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/55224
Reloadhttps://github.com/microsoft/TypeScript/pull/55224
Reloadhttps://github.com/microsoft/TypeScript/pull/55224
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
jakebailey:fix-54939https://github.com/jakebailey/TypeScript/tree/fix-54939
Conversationhttps://github.com/microsoft/TypeScript/pull/55224
Commits10 (10)https://github.com/microsoft/TypeScript/pull/55224/commits
Checkshttps://github.com/microsoft/TypeScript/pull/55224/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/55224/files
Improve performance of maybe stack in recursiveTypeRelatedTohttps://github.com/microsoft/TypeScript/pull/55224#top
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
jakebailey:fix-54939https://github.com/jakebailey/TypeScript/tree/fix-54939
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issue-1830466492
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
#54939https://github.com/microsoft/TypeScript/issues/54939
#54939https://github.com/microsoft/TypeScript/issues/54939
https://private-user-images.githubusercontent.com/5341706/257410186-9a1695f6-301e-4717-a9fd-b58c6188e610.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyMzA5NjksIm5iZiI6MTc5NTIzMDY2OSwicGF0aCI6Ii81MzQxNzA2LzI1NzQxMDE4Ni05YTE2OTVmNi0zMDFlLTQ3MTctYTlmZC1iNThjNjE4OGU2MTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjExMjFUMDMxMTA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTJiYzRkYWNiODQ0NjY1OTM4YzI5ZWNmMWM5MGU2MWJmOWMyMGFhNmNkOTBmNTQwNDgyOWVhOGM5ZWQ1ZTY2MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.Ha3-eKKH-PWDWzuOOfDRYpn9Q-yaNDMHA-CGGDoonlc
#54939https://github.com/microsoft/TypeScript/issues/54939
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Improve performance of maybe stack in recursiveTypeRelatedTohttps://github.com/microsoft/TypeScript/pull/55224/commits/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
0009999https://github.com/microsoft/TypeScript/pull/55224/commits/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#event-9971797490
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#event-9971797555
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569125
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569155
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156101
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569156
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156105
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659676052
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569157
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156098
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569160
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156103
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659594088
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569162
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156104
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659599168
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569163
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156100
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659699048
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569164
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156102
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659717760
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659569165
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
0009999https://github.com/microsoft/TypeScript/commit/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156099
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659616453
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659570366
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156098/artifacts?artifactName=tgz&fileId=E49FAF5AA96CA28D0EF28A168C4819F4AFF3183D35819C89C86845A911E47DC802&fileName=/typescript-5.2.0-insiders.20230801.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.2.0-pr-55224-9
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.2.0-pr-55224-9
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659594088
Jake Bailey (@jakebailey)https://github.com/jakebailey
rxjs-srchttps://github.com/microsoft/TypeScript/pull/55224
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659599168
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659616453
Jake Bailey (@jakebailey)https://github.com/jakebailey
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156099/artifacts?artifactName=benchmark&fileId=A72A264475CFC1DB0853E38497234AAFA500596A39B38562F799A927A01531D901&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
August 1, 2023 06:00https://github.com/microsoft/TypeScript/pull/55224#event-9972132755
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659620511
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659676052
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659699048
Jake Bailey (@jakebailey)https://github.com/jakebailey
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=156100&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1659717760
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557491041
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/0009999fa8b01ef71ff1782c50eddd3cca9a25dc
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/55224/files/0009999fa8b01ef71ff1782c50eddd3cca9a25dc#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Maybe improve perfhttps://github.com/microsoft/TypeScript/pull/55224/commits/a703f482a86e6a53fba24fde6032c5fbf08a0df8
a703f48https://github.com/microsoft/TypeScript/pull/55224/commits/a703f482a86e6a53fba24fde6032c5fbf08a0df8
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1660859505
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1660859553
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
a703f48https://github.com/microsoft/TypeScript/commit/a703f482a86e6a53fba24fde6032c5fbf08a0df8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156110
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1660940941
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557617431
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/a703f482a86e6a53fba24fde6032c5fbf08a0df8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55224/files/a703f482a86e6a53fba24fde6032c5fbf08a0df8#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1660940941
Jake Bailey (@jakebailey)https://github.com/jakebailey
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156110/artifacts?artifactName=benchmark&fileId=F5BF25217446539EFD84932E93A633C0239CD1C0D2A799C95CC143CF448A6B7701&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Cleanup and docshttps://github.com/microsoft/TypeScript/pull/55224/commits/9e0cf58a69e18e39a229f66610a0506469c7b940
9e0cf58https://github.com/microsoft/TypeScript/pull/55224/commits/9e0cf58a69e18e39a229f66610a0506469c7b940
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1660942267
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 1, 2023 20:34https://github.com/microsoft/TypeScript/pull/55224#event-9980929715
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557797047
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557807402
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557820541
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 1, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1557823242
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55224/files/0907e761b67e1cdae771d6f1d62a6113a77bc068#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (jakebailey)https://github.com/jakebailey
August 1, 2023 14:35https://github.com/microsoft/TypeScript/pull/55224#commits-pushed-c31d069
https://github.com/jakebailey
Re-add debug check on push, it's fast enoughhttps://github.com/microsoft/TypeScript/pull/55224/commits/c31d069fe1f5e014e756af4e10133e57a77b41ab
c31d069https://github.com/microsoft/TypeScript/pull/55224/commits/c31d069fe1f5e014e756af4e10133e57a77b41ab
https://github.com/jakebailey
Pass the value to stop after rather than calling each timehttps://github.com/microsoft/TypeScript/pull/55224/commits/42d68cbae59c87bf97d28707607c9aeb52d3593f
42d68cbhttps://github.com/microsoft/TypeScript/pull/55224/commits/42d68cbae59c87bf97d28707607c9aeb52d3593f
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1661135526
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1661135565
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
42d68cbhttps://github.com/microsoft/TypeScript/commit/42d68cbae59c87bf97d28707607c9aeb52d3593f
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156119
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1661150643
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 1, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1661150643
Jake Bailey (@jakebailey)https://github.com/jakebailey
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156119/artifacts?artifactName=benchmark&fileId=571A3733E7B4624D325D5D57C6400C82D2BBB2594005B62EA17DDEACD751B0A701&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 2, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1662581447
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 2, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1559635143
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/42d68cbae59c87bf97d28707607c9aeb52d3593f
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/55224/files/42d68cbae59c87bf97d28707607c9aeb52d3593f#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 2, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1559939094
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/42d68cbae59c87bf97d28707607c9aeb52d3593f
Jake Bailey (jakebailey)https://github.com/jakebailey
August 3, 2023 14:06https://github.com/microsoft/TypeScript/pull/55224#commits-pushed-b1ceaf2
https://github.com/jakebailey
Merge branch 'main' into fix-54939https://github.com/microsoft/TypeScript/pull/55224/commits/b1ceaf29fa653370a5c462ce59be7a08b4b21014
b1ceaf2https://github.com/microsoft/TypeScript/pull/55224/commits/b1ceaf29fa653370a5c462ce59be7a08b4b21014
https://github.com/jakebailey
Remove abstraction per Anders' feedbackhttps://github.com/microsoft/TypeScript/pull/55224/commits/6e3f4c54db1c7c1c420d1c50228320569eabf896
6e3f4c5https://github.com/microsoft/TypeScript/pull/55224/commits/6e3f4c54db1c7c1c420d1c50228320569eabf896
https://github.com/jakebailey
Remove reference to popping from commenthttps://github.com/microsoft/TypeScript/pull/55224/commits/b59f2b6b623cd1df584b03de658d946bb1b24681
b59f2b6https://github.com/microsoft/TypeScript/pull/55224/commits/b59f2b6b623cd1df584b03de658d946bb1b24681
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664652649
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664652691
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
b59f2b6https://github.com/microsoft/TypeScript/commit/b59f2b6b623cd1df584b03de658d946bb1b24681
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156204
The results are in!https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664709006
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Make parameter requiredhttps://github.com/microsoft/TypeScript/pull/55224/commits/6156ade8ba27990868824946057a03be2f09dcd2
6156adehttps://github.com/microsoft/TypeScript/pull/55224/commits/6156ade8ba27990868824946057a03be2f09dcd2
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664709006
Jake Bailey (@jakebailey)https://github.com/jakebailey
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156204/artifacts?artifactName=benchmark&fileId=EF576283B03D06274A56B346DB3D8C98EA17A1DD6B62300C41D953CAD2E036FB01&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664728610
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664728642
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
6156adehttps://github.com/microsoft/TypeScript/commit/6156ade8ba27990868824946057a03be2f09dcd2
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156206
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#issuecomment-1664729772
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
Jake Bailey (@jakebailey)https://github.com/jakebailey
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156206/artifacts?artifactName=tgz&fileId=A23F0B6FAC0AFB5D85599135F628EAD10B21EAAE0379EC502AC9AB95F5DB736702&fileName=/typescript-5.2.0-insiders.20230803.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.2.0-pr-55224-37
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.2.0-pr-55224-37
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 3, 2023 https://github.com/microsoft/TypeScript/pull/55224#pullrequestreview-1561953021
View reviewed changes https://github.com/microsoft/TypeScript/pull/55224/files/6156ade8ba27990868824946057a03be2f09dcd2
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 3, 2023 https://github.com/microsoft/TypeScript/pull/55224#ref-issue-1795563206
[PERFORMANCE]: TS takes several seconds to validate types resulting in poor DX #54939 https://github.com/microsoft/TypeScript/issues/54939
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
607d96fhttps://github.com/microsoft/TypeScript/commit/607d96f6dfc6dc557fa370d8ae86f5191608ec91
Aug 3, 2023https://github.com/microsoft/TypeScript/pull/55224#event-10003778634
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
August 3, 2023 22:53https://github.com/microsoft/TypeScript/pull/55224#event-10003778994
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 3, 2023 https://github.com/microsoft/TypeScript/pull/55224#ref-issue-1767616387
[BUG]: Extremely slow intellisense depending on schema size and amount drizzle-team/drizzle-orm#800 https://github.com/drizzle-team/drizzle-orm/issues/800
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Mar 28, 2024 https://github.com/microsoft/TypeScript/pull/55224#ref-pullrequest-2214259851
[experiment] Use Sets instead of lists in more places #57992 https://github.com/microsoft/TypeScript/pull/57992
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/55224#event-20419584329
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/55224/files/6156ade8ba27990868824946057a03be2f09dcd2
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55224
https://github.com/jakebailey
https://github.com/typescript-bot
https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.