René's URL Explorer Experiment


Title: Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' by rbuckton · Pull Request #55052 · microsoft/TypeScript · GitHub

Open Graph Title: Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' by rbuckton · Pull Request #55052 · microsoft/TypeScript

X Title: Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' by rbuckton · Pull Request #55052 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' by rbuckton · Pull Request #55052 · microsoft/TypeScript

Open Graph Description: This makes our instanceof narrowing more closely align to Steps 2-3 of the InstanceofOperator algorithm in the ECMA-262 specification by allowing any object type in the right-hand side of instanceo...

X Description: This makes our instanceof narrowing more closely align to Steps 2-3 of the InstanceofOperator algorithm in the ECMA-262 specification by allowing any object type in the right-hand side of instanceo...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/55052

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f3dcc42f-799a-bde2-f45a-a9397cfa3d8a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACBC:33D24F:2761337:328CB17:6B01A5A2
html-safe-nonce6af5ae947369d4551af2cce6342635f2b629e0b12456874cbf985ef71084f5bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0JDOjMzRDI0RjoyNzYxMzM3OjMyOENCMTc6NkIwMUE1QTIiLCJ2aXNpdG9yX2lkIjoiODUwMDU5MzA4NDk5MDU5NjUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacce467f81c9bf372bbbc7c47b92bc015e5c7c5c54aa0cf4523dd7eca8ec9fd7a3
hovercard-subject-tagpull_request:1437812044
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/55052/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99dd1a46485bc81437815506038303178d353aa04d311be84fef8eaf0bc1d24d/microsoft/TypeScript/pull/55052
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99dd1a46485bc81437815506038303178d353aa04d311be84fef8eaf0bc1d24d/microsoft/TypeScript/pull/55052
og:image:altThis makes our instanceof narrowing more closely align to Steps 2-3 of the InstanceofOperator algorithm in the ECMA-262 specification by allowing any object type in the right-hand side of instanceo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerbuckton
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/55052#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/55052
Reloadhttps://github.com/microsoft/TypeScript/pull/55052
Reloadhttps://github.com/microsoft/TypeScript/pull/55052
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Ron Buckton (rbuckton)https://github.com/rbuckton
mainhttps://github.com/microsoft/TypeScript/tree/main
instanceof-Symbol.hasInstancehttps://github.com/microsoft/TypeScript/tree/instanceof-Symbol.hasInstance
Conversationhttps://github.com/microsoft/TypeScript/pull/55052
Commits15 (15)https://github.com/microsoft/TypeScript/pull/55052/commits
Checkshttps://github.com/microsoft/TypeScript/pull/55052/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/55052/files
Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof'https://github.com/microsoft/TypeScript/pull/55052#top
Ron Buckton (rbuckton)https://github.com/rbuckton
mainhttps://github.com/microsoft/TypeScript/tree/main
instanceof-Symbol.hasInstancehttps://github.com/microsoft/TypeScript/tree/instanceof-Symbol.hasInstance
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 17, 2023https://github.com/microsoft/TypeScript/pull/55052#issue-1808315188
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
InstanceofOperatorhttps://tc39.es/ecma262/#sec-instanceofoperator
https://github.com/engine262/engine262/blob/435e533f8bb2f66961e3c16fe67150a0bba745bb/src/completion.mts#L70https://github.com/engine262/engine262/blob/435e533f8bb2f66961e3c16fe67150a0bba745bb/src/completion.mts#L70
#17360https://github.com/microsoft/TypeScript/issues/17360
#39064https://github.com/microsoft/TypeScript/issues/39064
#32080https://github.com/microsoft/TypeScript/issues/32080
#52670https://github.com/microsoft/TypeScript/issues/52670
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
[WIP] Support custom 'Symbol.hasInstance' methods when checking/narro…https://github.com/microsoft/TypeScript/pull/55052/commits/69f59daef2edbcd78833156c5f368fe0505f262e
69f59dahttps://github.com/microsoft/TypeScript/pull/55052/commits/69f59daef2edbcd78833156c5f368fe0505f262e
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 17, 2023https://github.com/microsoft/TypeScript/pull/55052#event-9841040308
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Jul 17, 2023https://github.com/microsoft/TypeScript/pull/55052#event-9841040456
https://github.com/rbuckton
Add tests for instanceof and narrowinghttps://github.com/microsoft/TypeScript/pull/55052/commits/161d1f16bfd6057dc8747c0925e9373717d9f83e
161d1f1https://github.com/microsoft/TypeScript/pull/55052/commits/161d1f16bfd6057dc8747c0925e9373717d9f83e
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 17, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1638949580
on our wiki's API Breaking Changes pagehttps://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Accept baseline, fix linthttps://github.com/microsoft/TypeScript/pull/55052/commits/6a4f838e705bf0cffde30e62bf93f570f8398353
6a4f838https://github.com/microsoft/TypeScript/pull/55052/commits/6a4f838e705bf0cffde30e62bf93f570f8398353
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
July 17, 2023 22:12https://github.com/microsoft/TypeScript/pull/55052#event-9843286087
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
July 17, 2023 22:12https://github.com/microsoft/TypeScript/pull/55052#event-9843288513
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 17, 2023https://github.com/microsoft/TypeScript/pull/55052#event-9843301982
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640886902
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640886940
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155911
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640889265
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155911/artifacts?artifactName=tgz&fileId=97BAAB5AACB42F8DDA14CB27D0D6B4CD5415D110CC5CD3B416AD60372D09BDEC02&fileName=/typescript-5.2.0-insiders.20230718.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.2.0-pr-55052-3
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.2.0-pr-55052-3
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 18, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1535811164
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944094
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944125
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155915
The results are in!https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640974614
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944127
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155912
The results are in!https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641006254
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944128
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155913
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944145
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155914
The results are in!https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641081103
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 18, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1535867980
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640974614
Ron Buckton (@rbuckton)https://github.com/rbuckton
rxjs-srchttps://github.com/microsoft/TypeScript/pull/55052
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641006254
Ron Buckton (@rbuckton)https://github.com/rbuckton
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155912/artifacts?artifactName=benchmark&fileId=C02CF80E010385974E3257315A9F8C792C27E624DC57E0147698D5CDAA86147402&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 18, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641081103
Ron Buckton (@rbuckton)https://github.com/rbuckton
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=155914&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 20, 2023 https://github.com/microsoft/TypeScript/pull/55052#ref-pullrequest-1794047145
Refactor completions into a discriminated union engine262/engine262#222 https://github.com/engine262/engine262/pull/222
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672101845
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 9, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672101892
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
6a4f838https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156423
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 9, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672104112
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156423/artifacts?artifactName=tgz&fileId=BBBB1882B63D1727843C1849163FCC29DE37D3F84D961910EDF835ACC1AB34AC02&fileName=/typescript-5.3.0-insiders.20230809.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.3.0-pr-55052-14
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.3.0-pr-55052-14
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 9, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672188338
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
The results are in!https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672289118
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 19, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1633793420
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (rbuckton)https://github.com/rbuckton
September 19, 2023 15:18https://github.com/microsoft/TypeScript/pull/55052#commits-pushed-4b0eafc
https://github.com/rbuckton
Fix formathttps://github.com/microsoft/TypeScript/pull/55052/commits/4b0eafc43304ddc48b338a213ba9a1f5911554e0
4b0eafchttps://github.com/microsoft/TypeScript/pull/55052/commits/4b0eafc43304ddc48b338a213ba9a1f5911554e0
https://github.com/rbuckton
Address PR feedbackhttps://github.com/microsoft/TypeScript/pull/55052/commits/befa293a880c91110ad57b6d34e924363e8ace85
befa293https://github.com/microsoft/TypeScript/pull/55052/commits/befa293a880c91110ad57b6d34e924363e8ace85
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 19, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1634199302
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
September 20, 2023 20:34https://github.com/microsoft/TypeScript/pull/55052#event-10427512483
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Sep 22, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1638903281
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1638903281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Comment cleanuphttps://github.com/microsoft/TypeScript/pull/55052/commits/559047e72ed967477aa762ddcf573d98607e95a3
559047ehttps://github.com/microsoft/TypeScript/pull/55052/commits/559047e72ed967477aa762ddcf573d98607e95a3
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 22, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1639122084
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/559047e72ed967477aa762ddcf573d98607e95a3
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/559047e72ed967477aa762ddcf573d98607e95a3#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (rbuckton)https://github.com/rbuckton
September 25, 2023 20:47https://github.com/microsoft/TypeScript/pull/55052#commits-pushed-8af777e
https://github.com/rbuckton
Switch synthetic call to use use 'resolveSignature' flowhttps://github.com/microsoft/TypeScript/pull/55052/commits/8af777e8270b79ad59f705ce670daa2f4fbed8cf
8af777ehttps://github.com/microsoft/TypeScript/pull/55052/commits/8af777e8270b79ad59f705ce670daa2f4fbed8cf
https://github.com/rbuckton
Merge branch 'main' into instanceof-Symbol.hasInstancehttps://github.com/microsoft/TypeScript/pull/55052/commits/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a
f3e94f0https://github.com/microsoft/TypeScript/pull/55052/commits/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a
https://github.com/rbuckton
Run formattinghttps://github.com/microsoft/TypeScript/pull/55052/commits/1d90af1a214ca7d85526238c31ceacf82e418dbc
1d90af1https://github.com/microsoft/TypeScript/pull/55052/commits/1d90af1a214ca7d85526238c31ceacf82e418dbc
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 26, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1734685587
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Merge branch 'main' into instanceof-Symbol.hasInstancehttps://github.com/microsoft/TypeScript/pull/55052/commits/b65f9bca73ba26dfe695757954d7b030241d988f
b65f9bchttps://github.com/microsoft/TypeScript/pull/55052/commits/b65f9bca73ba26dfe695757954d7b030241d988f
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Sep 28, 2023 https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1649116313
View reviewed changes https://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1649116313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Remove branch for 'instanceof' error message reportinghttps://github.com/microsoft/TypeScript/pull/55052/commits/0554f56101c81f5dee49c8ea668fa3ff828ba4d1
0554f56https://github.com/microsoft/TypeScript/pull/55052/commits/0554f56101c81f5dee49c8ea668fa3ff828ba4d1
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
9cf44dchttps://github.com/microsoft/TypeScript/commit/9cf44dc51ad0cf28073e4db1e17580b848e53715
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#event-10513907833
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
September 29, 2023 17:37https://github.com/microsoft/TypeScript/pull/55052#event-10513907959
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741266295
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741266357
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Ron Buckton (@rbuckton)https://github.com/rbuckton
0554f56https://github.com/microsoft/TypeScript/commit/0554f56101c81f5dee49c8ea668fa3ff828ba4d1
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158004
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
September 29, 2023 17:39https://github.com/microsoft/TypeScript/pull/55052#event-10513920496
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
September 29, 2023 17:43https://github.com/microsoft/TypeScript/pull/55052#event-10513956657
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741272580
Ron Buckton (@rbuckton)https://github.com/rbuckton
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=158004&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 29, 2023 https://github.com/microsoft/TypeScript/pull/55052#ref-commit-97bf30b
https://github.com/rbuckton
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871
microsoft#55052https://github.com/microsoft/TypeScript/pull/55052
into release-5.3https://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871
97bf30bhttps://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871
69f59dahttps://github.com/typescript-bot/TypeScript/commit/69f59daef2edbcd78833156c5f368fe0505f262e
161d1f1https://github.com/typescript-bot/TypeScript/commit/161d1f16bfd6057dc8747c0925e9373717d9f83e
6a4f838https://github.com/typescript-bot/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353
af6bb55https://github.com/typescript-bot/TypeScript/commit/af6bb551a162d7df4375e4ef604c1b7676aee565
6a83254https://github.com/typescript-bot/TypeScript/commit/6a83254c041a13f2616b4d6ce704ab0210845fbc
511c955https://github.com/typescript-bot/TypeScript/commit/511c9553a307722961f7ce44d6cb4197e6ed321b
9e3adb4https://github.com/typescript-bot/TypeScript/commit/9e3adb45cc2efffcbd27805b17261beeb5279881
4b0eafchttps://github.com/typescript-bot/TypeScript/commit/4b0eafc43304ddc48b338a213ba9a1f5911554e0
befa293https://github.com/typescript-bot/TypeScript/commit/befa293a880c91110ad57b6d34e924363e8ace85
559047ehttps://github.com/typescript-bot/TypeScript/commit/559047e72ed967477aa762ddcf573d98607e95a3
8af777ehttps://github.com/typescript-bot/TypeScript/commit/8af777e8270b79ad59f705ce670daa2f4fbed8cf
f3e94f0https://github.com/typescript-bot/TypeScript/commit/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a
1d90af1https://github.com/typescript-bot/TypeScript/commit/1d90af1a214ca7d85526238c31ceacf82e418dbc
b65f9bchttps://github.com/typescript-bot/TypeScript/commit/b65f9bca73ba26dfe695757954d7b030241d988f
0554f56https://github.com/typescript-bot/TypeScript/commit/0554f56101c81f5dee49c8ea668fa3ff828ba4d1
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741283278
typescript-bot@97bf30bhttps://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 29, 2023https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741284474
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rotu
Dan Rose (rotu)https://github.com/rotu
Nov 25, 2023 https://github.com/microsoft/TypeScript/pull/55052#ref-issue-2010469930
instanceof does not respect inherited Symbol.hasInstance #56536 https://github.com/microsoft/TypeScript/issues/56536
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jul 7, 2024 https://github.com/microsoft/TypeScript/pull/55052#ref-issue-2393848465
Naked generic type returned from iterator method #59161 https://github.com/microsoft/TypeScript/issues/59161
fix: unable to evaluate instanceof AjaxError ReactiveX/rxjs#6275 https://github.com/ReactiveX/rxjs/pull/6275
TS enforces left-hand side of instanceof must be an object type, but it can be any type. #59492 https://github.com/microsoft/TypeScript/issues/59492
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/55052#event-20419579568
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
Types defining Symbol.hasInstance should be eligible to use with the instanceof operator https://github.com/microsoft/TypeScript/issues/39064
Use Symbol.hasInstance for instanceof narrowing, include constructor as part of class structural type https://github.com/microsoft/TypeScript/issues/17360
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/55052
https://github.com/rbuckton
https://github.com/typescript-bot
https://github.com/gabritto
https://github.com/jakebailey
https://github.com/sandersn
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.