| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f3dcc42f-799a-bde2-f45a-a9397cfa3d8a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ACBC:33D24F:2761337:328CB17:6B01A5A2 |
| html-safe-nonce | 6af5ae947369d4551af2cce6342635f2b629e0b12456874cbf985ef71084f5bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0JDOjMzRDI0RjoyNzYxMzM3OjMyOENCMTc6NkIwMUE1QTIiLCJ2aXNpdG9yX2lkIjoiODUwMDU5MzA4NDk5MDU5NjUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ce467f81c9bf372bbbc7c47b92bc015e5c7c5c54aa0cf4523dd7eca8ec9fd7a3 |
| hovercard-subject-tag | pull_request:1437812044 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/55052/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/99dd1a46485bc81437815506038303178d353aa04d311be84fef8eaf0bc1d24d/microsoft/TypeScript/pull/55052 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/99dd1a46485bc81437815506038303178d353aa04d311be84fef8eaf0bc1d24d/microsoft/TypeScript/pull/55052 |
| og:image:alt | This makes our instanceof narrowing more closely align to Steps 2-3 of the InstanceofOperator algorithm in the ECMA-262 specification by allowing any object type in the right-hand side of instanceo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rbuckton |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/55052#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/55052 |
| Reload | https://github.com/microsoft/TypeScript/pull/55052 |
| Reload | https://github.com/microsoft/TypeScript/pull/55052 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| main | https://github.com/microsoft/TypeScript/tree/main |
| instanceof-Symbol.hasInstance | https://github.com/microsoft/TypeScript/tree/instanceof-Symbol.hasInstance |
| Conversation | https://github.com/microsoft/TypeScript/pull/55052 |
| Commits15 (15) | https://github.com/microsoft/TypeScript/pull/55052/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/55052/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/55052/files |
| Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' | https://github.com/microsoft/TypeScript/pull/55052#top |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| main | https://github.com/microsoft/TypeScript/tree/main |
| instanceof-Symbol.hasInstance | https://github.com/microsoft/TypeScript/tree/instanceof-Symbol.hasInstance |
|
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Jul 17, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issue-1808315188 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| InstanceofOperator | https://tc39.es/ecma262/#sec-instanceofoperator |
| https://github.com/engine262/engine262/blob/435e533f8bb2f66961e3c16fe67150a0bba745bb/src/completion.mts#L70 | https://github.com/engine262/engine262/blob/435e533f8bb2f66961e3c16fe67150a0bba745bb/src/completion.mts#L70 |
| #17360 | https://github.com/microsoft/TypeScript/issues/17360 |
| #39064 | https://github.com/microsoft/TypeScript/issues/39064 |
| #32080 | https://github.com/microsoft/TypeScript/issues/32080 |
| #52670 | https://github.com/microsoft/TypeScript/issues/52670 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
| [WIP] Support custom 'Symbol.hasInstance' methods when checking/narro… | https://github.com/microsoft/TypeScript/pull/55052/commits/69f59daef2edbcd78833156c5f368fe0505f262e |
| 69f59da | https://github.com/microsoft/TypeScript/pull/55052/commits/69f59daef2edbcd78833156c5f368fe0505f262e |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Jul 17, 2023 | https://github.com/microsoft/TypeScript/pull/55052#event-9841040308 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Jul 17, 2023 | https://github.com/microsoft/TypeScript/pull/55052#event-9841040456 |
|
| https://github.com/rbuckton |
| Add tests for instanceof and narrowing | https://github.com/microsoft/TypeScript/pull/55052/commits/161d1f16bfd6057dc8747c0925e9373717d9f83e |
| 161d1f1 | https://github.com/microsoft/TypeScript/pull/55052/commits/161d1f16bfd6057dc8747c0925e9373717d9f83e |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 17, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1638949580 |
| on our wiki's API Breaking Changes page | https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Ryan Cavanaugh (@RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
| Accept baseline, fix lint | https://github.com/microsoft/TypeScript/pull/55052/commits/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| 6a4f838 | https://github.com/microsoft/TypeScript/pull/55052/commits/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| July 17, 2023 22:12 | https://github.com/microsoft/TypeScript/pull/55052#event-9843286087 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| July 17, 2023 22:12 | https://github.com/microsoft/TypeScript/pull/55052#event-9843288513 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Jul 17, 2023 | https://github.com/microsoft/TypeScript/pull/55052#event-9843301982 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640886902 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640886940 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155911 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640889265 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155911/artifacts?artifactName=tgz&fileId=97BAAB5AACB42F8DDA14CB27D0D6B4CD5415D110CC5CD3B416AD60372D09BDEC02&fileName=/typescript-5.2.0-insiders.20230718.tgz |
| for this build | https://www.staging-typescript.org/play?ts=5.2.0-pr-55052-3 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.2.0-pr-55052-3 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
|
Jul 18, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1535811164 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944094 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944125 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155915 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640974614 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944127 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155912 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641006254 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944128 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155913 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640944145 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155914 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641081103 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
|
Jul 18, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1535867980 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1640974614 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| rxjs-src | https://github.com/microsoft/TypeScript/pull/55052 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641006254 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155912/artifacts?artifactName=benchmark&fileId=C02CF80E010385974E3257315A9F8C792C27E624DC57E0147698D5CDAA86147402&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jul 18, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1641081103 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=155914&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Jul 20, 2023
| https://github.com/microsoft/TypeScript/pull/55052#ref-pullrequest-1794047145 |
|
Refactor completions into a discriminated union
engine262/engine262#222
| https://github.com/engine262/engine262/pull/222 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Aug 9, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672101845 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 9, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672101892 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 6a4f838 | https://github.com/microsoft/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=156423 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 9, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672104112 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156423/artifacts?artifactName=tgz&fileId=BBBB1882B63D1727843C1849163FCC29DE37D3F84D961910EDF835ACC1AB34AC02&fileName=/typescript-5.3.0-insiders.20230809.tgz |
| for this build | https://www.staging-typescript.org/play?ts=5.3.0-pr-55052-14 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.3.0-pr-55052-14 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Aug 9, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672188338 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1672289118 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 19, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1633793420 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/9e3adb45cc2efffcbd27805b17261beeb5279881#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 19, 2023 15:18 | https://github.com/microsoft/TypeScript/pull/55052#commits-pushed-4b0eafc |
|
| https://github.com/rbuckton |
| Fix format | https://github.com/microsoft/TypeScript/pull/55052/commits/4b0eafc43304ddc48b338a213ba9a1f5911554e0 |
| 4b0eafc | https://github.com/microsoft/TypeScript/pull/55052/commits/4b0eafc43304ddc48b338a213ba9a1f5911554e0 |
|
| https://github.com/rbuckton |
| Address PR feedback | https://github.com/microsoft/TypeScript/pull/55052/commits/befa293a880c91110ad57b6d34e924363e8ace85 |
| befa293 | https://github.com/microsoft/TypeScript/pull/55052/commits/befa293a880c91110ad57b6d34e924363e8ace85 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 19, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1634199302 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| September 20, 2023 20:34 | https://github.com/microsoft/TypeScript/pull/55052#event-10427512483 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Sep 22, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1638903281 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1638903281 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
| Comment cleanup | https://github.com/microsoft/TypeScript/pull/55052/commits/559047e72ed967477aa762ddcf573d98607e95a3 |
| 559047e | https://github.com/microsoft/TypeScript/pull/55052/commits/559047e72ed967477aa762ddcf573d98607e95a3 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Sep 22, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1639122084 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/559047e72ed967477aa762ddcf573d98607e95a3 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/559047e72ed967477aa762ddcf573d98607e95a3#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 25, 2023 20:47 | https://github.com/microsoft/TypeScript/pull/55052#commits-pushed-8af777e |
|
| https://github.com/rbuckton |
| Switch synthetic call to use use 'resolveSignature' flow | https://github.com/microsoft/TypeScript/pull/55052/commits/8af777e8270b79ad59f705ce670daa2f4fbed8cf |
| 8af777e | https://github.com/microsoft/TypeScript/pull/55052/commits/8af777e8270b79ad59f705ce670daa2f4fbed8cf |
|
| https://github.com/rbuckton |
| Merge branch 'main' into instanceof-Symbol.hasInstance | https://github.com/microsoft/TypeScript/pull/55052/commits/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a |
| f3e94f0 | https://github.com/microsoft/TypeScript/pull/55052/commits/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a |
|
| https://github.com/rbuckton |
| Run formatting | https://github.com/microsoft/TypeScript/pull/55052/commits/1d90af1a214ca7d85526238c31ceacf82e418dbc |
| 1d90af1 | https://github.com/microsoft/TypeScript/pull/55052/commits/1d90af1a214ca7d85526238c31ceacf82e418dbc |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 26, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1734685587 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
| Merge branch 'main' into instanceof-Symbol.hasInstance | https://github.com/microsoft/TypeScript/pull/55052/commits/b65f9bca73ba26dfe695757954d7b030241d988f |
| b65f9bc | https://github.com/microsoft/TypeScript/pull/55052/commits/b65f9bca73ba26dfe695757954d7b030241d988f |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Sep 28, 2023
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1649116313 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| https://github.com/microsoft/TypeScript/pull/55052#pullrequestreview-1649116313 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
| Remove branch for 'instanceof' error message reporting | https://github.com/microsoft/TypeScript/pull/55052/commits/0554f56101c81f5dee49c8ea668fa3ff828ba4d1 |
| 0554f56 | https://github.com/microsoft/TypeScript/pull/55052/commits/0554f56101c81f5dee49c8ea668fa3ff828ba4d1 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| 9cf44dc | https://github.com/microsoft/TypeScript/commit/9cf44dc51ad0cf28073e4db1e17580b848e53715 |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#event-10513907833 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 29, 2023 17:37 | https://github.com/microsoft/TypeScript/pull/55052#event-10513907959 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741266295 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741266357 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| 0554f56 | https://github.com/microsoft/TypeScript/commit/0554f56101c81f5dee49c8ea668fa3ff828ba4d1 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=158004 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 29, 2023 17:39 | https://github.com/microsoft/TypeScript/pull/55052#event-10513920496 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 29, 2023 17:43 | https://github.com/microsoft/TypeScript/pull/55052#event-10513956657 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741272580 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=158004&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Sep 29, 2023
| https://github.com/microsoft/TypeScript/pull/55052#ref-commit-97bf30b |
|
| https://github.com/rbuckton |
|
| https://github.com/typescript-bot |
| Cherry-pick PR | https://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871 |
| microsoft#55052 | https://github.com/microsoft/TypeScript/pull/55052 |
| into release-5.3 | https://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871 |
| 97bf30b | https://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871 |
| 69f59da | https://github.com/typescript-bot/TypeScript/commit/69f59daef2edbcd78833156c5f368fe0505f262e |
| 161d1f1 | https://github.com/typescript-bot/TypeScript/commit/161d1f16bfd6057dc8747c0925e9373717d9f83e |
| 6a4f838 | https://github.com/typescript-bot/TypeScript/commit/6a4f838e705bf0cffde30e62bf93f570f8398353 |
| af6bb55 | https://github.com/typescript-bot/TypeScript/commit/af6bb551a162d7df4375e4ef604c1b7676aee565 |
| 6a83254 | https://github.com/typescript-bot/TypeScript/commit/6a83254c041a13f2616b4d6ce704ab0210845fbc |
| 511c955 | https://github.com/typescript-bot/TypeScript/commit/511c9553a307722961f7ce44d6cb4197e6ed321b |
| 9e3adb4 | https://github.com/typescript-bot/TypeScript/commit/9e3adb45cc2efffcbd27805b17261beeb5279881 |
| 4b0eafc | https://github.com/typescript-bot/TypeScript/commit/4b0eafc43304ddc48b338a213ba9a1f5911554e0 |
| befa293 | https://github.com/typescript-bot/TypeScript/commit/befa293a880c91110ad57b6d34e924363e8ace85 |
| 559047e | https://github.com/typescript-bot/TypeScript/commit/559047e72ed967477aa762ddcf573d98607e95a3 |
| 8af777e | https://github.com/typescript-bot/TypeScript/commit/8af777e8270b79ad59f705ce670daa2f4fbed8cf |
| f3e94f0 | https://github.com/typescript-bot/TypeScript/commit/f3e94f0dedf75d6e8e51aa36fdb798d15b8b006a |
| 1d90af1 | https://github.com/typescript-bot/TypeScript/commit/1d90af1a214ca7d85526238c31ceacf82e418dbc |
| b65f9bc | https://github.com/typescript-bot/TypeScript/commit/b65f9bca73ba26dfe695757954d7b030241d988f |
| 0554f56 | https://github.com/typescript-bot/TypeScript/commit/0554f56101c81f5dee49c8ea668fa3ff828ba4d1 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741283278 |
| typescript-bot@97bf30b | https://github.com/typescript-bot/TypeScript/commit/97bf30b22d91a816a8195c6d2fa175897fb52871 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 29, 2023 | https://github.com/microsoft/TypeScript/pull/55052#issuecomment-1741284474 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
| https://github.com/rotu |
| Dan Rose (rotu) | https://github.com/rotu |
|
Nov 25, 2023
| https://github.com/microsoft/TypeScript/pull/55052#ref-issue-2010469930 |
|
instanceof does not respect inherited Symbol.hasInstance
#56536
| https://github.com/microsoft/TypeScript/issues/56536 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
|
Jul 7, 2024
| https://github.com/microsoft/TypeScript/pull/55052#ref-issue-2393848465 |
|
Naked generic type returned from iterator method
#59161
| https://github.com/microsoft/TypeScript/issues/59161 |
|
fix: unable to evaluate instanceof AjaxError
ReactiveX/rxjs#6275
| https://github.com/ReactiveX/rxjs/pull/6275 |
|
TS enforces left-hand side of instanceof must be an object type, but it can be any type.
#59492
| https://github.com/microsoft/TypeScript/issues/59492 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 22, 2025 | https://github.com/microsoft/TypeScript/pull/55052#event-20419579568 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F55052 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/55052/files/befa293a880c91110ad57b6d34e924363e8ace85 |
|
| https://github.com/ahejlsberg |
|
Anders Hejlsberg (ahejlsberg)
| https://github.com/ahejlsberg |
|
| https://github.com/microsoft/TypeScript/pull/55052/files/b65f9bca73ba26dfe695757954d7b030241d988f |
|
| https://github.com/gabritto |
|
Gabriela Araujo Britto (gabritto)
| https://github.com/gabritto |
|
| https://github.com/microsoft/TypeScript/pull/55052/files/6a4f838e705bf0cffde30e62bf93f570f8398353 |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Types defining Symbol.hasInstance should be eligible to use with the instanceof operator
| https://github.com/microsoft/TypeScript/issues/39064 |
|
Use Symbol.hasInstance for instanceof narrowing, include constructor as part of class structural type
| https://github.com/microsoft/TypeScript/issues/17360 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/55052 |
|
| https://github.com/rbuckton |
|
| https://github.com/typescript-bot |
|
| https://github.com/gabritto |
|
| https://github.com/jakebailey |
|
| https://github.com/sandersn |
|
| https://github.com/ahejlsberg |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |