René's URL Explorer Experiment


Title: Forbid this as constructor parameter type by sandersn · Pull Request #5474 · microsoft/TypeScript · GitHub

Open Graph Title: Forbid this as constructor parameter type by sandersn · Pull Request #5474 · microsoft/TypeScript

X Title: Forbid this as constructor parameter type by sandersn · Pull Request #5474 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Forbid this as constructor parameter type by sandersn · Pull Request #5474 · microsoft/TypeScript

Open Graph Description: Fixes #5449. Thanks Anders Hejlsberg (@ahejlsberg) for pointing out how to fix this. If you have a better way to find out whether something is a constructor parameter, please do suggest it.

X Description: Fixes #5449. Thanks Anders Hejlsberg (@ahejlsberg) for pointing out how to fix this. If you have a better way to find out whether something is a constructor parameter, please do suggest it.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/5474

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d51333a6-3f1a-1503-8edb-f1c8156826fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9952:882E2:12FB05E:19077E0:6B0116DA
html-safe-nonce839762c84957969e5614e3ecc7d3c61ad2989842c03fbabf72245c3519f744d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTUyOjg4MkUyOjEyRkIwNUU6MTkwNzdFMDo2QjAxMTZEQSIsInZpc2l0b3JfaWQiOiI3NTk2MTEwMDI1MTM1ODIyNTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac03c1bc53b9f1824aaf375648737f636314f285472fd32d61e3134b0fcdda1ea2
hovercard-subject-tagpull_request:49324204
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/5474/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/71bbfd4c41f76a4b7e0d53bbab5360fc7be4fa1ab677430511a0b5dff24a5938/microsoft/TypeScript/pull/5474
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71bbfd4c41f76a4b7e0d53bbab5360fc7be4fa1ab677430511a0b5dff24a5938/microsoft/TypeScript/pull/5474
og:image:altFixes #5449. Thanks Anders Hejlsberg (@ahejlsberg) for pointing out how to fix this. If you have a better way to find out whether something is a constructor parameter, please do suggest it.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/5474#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5474
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5474
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/5474
Reloadhttps://github.com/microsoft/TypeScript/pull/5474
Reloadhttps://github.com/microsoft/TypeScript/pull/5474
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
forbid-this-as-constructor-parameter-typehttps://github.com/microsoft/TypeScript/tree/forbid-this-as-constructor-parameter-type
Conversationhttps://github.com/microsoft/TypeScript/pull/5474
Commits6 (6)https://github.com/microsoft/TypeScript/pull/5474/commits
Checkshttps://github.com/microsoft/TypeScript/pull/5474/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/5474/files
Forbid this as constructor parameter typehttps://github.com/microsoft/TypeScript/pull/5474#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
forbid-this-as-constructor-parameter-typehttps://github.com/microsoft/TypeScript/tree/forbid-this-as-constructor-parameter-type
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#issue-114358575
#5449https://github.com/microsoft/TypeScript/issues/5449
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 30, 2015 14:01https://github.com/microsoft/TypeScript/pull/5474#commits-pushed-c82d4a6
https://github.com/sandersn
Forbid 'this' as constructor parameter typehttps://github.com/microsoft/TypeScript/pull/5474/commits/c82d4a61e39d3ba5fc42618dda92c2375a706b85
c82d4a6https://github.com/microsoft/TypeScript/pull/5474/commits/c82d4a61e39d3ba5fc42618dda92c2375a706b85
https://github.com/sandersn
Add tests based onhttps://github.com/microsoft/TypeScript/pull/5474/commits/e609047b786f051aa8dd90e8823b516a41894c36
#5449https://github.com/microsoft/TypeScript/issues/5449
e609047https://github.com/microsoft/TypeScript/pull/5474/commits/e609047b786f051aa8dd90e8823b516a41894c36
https://github.com/sandersn
Accept baselineshttps://github.com/microsoft/TypeScript/pull/5474/commits/84b894769e33aad84d2bbff209c73db6aa39ab3d
84b8947https://github.com/microsoft/TypeScript/pull/5474/commits/84b894769e33aad84d2bbff209c73db6aa39ab3d
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#event-450866486
ahejlsberghttps://github.com/ahejlsberg
Oct 30, 2015 https://github.com/microsoft/TypeScript/pull/5474#discussion-diff-43554631
View reviewed changes https://github.com/microsoft/TypeScript/pull/5474/files/84b894769e33aad84d2bbff209c73db6aa39ab3d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/5474/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#discussion_r43554631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#discussion_r43554764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#discussion_r43557490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#issuecomment-152658511
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/sandersn
Fix isConstructorParameterhttps://github.com/microsoft/TypeScript/pull/5474/commits/6aecd43d9a7edca358df3e0ef629e0b2d994c6d0
6aecd43https://github.com/microsoft/TypeScript/pull/5474/commits/6aecd43d9a7edca358df3e0ef629e0b2d994c6d0
ahejlsberghttps://github.com/ahejlsberg
Oct 30, 2015 https://github.com/microsoft/TypeScript/pull/5474#discussion-diff-43563344
View reviewed changes https://github.com/microsoft/TypeScript/pull/5474/files/6aecd43d9a7edca358df3e0ef629e0b2d994c6d0#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/5474/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5474#discussion_r43563344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/sandersn
Switch to isNodeDescendantOfhttps://github.com/microsoft/TypeScript/pull/5474/commits/201266b97fa30087f13a84ab90fc647e23e41389
201266bhttps://github.com/microsoft/TypeScript/pull/5474/commits/201266b97fa30087f13a84ab90fc647e23e41389
ahejlsberghttps://github.com/ahejlsberg
Nov 2, 2015 https://github.com/microsoft/TypeScript/pull/5474#discussion-diff-43658880
View reviewed changes https://github.com/microsoft/TypeScript/pull/5474/files/201266b97fa30087f13a84ab90fc647e23e41389#diff-245b228017bc68b83368ffe4faa507fd96183245d1376774c984762ad2788872
tests/cases/conformance/types/thisType/thisTypeErrors2.tshttps://github.com/microsoft/TypeScript/pull/5474/files#diff-245b228017bc68b83368ffe4faa507fd96183245d1376774c984762ad2788872
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 2, 2015https://github.com/microsoft/TypeScript/pull/5474#discussion_r43658880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 2, 2015https://github.com/microsoft/TypeScript/pull/5474#issuecomment-153102623
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/sandersn
Add a variable of type this in constructor bodyhttps://github.com/microsoft/TypeScript/pull/5474/commits/67b9647069322eb3a29f8926500d834b89b0b5ee
67b9647https://github.com/microsoft/TypeScript/pull/5474/commits/67b9647069322eb3a29f8926500d834b89b0b5ee
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 2, 2015 https://github.com/microsoft/TypeScript/pull/5474#ref-commit-cc64210
https://github.com/sandersn
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/cc64210519bcc1ddc7ca9a02a2603469fdbbe1fc
#5474https://github.com/microsoft/TypeScript/pull/5474
from Microsoft/forbid-this-as-constructor-pa…https://github.com/microsoft/TypeScript/commit/cc64210519bcc1ddc7ca9a02a2603469fdbbe1fc
cc64210https://github.com/microsoft/TypeScript/commit/cc64210519bcc1ddc7ca9a02a2603469fdbbe1fc
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
cc64210https://github.com/microsoft/TypeScript/commit/cc64210519bcc1ddc7ca9a02a2603469fdbbe1fc
Nov 2, 2015https://github.com/microsoft/TypeScript/pull/5474#event-452348446
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
November 2, 2015 19:04https://github.com/microsoft/TypeScript/pull/5474#event-452348531
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/5474#event-1689622187
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5474
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
Argument of type 'this' is not assignable to parameter of type 'this'. https://github.com/microsoft/TypeScript/issues/5449
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5474
https://github.com/sandersn
https://github.com/DanielRosenwasser
https://github.com/ahejlsberg
https://github.com/weswigham
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.