René's URL Explorer Experiment


Title: Fixed a regression with string completions not being available directly in arguments typed using rest parameter by Andarist · Pull Request #54588 · microsoft/TypeScript · GitHub

Open Graph Title: Fixed a regression with string completions not being available directly in arguments typed using rest parameter by Andarist · Pull Request #54588 · microsoft/TypeScript

X Title: Fixed a regression with string completions not being available directly in arguments typed using rest parameter by Andarist · Pull Request #54588 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fixed a regression with string completions not being available directly in arguments typed using rest parameter by Andarist · Pull Request #54588 · microsoft/TypeScript

Open Graph Description: fixes #54572 (a regression from #52717 ) cc Andrew Branch (@andrewbranch)

X Description: fixes #54572 (a regression from #52717 ) cc Andrew Branch (@andrewbranch)

Opengraph URL: https://github.com/microsoft/TypeScript/pull/54588

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8145f973-aedc-0a1d-89ce-34b11875565b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD68:24A0A:BEC646:EFBE6D:6B012CD0
html-safe-nonce2dcf379b1885613574be459d2ae85a2c2687a0e9649a55a28badb35b995b746c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDY4OjI0QTBBOkJFQzY0NjpFRkJFNkQ6NkIwMTJDRDAiLCJ2aXNpdG9yX2lkIjoiNjc5ODIxNTkwMzEwNTMzMDM4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59d692da5e8e34447cff9ffb866488a9b18cbdbb0c6506ef3256dbcf0b272212
hovercard-subject-tagpull_request:1386504452
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/54588/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b337091e24a1b863d2875193b213ea7424bf581cb98c1b5af9ea2bf36231ddd3/microsoft/TypeScript/pull/54588
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b337091e24a1b863d2875193b213ea7424bf581cb98c1b5af9ea2bf36231ddd3/microsoft/TypeScript/pull/54588
og:image:altfixes #54572 (a regression from #52717 ) cc Andrew Branch (@andrewbranch)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/54588#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54588
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54588
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/54588
Reloadhttps://github.com/microsoft/TypeScript/pull/54588
Reloadhttps://github.com/microsoft/TypeScript/pull/54588
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests311 (311)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/string-literal-directly-in-resthttps://github.com/Andarist/TypeScript/tree/fix/string-literal-directly-in-rest
Conversationhttps://github.com/microsoft/TypeScript/pull/54588
Commits1 (1)https://github.com/microsoft/TypeScript/pull/54588/commits
Checkshttps://github.com/microsoft/TypeScript/pull/54588/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/54588/files
Fixed a regression with string completions not being available directly in arguments typed using rest parameterhttps://github.com/microsoft/TypeScript/pull/54588#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/string-literal-directly-in-resthttps://github.com/Andarist/TypeScript/tree/fix/string-literal-directly-in-rest
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 9, 2023https://github.com/microsoft/TypeScript/pull/54588#issue-1750239225
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
#54572https://github.com/microsoft/TypeScript/issues/54572
#52717https://github.com/microsoft/TypeScript/pull/52717
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/Andarist
Fixed a regression with string completions not being available direct…https://github.com/microsoft/TypeScript/pull/54588/commits/8e1f8b6c7a11cec03382bc0732114747a3a843d1
8e1f8b6https://github.com/microsoft/TypeScript/pull/54588/commits/8e1f8b6c7a11cec03382bc0732114747a3a843d1
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Jun 9, 2023https://github.com/microsoft/TypeScript/pull/54588#event-9486586210
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 9, 2023 https://github.com/microsoft/TypeScript/pull/54588#pullrequestreview-1472699046
View reviewed changes https://github.com/microsoft/TypeScript/pull/54588/files/8e1f8b6c7a11cec03382bc0732114747a3a843d1
src/services/stringCompletions.tshttps://github.com/microsoft/TypeScript/pull/54588/files/8e1f8b6c7a11cec03382bc0732114747a3a843d1#diff-3348dda4cea653e350948f038ce30f8c824e834bc7354128cc4c1d6858370084
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 9, 2023https://github.com/microsoft/TypeScript/pull/54588#discussion_r1224559535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 9, 2023https://github.com/microsoft/TypeScript/pull/54588#discussion_r1224562013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/microsoft/TypeScript/pull/53996/files#diff-3348dda4cea653e350948f038ce30f8c824e834bc7354128cc4c1d6858370084R391
#54121https://github.com/microsoft/TypeScript/pull/54121
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jun 12, 2023 https://github.com/microsoft/TypeScript/pull/54588#pullrequestreview-1475767997
View reviewed changes https://github.com/microsoft/TypeScript/pull/54588/files/8e1f8b6c7a11cec03382bc0732114747a3a843d1
Andrew Branch (andrewbranch)https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/54588#pullrequestreview-1475767997
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/abbe0d6e7b7569e26799cb25d0a1c090ae7171363e7ed807ea9568f18fe694bd/68747470733a2f2f6d656469612e74656e6f722e636f6d2f41414d6c6b566e446a586741414141432f6974732d67726f756e64686f672d6461792d616761696e2d7265706f7274696e672e676966
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
d95caa5https://github.com/microsoft/TypeScript/commit/d95caa51fcf907b8f23d67ce209a6ef7f1d482a4
Jun 12, 2023https://github.com/microsoft/TypeScript/pull/54588#event-9508416540
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 13, 2023https://github.com/microsoft/TypeScript/pull/54588#issuecomment-1588567462
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jun 13, 2023https://github.com/microsoft/TypeScript/pull/54588#issuecomment-1589642446
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jun 13, 2023https://github.com/microsoft/TypeScript/pull/54588#issuecomment-1589645968
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2023https://github.com/microsoft/TypeScript/pull/54588#issuecomment-1589646039
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
8e1f8b6https://github.com/microsoft/TypeScript/commit/8e1f8b6c7a11cec03382bc0732114747a3a843d1
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=155465
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2023 https://github.com/microsoft/TypeScript/pull/54588#ref-pullrequest-1755281314
🤖 Pick PR #54588 (Fixed a regression with string comp...) into release-5.1 #54635 https://github.com/microsoft/TypeScript/pull/54635
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2023https://github.com/microsoft/TypeScript/pull/54588#issuecomment-1589655590
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
#54635https://github.com/microsoft/TypeScript/pull/54635
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2023 https://github.com/microsoft/TypeScript/pull/54588#ref-commit-1e896e5
https://github.com/Andarist
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/1e896e50087635a65e451232d12de3f34140b549
microsoft#54588https://github.com/microsoft/TypeScript/pull/54588
into release-5.1https://github.com/typescript-bot/TypeScript/commit/1e896e50087635a65e451232d12de3f34140b549
1e896e5https://github.com/typescript-bot/TypeScript/commit/1e896e50087635a65e451232d12de3f34140b549
8e1f8b6https://github.com/typescript-bot/TypeScript/commit/8e1f8b6c7a11cec03382bc0732114747a3a843d1
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
June 13, 2023 17:09https://github.com/microsoft/TypeScript/pull/54588#event-9518984873
Add extra test cases for string literal completions #54714 https://github.com/microsoft/TypeScript/pull/54714
Code completion stopped working for a few scenarios in typescript 5.1 #54710 https://github.com/microsoft/TypeScript/issues/54710
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jun 26, 2023 https://github.com/microsoft/TypeScript/pull/54588#ref-commit-db3575a
https://github.com/Andarist
🤖 Pick PRhttps://github.com/microsoft/TypeScript/commit/db3575ab8a91ef5401f7b05bd00ec85db7f0d51d
#54588https://github.com/microsoft/TypeScript/pull/54588
(Fixed a regression with string comp...) into releas…https://github.com/microsoft/TypeScript/commit/db3575ab8a91ef5401f7b05bd00ec85db7f0d51d
db3575ahttps://github.com/microsoft/TypeScript/commit/db3575ab8a91ef5401f7b05bd00ec85db7f0d51d
#54635https://github.com/microsoft/TypeScript/pull/54635
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/54588#event-20419563294
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54588
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/54588/files/8e1f8b6c7a11cec03382bc0732114747a3a843d1
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Regression in autocompletion on spread generic arguments https://github.com/microsoft/TypeScript/issues/54572
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54588
https://github.com/Andarist
https://github.com/andrewbranch
https://github.com/DanielRosenwasser
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.