René's URL Explorer Experiment


Title: Narrow on else branch of multi-conditional guard by weswigham · Pull Request #5427 · microsoft/TypeScript · GitHub

Open Graph Title: Narrow on else branch of multi-conditional guard by weswigham · Pull Request #5427 · microsoft/TypeScript

X Title: Narrow on else branch of multi-conditional guard by weswigham · Pull Request #5427 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Narrow on else branch of multi-conditional guard by weswigham · Pull Request #5427 · microsoft/TypeScript

Open Graph Description: Fixes #1270. Removing the short-circuiting logic "shortcut" (which actually did an extra narrow when it doesn't strictly need to) fixes the issue.

X Description: Fixes #1270. Removing the short-circuiting logic "shortcut" (which actually did an extra narrow when it doesn't strictly need to) fixes the issue.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/5427

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:72ce686d-e95a-124f-a37b-374edc697be9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id979E:181AFD:27F852:36CB1A:6AFC02B5
html-safe-nonceeb8100fc406bd1206e76eaaf7762276f2f399a0575f0d0e81b82784c13005590
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzlFOjE4MUFGRDoyN0Y4NTI6MzZDQjFBOjZBRkMwMkI1IiwidmlzaXRvcl9pZCI6Ijc1NjE1MzY0MTAyODEwNTA4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca613183b319227a15a6a14f55f91bc66d97e875aac1babfe0c22635d208c700e
hovercard-subject-tagpull_request:48949756
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/5427/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0f5a08c94534cb5108dbd18c905ee41a9c58e0cae4d56346f09281ff7a772692/microsoft/TypeScript/pull/5427
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0f5a08c94534cb5108dbd18c905ee41a9c58e0cae4d56346f09281ff7a772692/microsoft/TypeScript/pull/5427
og:image:altFixes #1270. Removing the short-circuiting logic "shortcut" (which actually did an extra narrow when it doesn't strictly need to) fixes the issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/5427#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5427
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5427
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/5427
Reloadhttps://github.com/microsoft/TypeScript/pull/5427
Reloadhttps://github.com/microsoft/TypeScript/pull/5427
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests336 (336)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:narrow-and-else-branchhttps://github.com/weswigham/TypeScript/tree/narrow-and-else-branch
Conversationhttps://github.com/microsoft/TypeScript/pull/5427
Commits2 (2)https://github.com/microsoft/TypeScript/pull/5427/commits
Checkshttps://github.com/microsoft/TypeScript/pull/5427/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/5427/files
Narrow on else branch of multi-conditional guardhttps://github.com/microsoft/TypeScript/pull/5427#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:narrow-and-else-branchhttps://github.com/weswigham/TypeScript/tree/narrow-and-else-branch
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issue-113715333
#1270https://github.com/microsoft/TypeScript/issues/1270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
Wesley Wigham (weswigham)https://github.com/weswigham
October 27, 2015 16:29https://github.com/microsoft/TypeScript/pull/5427#commits-pushed-cf52ce6
https://github.com/weswigham
new testhttps://github.com/microsoft/TypeScript/pull/5427/commits/cf52ce63a4aed7d3ee609b51ed9be7adb8a9c7a9
cf52ce6https://github.com/microsoft/TypeScript/pull/5427/commits/cf52ce63a4aed7d3ee609b51ed9be7adb8a9c7a9
https://github.com/weswigham
fix it and accept new baselineshttps://github.com/microsoft/TypeScript/pull/5427/commits/41e84e11d23e57a8194f8b3cfe29cdfbe9250f31
41e84e1https://github.com/microsoft/TypeScript/pull/5427/commits/41e84e11d23e57a8194f8b3cfe29cdfbe9250f31
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-already-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-already-signed
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#event-447459873
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-151906108
#4874https://github.com/microsoft/TypeScript/issues/4874
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-151906789
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-151908937
#1270https://github.com/microsoft/TypeScript/issues/1270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-151967336
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-151976794
#4029https://github.com/microsoft/TypeScript/issues/4029
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 28, 2015 https://github.com/microsoft/TypeScript/pull/5427#ref-pullrequest-113948924
Improve type guard consistiency #5442 https://github.com/microsoft/TypeScript/pull/5442
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5427#issuecomment-152384556
#5442https://github.com/microsoft/TypeScript/pull/5442
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 30, 2015https://github.com/microsoft/TypeScript/pull/5427#event-449946185
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Feb 26, 2016 https://github.com/microsoft/TypeScript/pull/5427#ref-pullrequest-97639239
Adds empty object narrowing to type guards #4051 https://github.com/microsoft/TypeScript/pull/4051
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
August 17, 2017 23:03https://github.com/microsoft/TypeScript/pull/5427#event-1211044255
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/5427#event-1689621638
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5427
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
Type guard narrowing doesn't occur in else branch of conditionals with multiple conditions https://github.com/microsoft/TypeScript/issues/1270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5427
https://github.com/weswigham
https://github.com/sandersn
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.