René's URL Explorer Experiment


Title: Use union types for all common classes of AST nodes by weswigham · Pull Request #54148 · microsoft/TypeScript · GitHub

Open Graph Title: Use union types for all common classes of AST nodes by weswigham · Pull Request #54148 · microsoft/TypeScript

X Title: Use union types for all common classes of AST nodes by weswigham · Pull Request #54148 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Use union types for all common classes of AST nodes by weswigham · Pull Request #54148 · microsoft/TypeScript

Open Graph Description: Like Node, Expression, TypeNode, and the like. This allows us to make many more switch statements in our codebase exhaustive (a change not included in this PR, which just swaps over to unions and f...

X Description: Like Node, Expression, TypeNode, and the like. This allows us to make many more switch statements in our codebase exhaustive (a change not included in this PR, which just swaps over to unions and f...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/54148

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd76957d-52ca-6302-6dfe-ca3e6719b6f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1BE:A99C2:F41FC6:139B432:6B00FBA0
html-safe-nonce9281b899333a8637ec74a7c14dde1d39a190eb5c4c26d7effaf821cfae57277a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUJFOkE5OUMyOkY0MUZDNjoxMzlCNDMyOjZCMDBGQkEwIiwidmlzaXRvcl9pZCI6IjQ5ODQ5MjU5NzEwOTk0ODMwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac091e03eb770c8b95ed85102b135374af9c5ca5155468e61db5307d8dab95b2c1
hovercard-subject-tagpull_request:1339453819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/54148/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c282ee53645f256d2bb4b79ee5f89852b10f77c2c0c20ef22b2dbfa096fbe5b/microsoft/TypeScript/pull/54148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c282ee53645f256d2bb4b79ee5f89852b10f77c2c0c20ef22b2dbfa096fbe5b/microsoft/TypeScript/pull/54148
og:image:altLike Node, Expression, TypeNode, and the like. This allows us to make many more switch statements in our codebase exhaustive (a change not included in this PR, which just swaps over to unions and f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/54148#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54148
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54148
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/54148
Reloadhttps://github.com/microsoft/TypeScript/pull/54148
Reloadhttps://github.com/microsoft/TypeScript/pull/54148
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:node-as-union-2023https://github.com/weswigham/TypeScript/tree/node-as-union-2023
Conversationhttps://github.com/microsoft/TypeScript/pull/54148
Commits1 (1)https://github.com/microsoft/TypeScript/pull/54148/commits
Checkshttps://github.com/microsoft/TypeScript/pull/54148/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/54148/files
Use union types for all common classes of AST nodeshttps://github.com/microsoft/TypeScript/pull/54148#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:node-as-union-2023https://github.com/weswigham/TypeScript/tree/node-as-union-2023
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#issue-1697133361
#54146https://github.com/microsoft/TypeScript/issues/54146
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/weswigham
Use union types for all common classes of AST nodeshttps://github.com/microsoft/TypeScript/pull/54148/commits/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
6ce78bchttps://github.com/microsoft/TypeScript/pull/54148/commits/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jake Bailey (jakebailey)https://github.com/jakebailey
Ron Buckton (rbuckton)https://github.com/rbuckton
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 5, 2023 07:17https://github.com/microsoft/TypeScript/pull/54148#event-9174091829
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#event-9174092815
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#event-9174092865
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023 https://github.com/microsoft/TypeScript/pull/54148#pullrequestreview-1415000631
View reviewed changes https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186223995
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186305755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186311556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Josh Ghoulberg 👻 (@JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186314098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186345078
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@typescript-eslint/no-unnecessary-type-assertionhttps://typescript-eslint.io/rules/no-unnecessary-type-assertion
https://typescript-eslint.io/linting/troubleshooting/formattinghttps://typescript-eslint.io/linting/troubleshooting/formatting
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 6, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186662982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#issuecomment-1536481231
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023 https://github.com/microsoft/TypeScript/pull/54148#pullrequestreview-1415129133
View reviewed changes https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186308496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186311605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Josh Ghoulberg 👻 (@JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186345513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#54148 (comment)https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186345078
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023 https://github.com/microsoft/TypeScript/pull/54148#pullrequestreview-1415140398
View reviewed changes https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
Ron Buckton (rbuckton)https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/54148#pullrequestreview-1415140398
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186316019
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186428704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 6, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186601123
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/typescript-eslint/typescript-eslint/blob/09c04fb0d5a5dee0dc266abb2e21aa9a1c489712/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts#L260https://github.com/typescript-eslint/typescript-eslint/blob/09c04fb0d5a5dee0dc266abb2e21aa9a1c489712/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts#L260
#9879https://github.com/microsoft/TypeScript/issues/9879
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186316790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 6, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186602005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#54148 (comment)https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186601123
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186317039
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186317623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186317710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186335453
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/factory/parenthesizerRules.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-0a5e519de8242b88ee20745c03dd3bdf3ed2477204a309c6c1216f32c3473011
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186337372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186339831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186341417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
src/compiler/parser.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-12a6724be007eb1a19d80018c7a63bbc73525ca793a9b3e5da49a4e86bbf457c
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186342858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
Wesley Wigham (weswigham)https://github.com/weswigham
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186432224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#issuecomment-1536687505
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#issuecomment-1536905779
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
pprof-time-92423.pb.gzhttps://github.com/microsoft/TypeScript/files/11410660/pprof-time-92423.pb.gz
pprof-time-92885.pb.gzhttps://github.com/microsoft/TypeScript/files/11410661/pprof-time-92885.pb.gz
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 5, 2023https://github.com/microsoft/TypeScript/pull/54148#issuecomment-1536911083
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://user-images.githubusercontent.com/5341706/236585603-4c91d555-6a26-4d63-a585-bb05f65bb14d.png
https://user-images.githubusercontent.com/5341706/236585623-185e3d60-47fb-4783-9413-16ecc149bc97.png
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/JoshuaKGoldberg
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 6, 2023 https://github.com/microsoft/TypeScript/pull/54148#pullrequestreview-1415643244
View reviewed changes https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
May 6, 2023https://github.com/microsoft/TypeScript/pull/54148#discussion_r1186608954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/JoshuaKGoldberg
Josh Ghoulberg 👻 (JoshuaKGoldberg)https://github.com/JoshuaKGoldberg
Oct 11, 2023 https://github.com/microsoft/TypeScript/pull/54148#ref-issue-166933990
Proposal: Type Relationship API #9879 https://github.com/microsoft/TypeScript/issues/9879
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Oct 31, 2023 https://github.com/microsoft/TypeScript/pull/54148#ref-issue-1970698587
Replace Node interface with discriminated unions #56275 https://github.com/microsoft/TypeScript/issues/56275
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Nov 1, 2023 https://github.com/microsoft/TypeScript/pull/54148#ref-pullrequest-1970696104
[Reference] feat: switched Node to a discriminated union #56274 https://github.com/microsoft/TypeScript/pull/56274
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Feb 22, 2024 https://github.com/microsoft/TypeScript/pull/54148#ref-pullrequest-2147194585
Infer type predicates from function bodies using control flow analysis #57465 https://github.com/microsoft/TypeScript/pull/57465
https://github.com/danvk
Dan Vanderkam (danvk)https://github.com/danvk
Feb 26, 2024 https://github.com/microsoft/TypeScript/pull/54148#ref-pullrequest-2154927229
Single-expression only type predicates #57552 https://github.com/microsoft/TypeScript/pull/57552
https://github.com/danvk
Dan Vanderkam (danvk)https://github.com/danvk
Mar 6, 2024 https://github.com/microsoft/TypeScript/pull/54148#ref-pullrequest-2171966071
Experimental variant on #57465 with two optimizations #57660 https://github.com/microsoft/TypeScript/pull/57660
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Experiment https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/54148#event-13870209581
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/54148#event-13870212746
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
PR Backloghttps://github.com/orgs/microsoft/projects/1252
Apr 22, 2025https://github.com/microsoft/TypeScript/pull/54148#event-17355389952
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/54148#event-20324799641
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54148
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
https://github.com/JoshuaKGoldberg
Josh Ghoulberg 👻 (JoshuaKGoldberg) https://github.com/JoshuaKGoldberg
https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
https://github.com/Andarist
Mateusz Burzyński (Andarist) https://github.com/Andarist
https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/54148/files/6ce78bc9c8f13e35fc24e6ea030b3520a6f30193
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Experiment https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54148
https://github.com/weswigham
https://github.com/jakebailey
https://github.com/gabritto
https://github.com/JoshuaKGoldberg
https://github.com/rbuckton
https://github.com/Andarist
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.