René's URL Explorer Experiment


Title: Include source node inferences in string literal completions by rbuckton · Pull Request #54121 · microsoft/TypeScript · GitHub

Open Graph Title: Include source node inferences in string literal completions by rbuckton · Pull Request #54121 · microsoft/TypeScript

X Title: Include source node inferences in string literal completions by rbuckton · Pull Request #54121 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Include source node inferences in string literal completions by rbuckton · Pull Request #54121 · microsoft/TypeScript

Open Graph Description: This adopts the proposed fix mentioned in #49680 (comment). This is a different approach than the one taken by Mateusz Burzyński (@Andarist) in #52997, as that PR attempted to pre-filter results. F...

X Description: This adopts the proposed fix mentioned in #49680 (comment). This is a different approach than the one taken by Mateusz Burzyński (@Andarist) in #52997, as that PR attempted to pre-filter results. F...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/54121

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9210c19-ea62-8a03-7563-f884c0c7289d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B00:2C4BED:137023C:18C20B7:6B01256B
html-safe-nonce5b02d72c8259bb851043e356b6c65669d54663cee314c9e5b329df390e3b916a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjAwOjJDNEJFRDoxMzcwMjNDOjE4QzIwQjc6NkIwMTI1NkIiLCJ2aXNpdG9yX2lkIjoiNzExMTQ4OTM3ODg2MTUyNDMzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac795155fb89685c80a99a8fe86a3a84e8ee8a2d5559dc326dd27c0a405e4488fd
hovercard-subject-tagpull_request:1337245687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/54121/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d1f8d766673319f2a5f371e1667c16cb0a2fa516c4ad666b6d0a722573069554/microsoft/TypeScript/pull/54121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d1f8d766673319f2a5f371e1667c16cb0a2fa516c4ad666b6d0a722573069554/microsoft/TypeScript/pull/54121
og:image:altThis adopts the proposed fix mentioned in #49680 (comment). This is a different approach than the one taken by Mateusz Burzyński (@Andarist) in #52997, as that PR attempted to pre-filter results. F...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerbuckton
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/54121#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54121
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54121
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/54121
Reloadhttps://github.com/microsoft/TypeScript/pull/54121
Reloadhttps://github.com/microsoft/TypeScript/pull/54121
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Ron Buckton (rbuckton)https://github.com/rbuckton
mainhttps://github.com/microsoft/TypeScript/tree/main
fix-string-completions-from-inferhttps://github.com/microsoft/TypeScript/tree/fix-string-completions-from-infer
Conversationhttps://github.com/microsoft/TypeScript/pull/54121
Commits8 (8)https://github.com/microsoft/TypeScript/pull/54121/commits
Checkshttps://github.com/microsoft/TypeScript/pull/54121/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/54121/files
Include source node inferences in string literal completionshttps://github.com/microsoft/TypeScript/pull/54121#top
Ron Buckton (rbuckton)https://github.com/rbuckton
mainhttps://github.com/microsoft/TypeScript/tree/main
fix-string-completions-from-inferhttps://github.com/microsoft/TypeScript/tree/fix-string-completions-from-infer
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issue-1694678629
#49680 (comment)https://github.com/microsoft/TypeScript/issues/49680#issuecomment-1199933521
Mateusz Burzyński (@Andarist)https://github.com/Andarist
#52997https://github.com/microsoft/TypeScript/pull/52997
#49680https://github.com/microsoft/TypeScript/issues/49680
#52997https://github.com/microsoft/TypeScript/pull/52997
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jake Bailey (jakebailey)https://github.com/jakebailey
May 3, 2023 19:35https://github.com/microsoft/TypeScript/pull/54121#event-9159340910
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Ron Buckton (rbuckton)https://github.com/rbuckton
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#event-9159342116
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#event-9159342269
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 3, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1411973265
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/54121/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
force-pushedhttps://github.com/microsoft/TypeScript/compare/a236333b686fdde1e8d26e605ad4aee059277f2c..ef50d4521d8d33332b2708ed07a8cafdffd93c6c
a236333https://github.com/microsoft/TypeScript/commit/a236333b686fdde1e8d26e605ad4aee059277f2c
ef50d45https://github.com/microsoft/TypeScript/commit/ef50d4521d8d33332b2708ed07a8cafdffd93c6c
Compare https://github.com/microsoft/TypeScript/compare/a236333b686fdde1e8d26e605ad4aee059277f2c..ef50d4521d8d33332b2708ed07a8cafdffd93c6c
May 3, 2023 22:32https://github.com/microsoft/TypeScript/pull/54121#event-9160750500
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 3, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1412005815
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files
Jake Bailey (jakebailey)https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1412005815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533870666
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
this PR of minehttps://github.com/microsoft/TypeScript/pull/53996/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533873579
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533873619
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Jake Bailey (@jakebailey)https://github.com/jakebailey
ef50d45https://github.com/microsoft/TypeScript/commit/ef50d4521d8d33332b2708ed07a8cafdffd93c6c
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153801
The results are in!https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533973446
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533873620
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Jake Bailey (@jakebailey)https://github.com/jakebailey
ef50d45https://github.com/microsoft/TypeScript/commit/ef50d4521d8d33332b2708ed07a8cafdffd93c6c
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153800
The results are in!https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533884406
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533873621
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Jake Bailey (@jakebailey)https://github.com/jakebailey
ef50d45https://github.com/microsoft/TypeScript/commit/ef50d4521d8d33332b2708ed07a8cafdffd93c6c
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153799
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533874813
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Jake Bailey (@jakebailey)https://github.com/jakebailey
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153799/artifacts?artifactName=tgz&fileId=D9DBEDB481AEE9C8CA59301474984667DCA709E5AF3258C9390950189FBB5CAB02&fileName=/typescript-5.1.0-insiders.20230503.tgz
for this buildhttps://www.staging-typescript.org/play?ts=5.1.0-pr-54121-5
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.1.0-pr-54121-5
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533884406
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 4, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1533973446
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/ssalbdivad
David Blass (ssalbdivad)https://github.com/ssalbdivad
May 4, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-issue-1681657956
Validated completions available for string props are not available for shallow strings #53997 https://github.com/microsoft/TypeScript/issues/53997
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 4, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1696149709
Add extra test cases for string completions #54133 https://github.com/microsoft/TypeScript/pull/54133
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 4, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1534905038
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Retry querying string completions from the inferred type if the original completions request doesn't return anything #52875https://github.com/microsoft/TypeScript/pull/52875
Retry string completions from the inferred type by default #53481https://github.com/microsoft/TypeScript/pull/53481
Improve contextual completions #53554https://github.com/microsoft/TypeScript/pull/53554
herehttps://github.com/microsoft/TypeScript/pull/54133/files#diff-0ae733b6999a5dc6fc7eab9e21b4a0696ae994be34c4aef7e0f0cd1b07d1333bR34-R35
Validated completions available for string props are not available for shallow strings #53997https://github.com/microsoft/TypeScript/issues/53997
with infer in template string, suggestion works in 4.6, but not work in 4.7 #49680https://github.com/microsoft/TypeScript/issues/49680
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 4, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1413298037
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/54121/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 4, 2023https://github.com/microsoft/TypeScript/pull/54121#discussion_r1185125746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 5, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1536459358
#48410https://github.com/microsoft/TypeScript/pull/48410
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 9, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1419167797
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files
Andrew Branch (andrewbranch)https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1419167797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Mateusz Burzyński (@Andarist)https://github.com/Andarist
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
May 19, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1555129006
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 19, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1555232539
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Fixed a regression with string completions not being available directly in arguments typed using rest parameter #54588 https://github.com/microsoft/TypeScript/pull/54588
Merge remote-tracking branch 'origin/main' into fix-string-completions-from-infer #54668 https://github.com/microsoft/TypeScript/pull/54668
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 16, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1594250525
#54668https://github.com/microsoft/TypeScript/pull/54668
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jun 16, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1760114294
Revert stylistic changes in runWithoutResolvedSignatureCaching #54669 https://github.com/microsoft/TypeScript/pull/54669
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jul 27, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1654650019
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 15, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1679418471
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1701275684
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Ron Buckton (@rbuckton)https://github.com/rbuckton
#54668https://github.com/microsoft/TypeScript/pull/54668
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1701544474
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Ron Buckton (@rbuckton)https://github.com/rbuckton
#54668https://github.com/microsoft/TypeScript/pull/54668
https://github.com/microsoft/TypeScript/pull/53996/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8L32511-R32515https://github.com/microsoft/TypeScript/pull/53996/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8L32511-R32515
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1701670384
diffhttps://github.com/microsoft/TypeScript/compare/main...8a2405a7b1c65ae7ad4f95a16721746f823cf275
this expectationhttps://github.com/microsoft/TypeScript/compare/main...8a2405a7b1c65ae7ad4f95a16721746f823cf275#diff-0ae733b6999a5dc6fc7eab9e21b4a0696ae994be34c4aef7e0f0cd1b07d1333bR34
#53996https://github.com/microsoft/TypeScript/pull/53996
herehttps://github.com/microsoft/TypeScript/blob/dce7b6d2e7f5390e859ce45ae2bd50f1d68725c9/tests/cases/fourslash/stringCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypes.ts#L31
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1701686111
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Ron Buckton (rbuckton)https://github.com/rbuckton
August 31, 2023 15:46https://github.com/microsoft/TypeScript/pull/54121#commits-pushed-038bfd4
https://github.com/rbuckton
Include source node inferences in string literal completionshttps://github.com/microsoft/TypeScript/pull/54121/commits/038bfd49066624ed582e3d2dbfd522ccc062311c
038bfd4https://github.com/microsoft/TypeScript/pull/54121/commits/038bfd49066624ed582e3d2dbfd522ccc062311c
https://github.com/Andarist
https://github.com/rbuckton
Add extra test cases for string completions (https://github.com/microsoft/TypeScript/pull/54121/commits/c667870c776baef059d6391e7b8386e809e020b3
#54133https://github.com/microsoft/TypeScript/pull/54133
)https://github.com/microsoft/TypeScript/pull/54121/commits/c667870c776baef059d6391e7b8386e809e020b3
c667870https://github.com/microsoft/TypeScript/pull/54121/commits/c667870c776baef059d6391e7b8386e809e020b3
https://github.com/rbuckton
Remove commented line of codehttps://github.com/microsoft/TypeScript/pull/54121/commits/3e23961305fbddff4a842a9baf57a4c28a09477c
3e23961https://github.com/microsoft/TypeScript/pull/54121/commits/3e23961305fbddff4a842a9baf57a4c28a09477c
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
force-pushedhttps://github.com/microsoft/TypeScript/compare/23628ebb02199b3d4188d362edbc3cf12c4e43e4..c667870c776baef059d6391e7b8386e809e020b3
23628ebhttps://github.com/microsoft/TypeScript/commit/23628ebb02199b3d4188d362edbc3cf12c4e43e4
c667870https://github.com/microsoft/TypeScript/commit/c667870c776baef059d6391e7b8386e809e020b3
Compare https://github.com/microsoft/TypeScript/compare/23628ebb02199b3d4188d362edbc3cf12c4e43e4..c667870c776baef059d6391e7b8386e809e020b3
August 31, 2023 19:48https://github.com/microsoft/TypeScript/pull/54121#event-10249299578
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1701723510
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Remove extra completions from testhttps://github.com/microsoft/TypeScript/pull/54121/commits/e51def6e81d1b20609112a469cb3d5bcfba5e033
e51def6https://github.com/microsoft/TypeScript/pull/54121/commits/e51def6e81d1b20609112a469cb3d5bcfba5e033
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Aug 31, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1605703162
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files/e51def6e81d1b20609112a469cb3d5bcfba5e033
...es/fourslash/stringLiteralCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypes.tshttps://github.com/microsoft/TypeScript/pull/54121/files/e51def6e81d1b20609112a469cb3d5bcfba5e033#diff-0ae733b6999a5dc6fc7eab9e21b4a0696ae994be34c4aef7e0f0cd1b07d1333b
Mateusz Burzyński (Andarist)https://github.com/Andarist
Aug 31, 2023https://github.com/microsoft/TypeScript/pull/54121#discussion_r1312218113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/microsoft/TypeScript/blob/main/tests/cases/fourslash/stringCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypes.tshttps://github.com/microsoft/TypeScript/blob/main/tests/cases/fourslash/stringCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypes.ts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Remove duplicate testhttps://github.com/microsoft/TypeScript/pull/54121/commits/83434def7cbac4534554fa561d8207db8882a32d
83434dehttps://github.com/microsoft/TypeScript/pull/54121/commits/83434def7cbac4534554fa561d8207db8882a32d
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 1, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1702459728
#55552https://github.com/microsoft/TypeScript/pull/55552
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 4, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1879650741
Remove redundant code related to argument string completions #55624 https://github.com/microsoft/TypeScript/pull/55624
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 4, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1608893176
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files/83434def7cbac4534554fa561d8207db8882a32d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/54121/files/83434def7cbac4534554fa561d8207db8882a32d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 4, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1704739925
stringCompletionsFromGenericConditionalTypesUsingTemplateLiteralTypeshttps://github.com/Andarist/TypeScript/commit/26c1127bff6bdb213ee2fd6a7eba9f17bc4eebae#diff-13616dfe7e35d3a34aa70b8e355f0780be2b218657e04c8561c3833a44733cd5R31-R32
Andarist:get-rid-off-for-string-literal-arg-completionshttps://github.com/Andarist/TypeScript/tree/get-rid-off-for-string-literal-arg-completions
#55624https://github.com/microsoft/TypeScript/pull/55624
Andarist@26c1127https://github.com/Andarist/TypeScript/commit/26c1127bff6bdb213ee2fd6a7eba9f17bc4eebae
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/Andarist
Remove redundant code related to argument string completions (https://github.com/microsoft/TypeScript/pull/54121/commits/7210673e6f4a0ccb9ad64eb41bec1189f92f3e76
#55624https://github.com/microsoft/TypeScript/pull/55624
)https://github.com/microsoft/TypeScript/pull/54121/commits/7210673e6f4a0ccb9ad64eb41bec1189f92f3e76
7210673https://github.com/microsoft/TypeScript/pull/54121/commits/7210673e6f4a0ccb9ad64eb41bec1189f92f3e76
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 8, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1711793623
Mateusz Burzyński (@Andarist)https://github.com/Andarist
Andarist@26c1127https://github.com/Andarist/TypeScript/commit/26c1127bff6bdb213ee2fd6a7eba9f17bc4eebae
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Fix formattinghttps://github.com/microsoft/TypeScript/pull/54121/commits/cf58c08ed1fe8f569fcf20d074e60f72eab3015c
cf58c08https://github.com/microsoft/TypeScript/pull/54121/commits/cf58c08ed1fe8f569fcf20d074e60f72eab3015c
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1734383111
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Jake Bailey (@jakebailey)https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/54121#issuecomment-1734383500
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Sep 25, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1642910356
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files/cf58c08ed1fe8f569fcf20d074e60f72eab3015c
Jake Bailey (jakebailey)https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1642910356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Merge branch 'main' into fix-string-completions-from-inferhttps://github.com/microsoft/TypeScript/pull/54121/commits/c533abf71fb522dc5ddd7847862976edbc6a65b5
c533abfhttps://github.com/microsoft/TypeScript/pull/54121/commits/c533abf71fb522dc5ddd7847862976edbc6a65b5
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Sep 25, 2023 https://github.com/microsoft/TypeScript/pull/54121#pullrequestreview-1643024398
View reviewed changes https://github.com/microsoft/TypeScript/pull/54121/files/c533abf71fb522dc5ddd7847862976edbc6a65b5
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
d7b4ceehttps://github.com/microsoft/TypeScript/commit/d7b4cee7df2dc2f97f7ac717103014582991a610
Sep 25, 2023https://github.com/microsoft/TypeScript/pull/54121#event-10468064705
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
September 25, 2023 22:29https://github.com/microsoft/TypeScript/pull/54121#event-10468064852
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Sep 25, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1912384766
Remove CheckMode.IsForStringLiteralArgumentCompletions #55867 https://github.com/microsoft/TypeScript/pull/55867
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Oct 23, 2023 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1956750873
Include source node inferences in string literal completions deeper in arguments #56182 https://github.com/microsoft/TypeScript/pull/56182
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Jan 7, 2024 https://github.com/microsoft/TypeScript/pull/54121#ref-pullrequest-1600922855
Fixed string completions from generic conditional types that match typed argument against template literal type #52997 https://github.com/microsoft/TypeScript/pull/52997
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/54121#event-20419550598
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54121
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/54121/files/c533abf71fb522dc5ddd7847862976edbc6a65b5
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/54121/files/cf58c08ed1fe8f569fcf20d074e60f72eab3015c
https://github.com/Andarist
Mateusz Burzyński (Andarist) https://github.com/Andarist
https://github.com/microsoft/TypeScript/pull/54121/files/83434def7cbac4534554fa561d8207db8882a32d
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
with infer in template string, suggestion works in 4.6, but not work in 4.7 https://github.com/microsoft/TypeScript/issues/49680
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54121
https://github.com/rbuckton
https://github.com/Andarist
https://github.com/jakebailey
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.