| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:27aae811-d1af-b006-b52b-cd09bc2e08c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B2C4:1EC9BC:E46D86:12426D4:6B010A6B |
| html-safe-nonce | 2556d7411dace71bb2f9cf273d4e1c0e055737d5ea8b6d1e2738155e0b5ba04f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkM0OjFFQzlCQzpFNDZEODY6MTI0MjZENDo2QjAxMEE2QiIsInZpc2l0b3JfaWQiOiI4NDk2OTU5NTgxMzEyODQ2NDQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7586190632acb0f706970eb503f2372f5ad9f1878a8abb348ce205e215d8a766 |
| hovercard-subject-tag | pull_request:1337139737 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/54117/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b3c21982a07d5fe6026fc9d17dc7e405d04ee4f6684751e2e059fcd4877832de/microsoft/TypeScript/pull/54117 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b3c21982a07d5fe6026fc9d17dc7e405d04ee4f6684751e2e059fcd4877832de/microsoft/TypeScript/pull/54117 |
| og:image:alt | Per my suggestion and this comment. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | weswigham |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/54117#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54117 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54117 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/54117 |
| Reload | https://github.com/microsoft/TypeScript/pull/54117 |
| Reload | https://github.com/microsoft/TypeScript/pull/54117 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| weswigham:cew-debug-fail | https://github.com/weswigham/TypeScript/tree/cew-debug-fail |
| Conversation | https://github.com/microsoft/TypeScript/pull/54117 |
| Commits4 (4) | https://github.com/microsoft/TypeScript/pull/54117/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/54117/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/54117/files |
| Replace errorType return with Debug fail in checkExpressionWorker | https://github.com/microsoft/TypeScript/pull/54117#top |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| weswigham:cew-debug-fail | https://github.com/weswigham/TypeScript/tree/cew-debug-fail |
|
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issue-1694560633 |
| this comment | https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532008924 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#event-9158557507 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#event-9158557656 |
|
| https://github.com/weswigham |
| Replace errorType return with Debug fail in checkExpressionWorker | https://github.com/microsoft/TypeScript/pull/54117/commits/d7dabe8005283033654e56d4e3038a2363317661 |
| d7dabe8 | https://github.com/microsoft/TypeScript/pull/54117/commits/d7dabe8005283033654e56d4e3038a2363317661 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| force-pushed | https://github.com/microsoft/TypeScript/compare/68f07031c9f64d522560d3cced12440805c5b4bb..d7dabe8005283033654e56d4e3038a2363317661 |
| 68f0703 | https://github.com/microsoft/TypeScript/commit/68f07031c9f64d522560d3cced12440805c5b4bb |
| d7dabe8 | https://github.com/microsoft/TypeScript/commit/d7dabe8005283033654e56d4e3038a2363317661 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/68f07031c9f64d522560d3cced12440805c5b4bb..d7dabe8005283033654e56d4e3038a2363317661 |
| May 3, 2023 18:10 | https://github.com/microsoft/TypeScript/pull/54117#event-9158579097 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 3, 2023 12:13 | https://github.com/microsoft/TypeScript/pull/54117#commits-pushed-d36de35 |
|
| https://github.com/weswigham |
| Add ImportKeyword to checkExpressionWorker even though its not flag… | https://github.com/microsoft/TypeScript/pull/54117/commits/d36de3584be1fcd541d46f46b2fdc2a054e979c0 |
| d36de35 | https://github.com/microsoft/TypeScript/pull/54117/commits/d36de3584be1fcd541d46f46b2fdc2a054e979c0 |
|
| https://github.com/weswigham |
| Add a couple more non-explicit entries to checkExpressionWorker | https://github.com/microsoft/TypeScript/pull/54117/commits/fc0ae9535bf3f9d240dac7af427045b80e778414 |
| fc0ae95 | https://github.com/microsoft/TypeScript/pull/54117/commits/fc0ae9535bf3f9d240dac7af427045b80e778414 |
|
| https://github.com/weswigham |
| Make invalid syntax uses of ImportKeyword expressions the errorType | https://github.com/microsoft/TypeScript/pull/54117/commits/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| 7dfe497 | https://github.com/microsoft/TypeScript/pull/54117/commits/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533673888 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533673926 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| 7dfe497 | https://github.com/microsoft/TypeScript/commit/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153774 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533832119 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533673927 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| 7dfe497 | https://github.com/microsoft/TypeScript/commit/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153773 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533673929 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| 7dfe497 | https://github.com/microsoft/TypeScript/commit/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153771 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533806665 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533673932 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| 7dfe497 | https://github.com/microsoft/TypeScript/commit/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153772 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533782242 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533782242 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153772/artifacts?artifactName=benchmark&fileId=A8380F724E82FBCC34C078D363578FD902824450E583DA973B90F562978C8CF701&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533806665 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=153771&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-1533832119 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 3, 2023 22:26 | https://github.com/microsoft/TypeScript/pull/54117#event-9160719514 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
May 3, 2023
| https://github.com/microsoft/TypeScript/pull/54117#pullrequestreview-1411990650 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/54117/files/7dfe497bd5c0ddb8e6bc0a74b66da27511267875 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/54117/files/7dfe497bd5c0ddb8e6bc0a74b66da27511267875#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#discussion_r1184359740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 3, 2023 | https://github.com/microsoft/TypeScript/pull/54117#discussion_r1184372335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| May 13, 2025 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-2877560509 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/54117#event-23867703634 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/54117#issuecomment-4121427012 |
| 6.0 out | https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/ |
| final release vehicle for this codebase | https://redirect.github.com/microsoft/TypeScript/issues/62963 |
| post-6.0 patch criteria | https://redirect.github.com/microsoft/TypeScript/issues/62963#issuecomment-4100336368 |
| 6.0 iteration issue | https://redirect.github.com/microsoft/TypeScript/issues/63085 |
| typescript-go repo | https://redirect.github.com/microsoft/TypeScript-go |
| DOM Generator repo | https://redirect.github.com/microsoft/TypeScript-DOM-lib-generator |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| PR Backlog | https://github.com/orgs/microsoft/projects/1252 |
| Mar 24, 2026 | https://github.com/microsoft/TypeScript/pull/54117#event-23867707114 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54117 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/54117 |
|
| https://github.com/weswigham |
|
| https://github.com/typescript-bot |
|
| https://github.com/sandersn |
|
| https://github.com/rbuckton |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |