René's URL Explorer Experiment


Title: JSX namespace names should not be considered expressions by weswigham · Pull Request #54104 · microsoft/TypeScript · GitHub

Open Graph Title: JSX namespace names should not be considered expressions by weswigham · Pull Request #54104 · microsoft/TypeScript

X Title: JSX namespace names should not be considered expressions by weswigham · Pull Request #54104 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - JSX namespace names should not be considered expressions by weswigham · Pull Request #54104 · microsoft/TypeScript

Open Graph Description: Fixes the regression in this comment, which was regressed by #47356 (and followup #53799), which mistakenly classified JsxNamespacedName nodes as Expressions, which masked a ton of locations where ...

X Description: Fixes the regression in this comment, which was regressed by #47356 (and followup #53799), which mistakenly classified JsxNamespacedName nodes as Expressions, which masked a ton of locations where ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/54104

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c72c3cb-9898-8b03-9175-86718849e576
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id842C:ADA9D:10C8C62:15B1255:6B010805
html-safe-nonce9624f6c875e1d20979870bc5c61c61058687a0073ff11a2bf863fa3c89f440fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDJDOkFEQTlEOjEwQzhDNjI6MTVCMTI1NTo2QjAxMDgwNSIsInZpc2l0b3JfaWQiOiI3MDAyODIzMDk0MjA1MjIwODY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5882bed733c49f2842fcbe45777590ddac0cf4249c94edf58992243485e6ef45
hovercard-subject-tagpull_request:1335689846
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/54104/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b53b91cfdbe85d123d9b0e53ff27740481227d0ec7c85fbe5c008ae1773a3cb/microsoft/TypeScript/pull/54104
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b53b91cfdbe85d123d9b0e53ff27740481227d0ec7c85fbe5c008ae1773a3cb/microsoft/TypeScript/pull/54104
og:image:altFixes the regression in this comment, which was regressed by #47356 (and followup #53799), which mistakenly classified JsxNamespacedName nodes as Expressions, which masked a ton of locations where ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/54104#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54104
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54104
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/54104
Reloadhttps://github.com/microsoft/TypeScript/pull/54104
Reloadhttps://github.com/microsoft/TypeScript/pull/54104
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:fix-jsx-namespaced-name-index-signature-comparisonshttps://github.com/weswigham/TypeScript/tree/fix-jsx-namespaced-name-index-signature-comparisons
Conversationhttps://github.com/microsoft/TypeScript/pull/54104
Commits1 (1)https://github.com/microsoft/TypeScript/pull/54104/commits
Checkshttps://github.com/microsoft/TypeScript/pull/54104/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/54104/files
JSX namespace names should not be considered expressionshttps://github.com/microsoft/TypeScript/pull/54104#top
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:fix-jsx-namespaced-name-index-signature-comparisonshttps://github.com/weswigham/TypeScript/tree/fix-jsx-namespaced-name-index-signature-comparisons
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issue-1692928308
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
this commenthttps://github.com/microsoft/TypeScript/issues/53974#issuecomment-1519152756
#47356https://github.com/microsoft/TypeScript/pull/47356
#53799https://github.com/microsoft/TypeScript/pull/53799
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/weswigham
JSX namespace names should not be considered expressionshttps://github.com/microsoft/TypeScript/pull/54104/commits/b22a6714c9cbf4f11e01c1af21533a165c8836f8
b22a671https://github.com/microsoft/TypeScript/pull/54104/commits/b22a6714c9cbf4f11e01c1af21533a165c8836f8
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Ron Buckton (rbuckton)https://github.com/rbuckton
May 2, 2023 18:47https://github.com/microsoft/TypeScript/pull/54104#event-9148805946
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#event-9148806924
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#event-9148807034
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1531984877
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1531984943
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
Wesley Wigham (@weswigham)https://github.com/weswigham
b22a671https://github.com/microsoft/TypeScript/commit/b22a6714c9cbf4f11e01c1af21533a165c8836f8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153658
The results are in!https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532139102
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1531984946
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
Wesley Wigham (@weswigham)https://github.com/weswigham
b22a671https://github.com/microsoft/TypeScript/commit/b22a6714c9cbf4f11e01c1af21533a165c8836f8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153660
The results are in!https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532116802
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1531984948
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
Wesley Wigham (@weswigham)https://github.com/weswigham
b22a671https://github.com/microsoft/TypeScript/commit/b22a6714c9cbf4f11e01c1af21533a165c8836f8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153657
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1531984950
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
Wesley Wigham (@weswigham)https://github.com/weswigham
b22a671https://github.com/microsoft/TypeScript/commit/b22a6714c9cbf4f11e01c1af21533a165c8836f8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153659
The results are in!https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532056415
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532008924
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 2, 2023 https://github.com/microsoft/TypeScript/pull/54104#pullrequestreview-1409745477
View reviewed changes https://github.com/microsoft/TypeScript/pull/54104/files/b22a6714c9cbf4f11e01c1af21533a165c8836f8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/54104#pullrequestreview-1409745477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532056415
Wesley Wigham (@weswigham)https://github.com/weswigham
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153659/artifacts?artifactName=benchmark&fileId=79D7D92EB6D7B6374EC5D95F8643BB2094C31F1BA22747154D80CDBEF829BE1D01&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532116802
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532139102
Wesley Wigham (@weswigham)https://github.com/weswigham
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=153658&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532152449
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532217261
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532217320
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
b22a671https://github.com/microsoft/TypeScript/commit/b22a6714c9cbf4f11e01c1af21533a165c8836f8
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=153689
The results are in!https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532243684
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 2, 2023https://github.com/microsoft/TypeScript/pull/54104#issuecomment-1532243684
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153689/artifacts?artifactName=benchmark&fileId=2C9A2C61041DABFEA557C55051A8245AE8C91AF0FC11FD0A4726FD15D2B03AE501&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2023 https://github.com/microsoft/TypeScript/pull/54104#ref-pullrequest-1694560633
Replace errorType return with Debug fail in checkExpressionWorker #54117 https://github.com/microsoft/TypeScript/pull/54117
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
May 6, 2023 https://github.com/microsoft/TypeScript/pull/54104#pullrequestreview-1415756523
View reviewed changes https://github.com/microsoft/TypeScript/pull/54104/files/b22a6714c9cbf4f11e01c1af21533a165c8836f8
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
02bb310https://github.com/microsoft/TypeScript/commit/02bb3108ad625cddcec228846b9ff56cc5398976
May 9, 2023https://github.com/microsoft/TypeScript/pull/54104#event-9203431561
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/54104#event-20419549656
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F54104
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/54104/files/b22a6714c9cbf4f11e01c1af21533a165c8836f8
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
https://github.com/microsoft/TypeScript/pull/54104/files/b22a6714c9cbf4f11e01c1af21533a165c8836f8
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/54104
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/DanielRosenwasser
https://github.com/andrewbranch
https://github.com/jakebailey
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.