René's URL Explorer Experiment


Title: Don't slice whitespace in jsdoc parser unless needed by sandersn · Pull Request #53121 · microsoft/TypeScript · GitHub

Open Graph Title: Don't slice whitespace in jsdoc parser unless needed by sandersn · Pull Request #53121 · microsoft/TypeScript

X Title: Don't slice whitespace in jsdoc parser unless needed by sandersn · Pull Request #53121 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Don't slice whitespace in jsdoc parser unless needed by sandersn · Pull Request #53121 · microsoft/TypeScript

Open Graph Description: It's only needed when there's an indentation relative to the margin, which is rare and usually doesn't last for the entire comment text. The common case is to skip the whitespace. Edit:...

X Description: It's only needed when there's an indentation relative to the margin, which is rare and usually doesn't last for the entire comment text. The common case is to skip the white...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/53121

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e74abe7-b00b-a2ab-8c8e-db87d0b676db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E2C:3F8A67:BD3AE7:FDCD46:6B00FA39
html-safe-noncebef11b6e8f796cbecd40cc5b9dad66593fdae0fc688d001db2ee0da3cc0ab6e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTJDOjNGOEE2NzpCRDNBRTc6RkRDRDQ2OjZCMDBGQTM5IiwidmlzaXRvcl9pZCI6IjQ5NDg5NjA4Mjk3OTA4MTI3MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c682fe3216480ef24927b962e59e60c970c3a439f9b074f96ec6405ebc52962
hovercard-subject-tagpull_request:1265357187
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/53121/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2098e303f55abfeb2a8b39c37df3a9c9cfde630ae6cc7fdbd12219a6554bbec3/microsoft/TypeScript/pull/53121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2098e303f55abfeb2a8b39c37df3a9c9cfde630ae6cc7fdbd12219a6554bbec3/microsoft/TypeScript/pull/53121
og:image:altIt's only needed when there's an indentation relative to the margin, which is rare and usually doesn't last for the entire comment text. The common case is to skip the whitespace. Edit:...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/53121#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F53121
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F53121
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/53121
Reloadhttps://github.com/microsoft/TypeScript/pull/53121
Reloadhttps://github.com/microsoft/TypeScript/pull/53121
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
sandersn:lazy-whitespace-slicing-jsdoc-parserhttps://github.com/sandersn/TypeScript/tree/lazy-whitespace-slicing-jsdoc-parser
Conversationhttps://github.com/microsoft/TypeScript/pull/53121
Commits4 (4)https://github.com/microsoft/TypeScript/pull/53121/commits
Checkshttps://github.com/microsoft/TypeScript/pull/53121/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/53121/files
Don't slice whitespace in jsdoc parser unless neededhttps://github.com/microsoft/TypeScript/pull/53121#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
sandersn:lazy-whitespace-slicing-jsdoc-parserhttps://github.com/sandersn/TypeScript/tree/lazy-whitespace-slicing-jsdoc-parser
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 6, 2023https://github.com/microsoft/TypeScript/pull/53121#issue-1612411001
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
#52959https://github.com/microsoft/TypeScript/issues/52959
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
#53081https://github.com/microsoft/TypeScript/pull/53081
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
Don't slice whitespace in jsdoc parser unless neededhttps://github.com/microsoft/TypeScript/pull/53121/commits/000f7a5acfd355a1f0cd87d5c9757d62a3008442
000f7a5https://github.com/microsoft/TypeScript/pull/53121/commits/000f7a5acfd355a1f0cd87d5c9757d62a3008442
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 6, 2023https://github.com/microsoft/TypeScript/pull/53121#event-8680002622
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Mar 6, 2023https://github.com/microsoft/TypeScript/pull/53121#event-8680002743
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 6, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1457220651
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 6, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1457220740
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
000f7a5https://github.com/microsoft/TypeScript/commit/000f7a5acfd355a1f0cd87d5c9757d62a3008442
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=148424
The results are in!https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1457316102
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 7, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1457316102
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/148424/artifacts?artifactName=benchmark&fileId=9360AEDFCBE45E9784F470902B93FE0B43766DE03B4B406CD0A39EC3067DA53201&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 7, 2023 https://github.com/microsoft/TypeScript/pull/53121#pullrequestreview-1327714058
View reviewed changes https://github.com/microsoft/TypeScript/pull/53121/files/000f7a5acfd355a1f0cd87d5c9757d62a3008442
src/compiler/parser.tshttps://github.com/microsoft/TypeScript/pull/53121/files/000f7a5acfd355a1f0cd87d5c9757d62a3008442#diff-12a6724be007eb1a19d80018c7a63bbc73525ca793a9b3e5da49a4e86bbf457c
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 7, 2023https://github.com/microsoft/TypeScript/pull/53121#discussion_r1127396573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 7, 2023https://github.com/microsoft/TypeScript/pull/53121#discussion_r1128232821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 7, 2023 https://github.com/microsoft/TypeScript/pull/53121#ref-issue-1599434681
Investigate making JSDoc parsing lazier and more optimal #52959 https://github.com/microsoft/TypeScript/issues/52959
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 7, 2023 09:08https://github.com/microsoft/TypeScript/pull/53121#commits-pushed-6d792e7
https://github.com/sandersn
Merge branch 'main' into lazy-whitespace-slicing-jsdoc-parserhttps://github.com/microsoft/TypeScript/pull/53121/commits/6d792e75e585d9c7992f618805349d72e7361c5b
6d792e7https://github.com/microsoft/TypeScript/pull/53121/commits/6d792e75e585d9c7992f618805349d72e7361c5b
https://github.com/sandersn
Only slice once, and tokenise leading * as whitespacehttps://github.com/microsoft/TypeScript/pull/53121/commits/794b0f39fbcbd4a5df69f617c86310504cee2d25
794b0f3https://github.com/microsoft/TypeScript/pull/53121/commits/794b0f39fbcbd4a5df69f617c86310504cee2d25
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 7, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1458556516
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 7, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1458556585
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
794b0f3https://github.com/microsoft/TypeScript/commit/794b0f39fbcbd4a5df69f617c86310504cee2d25
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=148569
The results are in!https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1459457651
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
use lint-preferred empty-for formattinghttps://github.com/microsoft/TypeScript/pull/53121/commits/ae16f5e24c4fb16b417a59916cd6e5927813fbd2
ae16f5ehttps://github.com/microsoft/TypeScript/pull/53121/commits/ae16f5e24c4fb16b417a59916cd6e5927813fbd2
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 7, 2023 https://github.com/microsoft/TypeScript/pull/53121#ref-pullrequest-1609118535
Scan bigger/fewer jsdoc tokens #53081 https://github.com/microsoft/TypeScript/pull/53081
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 8, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1459457651
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/148569/artifacts?artifactName=benchmark&fileId=7A4222D1DE368C79A4C5D6FD20CB37194017A22598DD054205172722324D4AE701&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 8, 2023https://github.com/microsoft/TypeScript/pull/53121#issuecomment-1460422961
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 8, 2023https://github.com/microsoft/TypeScript/pull/53121#event-8698072751
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 8, 2023 16:07https://github.com/microsoft/TypeScript/pull/53121#event-8698077640
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/53121#event-20419516193
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F53121
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/53121/files/000f7a5acfd355a1f0cd87d5c9757d62a3008442
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/53121
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.