René's URL Explorer Experiment


Title: Do not report errors for classes and interfaces merging by mhegazy · Pull Request #5290 · microsoft/TypeScript · GitHub

Open Graph Title: Do not report errors for classes and interfaces merging by mhegazy · Pull Request #5290 · microsoft/TypeScript

X Title: Do not report errors for classes and interfaces merging by mhegazy · Pull Request #5290 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Do not report errors for classes and interfaces merging by mhegazy · Pull Request #5290 · microsoft/TypeScript

Open Graph Description: As discussed in #5269, this removes the restriction for non-ambient classes merging with interfaces.

X Description: As discussed in #5269, this removes the restriction for non-ambient classes merging with interfaces.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/5290

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b399b8b0-b245-0fb7-4ae8-bd32722dd02e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADC4:237673:E50B16:132FA74:6B0108CC
html-safe-noncea8a2073521c111d22ac9d47ef90c633b4f2869ba0e705a2e01d306bfb26591a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM0OjIzNzY3MzpFNTBCMTY6MTMyRkE3NDo2QjAxMDhDQyIsInZpc2l0b3JfaWQiOiIxMzYyNDA0MTI1MzMzMDYzODg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6abf4c7e9db5c9d3495b8ec349eb30fb380cdd2e596a0bbfc4fda53fce75e8ac
hovercard-subject-tagpull_request:47940439
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/5290/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dba01bc3d96fcb92786ed5e7751f7a766aedbadd3c1340c57cfee3fd7f9108c5/microsoft/TypeScript/pull/5290
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dba01bc3d96fcb92786ed5e7751f7a766aedbadd3c1340c57cfee3fd7f9108c5/microsoft/TypeScript/pull/5290
og:image:altAs discussed in #5269, this removes the restriction for non-ambient classes merging with interfaces.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhegazy
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/5290#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5290
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5290
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/5290
Reloadhttps://github.com/microsoft/TypeScript/pull/5290
Reloadhttps://github.com/microsoft/TypeScript/pull/5290
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
interfaceClassMergingFixhttps://github.com/microsoft/TypeScript/tree/interfaceClassMergingFix
Conversationhttps://github.com/microsoft/TypeScript/pull/5290
Commits2 (2)https://github.com/microsoft/TypeScript/pull/5290/commits
Checkshttps://github.com/microsoft/TypeScript/pull/5290/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/5290/files
Do not report errors for classes and interfaces merginghttps://github.com/microsoft/TypeScript/pull/5290#top
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
interfaceClassMergingFixhttps://github.com/microsoft/TypeScript/tree/interfaceClassMergingFix
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#issue-111879750
#5269https://github.com/microsoft/TypeScript/issues/5269
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
https://github.com/mhegazy
Do not report errors for classes and interfaces merginghttps://github.com/microsoft/TypeScript/pull/5290/commits/35a303ac01e43ec59ff425aec1427413d046e6e7
35a303ahttps://github.com/microsoft/TypeScript/pull/5290/commits/35a303ac01e43ec59ff425aec1427413d046e6e7
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#event-437796257
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5290#ref-issue-111677510
Type generation for "modularly designed" libraries is hard #5269 https://github.com/microsoft/TypeScript/issues/5269
sandersnhttps://github.com/sandersn
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5290#discussion-diff-42287355
View reviewed changes https://github.com/microsoft/TypeScript/pull/5290/files/35a303ac01e43ec59ff425aec1427413d046e6e7#diff-c7cba54a044314feb2c9e9c493e891ee2dddfc4ca4c052f2f883eb1fc3273d16
tests/cases/compiler/interfaceClassMerging2.tshttps://github.com/microsoft/TypeScript/pull/5290/files#diff-c7cba54a044314feb2c9e9c493e891ee2dddfc4ca4c052f2f883eb1fc3273d16
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#discussion_r42287355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#discussion_r42299841
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#issuecomment-148827785
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
RyanCavanaughhttps://github.com/RyanCavanaugh
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5290#discussion-diff-42288305
View reviewed changes https://github.com/microsoft/TypeScript/pull/5290/files/35a303ac01e43ec59ff425aec1427413d046e6e7#diff-6086d049b32237067a742beb2911ef4357fd8fff51e15094595b3f89aa8f88e2
tests/baselines/reference/augmentedTypesClass2.errors.txthttps://github.com/microsoft/TypeScript/pull/5290/files#diff-6086d049b32237067a742beb2911ef4357fd8fff51e15094595b3f89aa8f88e2
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#discussion_r42288305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#discussion_r42299882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#issuecomment-148833615
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
https://github.com/kwonoj
OJ Kwon (kwonoj)https://github.com/kwonoj
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5290#ref-pullrequest-111911419
chore(package.json): pin dev dependency package to known good ReactiveX/rxjs#551 https://github.com/ReactiveX/rxjs/pull/551
https://github.com/mhegazy
Fix commentshttps://github.com/microsoft/TypeScript/pull/5290/commits/8b8d33d8b8048b2bc31408f66086f9bab51aa740
8b8d33dhttps://github.com/microsoft/TypeScript/pull/5290/commits/8b8d33d8b8048b2bc31408f66086f9bab51aa740
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5290#ref-commit-bb369f1
https://github.com/mhegazy
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/bb369f142350d9b25829c16c50e9122a16e3cf8b
#5290https://github.com/microsoft/TypeScript/pull/5290
from Microsoft/interfaceClassMergingFixhttps://github.com/microsoft/TypeScript/commit/bb369f142350d9b25829c16c50e9122a16e3cf8b
bb369f1https://github.com/microsoft/TypeScript/commit/bb369f142350d9b25829c16c50e9122a16e3cf8b
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
bb369f1https://github.com/microsoft/TypeScript/commit/bb369f142350d9b25829c16c50e9122a16e3cf8b
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5290#event-438073840
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
October 16, 2015 23:45https://github.com/microsoft/TypeScript/pull/5290#event-438073854
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 21, 2015 https://github.com/microsoft/TypeScript/pull/5290#ref-issue-110696573
allow abstract interfaces in class definitions #5194 https://github.com/microsoft/TypeScript/issues/5194
https://github.com/david-driscoll
David Driscoll (david-driscoll)https://github.com/david-driscoll
Dec 8, 2015 https://github.com/microsoft/TypeScript/pull/5290#ref-pullrequest-120214469
Adding plumbing to support more granular and maintainable typings ReactiveX/rxjs#870 https://github.com/ReactiveX/rxjs/pull/870
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/5290#event-1689620224
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5290
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5290
https://github.com/mhegazy
https://github.com/sandersn
https://github.com/ahejlsberg
https://github.com/RyanCavanaugh
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.