René's URL Explorer Experiment


Title: Fix string completions depending on contextual signatures by Andarist · Pull Request #52717 · microsoft/TypeScript · GitHub

Open Graph Title: Fix string completions depending on contextual signatures by Andarist · Pull Request #52717 · microsoft/TypeScript

X Title: Fix string completions depending on contextual signatures by Andarist · Pull Request #52717 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix string completions depending on contextual signatures by Andarist · Pull Request #52717 · microsoft/TypeScript

Open Graph Description: fixes #53073 cc Andrew Branch (@andrewbranch)

X Description: fixes #53073 cc Andrew Branch (@andrewbranch)

Opengraph URL: https://github.com/microsoft/TypeScript/pull/52717

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60301f2f-9e08-070a-dbd1-81461868281c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC38E:33444D:31BFD3F:422856B:6B01EE86
html-safe-nonce211bdb2f99795268a8d0775d017713f7852fd9cf37e49fd05616d09fb9d47831
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzhFOjMzNDQ0RDozMUJGRDNGOjQyMjg1NkI6NkIwMUVFODYiLCJ2aXNpdG9yX2lkIjoiMjE4Njk5Mjc3NDc3ODMxODQ3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac03742eb30732cc4bdeef48a7b6b2f3fe954907cd0905ff6d3506309106449367
hovercard-subject-tagpull_request:1236992200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/52717/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/28205518760a38281c1b0f5bacd918f619c95f90afbefb8685e8be62ecf76d53/microsoft/TypeScript/pull/52717
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/28205518760a38281c1b0f5bacd918f619c95f90afbefb8685e8be62ecf76d53/microsoft/TypeScript/pull/52717
og:image:altfixes #53073 cc Andrew Branch (@andrewbranch)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/52717#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52717
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52717
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/52717
Reloadhttps://github.com/microsoft/TypeScript/pull/52717
Reloadhttps://github.com/microsoft/TypeScript/pull/52717
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/string-completions-depending-on-context-sensitive-signaturehttps://github.com/Andarist/TypeScript/tree/fix/string-completions-depending-on-context-sensitive-signature
Conversationhttps://github.com/microsoft/TypeScript/pull/52717
Commits3 (3)https://github.com/microsoft/TypeScript/pull/52717/commits
Checkshttps://github.com/microsoft/TypeScript/pull/52717/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/52717/files
Fix string completions depending on contextual signatureshttps://github.com/microsoft/TypeScript/pull/52717#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/string-completions-depending-on-context-sensitive-signaturehttps://github.com/Andarist/TypeScript/tree/fix/string-completions-depending-on-context-sensitive-signature
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Feb 10, 2023https://github.com/microsoft/TypeScript/pull/52717#issue-1580016093
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
#53073https://github.com/microsoft/TypeScript/issues/53073
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/Andarist
Fix string completions depending on contextual signatureshttps://github.com/microsoft/TypeScript/pull/52717/commits/1dc3b0389ddac602b8106b839e41c35a78278185
1dc3b03https://github.com/microsoft/TypeScript/pull/52717/commits/1dc3b0389ddac602b8106b839e41c35a78278185
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Feb 10, 2023https://github.com/microsoft/TypeScript/pull/52717#event-8491824200
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Feb 10, 2023https://github.com/microsoft/TypeScript/pull/52717#issuecomment-1426069923
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Feb 10, 2023 https://github.com/microsoft/TypeScript/pull/52717#pullrequestreview-1293565729
View reviewed changes https://github.com/microsoft/TypeScript/pull/52717/files/1dc3b0389ddac602b8106b839e41c35a78278185
tests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.tshttps://github.com/microsoft/TypeScript/pull/52717/files/1dc3b0389ddac602b8106b839e41c35a78278185#diff-b46661d47117bdbd4753b4f22abfd23adec7c5698095f2eb170e6822c93eaf81
Mateusz Burzyński (Andarist)https://github.com/Andarist
Feb 10, 2023https://github.com/microsoft/TypeScript/pull/52717#discussion_r1102993663
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 3, 2023https://github.com/microsoft/TypeScript/pull/52717#issuecomment-1452753197
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 3, 2023https://github.com/microsoft/TypeScript/pull/52717#event-8655076173
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 3, 2023 00:09https://github.com/microsoft/TypeScript/pull/52717#event-8655078274
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 3, 2023 https://github.com/microsoft/TypeScript/pull/52717#pullrequestreview-1323277636
View reviewed changes https://github.com/microsoft/TypeScript/pull/52717/files/1dc3b0389ddac602b8106b839e41c35a78278185
tests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.tshttps://github.com/microsoft/TypeScript/pull/52717/files/1dc3b0389ddac602b8106b839e41c35a78278185#diff-b46661d47117bdbd4753b4f22abfd23adec7c5698095f2eb170e6822c93eaf81
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/Andarist
Fixed a syntax error in the added testhttps://github.com/microsoft/TypeScript/pull/52717/commits/317117924c17b185784734093c9c29c40788ce97
3171179https://github.com/microsoft/TypeScript/pull/52717/commits/317117924c17b185784734093c9c29c40788ce97
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 3, 2023 https://github.com/microsoft/TypeScript/pull/52717#pullrequestreview-1323279794
View reviewed changes https://github.com/microsoft/TypeScript/pull/52717/files/317117924c17b185784734093c9c29c40788ce97
tests/cases/fourslash/completionsForStringDependingOnContexSensitiveSignature.tshttps://github.com/microsoft/TypeScript/pull/52717/files/317117924c17b185784734093c9c29c40788ce97#diff-b46661d47117bdbd4753b4f22abfd23adec7c5698095f2eb170e6822c93eaf81
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/Andarist
Update tests/cases/fourslash/completionsForStringDependingOnContexSen…https://github.com/microsoft/TypeScript/pull/52717/commits/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
50872eehttps://github.com/microsoft/TypeScript/pull/52717/commits/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Mar 3, 2023https://github.com/microsoft/TypeScript/pull/52717#issuecomment-1453151032
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#53073https://github.com/microsoft/TypeScript/issues/53073
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/zardoy
Vitaly (zardoy)https://github.com/zardoy
Mar 4, 2023 https://github.com/microsoft/TypeScript/pull/52717#ref-issue-1577025205
Incorrect completions in object literal expression for overloads #52692 https://github.com/microsoft/TypeScript/issues/52692
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Mar 7, 2023 https://github.com/microsoft/TypeScript/pull/52717#pullrequestreview-1329512736
View reviewed changes https://github.com/microsoft/TypeScript/pull/52717/files/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 8, 2023 https://github.com/microsoft/TypeScript/pull/52717#pullrequestreview-1329788291
View reviewed changes https://github.com/microsoft/TypeScript/pull/52717/files/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
6e4f0a4https://github.com/microsoft/TypeScript/commit/6e4f0a430e5b1a4d310be2ee8cc2d4d69f295b31
Mar 8, 2023https://github.com/microsoft/TypeScript/pull/52717#event-8691835261
Regression in autocompletion on spread generic arguments #54572 https://github.com/microsoft/TypeScript/issues/54572
Fixed a regression with string completions not being available directly in arguments typed using rest parameter #54588 https://github.com/microsoft/TypeScript/pull/54588
Fixed an issue with errors not being correctly reported after completion requests in nested calls #54658 https://github.com/microsoft/TypeScript/pull/54658
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/52717#event-20419504451
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52717
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/52717/files/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/52717/files/50872ee1512dbf3b4ef7b42ef21a4a71c78e0121
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
String completions fail when they depend on the contextual signature https://github.com/microsoft/TypeScript/issues/53073
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52717
https://github.com/Andarist
https://github.com/typescript-bot
https://github.com/sandersn
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.