| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f15fdc13-5189-5dd0-ed08-a285161d1519 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4B4:363D8E:2AE1A0B:365FA15:6B01929E |
| html-safe-nonce | 401c24e82579cc06f51c40a52f74f31a90cc2f0476c330ca95bcc1ee6faaa267 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI0OjM2M0Q4RToyQUUxQTBCOjM2NUZBMTU6NkIwMTkyOUUiLCJ2aXNpdG9yX2lkIjoiNzM2Mzg4MzUyODc4NTU3NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 71da6d7f49a99ccb0005295d7da79229c9103caea57ab7737e9c2b79b230e748 |
| hovercard-subject-tag | pull_request:1234325072 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/52690/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/45dbba8bd890c0aa51bdeacd3322e20d02cf93f50330d30019af28576c92fdb6/microsoft/TypeScript/pull/52690 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/45dbba8bd890c0aa51bdeacd3322e20d02cf93f50330d30019af28576c92fdb6/microsoft/TypeScript/pull/52690 |
| og:image:alt | Tried to find oldest completion issue :)
Fixes #1858 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zardoy |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/52690#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52690 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52690 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/52690 |
| Reload | https://github.com/microsoft/TypeScript/pull/52690 |
| Reload | https://github.com/microsoft/TypeScript/pull/52690 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| zardoy:no-self-completions-in-parameter | https://github.com/zardoy/TypeScript/tree/no-self-completions-in-parameter |
| Conversation | https://github.com/microsoft/TypeScript/pull/52690 |
| Commits19 (19) | https://github.com/microsoft/TypeScript/pull/52690/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/52690/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/52690/files |
| Don't include completions for current and later parameters | https://github.com/microsoft/TypeScript/pull/52690#top |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| zardoy:no-self-completions-in-parameter | https://github.com/zardoy/TypeScript/tree/no-self-completions-in-parameter |
|
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issue-1576994381 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| #1858 | https://github.com/microsoft/TypeScript/issues/1858 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| February 9, 2023 03:03 | https://github.com/microsoft/TypeScript/pull/52690#commits-pushed-f259b14 |
|
| https://github.com/zardoy |
| add impl to ensure its not lost | https://github.com/microsoft/TypeScript/pull/52690/commits/f259b1461c058f54f7f5f7ce116bd916b24854f5 |
| f259b14 | https://github.com/microsoft/TypeScript/pull/52690/commits/f259b1461c058f54f7f5f7ce116bd916b24854f5 |
|
| https://github.com/zardoy |
| add test that seems okay | https://github.com/microsoft/TypeScript/pull/52690/commits/7c1fdfb2b3a4415c32eab2e859484d41f037fde7 |
| 7c1fdfb | https://github.com/microsoft/TypeScript/pull/52690/commits/7c1fdfb2b3a4415c32eab2e859484d41f037fde7 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#event-8474223098 |
|
| https://github.com/zardoy |
| hope to fix lint | https://github.com/microsoft/TypeScript/pull/52690/commits/f69d9d7a3cabba3f585651babe6144ca5e450767 |
| f69d9d7 | https://github.com/microsoft/TypeScript/pull/52690/commits/f69d9d7a3cabba3f585651babe6144ca5e450767 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#event-8474293987 |
|
| https://github.com/zardoy |
| fix lint (more chances) | https://github.com/microsoft/TypeScript/pull/52690/commits/47497130b7b81a015b0f76ccefdf276c22bea1ab |
| 4749713 | https://github.com/microsoft/TypeScript/pull/52690/commits/47497130b7b81a015b0f76ccefdf276c22bea1ab |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Feb 9, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1290248808 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/47497130b7b81a015b0f76ccefdf276c22bea1ab |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1290248808 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/47497130b7b81a015b0f76ccefdf276c22bea1ab#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1100845067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1100886997 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1100887191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1101825361 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1101849228 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| TypeScript/tests/cases/fourslash/completionListWithoutVariableinitializer.ts | https://github.com/microsoft/TypeScript/blob/0791bb0f8405058877c9930d63457f32522ae27c/tests/cases/fourslash/completionListWithoutVariableinitializer.ts#L50 |
| 0791bb0 | https://github.com/microsoft/TypeScript/commit/0791bb0f8405058877c9930d63457f32522ae27c |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/47497130b7b81a015b0f76ccefdf276c22bea1ab#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1100850516 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#discussion_r1100909068 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| tests/cases/fourslash/noIncorrectParamaterCompletions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/47497130b7b81a015b0f76ccefdf276c22bea1ab#diff-2b7f0632e16cd908543a59b393c691700db9270ff398d0ee448e3b400e6300b7 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| February 9, 2023 04:46 | https://github.com/microsoft/TypeScript/pull/52690#commits-pushed-09caed3 |
|
| https://github.com/zardoy |
| be surprised with the number of tests to fix | https://github.com/microsoft/TypeScript/pull/52690/commits/09caed3b49dbab4d0e60655c64365653fe6728cb |
| 09caed3 | https://github.com/microsoft/TypeScript/pull/52690/commits/09caed3b49dbab4d0e60655c64365653fe6728cb |
|
| https://github.com/zardoy |
| fix don't include index signature | https://github.com/microsoft/TypeScript/pull/52690/commits/d520a3106767a1a6352c5e5184e9caf6d5ff3456 |
| d520a31 | https://github.com/microsoft/TypeScript/pull/52690/commits/d520a3106767a1a6352c5e5184e9caf6d5ff3456 |
|
| https://github.com/zardoy |
| fix my tests | https://github.com/microsoft/TypeScript/pull/52690/commits/e27faedb32860da950454a2733e56963049ed592 |
| e27faed | https://github.com/microsoft/TypeScript/pull/52690/commits/e27faedb32860da950454a2733e56963049ed592 |
|
| https://github.com/zardoy |
| add positive testcases | https://github.com/microsoft/TypeScript/pull/52690/commits/fee4e96bd77c32321f7c2633c2760504f127b77e |
| fee4e96 | https://github.com/microsoft/TypeScript/pull/52690/commits/fee4e96bd77c32321f7c2633c2760504f127b77e |
|
| https://github.com/zardoy |
| simplify implementation | https://github.com/microsoft/TypeScript/pull/52690/commits/f3154b05a8e7f4d7ed61a497ead337a8addd1850 |
| f3154b0 | https://github.com/microsoft/TypeScript/pull/52690/commits/f3154b05a8e7f4d7ed61a497ead337a8addd1850 |
|
| https://github.com/zardoy |
| refactor to getVariableOrParameterDeclaration (simplify) | https://github.com/microsoft/TypeScript/pull/52690/commits/36ed7b743b7f2e3e1887819d229cb1862899a94f |
| 36ed7b7 | https://github.com/microsoft/TypeScript/pull/52690/commits/36ed7b743b7f2e3e1887819d229cb1862899a94f |
|
| https://github.com/zardoy |
| fix remaining test? | https://github.com/microsoft/TypeScript/pull/52690/commits/c1d02f2fe17819c431a8c23b0e4ca024bd52844b |
| c1d02f2 | https://github.com/microsoft/TypeScript/pull/52690/commits/c1d02f2fe17819c431a8c23b0e4ca024bd52844b |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#event-8474943472 |
|
| https://github.com/zardoy |
| rename test file | https://github.com/microsoft/TypeScript/pull/52690/commits/b204b1d2b8e1cae8eff4fb88dc90c008c341c604 |
| b204b1d | https://github.com/microsoft/TypeScript/pull/52690/commits/b204b1d2b8e1cae8eff4fb88dc90c008c341c604 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1423785512 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| February 9, 2023 21:25 | https://github.com/microsoft/TypeScript/pull/52690#commits-pushed-b6eafdd |
|
| https://github.com/zardoy |
| again fix bunch of tests (imporve quality) | https://github.com/microsoft/TypeScript/pull/52690/commits/b6eafdddc87db03690f950f2038d35d645b2f0a2 |
| b6eafdd | https://github.com/microsoft/TypeScript/pull/52690/commits/b6eafdddc87db03690f950f2038d35d645b2f0a2 |
|
| https://github.com/zardoy |
| fix const a = () => a | https://github.com/microsoft/TypeScript/pull/52690/commits/038e9536ed37713f0f92422e4cb89f4620281a7d |
| 038e953 | https://github.com/microsoft/TypeScript/pull/52690/commits/038e9536ed37713f0f92422e4cb89f4620281a7d |
|
| https://github.com/zardoy |
| add more complex test case | https://github.com/microsoft/TypeScript/pull/52690/commits/a0aea6222a53103e6797ad09a24da162eedae3a2 |
| a0aea62 | https://github.com/microsoft/TypeScript/pull/52690/commits/a0aea6222a53103e6797ad09a24da162eedae3a2 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1424655384 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| February 9, 2023 18:43 | https://github.com/microsoft/TypeScript/pull/52690#event-8482640039 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1424671431 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
|
Feb 11, 2023
| https://github.com/microsoft/TypeScript/pull/52690#ref-pullrequest-1580970485 |
|
Exclude completions of binding pattern variable initializers
#52723
| https://github.com/microsoft/TypeScript/pull/52723 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 17, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1434979172 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| February 17, 2023 18:46 | https://github.com/microsoft/TypeScript/pull/52690#event-8549988254 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Feb 17, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1304042878 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/a0aea6222a53103e6797ad09a24da162eedae3a2 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/a0aea6222a53103e6797ad09a24da162eedae3a2#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
|
| https://github.com/zardoy |
| avoid casting | https://github.com/microsoft/TypeScript/pull/52690/commits/85e35e0ba9019c02c813303627e35a26630efdea |
| 85e35e0 | https://github.com/microsoft/TypeScript/pull/52690/commits/85e35e0ba9019c02c813303627e35a26630efdea |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Feb 18, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1435416829 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| Vitaly (zardoy) | https://github.com/zardoy |
| February 19, 2023 04:40 | https://github.com/microsoft/TypeScript/pull/52690#commits-pushed-0b281e2 |
|
| https://github.com/zardoy |
| do the same for type parameters | https://github.com/microsoft/TypeScript/pull/52690/commits/0b281e21ce455da44dc4132b0c600ebd50af8c2a |
| 0b281e2 | https://github.com/microsoft/TypeScript/pull/52690/commits/0b281e21ce455da44dc4132b0c600ebd50af8c2a |
| 3f2a0ff | https://github.com/zardoy/TypeScript/commit/3f2a0ffda9a286f9fd817f8492e273900c624aa4 |
|
| https://github.com/zardoy |
| fix tests | https://github.com/microsoft/TypeScript/pull/52690/commits/dced6bc2899a15db10484fead989884939f4fcd5 |
| dced6bc | https://github.com/microsoft/TypeScript/pull/52690/commits/dced6bc2899a15db10484fead989884939f4fcd5 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
|
Feb 19, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1304686571 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5 |
| tests/cases/fourslash/completionListIsGlobalCompletion.ts | https://github.com/microsoft/TypeScript/pull/52690/files/0b281e21ce455da44dc4132b0c600ebd50af8c2a..dced6bc2899a15db10484fead989884939f4fcd5#diff-a23e0fd225f9e43272f1258c84d476b8bbe520e6c1153500d355a4a33fac7ad9 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Feb 19, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1435831343 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Mar 7, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1329054149 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1329054149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| tests/cases/fourslash/completionListInUnclosedFunction09.ts | https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5#diff-22b98773ad3f1ad2de110a93969f4dbe0af81844a3ead2280e5a4be4f9f8a122 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/52690/files/dced6bc2899a15db10484fead989884939f4fcd5#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
|
| https://github.com/zardoy |
| proposed changes | https://github.com/microsoft/TypeScript/pull/52690/commits/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
| d1666e8 | https://github.com/microsoft/TypeScript/pull/52690/commits/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Mar 9, 2023 | https://github.com/microsoft/TypeScript/pull/52690#event-8711339037 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Mar 15, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1342607659 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
| https://github.com/zardoy |
| Vitaly (zardoy) | https://github.com/zardoy |
| Mar 20, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1476926692 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Apr 13, 2023 | https://github.com/microsoft/TypeScript/pull/52690#issuecomment-1507656284 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Apr 15, 2023
| https://github.com/microsoft/TypeScript/pull/52690#pullrequestreview-1386270459 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/52690/files/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| c70fa51 | https://github.com/microsoft/TypeScript/commit/c70fa514b0902764b3f669c215f605080f55c7de |
| Apr 15, 2023 | https://github.com/microsoft/TypeScript/pull/52690#event-9012391653 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
|
Jun 15, 2023
| https://github.com/microsoft/TypeScript/pull/52690#ref-issue-1758894532 |
|
Code comlpetion not working for variables
#54654
| https://github.com/microsoft/TypeScript/issues/54654 |
| https://github.com/Andarist |
| Mateusz Burzyński (Andarist) | https://github.com/Andarist |
|
Nov 20, 2023
| https://github.com/microsoft/TypeScript/pull/52690#ref-issue-2002780794 |
|
Latter type parameters are not suggested in constraints of the preceding ones
#56474
| https://github.com/microsoft/TypeScript/issues/56474 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 22, 2025 | https://github.com/microsoft/TypeScript/pull/52690#event-20419503591 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52690 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/52690/files/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/52690/files/d1666e86cc427cc55664e93e8d65ccb586eaffd3 |
|
| https://github.com/jakebailey |
|
Jake Bailey (jakebailey)
| https://github.com/jakebailey |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Only prior declared parameters should appear in completion lists for initializers
| https://github.com/microsoft/TypeScript/issues/1858 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/52690 |
|
| https://github.com/zardoy |
|
| https://github.com/jakebailey |
|
| https://github.com/sandersn |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |