René's URL Explorer Experiment


Title: Address code review of #5127 by zhengbli · Pull Request #5263 · microsoft/TypeScript · GitHub

Open Graph Title: Address code review of #5127 by zhengbli · Pull Request #5263 · microsoft/TypeScript

X Title: Address code review of #5127 by zhengbli · Pull Request #5263 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Address code review of #5127 by zhengbli · Pull Request #5263 · microsoft/TypeScript

Open Graph Description: Edit by Daniel Rosenwasser (@DanielRosenwasser): #5127

X Description: Edit by Daniel Rosenwasser (@DanielRosenwasser): #5127

Opengraph URL: https://github.com/microsoft/TypeScript/pull/5263

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8565e46c-8832-b887-a3df-0233a53830cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF72:10DACD:12106A8:17FEBB7:6B011AAA
html-safe-nonce15bc63554997ddce3157fa11ec5c090bf65ae40d00f730c8afaf7e3a54c75309
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjcyOjEwREFDRDoxMjEwNkE4OjE3RkVCQjc6NkIwMTFBQUEiLCJ2aXNpdG9yX2lkIjoiMzQ2NzM3NDUyMDU4OTk0OTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb3dd79b55a158252c4ba1a1ea4900566200769cc46eb80ec9af670e26a99593
hovercard-subject-tagpull_request:47743727
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/5263/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/63fcce2427366f9855737d2b4937547fea93d8b13b217d29bd0c5929f379cf3b/microsoft/TypeScript/pull/5263
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/63fcce2427366f9855737d2b4937547fea93d8b13b217d29bd0c5929f379cf3b/microsoft/TypeScript/pull/5263
og:image:altEdit by Daniel Rosenwasser (@DanielRosenwasser): #5127
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhengbli
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/5263#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5263
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5263
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/5263
Reloadhttps://github.com/microsoft/TypeScript/pull/5263
Reloadhttps://github.com/microsoft/TypeScript/pull/5263
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Zhengbo Li (zhengbli)https://github.com/zhengbli
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
zhengbli:pr5127crhttps://github.com/zhengbli/TypeScript/tree/pr5127cr
Conversationhttps://github.com/microsoft/TypeScript/pull/5263
Commits4 (4)https://github.com/microsoft/TypeScript/pull/5263/commits
Checkshttps://github.com/microsoft/TypeScript/pull/5263/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/5263/files
Address code review of #5127https://github.com/microsoft/TypeScript/pull/5263#top
Zhengbo Li (zhengbli)https://github.com/zhengbli
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
zhengbli:pr5127crhttps://github.com/zhengbli/TypeScript/tree/pr5127cr
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#issue-111544033
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
#5127https://github.com/microsoft/TypeScript/pull/5127
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Address code review at 5127https://github.com/microsoft/TypeScript/pull/5263/commits/3e37b3158b538a370680bc551579e90fd54bca82
3e37b31https://github.com/microsoft/TypeScript/pull/5263/commits/3e37b3158b538a370680bc551579e90fd54bca82
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#event-435993126
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 15, 2015 https://github.com/microsoft/TypeScript/pull/5263#ref-pullrequest-109908503
Add directory watcher for tsserver and tsc #5127 https://github.com/microsoft/TypeScript/pull/5127
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#issuecomment-148291040
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
DanielRosenwasserhttps://github.com/DanielRosenwasser
Oct 15, 2015 https://github.com/microsoft/TypeScript/pull/5263#discussion-diff-42162862
View reviewed changes https://github.com/microsoft/TypeScript/pull/5263/files/3e37b3158b538a370680bc551579e90fd54bca82#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/5263/files#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42162862
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42178159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/Microsoft/TypeScript/blob/99d448a1672490a1924adbb377cae2363b28fe33/src/compiler/program.ts#L429https://github.com/Microsoft/TypeScript/blob/99d448a1672490a1924adbb377cae2363b28fe33/src/compiler/program.ts#L429
https://github.com/Microsoft/TypeScript/blob/99d448a1672490a1924adbb377cae2363b28fe33/src/compiler/program.ts#L450https://github.com/Microsoft/TypeScript/blob/99d448a1672490a1924adbb377cae2363b28fe33/src/compiler/program.ts#L450
https://github.com/Microsoft/TypeScript/blob/331d26f40271c7a21c6fa74ffac633b45f653dda/src/harness/loggedIO.ts#L226https://github.com/Microsoft/TypeScript/blob/331d26f40271c7a21c6fa74ffac633b45f653dda/src/harness/loggedIO.ts#L226
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
CR feedbackhttps://github.com/microsoft/TypeScript/pull/5263/commits/ea9bf7313ae7334cdbed9a32306bccb4a22e3f5a
ea9bf73https://github.com/microsoft/TypeScript/pull/5263/commits/ea9bf7313ae7334cdbed9a32306bccb4a22e3f5a
DanielRosenwasserhttps://github.com/DanielRosenwasser
Oct 15, 2015 https://github.com/microsoft/TypeScript/pull/5263#discussion-diff-42184404
View reviewed changes https://github.com/microsoft/TypeScript/pull/5263/files/ea9bf7313ae7334cdbed9a32306bccb4a22e3f5a#diff-cae7a2f87589a6edbba69413c534173c9b7326d094bf64718aec199f669be11e
src/compiler/tsc.tshttps://github.com/microsoft/TypeScript/pull/5263/files#diff-cae7a2f87589a6edbba69413c534173c9b7326d094bf64718aec199f669be11e
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42184404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Vladimir Matveev (vladima)https://github.com/vladima
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42264093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42276873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42281361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Zhengbo Li (@zhengbli)https://github.com/zhengbli
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42285464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 15, 2015https://github.com/microsoft/TypeScript/pull/5263#issuecomment-148528760
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Add sortBeforeComparison option back to arrayIsEqualTohttps://github.com/microsoft/TypeScript/pull/5263/commits/e7e1fa72ec198f63d794abb296c4befb8b823dbb
e7e1fa7https://github.com/microsoft/TypeScript/pull/5263/commits/e7e1fa72ec198f63d794abb296c4befb8b823dbb
DanielRosenwasserhttps://github.com/DanielRosenwasser
Oct 16, 2015 https://github.com/microsoft/TypeScript/pull/5263#discussion-diff-42292290
View reviewed changes https://github.com/microsoft/TypeScript/pull/5263/files/e7e1fa72ec198f63d794abb296c4befb8b823dbb#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/5263/files#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42292290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 16, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42296277
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 18, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42328722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 19, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42387824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 19, 2015https://github.com/microsoft/TypeScript/pull/5263#discussion_r42416459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
CR feedbackhttps://github.com/microsoft/TypeScript/pull/5263/commits/39254b54ae3b5b51517aa7a2217c5c852e8ceab2
39254b5https://github.com/microsoft/TypeScript/pull/5263/commits/39254b54ae3b5b51517aa7a2217c5c852e8ceab2
Zhengbo Li (zhengbli)https://github.com/zhengbli
Oct 20, 2015 https://github.com/microsoft/TypeScript/pull/5263#ref-commit-1b36407
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/1b3640760b96bcea0e595f68b4cbccf40068c3e1
#5263https://github.com/microsoft/TypeScript/pull/5263
from zhengbli/pr5127crhttps://github.com/microsoft/TypeScript/commit/1b3640760b96bcea0e595f68b4cbccf40068c3e1
1b36407https://github.com/microsoft/TypeScript/commit/1b3640760b96bcea0e595f68b4cbccf40068c3e1
#5127https://github.com/microsoft/TypeScript/pull/5127
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
1b36407https://github.com/microsoft/TypeScript/commit/1b3640760b96bcea0e595f68b4cbccf40068c3e1
Oct 20, 2015https://github.com/microsoft/TypeScript/pull/5263#event-439921169
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/5263#event-1689619980
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F5263
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/5263
https://github.com/zhengbli
https://github.com/vladima
https://github.com/DanielRosenwasser
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.