René's URL Explorer Experiment


Title: Improve handling of corner cases in `narrowTypeByInstanceof` by ahejlsberg · Pull Request #52592 · microsoft/TypeScript · GitHub

Open Graph Title: Improve handling of corner cases in `narrowTypeByInstanceof` by ahejlsberg · Pull Request #52592 · microsoft/TypeScript

X Title: Improve handling of corner cases in `narrowTypeByInstanceof` by ahejlsberg · Pull Request #52592 · microsoft/TypeScript

Description: Fixes #52571.

Open Graph Description: Fixes #52571.

X Description: Fixes #52571.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/52592

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ca042f34-49a4-e95d-8765-f0b6ede9b709
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDD6:16EED3:2DD5077:3A6519E:6B01C020
html-safe-nonceac7d65cd3a66cfa9a45d8f4c14c02f78cbf0f068c030f144af13cc2ca0bfbf85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREQ2OjE2RUVEMzoyREQ1MDc3OjNBNjUxOUU6NkIwMUMwMjAiLCJ2aXNpdG9yX2lkIjoiMjMwMTAzMzMzNDgzMjIxODE0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4b91d1361c9f489563d7b3d46a615ebeff2a344f069587fbde070d8c9f6ece9b
hovercard-subject-tagpull_request:1228367032
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/52592/files
twitter:imagehttps://avatars.githubusercontent.com/u/4226954?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4226954?s=400&v=4
og:image:altFixes #52571.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/52592/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52592%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52592%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/52592/files
Reloadhttps://github.com/microsoft/TypeScript/pull/52592/files
Reloadhttps://github.com/microsoft/TypeScript/pull/52592/files
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
mainhttps://github.com/microsoft/TypeScript/tree/main
fix52571https://github.com/microsoft/TypeScript/tree/fix52571
Conversation 19 https://github.com/microsoft/TypeScript/pull/52592
Commits 5 https://github.com/microsoft/TypeScript/pull/52592/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/52592/checks
Files changed https://github.com/microsoft/TypeScript/pull/52592/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52592/files
Improve handling of corner cases in narrowTypeByInstanceof https://github.com/microsoft/TypeScript/pull/52592/files#top
Show all changes 5 commits https://github.com/microsoft/TypeScript/pull/52592/files
31d335f Improve handling of corner cases in `narrowTypeByInstanceof` ahejlsberg Feb 3, 2023 https://github.com/microsoft/TypeScript/pull/52592/commits/31d335f0b0299940cb43c2989c2fdfcb0fee84e7
1337f28 Add regression tests ahejlsberg Feb 3, 2023 https://github.com/microsoft/TypeScript/pull/52592/commits/1337f28f432e4f8a12ea68b4bb172eea5b8ff23e
59fae7f Keep existing handling of `any` on right hand side ahejlsberg Feb 3, 2023 https://github.com/microsoft/TypeScript/pull/52592/commits/59fae7f8bac7f884176195171dbdb085b1f03768
13bd783 Add extra test ahejlsberg Feb 3, 2023 https://github.com/microsoft/TypeScript/pull/52592/commits/13bd78368bb96b240784a15e1579ca0a69b64c28
2577f94 Merge branch 'main' into fix52571 ahejlsberg Feb 3, 2023 https://github.com/microsoft/TypeScript/pull/52592/commits/2577f940529df5b6a0b221aa38bfce9011614a0c
Clear filters https://github.com/microsoft/TypeScript/pull/52592/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52592/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52592/files
checker.ts https://github.com/microsoft/TypeScript/pull/52592/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
narrowByInstanceof.js https://github.com/microsoft/TypeScript/pull/52592/files#diff-e504cddb65ce46a19e2e7fda0a496fce68433a5b4cc75bc7eaf80e8e42b09b77
narrowByInstanceof.symbols https://github.com/microsoft/TypeScript/pull/52592/files#diff-85715d6eae42661aee922360d00b0b1bad83cc72725089bc84dcf15858156cc0
narrowByInstanceof.types https://github.com/microsoft/TypeScript/pull/52592/files#diff-761c3e9cb12e2cf6e90e7154c84ad8d6a604253e82b07d37938c9167bad22d7b
narrowByInstanceof.ts https://github.com/microsoft/TypeScript/pull/52592/files#diff-f4acced546870f67506e06ef47a0a55c285decb28df776ad4c43180a72da0d08
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/52592/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/microsoft/TypeScript/blob/2577f940529df5b6a0b221aa38bfce9011614a0c/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52592/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/52592/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/52592/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
tests/baselines/reference/narrowByInstanceof.jshttps://github.com/microsoft/TypeScript/pull/52592/files#diff-e504cddb65ce46a19e2e7fda0a496fce68433a5b4cc75bc7eaf80e8e42b09b77
View file https://github.com/microsoft/TypeScript/blob/2577f940529df5b6a0b221aa38bfce9011614a0c/tests/baselines/reference/narrowByInstanceof.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52592/{{ revealButtonHref }}
tests/baselines/reference/narrowByInstanceof.symbolshttps://github.com/microsoft/TypeScript/pull/52592/files#diff-85715d6eae42661aee922360d00b0b1bad83cc72725089bc84dcf15858156cc0
View file https://github.com/microsoft/TypeScript/blob/2577f940529df5b6a0b221aa38bfce9011614a0c/tests/baselines/reference/narrowByInstanceof.symbols
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52592/{{ revealButtonHref }}
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52592/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.