René's URL Explorer Experiment


Title: Fix completion of partial identifier inside a JsxExpression by pyBlob · Pull Request #52572 · microsoft/TypeScript · GitHub

Open Graph Title: Fix completion of partial identifier inside a JsxExpression by pyBlob · Pull Request #52572 · microsoft/TypeScript

X Title: Fix completion of partial identifier inside a JsxExpression by pyBlob · Pull Request #52572 · microsoft/TypeScript

Description: This originated from a typo (logical or instead of and) introduced here: #51855 I tried to use fourslash tests, but this didn't work, because they can only pass "includeInsertTextCompletions" to the preferences. This bug can only be triggered when passing the deprecated "includeInsertTextCompletions" to the CompletionsRequest. Fixes #52288

Open Graph Description: This originated from a typo (logical or instead of and) introduced here: #51855 I tried to use fourslash tests, but this didn't work, because they can only pass "includeInsertTextCompletio...

X Description: This originated from a typo (logical or instead of and) introduced here: #51855 I tried to use fourslash tests, but this didn't work, because they can only pass "includeInsertTextC...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/52572

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8bd8169a-2945-d264-9f52-0e8b08297b1f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC930:4BB79:26EAD7E:31B5B1A:6B019F32
html-safe-nonce8804cca355274958e7631177ce39723948a6bd0f38ff91b74a796a482f778dad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTMwOjRCQjc5OjI2RUFEN0U6MzFCNUIxQTo2QjAxOUYzMiIsInZpc2l0b3JfaWQiOiIzNzkxNDM0MTk2ODI0NzI3MzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac32ade67d8ffdec8f3d30f76f7e27fa0d8c4b1c5680d090874d9eb5d092377d1f
hovercard-subject-tagpull_request:1226839856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/52572/files
twitter:imagehttps://avatars.githubusercontent.com/u/10408403?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10408403?s=400&v=4
og:image:altThis originated from a typo (logical or instead of and) introduced here: #51855 I tried to use fourslash tests, but this didn't work, because they can only pass "includeInsertTextCompletio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/52572/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52572%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F52572%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/52572/files
Reloadhttps://github.com/microsoft/TypeScript/pull/52572/files
Reloadhttps://github.com/microsoft/TypeScript/pull/52572/files
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
pyBlob:fix-jsx-expression-complete-identifierhttps://github.com/pyBlob/TypeScript/tree/fix-jsx-expression-complete-identifier
Conversation 8 https://github.com/microsoft/TypeScript/pull/52572
Commits 4 https://github.com/microsoft/TypeScript/pull/52572/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/52572/checks
Files changed https://github.com/microsoft/TypeScript/pull/52572/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52572/files
Fix completion of partial identifier inside a JsxExpression https://github.com/microsoft/TypeScript/pull/52572/files#top
Show all changes 4 commits https://github.com/microsoft/TypeScript/pull/52572/files
43fa448 add failing test Feb 2, 2023 https://github.com/microsoft/TypeScript/pull/52572/commits/43fa44887c2c48be326334b9dea403b6199a2ea5
64accea Fix completion entry for identifier in JsxExpression Feb 2, 2023 https://github.com/microsoft/TypeScript/pull/52572/commits/64acceaf8a8dba1f59939c7445d83cdbc5120dc6
40faef9 fix lint Feb 2, 2023 https://github.com/microsoft/TypeScript/pull/52572/commits/40faef909d284017499751f35819d2700234a873
6fe126e add fourslash test, remove unit test gabritto Feb 4, 2023 https://github.com/microsoft/TypeScript/pull/52572/commits/6fe126eef2ce9e3ff4aad2fd38898bd1d7bf7134
Clear filters https://github.com/microsoft/TypeScript/pull/52572/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52572/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/52572/files
completions.ts https://github.com/microsoft/TypeScript/pull/52572/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
tests.ts https://github.com/microsoft/TypeScript/pull/52572/files#diff-b19a23ae3c1fb87bc796dd7bd1889bb4842fb49305d1d544550ca11dc073262b
completionsJsxExpression.ts https://github.com/microsoft/TypeScript/pull/52572/files#diff-d91bfa3569ef744aa34f45985b70aced942dc5622dda08885c0a35a171358662
src/services/completions.tshttps://github.com/microsoft/TypeScript/pull/52572/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
View file https://github.com/pyBlob/TypeScript/blob/6fe126eef2ce9e3ff4aad2fd38898bd1d7bf7134/src/services/completions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52572/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/52572/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
https://github.com/microsoft/TypeScript/pull/52572/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
src/testRunner/tests.tshttps://github.com/microsoft/TypeScript/pull/52572/files#diff-b19a23ae3c1fb87bc796dd7bd1889bb4842fb49305d1d544550ca11dc073262b
View file https://github.com/pyBlob/TypeScript/blob/6fe126eef2ce9e3ff4aad2fd38898bd1d7bf7134/src/testRunner/tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52572/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/52572/files#diff-b19a23ae3c1fb87bc796dd7bd1889bb4842fb49305d1d544550ca11dc073262b
tests/cases/fourslash/completionsJsxExpression.tshttps://github.com/microsoft/TypeScript/pull/52572/files#diff-d91bfa3569ef744aa34f45985b70aced942dc5622dda08885c0a35a171358662
View file https://github.com/pyBlob/TypeScript/blob/6fe126eef2ce9e3ff4aad2fd38898bd1d7bf7134/tests/cases/fourslash/completionsJsxExpression.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/52572/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.