| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dcc314bd-29bc-7e12-a074-072866aaa69a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F26:9431E:1CAC1B:28857B:6A61FCA6 |
| html-safe-nonce | d6428247c892416fc6eb6d179c6a51f0f815df5528639025084ceef2ce7673a8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjI2Ojk0MzFFOjFDQUMxQjoyODg1N0I6NkE2MUZDQTYiLCJ2aXNpdG9yX2lkIjoiMTYxNTQyNjI3NTEzNzE1ODMxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 43b3d4e82bba15caa45603b16b7b6df078d874719f27a8e35d74b5f742b9ef31 |
| hovercard-subject-tag | pull_request:1155976114 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/51837/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/50be6365cdeee0d5b43d2f87933870fcf635b2fe0b7115772610432b29307f48/microsoft/TypeScript/pull/51837 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/50be6365cdeee0d5b43d2f87933870fcf635b2fe0b7115772610432b29307f48/microsoft/TypeScript/pull/51837 |
| og:image:alt | #23801 makes bad escape sequences in tagged template allowable, but only in certain cases. #41030 aims to fix this but was closed.
In contrast, octal escape sequences in string literals (as in #396... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | graphemecluster |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9e41a6fd863e96b9c7e9185dc317bf107dbbf8cb10efd6dea957211963f33775 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2ed5e9c44acb35dcc1d752e449d2a6f7a6164b7b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/51837#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51837 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51837 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/51837 |
| Reload | https://github.com/microsoft/TypeScript/pull/51837 |
| Reload | https://github.com/microsoft/TypeScript/pull/51837 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
21
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| graphemecluster:escape-sequence | https://github.com/graphemecluster/TypeScript/tree/escape-sequence |
| Conversation | https://github.com/microsoft/TypeScript/pull/51837 |
| Commits8 (8) | https://github.com/microsoft/TypeScript/pull/51837/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/51837/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/51837/files |
| fix(396): (Dis)allow Octal and Bad Escape Sequences in String and (Tagged) Template Literals | https://github.com/microsoft/TypeScript/pull/51837#top |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| graphemecluster:escape-sequence | https://github.com/graphemecluster/TypeScript/tree/escape-sequence |
|
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issue-1486674257 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| #23801 | https://github.com/microsoft/TypeScript/pull/23801 |
| #41030 | https://github.com/microsoft/TypeScript/pull/41030 |
| #396 | https://github.com/microsoft/TypeScript/issues/396 |
| #12700 | https://github.com/microsoft/TypeScript/issues/12700 |
| #396 | https://github.com/microsoft/TypeScript/issues/396 |
| #39038 | https://github.com/microsoft/TypeScript/issues/39038 |
| #39715 | https://github.com/microsoft/TypeScript/issues/39715 |
| #42887 | https://github.com/microsoft/TypeScript/issues/42887 |
| #39563 | https://github.com/microsoft/TypeScript/issues/39563 |
| #39698 | https://github.com/microsoft/TypeScript/pull/39698 |
| #396 (comment) | https://github.com/microsoft/TypeScript/issues/396#issuecomment-853564421 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#event-7998298311 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344268507 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#event-7998437451 |
| https://github.com/RyanCavanaugh |
| RyanCavanaugh | https://github.com/RyanCavanaugh |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612159 |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612199 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140055 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344661056 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612200 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140056 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612201 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140057 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344731369 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612202 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140061 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344623433 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612203 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140060 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344713302 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612204 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140058 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344620193 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344612206 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| d1ba506 | https://github.com/microsoft/TypeScript/commit/d1ba506c8c0d34c54ad51017e6f24969fccb33b4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=140059 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344620193 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344623433 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344624949 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| here. | https://mseng.visualstudio.com/DefaultCollection/Typescript/_git/Typescript/pullrequest/692927 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344661056 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/140055/artifacts?artifactName=benchmark&fileId=73558F0A1178728C48AD061429B89AA29436CCCBD931C10DE5EDBC8F9D22696902&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344713302 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Dec 9, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1344731369 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| backstage/backstage | https://github.com/backstage/backstage |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| felixrieseberg/windows95 | https://github.com/felixrieseberg/windows95 |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| palantir/blueprint | https://github.com/palantir/blueprint |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| type-challenges/type-challenges | https://github.com/type-challenges/type-challenges |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| artifact folder | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=140057&view=artifacts&type=publishedArtifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214587947 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| tests/baselines/reference/api/typescript.d.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214588590 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| src/compiler/factory/nodeFactory.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214592452 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214592848 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214593533 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214595233 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| tests/baselines/reference/octalLiteralInStrictModeES3.errors.txt | https://github.com/microsoft/TypeScript/pull/51837/files#diff-856e456ee3ea627d719e536c807ef4401aef7e9c1a774331664ba7a660a82f9e |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Dec 13, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214596896 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1214596896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| Dec 13, 2022 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1348141107 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
Dec 14, 2022
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1216597133 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files |
| tests/cases/conformance/expressions/objectLiterals/objectLiteralErrors.ts | https://github.com/microsoft/TypeScript/pull/51837/files#diff-39cad89f6c045649322ed6cb6ae731d400001eb763f2f03a000b93039fc642fe |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| graphemecluster | https://github.com/graphemecluster |
| December 14, 2022 08:57 | https://github.com/microsoft/TypeScript/pull/51837#commits-pushed-51416df |
|
| https://github.com/graphemecluster |
| Literal and Escape Sequence | https://github.com/microsoft/TypeScript/pull/51837/commits/51416df32927c122f3e6fcef38119933e08a2af3 |
| 51416df | https://github.com/microsoft/TypeScript/pull/51837/commits/51416df32927c122f3e6fcef38119933e08a2af3 |
|
| https://github.com/graphemecluster |
| Remove strict mode and target check; Refactoring | https://github.com/microsoft/TypeScript/pull/51837/commits/cecc6ef9ae9f1752d499067eb74674cf59a98844 |
| cecc6ef | https://github.com/microsoft/TypeScript/pull/51837/commits/cecc6ef9ae9f1752d499067eb74674cf59a98844 |
|
| https://github.com/graphemecluster |
| Bug Fix | https://github.com/microsoft/TypeScript/pull/51837/commits/0f211b754110257c3b8c9259f4e8183372828931 |
| 0f211b7 | https://github.com/microsoft/TypeScript/pull/51837/commits/0f211b754110257c3b8c9259f4e8183372828931 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| force-pushed | https://github.com/microsoft/TypeScript/compare/e8b6e50bff4a479c8fbcc684d9fa883323502499..0f211b754110257c3b8c9259f4e8183372828931 |
| e8b6e50 | https://github.com/microsoft/TypeScript/commit/e8b6e50bff4a479c8fbcc684d9fa883323502499 |
| 0f211b7 | https://github.com/microsoft/TypeScript/commit/0f211b754110257c3b8c9259f4e8183372828931 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/e8b6e50bff4a479c8fbcc684d9fa883323502499..0f211b754110257c3b8c9259f4e8183372828931 |
| December 14, 2022 01:13 | https://github.com/microsoft/TypeScript/pull/51837#event-8031654432 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1467238564 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| @gabritto | https://github.com/gabritto |
| 251e536 | https://github.com/microsoft/TypeScript/commit/251e5366a4f34b5e1498b2760e9d4a998f87109c |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=149248 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1467338334 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1467338334 |
| @gabritto | https://github.com/gabritto |
| You can check the log here | https://typescript.visualstudio.com/TypeScript/_build/index?buildId=149248&_a=summary |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1468413453 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1468416274 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1468418322 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
|
Mar 14, 2023
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1339720218 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c |
| sandersn | https://github.com/sandersn |
|
Mar 14, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-commit-624f965 |
|
| https://github.com/sandersn |
| Update vk-openapi tests | https://github.com/DefinitelyTyped/DefinitelyTyped/commit/624f965d9e9cd0b71786443b0f3ab5e1df34226b |
| 624f965 | https://github.com/DefinitelyTyped/DefinitelyTyped/commit/624f965d9e9cd0b71786443b0f3ab5e1df34226b |
| microsoft/TypeScript#51837 | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
|
Mar 14, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-pullrequest-1623848354 |
|
Update vk-openapi tests
DefinitelyTyped/DefinitelyTyped#64741
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/64741 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| Mar 14, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1468426549 |
| DefinitelyTyped/DefinitelyTyped#64741 | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/64741 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| sandersn | https://github.com/sandersn |
|
Mar 14, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-commit-3df4c1e |
|
| https://github.com/sandersn |
| Update vk-openapi tests ( | https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3df4c1ef250253ce48fbe247c4f559ef609f7c85 |
| #64741 | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/64741 |
| ) | https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3df4c1ef250253ce48fbe247c4f559ef609f7c85 |
| 3df4c1e | https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3df4c1ef250253ce48fbe247c4f559ef609f7c85 |
| microsoft/TypeScript#51837 | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
|
Mar 17, 2023
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1346444097 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c |
| jakebailey | https://github.com/jakebailey |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1346444097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| src/compiler/scanner.ts | https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| tests/baselines/reference/api/typescript.d.ts | https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| stale review | https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1346444097 |
| March 17, 2023 18:02 | https://github.com/microsoft/TypeScript/pull/51837#event-8781146329 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| March 17, 2023 18:02 | https://github.com/microsoft/TypeScript/pull/51837#event-8781147023 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
|
Mar 17, 2023
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1346471215 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Mar 17, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1474235089 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Mar 17, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1474236507 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| March 20, 2023 17:57 | https://github.com/microsoft/TypeScript/pull/51837#event-8797660046 |
|
| https://github.com/graphemecluster |
| Merge branch 'main' into escape-sequence | https://github.com/microsoft/TypeScript/pull/51837/commits/c508e29803cf947d89f2a924a27f3d4e32b4636b |
| c508e29 | https://github.com/microsoft/TypeScript/pull/51837/commits/c508e29803cf947d89f2a924a27f3d4e32b4636b |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Mar 24, 2023
| https://github.com/microsoft/TypeScript/pull/51837#pullrequestreview-1357557864 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/51837/files/c508e29803cf947d89f2a924a27f3d4e32b4636b |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| c2dc2fd | https://github.com/microsoft/TypeScript/commit/c2dc2fd9b9c5e72227a91c76b657aad18914915c |
| Mar 24, 2023 | https://github.com/microsoft/TypeScript/pull/51837#event-8843541950 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| Mar 24, 2023 | https://github.com/microsoft/TypeScript/pull/51837#issuecomment-1483566527 |
| @graphemecluster | https://github.com/graphemecluster |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Breaking Change
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22 |
| Mar 24, 2023 | https://github.com/microsoft/TypeScript/pull/51837#event-8843544133 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| TypeScript 5.1.0 | https://github.com/microsoft/TypeScript/milestone/178 |
| Mar 24, 2023 | https://github.com/microsoft/TypeScript/pull/51837#event-8843544384 |
| alex-sonar | https://github.com/alex-sonar |
|
Jun 7, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-commit-f3aac6b |
| ruling changes due to disallowed octals in TS 5.1 - | https://github.com/SonarSource/SonarJS/commit/f3aac6b37827a23de866a6a5c035d65567526e9c |
| microsoft/TypeScr… | https://github.com/microsoft/TypeScript/pull/51837 |
| f3aac6b | https://github.com/SonarSource/SonarJS/commit/f3aac6b37827a23de866a6a5c035d65567526e9c |
| …ipt#51837 | https://github.com/microsoft/TypeScript/pull/51837 |
|
Provide Basic Syntax Check for Regular Expression Literals
#54744
| https://github.com/microsoft/TypeScript/issues/54744 |
|
Compiler should error when encountering invalid regular expressions
#3432
| https://github.com/microsoft/TypeScript/issues/3432 |
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
|
Aug 14, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-pullrequest-1850260448 |
|
Fixed hasInvalidEscape implementation
#55373
| https://github.com/microsoft/TypeScript/pull/55373 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
Sep 1, 2023
| https://github.com/microsoft/TypeScript/pull/51837#ref-pullrequest-1877164636 |
|
Provide Syntax Checking for Regular Expressions
#55600
| https://github.com/microsoft/TypeScript/pull/55600 |
| https://github.com/graphemecluster |
| graphemecluster | https://github.com/graphemecluster |
|
Apr 23, 2024
| https://github.com/microsoft/TypeScript/pull/51837#ref-pullrequest-2259348028 |
|
Report RegExp errors in grammar check, use Annex B grammar
#58295
| https://github.com/microsoft/TypeScript/pull/58295 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 22, 2025 | https://github.com/microsoft/TypeScript/pull/51837#event-20417638130 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51837 |
|
| https://github.com/sandersn |
|
sandersn
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c |
|
| https://github.com/DanielRosenwasser |
|
DanielRosenwasser
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/51837/files/c508e29803cf947d89f2a924a27f3d4e32b4636b |
|
| https://github.com/jakebailey |
|
jakebailey
| https://github.com/jakebailey |
|
| https://github.com/microsoft/TypeScript/pull/51837/files/251e5366a4f34b5e1498b2760e9d4a998f87109c |
|
| https://github.com/jakebailey |
|
jakebailey
| https://github.com/jakebailey |
|
Breaking Change
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22 |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
TypeScript 5.1.0
| https://github.com/microsoft/TypeScript/milestone/178 |
|
raw tagged string doesn't support for \x
| https://github.com/microsoft/TypeScript/issues/39715 |
|
Numeric separated literals should disallow zero leading
| https://github.com/microsoft/TypeScript/issues/39563 |
|
octal escape sequence literal type
| https://github.com/microsoft/TypeScript/issues/39038 |
|
Lift Template Literal Restriction on Backslashes
| https://github.com/microsoft/TypeScript/issues/12700 |
|
Octal escape sequences should be a lexical/syntactic error in strict mode and ES5
| https://github.com/microsoft/TypeScript/issues/396 |
|
\u in String.raw
| https://github.com/microsoft/TypeScript/issues/42887 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/51837 |
|
| https://github.com/graphemecluster |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/typescript-bot |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/sandersn |
|
| https://github.com/jakebailey |
|
| https://github.com/gabritto |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |