René's URL Explorer Experiment


Title: Narrow intersected classes using `instanceof` by Andarist · Pull Request #51032 · microsoft/TypeScript · GitHub

Open Graph Title: Narrow intersected classes using `instanceof` by Andarist · Pull Request #51032 · microsoft/TypeScript

X Title: Narrow intersected classes using `instanceof` by Andarist · Pull Request #51032 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Narrow intersected classes using `instanceof` by Andarist · Pull Request #51032 · microsoft/TypeScript

Open Graph Description: fixes #50844 the logic was exiting from handling the intersection based on this isTypeDerivedFrom check here in the narrowTypeByInstanceof isTypeDerivedFrom was not happy about the source state be...

X Description: fixes #50844 the logic was exiting from handling the intersection based on this isTypeDerivedFrom check here in the narrowTypeByInstanceof isTypeDerivedFrom was not happy about the source state be...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/51032

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94d786d9-7338-e1b3-e351-063fd976d05a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE37E:2E3FEE:2E93342:3AFAA0E:6B01BB10
html-safe-nonce116215f507918a28dc6ecd91b70602a4740b7a23882abe918b79f46a9a8e5e2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzdFOjJFM0ZFRToyRTkzMzQyOjNBRkFBMEU6NkIwMUJCMTAiLCJ2aXNpdG9yX2lkIjoiODk5OTUxNDAyMjQ0NTQzMTU2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac347716ca477603c943b959c99e2ed85b7fea70494ebee0a8eea50abd9685b2e1
hovercard-subject-tagpull_request:1073944616
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/51032/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1758dfb382f1b00e0f6a2553d39c23cb4220d9daf55d602596f647ea09cbf626/microsoft/TypeScript/pull/51032
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1758dfb382f1b00e0f6a2553d39c23cb4220d9daf55d602596f647ea09cbf626/microsoft/TypeScript/pull/51032
og:image:altfixes #50844 the logic was exiting from handling the intersection based on this isTypeDerivedFrom check here in the narrowTypeByInstanceof isTypeDerivedFrom was not happy about the source state be...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/51032#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51032
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51032
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/51032
Reloadhttps://github.com/microsoft/TypeScript/pull/51032
Reloadhttps://github.com/microsoft/TypeScript/pull/51032
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Mateusz Burzyński (Andarist)https://github.com/Andarist
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/50844https://github.com/Andarist/TypeScript/tree/fix/50844
Conversationhttps://github.com/microsoft/TypeScript/pull/51032
Commits1 (1)https://github.com/microsoft/TypeScript/pull/51032/commits
Checkshttps://github.com/microsoft/TypeScript/pull/51032/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/51032/files
Narrow intersected classes using instanceofhttps://github.com/microsoft/TypeScript/pull/51032#top
Mateusz Burzyński (Andarist)https://github.com/Andarist
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/50844https://github.com/Andarist/TypeScript/tree/fix/50844
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Oct 2, 2022https://github.com/microsoft/TypeScript/pull/51032#issue-1393896440
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
#50844https://github.com/microsoft/TypeScript/issues/50844
herehttps://github.dev/microsoft/TypeScript/blob/8a1b85880f89c9cff606c5844e8883e5f483c7db/src/compiler/checker.ts#L25693-L25695
herehttps://github.dev/microsoft/TypeScript/blob/8a1b85880f89c9cff606c5844e8883e5f483c7db/src/compiler/checker.ts#L17778
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Backlog Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
Oct 2, 2022https://github.com/microsoft/TypeScript/pull/51032#event-7502577693
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
force-pushedhttps://github.com/microsoft/TypeScript/compare/6691c56ed0cbb110704fe4fa70935f83d0e3e5cc..040f01639ecb77faf5dd1901db011c40c98be533
6691c56https://github.com/microsoft/TypeScript/commit/6691c56ed0cbb110704fe4fa70935f83d0e3e5cc
040f016https://github.com/microsoft/TypeScript/commit/040f01639ecb77faf5dd1901db011c40c98be533
Compare https://github.com/microsoft/TypeScript/compare/6691c56ed0cbb110704fe4fa70935f83d0e3e5cc..040f01639ecb77faf5dd1901db011c40c98be533
October 2, 2022 20:57https://github.com/microsoft/TypeScript/pull/51032#event-7502578271
https://github.com/Andarist
Narrow intersected classes using instanceofhttps://github.com/microsoft/TypeScript/pull/51032/commits/5cb1fc06968426bbd37e93bc9420bffa5b75f33f
5cb1fc0https://github.com/microsoft/TypeScript/pull/51032/commits/5cb1fc06968426bbd37e93bc9420bffa5b75f33f
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
force-pushedhttps://github.com/microsoft/TypeScript/compare/040f01639ecb77faf5dd1901db011c40c98be533..5cb1fc06968426bbd37e93bc9420bffa5b75f33f
040f016https://github.com/microsoft/TypeScript/commit/040f01639ecb77faf5dd1901db011c40c98be533
5cb1fc0https://github.com/microsoft/TypeScript/commit/5cb1fc06968426bbd37e93bc9420bffa5b75f33f
Compare https://github.com/microsoft/TypeScript/compare/040f01639ecb77faf5dd1901db011c40c98be533..5cb1fc06968426bbd37e93bc9420bffa5b75f33f
October 2, 2022 21:27https://github.com/microsoft/TypeScript/pull/51032#event-7502612258
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 15, 2022 22:16https://github.com/microsoft/TypeScript/pull/51032#event-7817984328
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 15, 2022https://github.com/microsoft/TypeScript/pull/51032#event-7817985333
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jake Bailey (jakebailey)https://github.com/jakebailey
November 15, 2022 22:16https://github.com/microsoft/TypeScript/pull/51032#event-7817986047
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 23, 2022 https://github.com/microsoft/TypeScript/pull/51032#pullrequestreview-1191161987
View reviewed changes https://github.com/microsoft/TypeScript/pull/51032/files/5cb1fc06968426bbd37e93bc9420bffa5b75f33f
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/51032/files/5cb1fc06968426bbd37e93bc9420bffa5b75f33f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 23, 2022https://github.com/microsoft/TypeScript/pull/51032#discussion_r1030109260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#51631https://github.com/microsoft/TypeScript/pull/51631
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Nov 23, 2022https://github.com/microsoft/TypeScript/pull/51032#issuecomment-1324687328
#51631https://github.com/microsoft/TypeScript/pull/51631
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Nov 23, 2022https://github.com/microsoft/TypeScript/pull/51032#event-7874639813
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
November 23, 2022 08:12https://github.com/microsoft/TypeScript/pull/51032#event-7874640241
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/51032#event-20417608123
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F51032
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/51032/files/5cb1fc06968426bbd37e93bc9420bffa5b75f33f
https://github.com/jakebailey
Jake Bailey (jakebailey) https://github.com/jakebailey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
For Backlog Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
instanceof does not narrow when the class is intersected with & https://github.com/microsoft/TypeScript/issues/50844
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/51032
https://github.com/Andarist
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.