René's URL Explorer Experiment


Title: Fixed an issue with unsound indexed access on unknown type param by Andarist · Pull Request #49729 · microsoft/TypeScript · GitHub

Open Graph Title: Fixed an issue with unsound indexed access on unknown type param by Andarist · Pull Request #49729 · microsoft/TypeScript

X Title: Fixed an issue with unsound indexed access on unknown type param by Andarist · Pull Request #49729 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fixed an issue with unsound indexed access on unknown type param by Andarist · Pull Request #49729 · microsoft/TypeScript

Open Graph Description: given the changed behavior from #49119 those indexed accesses within those generic functions should error as mentioned by @RyanCavanaugh here: #49696 (comment)

X Description: given the changed behavior from #49119 those indexed accesses within those generic functions should error as mentioned by @RyanCavanaugh here: #49696 (comment)

Opengraph URL: https://github.com/microsoft/TypeScript/pull/49729

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d04c1aad-e9fd-8da3-1d46-8cf89f42481d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3AA:10F37C:11C26D:179B68:6A515D4C
html-safe-noncee3461da1e88b8c3fdf798dbeb2dff703a6dfcfb69fd29677c4a0eb047eab0e26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0FBOjEwRjM3QzoxMUMyNkQ6MTc5QjY4OjZBNTE1RDRDIiwidmlzaXRvcl9pZCI6IjI0OTU5MjYzNTM1NzQwNTkzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac037e50fb9d3ef2d23e0f8f26ce2e7af72652051cfe399cbac1772ebcb8fb5cae
hovercard-subject-tagpull_request:982419529
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/49729/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1dcb159bb00ed2484bb7f1dfb34faef7288eb5e9bb59c58e2004ce19bb5ea33a/microsoft/TypeScript/pull/49729
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1dcb159bb00ed2484bb7f1dfb34faef7288eb5e9bb59c58e2004ce19bb5ea33a/microsoft/TypeScript/pull/49729
og:image:altgiven the changed behavior from #49119 those indexed accesses within those generic functions should error as mentioned by @RyanCavanaugh here: #49696 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndarist
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2eeb434949a926fad21064b4d395a54759f7a0b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/49729#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49729
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49729
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/49729
Reloadhttps://github.com/microsoft/TypeScript/pull/49729
Reloadhttps://github.com/microsoft/TypeScript/pull/49729
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 31 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Andaristhttps://github.com/Andarist
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/generic-unknown-type-param-with-keyof-indexed-accesshttps://github.com/Andarist/TypeScript/tree/fix/generic-unknown-type-param-with-keyof-indexed-access
Conversationhttps://github.com/microsoft/TypeScript/pull/49729
Commits1 (1)https://github.com/microsoft/TypeScript/pull/49729/commits
Checkshttps://github.com/microsoft/TypeScript/pull/49729/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/49729/files
Fixed an issue with unsound indexed access on unknown type paramhttps://github.com/microsoft/TypeScript/pull/49729#top
Andaristhttps://github.com/Andarist
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
Andarist:fix/generic-unknown-type-param-with-keyof-indexed-accesshttps://github.com/Andarist/TypeScript/tree/fix/generic-unknown-type-param-with-keyof-indexed-access
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#issue-1288523159
#49119https://github.com/microsoft/TypeScript/pull/49119
@RyanCavanaughhttps://github.com/RyanCavanaugh
#49696 (comment)https://github.com/microsoft/TypeScript/pull/49696#discussion_r908739090
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Fixed an issue with unsound indexed access on unknown type paramhttps://github.com/microsoft/TypeScript/pull/49729/commits/e3483834e6e90521baeaf69ce224174cd7f061e1
e348383https://github.com/microsoft/TypeScript/pull/49729/commits/e3483834e6e90521baeaf69ce224174cd7f061e1
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#event-6901262196
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#issuecomment-1169828323
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jun 29, 2022 https://github.com/microsoft/TypeScript/pull/49729#pullrequestreview-1023132234
View reviewed changes https://github.com/microsoft/TypeScript/pull/49729/files/e3483834e6e90521baeaf69ce224174cd7f061e1
tests/baselines/reference/genericUnknownTypeParamWithKeyofIndexedAccess.errors.txthttps://github.com/microsoft/TypeScript/pull/49729/files/e3483834e6e90521baeaf69ce224174cd7f061e1#diff-453c16016bc53acd3c21408e43722e1df1a853b1b17b34ba900435e178443963
Andaristhttps://github.com/Andarist
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#discussion_r909482792
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/microsoft/TypeScript/pull/49696#discussion_r907811832
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jun 29, 2022 https://github.com/microsoft/TypeScript/pull/49729#pullrequestreview-1023137366
View reviewed changes https://github.com/microsoft/TypeScript/pull/49729/files/e3483834e6e90521baeaf69ce224174cd7f061e1
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/49729/files/e3483834e6e90521baeaf69ce224174cd7f061e1#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Andaristhttps://github.com/Andarist
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#discussion_r909486277
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.dev/microsoft/TypeScript/blob/b379e7fc791fc8646d9d255adce5127a6ab83099/src/compiler/checker.ts#L23562-L23564https://github.dev/microsoft/TypeScript/blob/b379e7fc791fc8646d9d255adce5127a6ab83099/src/compiler/checker.ts#L23562-L23564
https://github.com/microsoft/TypeScript/pull/49119/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8R18815-R18817https://github.com/microsoft/TypeScript/pull/49119/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8R18815-R18817
https://github.com/microsoft/TypeScript/pull/49481/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8R18795https://github.com/microsoft/TypeScript/pull/49481/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8R18795
@ahejlsberghttps://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jun 29, 2022https://github.com/microsoft/TypeScript/pull/49729#issuecomment-1169915531
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jul 7, 2022https://github.com/microsoft/TypeScript/pull/49729#event-6954266787
https://github.com/Andarist
Andaristhttps://github.com/Andarist
Jul 7, 2022https://github.com/microsoft/TypeScript/pull/49729#issuecomment-1178037307
#49696 (comment)https://github.com/microsoft/TypeScript/pull/49696#discussion_r910380963
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
Andaristhttps://github.com/Andarist
July 7, 2022 18:22https://github.com/microsoft/TypeScript/pull/49729#event-6954273090
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/49729#event-20417561901
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49729
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49729
https://github.com/Andarist
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.