René's URL Explorer Experiment


Title: Improve narrowing logic for `instanceof`, type predicate functions, and assertion functions by ahejlsberg · Pull Request #49625 · microsoft/TypeScript · GitHub

Open Graph Title: Improve narrowing logic for `instanceof`, type predicate functions, and assertion functions by ahejlsberg · Pull Request #49625 · microsoft/TypeScript

X Title: Improve narrowing logic for `instanceof`, type predicate functions, and assertion functions by ahejlsberg · Pull Request #49625 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve narrowing logic for `instanceof`, type predicate functions, and assertion functions by ahejlsberg · Pull Request #49625 · microsoft/TypeScript

Open Graph Description: This PR improves our narrowing logic for instanceof, type predicate functions, and assertion functions. In particular, we now correctly handle situations where the narrowing target type is a union ...

X Description: This PR improves our narrowing logic for instanceof, type predicate functions, and assertion functions. In particular, we now correctly handle situations where the narrowing target type is a union ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/49625

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:87e0e96e-6c42-3da5-ac88-431f390f38ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE176:269AD9:A5C830:DF4A7B:6B00EE5D
html-safe-nonce79eddc8693fc2121a8db2cafd95f8a7fde567d3dedac70861bf5fd66b0d1d2cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTc2OjI2OUFEOTpBNUM4MzA6REY0QTdCOjZCMDBFRTVEIiwidmlzaXRvcl9pZCI6IjY3NTUzNjQ0MzQ1NzI1Mzc0MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c3b455cabea10d78ead16f4010fe8beceebb22a52a8a3fb7f5b61b8fd2c45a6
hovercard-subject-tagpull_request:974325054
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/49625/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7347212f2b5ef76db7d3cc33becfd4af793b582b5ff077678aad75d2ed44ae36/microsoft/TypeScript/pull/49625
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7347212f2b5ef76db7d3cc33becfd4af793b582b5ff077678aad75d2ed44ae36/microsoft/TypeScript/pull/49625
og:image:altThis PR improves our narrowing logic for instanceof, type predicate functions, and assertion functions. In particular, we now correctly handle situations where the narrowing target type is a union ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/49625#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49625
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49625
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/49625
Reloadhttps://github.com/microsoft/TypeScript/pull/49625
Reloadhttps://github.com/microsoft/TypeScript/pull/49625
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
mainhttps://github.com/microsoft/TypeScript/tree/main
fix31156https://github.com/microsoft/TypeScript/tree/fix31156
Conversationhttps://github.com/microsoft/TypeScript/pull/49625
Commits7 (7)https://github.com/microsoft/TypeScript/pull/49625/commits
Checkshttps://github.com/microsoft/TypeScript/pull/49625/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/49625/files
Improve narrowing logic for instanceof, type predicate functions, and assertion functionshttps://github.com/microsoft/TypeScript/pull/49625#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
mainhttps://github.com/microsoft/TypeScript/tree/main
fix31156https://github.com/microsoft/TypeScript/tree/fix31156
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issue-1279278862
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
#31156https://github.com/microsoft/TypeScript/issues/31156
#35953https://github.com/microsoft/TypeScript/issues/35953
#37807https://github.com/microsoft/TypeScript/issues/37807
#38869https://github.com/microsoft/TypeScript/issues/38869
#39105https://github.com/microsoft/TypeScript/issues/39105
#40035https://github.com/microsoft/TypeScript/issues/40035
#41871https://github.com/microsoft/TypeScript/issues/41871
#42101https://github.com/microsoft/TypeScript/issues/42101
#43825https://github.com/microsoft/TypeScript/issues/43825
#44754https://github.com/microsoft/TypeScript/issues/44754
#46909https://github.com/microsoft/TypeScript/issues/46909
#49588https://github.com/microsoft/TypeScript/issues/49588
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
June 21, 2022 16:56https://github.com/microsoft/TypeScript/pull/49625#commits-pushed-b779e3b
https://github.com/ahejlsberg
Improve narrowing logic for instanceof, type predicates, and assertionshttps://github.com/microsoft/TypeScript/pull/49625/commits/b779e3b69641cbdca85b6088c95fa6456516ccc0
b779e3bhttps://github.com/microsoft/TypeScript/pull/49625/commits/b779e3b69641cbdca85b6088c95fa6456516ccc0
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/49625/commits/cbd3f3dc9db94a6804ed2b84d0e5ba15e1041a20
cbd3f3dhttps://github.com/microsoft/TypeScript/pull/49625/commits/cbd3f3dc9db94a6804ed2b84d0e5ba15e1041a20
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/49625/commits/fc81aff57030abec0b8f201db167284b0ef15b9b
fc81affhttps://github.com/microsoft/TypeScript/pull/49625/commits/fc81aff57030abec0b8f201db167284b0ef15b9b
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#event-6851981282
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Backlog Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#event-6851981358
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162495273
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162495288
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
fc81affhttps://github.com/microsoft/TypeScript/commit/fc81aff57030abec0b8f201db167284b0ef15b9b
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128572
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162503634
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162495289
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
fc81affhttps://github.com/microsoft/TypeScript/commit/fc81aff57030abec0b8f201db167284b0ef15b9b
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128573
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162505765
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162495290
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
fc81affhttps://github.com/microsoft/TypeScript/commit/fc81aff57030abec0b8f201db167284b0ef15b9b
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128570
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162495292
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
fc81affhttps://github.com/microsoft/TypeScript/commit/fc81aff57030abec0b8f201db167284b0ef15b9b
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128571
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Andrew Branch (andrewbranch)https://github.com/andrewbranch
June 22, 2022 00:36https://github.com/microsoft/TypeScript/pull/49625#event-6851984094
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162503634
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/128572/artifacts?artifactName=benchmark&fileId=EAE24294A46E5BF94EE23A18FA099262CBDD55FAC22B84B540A1D8E36A30F95201&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162504569
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
here.https://mseng.visualstudio.com/DefaultCollection/Typescript/_git/Typescript/pullrequest/667395
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1162505765
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
June 22, 2022 12:18https://github.com/microsoft/TypeScript/pull/49625#commits-pushed-d6d1533
https://github.com/ahejlsberg
Tweak algorithmhttps://github.com/microsoft/TypeScript/pull/49625/commits/d6d1533c80561c68ceca290370ebdfac1f2338a1
d6d1533https://github.com/microsoft/TypeScript/pull/49625/commits/d6d1533c80561c68ceca290370ebdfac1f2338a1
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/49625/commits/37bfa91ecb012960004ceb1a217341d2af79f157
37bfa91https://github.com/microsoft/TypeScript/pull/49625/commits/37bfa91ecb012960004ceb1a217341d2af79f157
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163585306
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163585341
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
37bfa91https://github.com/microsoft/TypeScript/commit/37bfa91ecb012960004ceb1a217341d2af79f157
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128628
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163596674
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163585342
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
37bfa91https://github.com/microsoft/TypeScript/commit/37bfa91ecb012960004ceb1a217341d2af79f157
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128627
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163609521
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163585344
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
37bfa91https://github.com/microsoft/TypeScript/commit/37bfa91ecb012960004ceb1a217341d2af79f157
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128626
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163596674
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163598264
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
here.https://mseng.visualstudio.com/DefaultCollection/Typescript/_git/Typescript/pullrequest/667537
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163599766
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163599797
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
37bfa91https://github.com/microsoft/TypeScript/commit/37bfa91ecb012960004ceb1a217341d2af79f157
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=128629
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163609521
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/128627/artifacts?artifactName=benchmark&fileId=BE9C9A17B1DD608F00B322E3E7140FD1141C91A37892B1A8E44D5128ED388CFB01&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 22, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1163625504
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/128629/artifacts?artifactName=tgz&fileId=9370A02BE9286083A98BB5F91ED39114FDC7E27C11CF7BF17C728DC44CF30EDE02&fileName=/typescript-4.8.0-insiders.20220622.tgz
for this buildhttps://www.staging-typescript.org/play?ts=4.8.0-pr-49625-17
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/4.8.0-pr-49625-17
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Optimize for discriminated unionshttps://github.com/microsoft/TypeScript/pull/49625/commits/e85971c037a40802b9c9682e82e3f26a928fa415
e85971chttps://github.com/microsoft/TypeScript/pull/49625/commits/e85971c037a40802b9c9682e82e3f26a928fa415
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175333553
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175333592
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
960ad11https://github.com/microsoft/TypeScript/commit/960ad11e9ac6a20c68d25645756040a85982d3e5
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=129254
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175344619
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175344619
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Download Benchmarkhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/129254/artifacts?artifactName=benchmark&fileId=EE02F18E648DB53E8B32BC597E8CFD69747E0A52761373DF9D5A181110F2AE5601&fileName=linux.benchmark
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175382135
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175382234
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
960ad11https://github.com/microsoft/TypeScript/commit/960ad11e9ac6a20c68d25645756040a85982d3e5
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=129262
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175382235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
960ad11https://github.com/microsoft/TypeScript/commit/960ad11e9ac6a20c68d25645756040a85982d3e5
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=129263
The results are in!https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175404036
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175382236
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
960ad11https://github.com/microsoft/TypeScript/commit/960ad11e9ac6a20c68d25645756040a85982d3e5
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=129261
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175404036
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 5, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1175407384
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
here.https://mseng.visualstudio.com/DefaultCollection/Typescript/_git/Typescript/pullrequest/669270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 11, 2022 https://github.com/microsoft/TypeScript/pull/49625#pullrequestreview-1034946321
View reviewed changes https://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 11, 2022 https://github.com/microsoft/TypeScript/pull/49625#pullrequestreview-1034955211
View reviewed changes https://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 15, 2022 https://github.com/microsoft/TypeScript/pull/49625#pullrequestreview-1040885187
View reviewed changes https://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Jul 15, 2022https://github.com/microsoft/TypeScript/pull/49625#issuecomment-1186028880
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
2c68dedhttps://github.com/microsoft/TypeScript/commit/2c68ded95498dc637acdb00e8349f51832f5a6df
Jul 16, 2022https://github.com/microsoft/TypeScript/pull/49625#event-7005328496
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
July 16, 2022 00:01https://github.com/microsoft/TypeScript/pull/49625#event-7005328576
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 18, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1308688685
Crash in narrowing when using for-in #49942 https://github.com/microsoft/TypeScript/issues/49942
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 21, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1313641354
#49625 breaks node type expectations #49988 https://github.com/microsoft/TypeScript/issues/49988
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 21, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-commit-59e7b9d
https://github.com/sandersn
Update node types.isMap testshttps://github.com/DefinitelyTyped/DefinitelyTyped/commit/59e7b9debf261955e7fb18558dd3d71349864da3
59e7b9dhttps://github.com/DefinitelyTyped/DefinitelyTyped/commit/59e7b9debf261955e7fb18558dd3d71349864da3
microsoft/TypeScript#49625https://github.com/microsoft/TypeScript/pull/49625
microsoft/TypeScript#49988https://github.com/microsoft/TypeScript/issues/49988
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 21, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-pullrequest-1313653636
Update node types.isMap tests DefinitelyTyped/DefinitelyTyped#61389 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/61389
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 22, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-commit-87c7553
https://github.com/sandersn
Update node types.isMap tests (https://github.com/DefinitelyTyped/DefinitelyTyped/commit/87c7553d7c0afac0ab30c278bad67612dc80d021
#61389https://github.com/DefinitelyTyped/DefinitelyTyped/pull/61389
)https://github.com/DefinitelyTyped/DefinitelyTyped/commit/87c7553d7c0afac0ab30c278bad67612dc80d021
87c7553https://github.com/DefinitelyTyped/DefinitelyTyped/commit/87c7553d7c0afac0ab30c278bad67612dc80d021
microsoft/TypeScript#49625https://github.com/microsoft/TypeScript/pull/49625
microsoft/TypeScript#49988https://github.com/microsoft/TypeScript/issues/49988
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 22, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1315324499
Design Meeting Notes, 7/22/2022 #50008 https://github.com/microsoft/TypeScript/issues/50008
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 22, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-commit-399faf6
https://github.com/sandersn
Update underscore and weak-napi tests for TS 4.8https://github.com/DefinitelyTyped/DefinitelyTyped/commit/399faf690c0f6317050eac380ded07526179489a
399faf6https://github.com/DefinitelyTyped/DefinitelyTyped/commit/399faf690c0f6317050eac380ded07526179489a
microsoft/TypeScript#49625https://github.com/microsoft/TypeScript/pull/49625
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 22, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-pullrequest-1315469669
Update underscore and weak-napi tests for TS 4.8 DefinitelyTyped/DefinitelyTyped#61419 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/61419
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 22, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-commit-6a6411f
https://github.com/sandersn
Update underscore and weak-napi tests for TS 4.8 (https://github.com/DefinitelyTyped/DefinitelyTyped/commit/6a6411f9251b6a7cdf8078193604758204a65bab
#61419https://github.com/DefinitelyTyped/DefinitelyTyped/pull/61419
)https://github.com/DefinitelyTyped/DefinitelyTyped/commit/6a6411f9251b6a7cdf8078193604758204a65bab
6a6411fhttps://github.com/DefinitelyTyped/DefinitelyTyped/commit/6a6411f9251b6a7cdf8078193604758204a65bab
microsoft/TypeScript#49625https://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jul 25, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-pullrequest-1317430745
Favor asserted type in type predicate narrowing #50044 https://github.com/microsoft/TypeScript/pull/50044
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Oct 7, 2022 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1099565453
Pragmatic yet more correct narrowing algorithm for UDTP #47389 https://github.com/microsoft/TypeScript/issues/47389
https://github.com/rf-figma
Ryan Fitzgerald (rf-figma)https://github.com/rf-figma
May 5, 2023 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1696842132
Type guard incorrectly erases union type #54143 https://github.com/microsoft/TypeScript/issues/54143
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Oct 1, 2023 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1551568591
Performance regression from #48044 #52345 https://github.com/microsoft/TypeScript/issues/52345
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
Oct 2, 2023 https://github.com/microsoft/TypeScript/pull/49625#ref-issue-1922665580
Performance regression from #49625 and #52984 #55948 https://github.com/microsoft/TypeScript/issues/55948
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/49625#event-20417558122
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F49625
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/49625/files/960ad11e9ac6a20c68d25645756040a85982d3e5
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Backlog Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
Subtype narrowing bug with falsey types (''/0/[]) https://github.com/microsoft/TypeScript/issues/39105
Previous generic union does not narrow to an union again with type predicate https://github.com/microsoft/TypeScript/issues/38869
Narrowing type via Function Assertion loses numeric type https://github.com/microsoft/TypeScript/issues/37807
Typeguard for union not working after adding a property to the superclass of one of the union members https://github.com/microsoft/TypeScript/issues/35953
Typeguard with ""|undefined not working https://github.com/microsoft/TypeScript/issues/31156
Discriminated union narrowed incorrectly by user-defined type predicate https://github.com/microsoft/TypeScript/issues/40035
Incorrect narrowing when a type guard returns a type union https://github.com/microsoft/TypeScript/issues/41871
Type guard does not work correctly with empty string type https://github.com/microsoft/TypeScript/issues/42101
union types narrowed incorrectly by assertion functions and type predicate functions https://github.com/microsoft/TypeScript/issues/43825
Type narrowing of union types by type predicate narrows to only first branch of union https://github.com/microsoft/TypeScript/issues/44754
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/49625
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/RyanCavanaugh
https://github.com/jakebailey
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.