René's URL Explorer Experiment


Title: fix(48166): Checking module.exports should not yield a This condition will always return true since this function is always defined error by a-tarasyuk · Pull Request #48337 · microsoft/TypeScript · GitHub

Open Graph Title: fix(48166): Checking module.exports should not yield a This condition will always return true since this function is always defined error by a-tarasyuk · Pull Request #48337 · microsoft/TypeScript

X Title: fix(48166): Checking module.exports should not yield a This condition will always return true since this function is always defined error by a-tarasyuk · Pull Request #48337 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - fix(48166): Checking module.exports should not yield a This condition will always return true since this function is always defined error by a-tarasyuk · Pull Request #48337 · microsoft/TypeScript

Open Graph Description: Fixes #48166

X Description: Fixes #48166

Opengraph URL: https://github.com/microsoft/TypeScript/pull/48337

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2c6e846a-2012-9aea-8b56-01aeab7ef496
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDCA:1DF43C:A91FE2:E66843:6A63B214
html-safe-noncecd81de64f5d4bd0d0ef4812d3c4173d39aec6c6d45d65cf1578dd14f851cad12
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRENBOjFERjQzQzpBOTFGRTI6RTY2ODQzOjZBNjNCMjE0IiwidmlzaXRvcl9pZCI6IjQ4NzgxOTU5MDkyMjk1MjM0NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca86065b47262b34c1f7651a170a3d3cb571d4b677aab01e8cae5ec8c7fb19cba
hovercard-subject-tagpull_request:884021876
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/48337/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ac933a6647b8377e78a1f3972e991690e25eb0264715cabb4738ec3b83611f15/microsoft/TypeScript/pull/48337
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac933a6647b8377e78a1f3972e991690e25eb0264715cabb4738ec3b83611f15/microsoft/TypeScript/pull/48337
og:image:altFixes #48166
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamea-tarasyuk
hostnamegithub.com
expected-hostnamegithub.com
Nonec69b5576237034cb6ab5477391df7811093a00579a751b33bed4b527d68aade6
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5c31956f7a31ef033ef93ba813dcb6f7e8eb0972
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/48337#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48337
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48337
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/48337
Reloadhttps://github.com/microsoft/TypeScript/pull/48337
Reloadhttps://github.com/microsoft/TypeScript/pull/48337
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/48337
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 21 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
sandersnhttps://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
a-tarasyuk:fix/48166https://github.com/a-tarasyuk/TypeScript/tree/fix/48166
Conversationhttps://github.com/microsoft/TypeScript/pull/48337
Commits1 (1)https://github.com/microsoft/TypeScript/pull/48337/commits
Checkshttps://github.com/microsoft/TypeScript/pull/48337/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/48337/files
fix(48166): Checking module.exports should not yield a This condition will always return true since this function is always defined errorhttps://github.com/microsoft/TypeScript/pull/48337#top
sandersnhttps://github.com/sandersn
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
a-tarasyuk:fix/48166https://github.com/a-tarasyuk/TypeScript/tree/fix/48166
https://github.com/a-tarasyuk
a-tarasyukhttps://github.com/a-tarasyuk
Mar 19, 2022https://github.com/microsoft/TypeScript/pull/48337#issue-1174322986
#48166https://github.com/microsoft/TypeScript/issues/48166
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/48337
https://github.com/a-tarasyuk
fix(48166): skip checking module.exports in a truthiness call expressionhttps://github.com/microsoft/TypeScript/pull/48337/commits/c179ef01e5e50edaeec761ee79ba83417da48570
c179ef0https://github.com/microsoft/TypeScript/pull/48337/commits/c179ef01e5e50edaeec761ee79ba83417da48570
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Mar 19, 2022https://github.com/microsoft/TypeScript/pull/48337#event-6270199379
https://github.com/a-tarasyuk
a-tarasyukhttps://github.com/a-tarasyuk
Mar 23, 2022https://github.com/microsoft/TypeScript/pull/48337#issuecomment-1076475073
@weswighamhttps://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/48337
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Mar 23, 2022 https://github.com/microsoft/TypeScript/pull/48337#pullrequestreview-918942166
View reviewed changes https://github.com/microsoft/TypeScript/pull/48337/files/c179ef01e5e50edaeec761ee79ba83417da48570
https://github.com/sandersn
sandersnhttps://github.com/sandersn
c720ad6https://github.com/microsoft/TypeScript/commit/c720ad6ffb54f4e7039f0d2010966dc209b74582
Mar 28, 2022https://github.com/microsoft/TypeScript/pull/48337#event-6319521988
sidharthv96https://github.com/sidharthv96
Apr 1, 2022 https://github.com/microsoft/TypeScript/pull/48337#ref-commit-e149cc3
https://github.com/sidharthv96
Merge remote-tracking branch 'upstream/main' into fix/46149https://github.com/sidharthv96/TypeScript/commit/e149cc332a8dfb2f9fd3fbb8f2e594df84ff187f
e149cc3https://github.com/sidharthv96/TypeScript/commit/e149cc332a8dfb2f9fd3fbb8f2e594df84ff187f
microsoft#48499https://github.com/microsoft/TypeScript/pull/48499
microsoft#48481https://github.com/microsoft/TypeScript/pull/48481
microsoft#48411https://github.com/microsoft/TypeScript/pull/48411
microsoft#48380https://github.com/microsoft/TypeScript/pull/48380
microsoft#47748https://github.com/microsoft/TypeScript/pull/47748
microsoft#48490https://github.com/microsoft/TypeScript/pull/48490
microsoft#48189https://github.com/microsoft/TypeScript/pull/48189
microsoft#47212https://github.com/microsoft/TypeScript/pull/47212
microsoft#48429https://github.com/microsoft/TypeScript/pull/48429
microsoft#48168https://github.com/microsoft/TypeScript/pull/48168
microsoft#48410https://github.com/microsoft/TypeScript/pull/48410
microsoft#48449https://github.com/microsoft/TypeScript/pull/48449
microsoft#48463https://github.com/microsoft/TypeScript/pull/48463
microsoft#48464https://github.com/microsoft/TypeScript/pull/48464
microsoft#48459https://github.com/microsoft/TypeScript/pull/48459
microsoft#48337https://github.com/microsoft/TypeScript/pull/48337
microsoft#48050https://github.com/microsoft/TypeScript/pull/48050
microsoft#43937https://github.com/microsoft/TypeScript/pull/43937
microsoft#48426https://github.com/microsoft/TypeScript/pull/48426
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 22, 2025https://github.com/microsoft/TypeScript/pull/48337#event-20417512228
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48337
https://github.com/weswigham
weswigham https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/48337/files/c179ef01e5e50edaeec761ee79ba83417da48570
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Checking module.exports should not yield a This condition will always return true since this function is always defined error https://github.com/microsoft/TypeScript/issues/48166
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/48337
https://github.com/a-tarasyuk
https://github.com/weswigham
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.