| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6fc38806-e2af-816b-72f7-4d7e8b46ac4e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB76:19AC88:B9DCFE:FFF875:6A63B365 |
| html-safe-nonce | 4bde04aae8c6eed7b4c81ae640e327336083197651b213bf0b25b94fc639b554 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjc2OjE5QUM4ODpCOURDRkU6RkZGODc1OjZBNjNCMzY1IiwidmlzaXRvcl9pZCI6IjIwNzYxOTc0MDE4MDg1ODE0NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8b03f3c8a89def0723b28d836f3a084a6d10c943490e87aa46a42f56db8a8257 |
| hovercard-subject-tag | pull_request:873676699 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/48168/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/44801a35ac9cf3608741a0ac7dacf4717722f2e4f62ca8b5c0b2585357548d1d/microsoft/TypeScript/pull/48168 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44801a35ac9cf3608741a0ac7dacf4717722f2e4f62ca8b5c0b2585357548d1d/microsoft/TypeScript/pull/48168 |
| og:image:alt | Fixes #46590.
This PR enables signature completions for methods in object literals. In the following code:
interface IFoo {
bar(x: number): void;
}
const obj: IFoo = {
|
}
we now offer as ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabritto |
| hostname | github.com |
| expected-hostname | github.com |
| None | b1a203abf5b8fb9010b42a32ce0f19fb6e11e656f254d0d3dcdba4b65a6961a6 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3ae9132c55b60e2a8f9553322217eb369dd24575 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/48168#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48168 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48168 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/48168 |
| Reload | https://github.com/microsoft/TypeScript/pull/48168 |
| Reload | https://github.com/microsoft/TypeScript/pull/48168 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
21
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| gabritto | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/issue46590 | https://github.com/microsoft/TypeScript/tree/gabritto/issue46590 |
| Conversation | https://github.com/microsoft/TypeScript/pull/48168 |
| Commits38 (38) | https://github.com/microsoft/TypeScript/pull/48168/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/48168/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/48168/files |
| Enable method signature completion for object literals | https://github.com/microsoft/TypeScript/pull/48168#top |
| gabritto | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/issue46590 | https://github.com/microsoft/TypeScript/tree/gabritto/issue46590 |
|
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Mar 7, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issue-1162059377 |
| #46590 | https://github.com/microsoft/TypeScript/issues/46590 |
| await completions should auto-add an async modifier to containing method #48093 | https://github.com/microsoft/TypeScript/issues/48093 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| gabritto | https://github.com/gabritto |
| February 23, 2022 12:30 | https://github.com/microsoft/TypeScript/pull/48168#commits-pushed-41913b7 |
|
| https://github.com/gabritto |
| skeleton of new feature | https://github.com/microsoft/TypeScript/pull/48168/commits/41913b76e2d3e2aad2089394d3260c931bb89dad |
| 41913b7 | https://github.com/microsoft/TypeScript/pull/48168/commits/41913b76e2d3e2aad2089394d3260c931bb89dad |
|
| https://github.com/gabritto |
| working prototype | https://github.com/microsoft/TypeScript/pull/48168/commits/d5038cecc7322a54d3973e272d3baa529dd7e2c3 |
| d5038ce | https://github.com/microsoft/TypeScript/pull/48168/commits/d5038cecc7322a54d3973e272d3baa529dd7e2c3 |
|
| https://github.com/gabritto |
| refactor print and format code into its own function | https://github.com/microsoft/TypeScript/pull/48168/commits/fca74c1e74a92e8952d1c698981ff3b3bafc1113 |
| fca74c1 | https://github.com/microsoft/TypeScript/pull/48168/commits/fca74c1e74a92e8952d1c698981ff3b3bafc1113 |
|
| https://github.com/gabritto |
| minor changes; don't support overloads | https://github.com/microsoft/TypeScript/pull/48168/commits/249c3baf584725571e85f4e9a704d6939de5e367 |
| 249c3ba | https://github.com/microsoft/TypeScript/pull/48168/commits/249c3baf584725571e85f4e9a704d6939de5e367 |
|
| https://github.com/gabritto |
| have two completion entries | https://github.com/microsoft/TypeScript/pull/48168/commits/ef15f8193eb8f09ae5aec7a1e19d6f46f002bfbc |
| ef15f81 | https://github.com/microsoft/TypeScript/pull/48168/commits/ef15f8193eb8f09ae5aec7a1e19d6f46f002bfbc |
|
| https://github.com/gabritto |
| get rid of accessor support | https://github.com/microsoft/TypeScript/pull/48168/commits/1f26a523b97ef7d0399a27a7f3f77febf5e1610a |
| 1f26a52 | https://github.com/microsoft/TypeScript/pull/48168/commits/1f26a523b97ef7d0399a27a7f3f77febf5e1610a |
|
| https://github.com/gabritto |
| add snippet support | https://github.com/microsoft/TypeScript/pull/48168/commits/1c2809080d585fb6aaef93ba18249af6ef671780 |
| 1c28090 | https://github.com/microsoft/TypeScript/pull/48168/commits/1c2809080d585fb6aaef93ba18249af6ef671780 |
|
| https://github.com/gabritto |
| add formatting | https://github.com/microsoft/TypeScript/pull/48168/commits/e6285909eb503c857377a34f560f2de1a1c80bdb |
| e628590 | https://github.com/microsoft/TypeScript/pull/48168/commits/e6285909eb503c857377a34f560f2de1a1c80bdb |
|
| https://github.com/gabritto |
| add trailing comma | https://github.com/microsoft/TypeScript/pull/48168/commits/515fc738ab861c4615dc5e5e3a0a0f3a1d5b7b98 |
| 515fc73 | https://github.com/microsoft/TypeScript/pull/48168/commits/515fc738ab861c4615dc5e5e3a0a0f3a1d5b7b98 |
|
| https://github.com/gabritto |
| add sourcedisplay | https://github.com/microsoft/TypeScript/pull/48168/commits/0229a7d8e149789a77f994f3fa3cc5d3ced89ffb |
| 0229a7d | https://github.com/microsoft/TypeScript/pull/48168/commits/0229a7d8e149789a77f994f3fa3cc5d3ced89ffb |
|
| https://github.com/gabritto |
| support auto-imports via completion details | https://github.com/microsoft/TypeScript/pull/48168/commits/9892dc8290826f7491e226c83041a390ad0dd102 |
| 9892dc8 | https://github.com/microsoft/TypeScript/pull/48168/commits/9892dc8290826f7491e226c83041a390ad0dd102 |
|
| https://github.com/gabritto |
| add user preference option and fix ordering of entries | https://github.com/microsoft/TypeScript/pull/48168/commits/8550bba8f597281ed8041cdbafc19a829a942a0c |
| 8550bba | https://github.com/microsoft/TypeScript/pull/48168/commits/8550bba8f597281ed8041cdbafc19a829a942a0c |
|
| https://github.com/gabritto |
| cleanup | https://github.com/microsoft/TypeScript/pull/48168/commits/78c7d9e9b4385a49538cb3454d2ee4f18d4ea304 |
| 78c7d9e | https://github.com/microsoft/TypeScript/pull/48168/commits/78c7d9e9b4385a49538cb3454d2ee4f18d4ea304 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| gabritto | https://github.com/gabritto |
| Mar 7, 2022 | https://github.com/microsoft/TypeScript/pull/48168#event-6198769911 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
| Mar 7, 2022 | https://github.com/microsoft/TypeScript/pull/48168#event-6198769981 |
| gabritto | https://github.com/gabritto |
| March 7, 2022 16:26 | https://github.com/microsoft/TypeScript/pull/48168#commits-pushed-1f67d97 |
|
| https://github.com/gabritto |
| don't return code actions for no import fixes | https://github.com/microsoft/TypeScript/pull/48168/commits/1f67d97812e9b8829e2b0fc2ac280216277c34ef |
| 1f67d97 | https://github.com/microsoft/TypeScript/pull/48168/commits/1f67d97812e9b8829e2b0fc2ac280216277c34ef |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/issue46590 | https://github.com/microsoft/TypeScript/pull/48168/commits/6c96290e1b0e69c82a6c31e781c51fdc00c89b76 |
| 6c96290 | https://github.com/microsoft/TypeScript/pull/48168/commits/6c96290e1b0e69c82a6c31e781c51fdc00c89b76 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| March 8, 2022 00:52 | https://github.com/microsoft/TypeScript/pull/48168#event-6198974354 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| amcasey | https://github.com/amcasey |
| andrewbranch | https://github.com/andrewbranch |
| March 8, 2022 01:07 | https://github.com/microsoft/TypeScript/pull/48168#event-6199023301 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Mar 8, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1061302807 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Mar 8, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1062061887 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
|
| https://github.com/gabritto |
| make sortText lower priority for snippets | https://github.com/microsoft/TypeScript/pull/48168/commits/814561f64945eda6e31bacc78720035de9d3205e |
| 814561f | https://github.com/microsoft/TypeScript/pull/48168/commits/814561f64945eda6e31bacc78720035de9d3205e |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| March 9, 2022 00:57 | https://github.com/microsoft/TypeScript/pull/48168#event-6206566578 |
| https://github.com/RyanCavanaugh |
| RyanCavanaugh | https://github.com/RyanCavanaugh |
| Mar 9, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1063223022 |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 9, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1063223425 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| 814561f | https://github.com/microsoft/TypeScript/commit/814561f64945eda6e31bacc78720035de9d3205e |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=121521 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 9, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1063241088 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| @RyanCavanaugh | https://github.com/RyanCavanaugh |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/121521/artifacts?artifactName=tgz&fileId=DA6CBC84DA5E5CF30D3454243FDA8980270092508288925B1CD311BF1EE7888902&fileName=/typescript-4.7.0-insiders.20220309.tgz |
| for this build | https://www.staging-typescript.org/play?ts=4.7.0-pr-48168-4 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/4.7.0-pr-48168-4 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Mar 9, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1063262857 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/issue46590 | https://github.com/microsoft/TypeScript/pull/48168/commits/b032aa564fbbcc52990fcfa4f5ac4a3d6a18ebd3 |
| b032aa5 | https://github.com/microsoft/TypeScript/pull/48168/commits/b032aa564fbbcc52990fcfa4f5ac4a3d6a18ebd3 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
|
Mar 23, 2022
| https://github.com/microsoft/TypeScript/pull/48168#pullrequestreview-919131114 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/48168/files/5b0d86df70cc0c939568ada020920f348b637c0f |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/48168/files/7c9cbdbfc2b5faafdf1f31a9b3e324685ea291f9..5b0d86df70cc0c939568ada020920f348b637c0f#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076666160 |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076666758 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| @gabritto | https://github.com/gabritto |
| b032aa5 | https://github.com/microsoft/TypeScript/commit/b032aa564fbbcc52990fcfa4f5ac4a3d6a18ebd3 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=122506 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| gabritto | https://github.com/gabritto |
| March 23, 2022 12:46 | https://github.com/microsoft/TypeScript/pull/48168#commits-pushed-08a55c3 |
|
| https://github.com/gabritto |
| re-add flag | https://github.com/microsoft/TypeScript/pull/48168/commits/08a55c34f4cde46861d364ec991d75d92a91048b |
| 08a55c3 | https://github.com/microsoft/TypeScript/pull/48168/commits/08a55c34f4cde46861d364ec991d75d92a91048b |
|
| https://github.com/gabritto |
| fix tests | https://github.com/microsoft/TypeScript/pull/48168/commits/6ebe361b38546458cb46f53f16d2077551bdb6db |
| 6ebe361 | https://github.com/microsoft/TypeScript/pull/48168/commits/6ebe361b38546458cb46f53f16d2077551bdb6db |
|
| https://github.com/gabritto |
| rename sort text helper | https://github.com/microsoft/TypeScript/pull/48168/commits/411bc18581826904f41c9aab964c72de68f37b53 |
| 411bc18 | https://github.com/microsoft/TypeScript/pull/48168/commits/411bc18581826904f41c9aab964c72de68f37b53 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076890265 |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076890294 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| @andrewbranch | https://github.com/andrewbranch |
| 411bc18 | https://github.com/microsoft/TypeScript/commit/411bc18581826904f41c9aab964c72de68f37b53 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=122534 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
|
Mar 23, 2022
| https://github.com/microsoft/TypeScript/pull/48168#pullrequestreview-919536863 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/48168/files/411bc18581826904f41c9aab964c72de68f37b53 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/48168/files/411bc18581826904f41c9aab964c72de68f37b53#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076900019 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| @andrewbranch | https://github.com/andrewbranch |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/122534/artifacts?artifactName=tgz&fileId=60AB0E85050006EA44CE384DB33288D1AEF05E4219B1A590F13CE020D289F31B02&fileName=/typescript-4.7.0-insiders.20220323.tgz |
| for this build | https://www.staging-typescript.org/play?ts=4.7.0-pr-48168-33 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/4.7.0-pr-48168-33 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Mar 23, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076908515 |
| https://user-images.githubusercontent.com/3277153/159809017-112e44bf-ee0c-46d0-acf2-1dd2f863b0ee.png |
| https://user-images.githubusercontent.com/3277153/159810424-04fce61b-ff47-4f9f-8611-3dfd6757f7d6.png |
| newer label scheme | https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItemLabelDetails |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
|
Mar 23, 2022
| https://github.com/microsoft/TypeScript/pull/48168#pullrequestreview-919558201 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/48168/files/411bc18581826904f41c9aab964c72de68f37b53 |
| tests/cases/fourslash/completionsObjectLiteralMethod3.ts | https://github.com/microsoft/TypeScript/pull/48168/files/411bc18581826904f41c9aab964c72de68f37b53#diff-99dacda0e0e1173289072e59a70ac64988e4afa68f4c5b7dffe0d88cb49bf04e |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
|
| https://github.com/gabritto |
| fix test and code for union case | https://github.com/microsoft/TypeScript/pull/48168/commits/1ebdf3d52719944b2348a5030382e86e38904483 |
| 1ebdf3d | https://github.com/microsoft/TypeScript/pull/48168/commits/1ebdf3d52719944b2348a5030382e86e38904483 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
|
Mar 24, 2022
| https://github.com/microsoft/TypeScript/pull/48168#ref-pullrequest-1178847708 |
|
[typescript-language-features] Add includeCompletionsWithObjectLiteralMethodSnippets preference
microsoft/vscode#145941
| https://github.com/microsoft/vscode/pull/145941 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Mar 24, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1076999422 |
| newer label scheme | https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItemLabelDetails |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Mar 24, 2022 | https://github.com/microsoft/TypeScript/pull/48168#issuecomment-1077792793 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| gabritto | https://github.com/gabritto |
| March 24, 2022 11:25 | https://github.com/microsoft/TypeScript/pull/48168#commits-pushed-5477408 |
|
| https://github.com/gabritto |
| add new flag to protocol type | https://github.com/microsoft/TypeScript/pull/48168/commits/54774085faa67ccff2981f1b93ba26423ca86f83 |
| 5477408 | https://github.com/microsoft/TypeScript/pull/48168/commits/54774085faa67ccff2981f1b93ba26423ca86f83 |
|
| https://github.com/gabritto |
| fix spaces | https://github.com/microsoft/TypeScript/pull/48168/commits/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051 |
| af7de76 | https://github.com/microsoft/TypeScript/pull/48168/commits/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
|
Mar 25, 2022
| https://github.com/microsoft/TypeScript/pull/48168#ref-pullrequest-1181246959 |
|
Add label details to completion entry
#48429
| https://github.com/microsoft/TypeScript/pull/48429 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
|
Mar 29, 2022
| https://github.com/microsoft/TypeScript/pull/48168#pullrequestreview-925094546 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| andrewbranch | https://github.com/andrewbranch |
| Mar 29, 2022 | https://github.com/microsoft/TypeScript/pull/48168#discussion_r837833168 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| gabritto | https://github.com/gabritto |
| Mar 29, 2022 | https://github.com/microsoft/TypeScript/pull/48168#discussion_r837956740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| andrewbranch | https://github.com/andrewbranch |
| Mar 30, 2022 | https://github.com/microsoft/TypeScript/pull/48168#discussion_r838006129 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
| gabritto | https://github.com/gabritto |
| March 29, 2022 13:06 | https://github.com/microsoft/TypeScript/pull/48168#commits-pushed-1b884c4 |
|
| https://github.com/gabritto |
| CR: minor fixes | https://github.com/microsoft/TypeScript/pull/48168/commits/1b884c4012eddb2faa5b7b87eb6f0a0907e923ae |
| 1b884c4 | https://github.com/microsoft/TypeScript/pull/48168/commits/1b884c4012eddb2faa5b7b87eb6f0a0907e923ae |
|
| https://github.com/gabritto |
| CR: more fixes | https://github.com/microsoft/TypeScript/pull/48168/commits/3820f32ee8070e55b30a92cb784b7d38f3cb5a89 |
| 3820f32 | https://github.com/microsoft/TypeScript/pull/48168/commits/3820f32ee8070e55b30a92cb784b7d38f3cb5a89 |
|
| https://github.com/gabritto |
| CR: restructure main flow | https://github.com/microsoft/TypeScript/pull/48168/commits/e7a51e6231a4e308a7acc0056b2d6e566449e2e8 |
| e7a51e6 | https://github.com/microsoft/TypeScript/pull/48168/commits/e7a51e6231a4e308a7acc0056b2d6e566449e2e8 |
|
| https://github.com/gabritto |
| minor fix | https://github.com/microsoft/TypeScript/pull/48168/commits/203aab00ccf4006d10b6730b7cb5959a4f1780d6 |
| 203aab0 | https://github.com/microsoft/TypeScript/pull/48168/commits/203aab00ccf4006d10b6730b7cb5959a4f1780d6 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
|
Mar 30, 2022
| https://github.com/microsoft/TypeScript/pull/48168#pullrequestreview-925363578 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/48168/files/203aab00ccf4006d10b6730b7cb5959a4f1780d6 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| e25f04a | https://github.com/microsoft/TypeScript/commit/e25f04a30f457c4d6da7c6e60946950d169159e7 |
| Mar 30, 2022 | https://github.com/microsoft/TypeScript/pull/48168#event-6330784415 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| March 30, 2022 00:19 | https://github.com/microsoft/TypeScript/pull/48168#event-6330784516 |
| sidharthv96 | https://github.com/sidharthv96 |
|
Apr 1, 2022
| https://github.com/microsoft/TypeScript/pull/48168#ref-commit-e149cc3 |
|
| https://github.com/sidharthv96 |
| Merge remote-tracking branch 'upstream/main' into fix/46149 | https://github.com/sidharthv96/TypeScript/commit/e149cc332a8dfb2f9fd3fbb8f2e594df84ff187f |
| e149cc3 | https://github.com/sidharthv96/TypeScript/commit/e149cc332a8dfb2f9fd3fbb8f2e594df84ff187f |
| microsoft#48499 | https://github.com/microsoft/TypeScript/pull/48499 |
| microsoft#48481 | https://github.com/microsoft/TypeScript/pull/48481 |
| microsoft#48411 | https://github.com/microsoft/TypeScript/pull/48411 |
| microsoft#48380 | https://github.com/microsoft/TypeScript/pull/48380 |
| microsoft#47748 | https://github.com/microsoft/TypeScript/pull/47748 |
| microsoft#48490 | https://github.com/microsoft/TypeScript/pull/48490 |
| microsoft#48189 | https://github.com/microsoft/TypeScript/pull/48189 |
| microsoft#47212 | https://github.com/microsoft/TypeScript/pull/47212 |
| microsoft#48429 | https://github.com/microsoft/TypeScript/pull/48429 |
| microsoft#48168 | https://github.com/microsoft/TypeScript/pull/48168 |
| microsoft#48410 | https://github.com/microsoft/TypeScript/pull/48410 |
| microsoft#48449 | https://github.com/microsoft/TypeScript/pull/48449 |
| microsoft#48463 | https://github.com/microsoft/TypeScript/pull/48463 |
| microsoft#48464 | https://github.com/microsoft/TypeScript/pull/48464 |
| microsoft#48459 | https://github.com/microsoft/TypeScript/pull/48459 |
| microsoft#48337 | https://github.com/microsoft/TypeScript/pull/48337 |
| microsoft#48050 | https://github.com/microsoft/TypeScript/pull/48050 |
| microsoft#43937 | https://github.com/microsoft/TypeScript/pull/43937 |
| microsoft#48426 | https://github.com/microsoft/TypeScript/pull/48426 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 22, 2025 | https://github.com/microsoft/TypeScript/pull/48168#event-20417506736 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F48168 |
|
| https://github.com/andrewbranch |
|
andrewbranch
| https://github.com/andrewbranch |
|
| https://github.com/microsoft/TypeScript/pull/48168/files/af7de76d6c1f4d9b5adbeacb8d1eb87eb2f05051 |
|
| https://github.com/DanielRosenwasser |
|
DanielRosenwasser
| https://github.com/DanielRosenwasser |
|
| https://github.com/amcasey |
|
amcasey
| https://github.com/amcasey |
|
| https://github.com/microsoft/TypeScript/pull/48168/files/b5d05c0a9a3cd043805b818ae40bdcfeaf5492d5 |
|
| https://github.com/gabritto |
|
gabritto
| https://github.com/gabritto |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Enable method signature completions for object literal that is implementing an interface
| https://github.com/microsoft/TypeScript/issues/46590 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/48168 |
|
| https://github.com/gabritto |
|
| https://github.com/andrewbranch |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/typescript-bot |
|
| https://github.com/amcasey |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |