| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:de68c139-1b2d-b300-0a2d-3f725f6e8647 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2BA:AD745:23DDB66:30DE155:6964CB56 |
| html-safe-nonce | cfbbb2fc711a28d6ee330c381f50db5259b82f9b0cd20760318ca7e093f66977 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkJBOkFENzQ1OjIzRERCNjY6MzBERTE1NTo2OTY0Q0I1NiIsInZpc2l0b3JfaWQiOiIxMjMwMzAzMTM3NTc4MTQyNTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | abe6ed74be44b422aa6dc7051c79138eb4df16422651f8cc261976fd9c9916fb |
| hovercard-subject-tag | pull_request:737814068 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/45974/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/29b0e18eede8c88e12c4eba1f8952c9bcabd26bd147110c4bfba48940d45211a/microsoft/TypeScript/pull/45974 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/29b0e18eede8c88e12c4eba1f8952c9bcabd26bd147110c4bfba48940d45211a/microsoft/TypeScript/pull/45974 |
| og:image:alt | Fixes #40617
Fixes #45965
Fixes #36230
Fixes #29042
Fixes #46111
Fixes #14137 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | a-tarasyuk |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8f997e7f84bd1db9537ba403fa68be0da3423594 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/45974#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45974 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45974 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/45974 |
| Reload | https://github.com/microsoft/TypeScript/pull/45974 |
| Reload | https://github.com/microsoft/TypeScript/pull/45974 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.2k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
107k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
496
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
1
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/microsoft/TypeScript/security |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/microsoft/TypeScript/pull/45974#issue-comment-box |
| weswigham | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| a-tarasyuk:fix/40617 | https://github.com/a-tarasyuk/TypeScript/tree/fix/40617 |
|
[Experiment] fix(40617): handle uninitialized class member with computed key
| https://github.com/microsoft/TypeScript/pull/45974#top |
| weswigham | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| a-tarasyuk:fix/40617 | https://github.com/a-tarasyuk/TypeScript/tree/fix/40617 |
|
Conversation
39
| https://github.com/microsoft/TypeScript/pull/45974 |
|
Commits
1
| https://github.com/microsoft/TypeScript/pull/45974/commits |
|
Checks
0
| https://github.com/microsoft/TypeScript/pull/45974/checks |
|
Files changed
| https://github.com/microsoft/TypeScript/pull/45974/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| Sep 20, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issue-1001255065 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| #40617 | https://github.com/microsoft/TypeScript/issues/40617 |
| #45965 | https://github.com/microsoft/TypeScript/issues/45965 |
| #36230 | https://github.com/microsoft/TypeScript/issues/36230 |
| #29042 | https://github.com/microsoft/TypeScript/issues/29042 |
| #46111 | https://github.com/microsoft/TypeScript/issues/46111 |
| #14137 | https://github.com/microsoft/TypeScript/issues/14137 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| September 20, 2021 18:12 | https://github.com/microsoft/TypeScript/pull/45974#event-5330095460 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Sep 20, 2021 | https://github.com/microsoft/TypeScript/pull/45974#event-5330096077 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/7dc42e83c0110122d7c9970c61fe374e0b3d52d6..fed9253efbb351aee8f95adebd4c358f4f10bd67 |
| 7dc42e8 | https://github.com/microsoft/TypeScript/commit/7dc42e83c0110122d7c9970c61fe374e0b3d52d6 |
| fed9253 | https://github.com/microsoft/TypeScript/commit/fed9253efbb351aee8f95adebd4c358f4f10bd67 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/7dc42e83c0110122d7c9970c61fe374e0b3d52d6..fed9253efbb351aee8f95adebd4c358f4f10bd67 |
| September 21, 2021 15:09 | https://github.com/microsoft/TypeScript/pull/45974#event-5336424397 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#event-5336425698 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924320588 |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924320621 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @andrewbranch | https://github.com/andrewbranch |
| fed9253 | https://github.com/microsoft/TypeScript/commit/fed9253efbb351aee8f95adebd4c358f4f10bd67 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=111061 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924345411 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924320622 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @andrewbranch | https://github.com/andrewbranch |
| fed9253 | https://github.com/microsoft/TypeScript/commit/fed9253efbb351aee8f95adebd4c358f4f10bd67 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=111062 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924334647 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @andrewbranch | https://github.com/andrewbranch |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/111062/artifacts?artifactName=tgz&fileId=7CA2AC096B167B7FDD4276560CB0C161A854525027E66E66D7D7B6164D844A3102&fileName=/typescript-4.5.0-insiders.20210921.tgz |
| for this build | https://www.staging-typescript.org/play?ts=4.5.0-pr-45974-3 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/4.5.0-pr-45974-3 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Sep 21, 2021 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-924345411 |
| @andrewbranch | https://github.com/andrewbranch |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/111061/artifacts?artifactName=benchmark&fileId=EF1D40025EDCA1F90A30AAD5CF3A73C30711FE561995BDDF91C5F05A070B936D01&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/0d8ea001a1215c8143cd7b7d822b4b8f1d128f05..5966bcac6b19680587f9a5071214a85444e9d483 |
| 0d8ea00 | https://github.com/microsoft/TypeScript/commit/0d8ea001a1215c8143cd7b7d822b4b8f1d128f05 |
| 5966bca | https://github.com/microsoft/TypeScript/commit/5966bcac6b19680587f9a5071214a85444e9d483 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/0d8ea001a1215c8143cd7b7d822b4b8f1d128f05..5966bcac6b19680587f9a5071214a85444e9d483 |
| September 25, 2021 17:29 | https://github.com/microsoft/TypeScript/pull/45974#event-5360017755 |
|
TS does not automatically understand object with accessor type if not extracted to a variable
#46111
| https://github.com/microsoft/TypeScript/issues/46111 |
|
Discriminant property type guard not applied with bracket notation
#10530
| https://github.com/microsoft/TypeScript/issues/10530 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/5966bcac6b19680587f9a5071214a85444e9d483..e3d3857ebfd0f96153e5bdbf2a85364a68151867 |
| 5966bca | https://github.com/microsoft/TypeScript/commit/5966bcac6b19680587f9a5071214a85444e9d483 |
| e3d3857 | https://github.com/microsoft/TypeScript/commit/e3d3857ebfd0f96153e5bdbf2a85364a68151867 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/5966bcac6b19680587f9a5071214a85444e9d483..e3d3857ebfd0f96153e5bdbf2a85364a68151867 |
| September 28, 2021 20:21 | https://github.com/microsoft/TypeScript/pull/45974#event-5376385156 |
| https://github.com/easyrider |
| easyrider | https://github.com/easyrider |
|
Sep 28, 2021
| https://github.com/microsoft/TypeScript/pull/45974#pullrequestreview-765926591 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/45974/files |
| tests/baselines/reference/controlFlowOptionalChain.errors.txt | https://github.com/microsoft/TypeScript/pull/45974/files#diff-7a3f42f67d0c2ae85dc77bac10c373e645135925a516926a24b1db125e99e01d |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/7532268d89ad5392152cc517a5a52411187b9b8d..d62e104adc313e41b8b895cad1032c9438be3315 |
| 7532268 | https://github.com/microsoft/TypeScript/commit/7532268d89ad5392152cc517a5a52411187b9b8d |
| d62e104 | https://github.com/microsoft/TypeScript/commit/d62e104adc313e41b8b895cad1032c9438be3315 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/7532268d89ad5392152cc517a5a52411187b9b8d..d62e104adc313e41b8b895cad1032c9438be3315 |
| September 29, 2021 09:19 | https://github.com/microsoft/TypeScript/pull/45974#event-5379309188 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
|
Experiment
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment |
| Sep 29, 2021 | https://github.com/microsoft/TypeScript/pull/45974#event-5383022287 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| weswigham | https://github.com/weswigham |
| Sep 29, 2021 | https://github.com/microsoft/TypeScript/pull/45974#event-5383038860 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| weswigham | https://github.com/weswigham |
| September 29, 2021 19:24 | https://github.com/microsoft/TypeScript/pull/45974#event-5383039275 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| gabritto | https://github.com/gabritto |
| Sep 29, 2021 | https://github.com/microsoft/TypeScript/pull/45974#event-5383039687 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| gabritto | https://github.com/gabritto |
| September 29, 2021 19:24 | https://github.com/microsoft/TypeScript/pull/45974#event-5383040285 |
| https://github.com/weswigham |
| weswigham | https://github.com/weswigham |
|
Sep 29, 2021
| https://github.com/microsoft/TypeScript/pull/45974#pullrequestreview-767148684 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/45974/files |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/45974/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/674f8ac5d0ea6009d1bd344c8ca2cf28748a55aa..f62eed2a321ce2c10275eea783e91ddb04e72f1d |
| 674f8ac | https://github.com/microsoft/TypeScript/commit/674f8ac5d0ea6009d1bd344c8ca2cf28748a55aa |
| f62eed2 | https://github.com/microsoft/TypeScript/commit/f62eed2a321ce2c10275eea783e91ddb04e72f1d |
|
Compare
| https://github.com/microsoft/TypeScript/compare/674f8ac5d0ea6009d1bd344c8ca2cf28748a55aa..f62eed2a321ce2c10275eea783e91ddb04e72f1d |
| September 29, 2021 21:40 | https://github.com/microsoft/TypeScript/pull/45974#event-5383668595 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| weswigham | https://github.com/weswigham |
| September 29, 2021 21:58 | https://github.com/microsoft/TypeScript/pull/45974#event-5383737214 |
| https://github.com/weswigham |
| weswigham | https://github.com/weswigham |
|
Sep 29, 2021
| https://github.com/microsoft/TypeScript/pull/45974#pullrequestreview-767252887 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/45974/files |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/45974/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/f62eed2a321ce2c10275eea783e91ddb04e72f1d..3d7ce14f2fc46a2ab806af3b76ea170a0b8f6a29 |
| f62eed2 | https://github.com/microsoft/TypeScript/commit/f62eed2a321ce2c10275eea783e91ddb04e72f1d |
| 3d7ce14 | https://github.com/microsoft/TypeScript/commit/3d7ce14f2fc46a2ab806af3b76ea170a0b8f6a29 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/f62eed2a321ce2c10275eea783e91ddb04e72f1d..3d7ce14f2fc46a2ab806af3b76ea170a0b8f6a29 |
| September 30, 2021 06:46 | https://github.com/microsoft/TypeScript/pull/45974#event-5385355344 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/591ce0f9daa01b7fd0fc9e818d07198accb2c7fb..c1ea660b148d108041dceb1ac496a6df7adb1792 |
| 591ce0f | https://github.com/microsoft/TypeScript/commit/591ce0f9daa01b7fd0fc9e818d07198accb2c7fb |
| c1ea660 | https://github.com/microsoft/TypeScript/commit/c1ea660b148d108041dceb1ac496a6df7adb1792 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/591ce0f9daa01b7fd0fc9e818d07198accb2c7fb..c1ea660b148d108041dceb1ac496a6df7adb1792 |
| February 13, 2022 10:12 | https://github.com/microsoft/TypeScript/pull/45974#event-6060582589 |
|
| https://github.com/a-tarasyuk |
| fix(40617): handle uninitialized class member with computed key | https://github.com/microsoft/TypeScript/pull/45974/commits/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| 5a5a04a | https://github.com/microsoft/TypeScript/pull/45974/commits/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
| force-pushed | https://github.com/microsoft/TypeScript/compare/c1ea660b148d108041dceb1ac496a6df7adb1792..5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| c1ea660 | https://github.com/microsoft/TypeScript/commit/c1ea660b148d108041dceb1ac496a6df7adb1792 |
| 5a5a04a | https://github.com/microsoft/TypeScript/commit/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
|
Compare
| https://github.com/microsoft/TypeScript/compare/c1ea660b148d108041dceb1ac496a6df7adb1792..5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| February 13, 2022 10:13 | https://github.com/microsoft/TypeScript/pull/45974#event-6060588132 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| Feb 14, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039490934 |
| @typescript-bot | https://github.com/typescript-bot |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 14, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039490992 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| 5a5a04a | https://github.com/microsoft/TypeScript/commit/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=120006 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039724362 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 14, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039490993 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| 5a5a04a | https://github.com/microsoft/TypeScript/commit/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=120005 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 14, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039510242 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/120005/artifacts?artifactName=tgz&fileId=EE505446B5807332B826CBF47E7BCADCF9F3437137E46FBD2665ED222C83B2FD02&fileName=/typescript-4.7.0-insiders.20220214.tgz |
| for this build | https://www.staging-typescript.org/play?ts=4.7.0-pr-45974-15 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/4.7.0-pr-45974-15 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 15, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1039724362 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/120006/artifacts?artifactName=benchmark&fileId=64D84D7BBC6285526522C21B7BA817778649C6F463B833F709BC255DAAA4034102&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043695296 |
| @weswigham | https://github.com/weswigham |
| @andrewbranch | https://github.com/andrewbranch |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043703520 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/weswigham |
| weswigham | https://github.com/weswigham |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043710752 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043721818 |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043721872 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| 5a5a04a | https://github.com/microsoft/TypeScript/commit/5a5a04a7d6ab206bc7f6dc193df6bbae04ba7b8b |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=120436 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043756965 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1043756965 |
| @DanielRosenwasser | https://github.com/DanielRosenwasser |
| Download Benchmark | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/120436/artifacts?artifactName=benchmark&fileId=C9917A38EA318A270D69887859F06D0666F33F01300ED92514E933DEEAE140B002&fileName=linux.benchmark |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/andrewbranch |
| andrewbranch | https://github.com/andrewbranch |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1044961303 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1045208764 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| ahejlsberg | https://github.com/ahejlsberg |
| weswigham | https://github.com/weswigham |
| andrewbranch | https://github.com/andrewbranch |
| gabritto | https://github.com/gabritto |
| Feb 18, 2022 | https://github.com/microsoft/TypeScript/pull/45974#event-6102661674 |
| https://github.com/DanielRosenwasser |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Feb 23, 2022
| https://github.com/microsoft/TypeScript/pull/45974#ref-issue-1148513024 |
|
Design Meeting Notes, 2/18/2022
#48017
| https://github.com/microsoft/TypeScript/issues/48017 |
| https://github.com/ethanresnick |
| ethanresnick | https://github.com/ethanresnick |
| Feb 23, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1049197783 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/weswigham |
| weswigham | https://github.com/weswigham |
| 162713f | https://github.com/microsoft/TypeScript/commit/162713fac9da0304769ef0b7cfdd568f319a55ea |
| Mar 5, 2022 | https://github.com/microsoft/TypeScript/pull/45974#event-6188345997 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
| Apr 20, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1104464101 |
| blog post | https://devblogs.microsoft.com/typescript/announcing-typescript-4-7-beta/#control-flow-analysis-for-computed-properties |
| TS Playground Link | https://www.typescriptlang.org/play?ts=4.7.0-dev.20220420#code/JYOwLgpgTgZghgYwgAgGIHt3IN4ChnIDaA1hAJ4BcyAzmFKAOYC6VIArgLYBG0yAPjTqMA3LgC+uXABMICADZwoKGGxAIwwdCGQMIIaHEgBpcgAoAlFVr0QDUbhVqNW5DBCmYmKhnTmc+ZAQtWmRSMmQAXh09A2Mzc1ECYBhkUzAyAAcIdBTPdBJyJkiIqIBydm5oUr88AgI8grImADowdABRAA8MrT0NODlTACYEgIIAenHkdqgodCgqAAU5rKh05FK2rp79cGAB0uQpdAhqZBB0MGQITuAQl3SsjetGfnPOHihS5oCJCSA |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Apr 21, 2022 | https://github.com/microsoft/TypeScript/pull/45974#issuecomment-1104719859 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
Apr 21, 2022
| https://github.com/microsoft/TypeScript/pull/45974#ref-issue-1211171652 |
|
TS 4.7 Beta: Object access should be narrowable after check
#48802
| https://github.com/microsoft/TypeScript/issues/48802 |
| https://github.com/jcalz |
| jcalz | https://github.com/jcalz |
|
Jun 17, 2022
| https://github.com/microsoft/TypeScript/pull/45974#ref-issue-1275337999 |
|
Typescript 4.7.3 bracketed class property compilation error strictPropertyInitialization:true
#49594
| https://github.com/microsoft/TypeScript/issues/49594 |
| https://github.com/a-tarasyuk |
| a-tarasyuk | https://github.com/a-tarasyuk |
|
Oct 24, 2022
| https://github.com/microsoft/TypeScript/pull/45974#ref-pullrequest-1299872003 |
|
feat(25758): Computed properties no throws if there is a duplicate
#49848
| https://github.com/microsoft/TypeScript/pull/49848 |
| https://github.com/RyanCavanaugh |
| RyanCavanaugh | https://github.com/RyanCavanaugh |
|
Apr 22, 2025
| https://github.com/microsoft/TypeScript/pull/45974#ref-issue-3011597405 |
|
Unexpected circularity error when variable is initialized from a class member
#61606
| https://github.com/microsoft/TypeScript/issues/61606 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/45974#event-20417448706 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45974 |
|
| https://github.com/gabritto |
|
gabritto
| https://github.com/gabritto |
|
| https://github.com/DanielRosenwasser |
|
DanielRosenwasser
| https://github.com/DanielRosenwasser |
|
| https://github.com/weswigham |
|
weswigham
| https://github.com/weswigham |
|
| https://github.com/andrewbranch |
|
andrewbranch
| https://github.com/andrewbranch |
|
| https://github.com/easyrider |
|
easyrider
| https://github.com/easyrider |
|
| https://github.com/microsoft/TypeScript/pull/45974/files/e3d3857ebfd0f96153e5bdbf2a85364a68151867 |
|
| https://github.com/ahejlsberg |
|
ahejlsberg
| https://github.com/ahejlsberg |
|
Experiment
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
TypeScript 4.7.0
| https://github.com/microsoft/TypeScript/milestone/156 |
|
TypeScript failing to narrow field types indexed w/ const assertions
| https://github.com/microsoft/TypeScript/issues/45965 |
|
Uncaught uninitialized class member with Symbol key
| https://github.com/microsoft/TypeScript/issues/40617 |
|
Element access with non-literal constant key should be narrowable
| https://github.com/microsoft/TypeScript/issues/36230 |
|
this[variable] and this[stringLiteral] have different behavior
| https://github.com/microsoft/TypeScript/issues/29042 |
|
Private members used only via [] notation trigger --noUnusedLocals error
| https://github.com/microsoft/TypeScript/issues/14137 |
|
TS does not automatically understand object with accessor type if not extracted to a variable
| https://github.com/microsoft/TypeScript/issues/46111 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/45974 |
|
| https://github.com/a-tarasyuk |
|
| https://github.com/andrewbranch |
|
| https://github.com/typescript-bot |
|
| https://github.com/DerGernTod |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/sandersn |
|
| https://github.com/weswigham |
|
| https://github.com/ethanresnick |
|
| https://github.com/kyliau |
|
| https://github.com/jakebailey |
|
| https://github.com/easyrider |
|
| https://github.com/ahejlsberg |
|
| https://github.com/gabritto |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |