René's URL Explorer Experiment


Title: `keyof` should always include remapped keys by weswigham · Pull Request #45923 · microsoft/TypeScript · GitHub

Open Graph Title: `keyof` should always include remapped keys by weswigham · Pull Request #45923 · microsoft/TypeScript

X Title: `keyof` should always include remapped keys by weswigham · Pull Request #45923 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - `keyof` should always include remapped keys by weswigham · Pull Request #45923 · microsoft/TypeScript

Open Graph Description: Fixes #45825 To do this, I've extracted some of the functionality of resolvemappedTypeMembers into a common helper and reused it in getIndexTypeForMappedType. Doing this correctly necessitates ...

X Description: Fixes #45825 To do this, I've extracted some of the functionality of resolvemappedTypeMembers into a common helper and reused it in getIndexTypeForMappedType. Doing this correctly necessita...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/45923

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9fa925ec-dadd-a856-7614-a211efc8c90d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A4A:399E4B:270E007:33D240A:6B01A0FD
html-safe-noncee4291a07d75f2d1b3caa30aa73b6e3b61b16e56e949a3c9c93c5e62763be5211
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTRBOjM5OUU0QjoyNzBFMDA3OjMzRDI0MEE6NkIwMUEwRkQiLCJ2aXNpdG9yX2lkIjoiMTA3NDYyMjk2ODQwMDgxNDMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac215ffd3ec0c2c07cbf0aa9b70905716a6804b7edbcdcaf9e60c0f854e14daeea
hovercard-subject-tagpull_request:735947464
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/45923/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf344179323a8dfed6cc4668b2a1c36be75003efc515269d6b29b1e30bdec32f/microsoft/TypeScript/pull/45923
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf344179323a8dfed6cc4668b2a1c36be75003efc515269d6b29b1e30bdec32f/microsoft/TypeScript/pull/45923
og:image:altFixes #45825 To do this, I've extracted some of the functionality of resolvemappedTypeMembers into a common helper and reused it in getIndexTypeForMappedType. Doing this correctly necessitates ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/45923#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45923
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45923
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/45923
Reloadhttps://github.com/microsoft/TypeScript/pull/45923
Reloadhttps://github.com/microsoft/TypeScript/pull/45923
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:name-remapping-includes-string-keys-when-symbol-presenthttps://github.com/weswigham/TypeScript/tree/name-remapping-includes-string-keys-when-symbol-present
Conversationhttps://github.com/microsoft/TypeScript/pull/45923
Commits3 (3)https://github.com/microsoft/TypeScript/pull/45923/commits
Checkshttps://github.com/microsoft/TypeScript/pull/45923/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/45923/files
keyof should always include remapped keyshttps://github.com/microsoft/TypeScript/pull/45923#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
weswigham:name-remapping-includes-string-keys-when-symbol-presenthttps://github.com/weswigham/TypeScript/tree/name-remapping-includes-string-keys-when-symbol-present
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 17, 2021https://github.com/microsoft/TypeScript/pull/45923#issue-998791548
#45825https://github.com/microsoft/TypeScript/issues/45825
this discussionhttps://github.com/microsoft/TypeScript/pull/41976#discussion_r556950942
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/45923
Wesley Wigham (weswigham)https://github.com/weswigham
September 16, 2021 13:46https://github.com/microsoft/TypeScript/pull/45923#commits-pushed-19944df
https://github.com/weswigham
Loosen check in getIndexTypeForMappedType to directly map property na…https://github.com/microsoft/TypeScript/pull/45923/commits/19944dfafff8af4a7e7305d46dd2b1ebceb2b8eb
19944dfhttps://github.com/microsoft/TypeScript/pull/45923/commits/19944dfafff8af4a7e7305d46dd2b1ebceb2b8eb
https://github.com/weswigham
Handle homomorphic mappings better in keyof, add specific relationshi…https://github.com/microsoft/TypeScript/pull/45923/commits/18285f7f6b0a420c19199beca87cfeeb58eeaf09
18285f7https://github.com/microsoft/TypeScript/pull/45923/commits/18285f7f6b0a420c19199beca87cfeeb58eeaf09
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
September 17, 2021 00:23https://github.com/microsoft/TypeScript/pull/45923#event-5315837889
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 17, 2021https://github.com/microsoft/TypeScript/pull/45923#event-5315838088
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Sep 17, 2021https://github.com/microsoft/TypeScript/pull/45923#event-5315838149
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 17, 2021https://github.com/microsoft/TypeScript/pull/45923#event-5315839336
https://github.com/weswigham
Remove trailing whitespacehttps://github.com/microsoft/TypeScript/pull/45923/commits/6327c7b7dcd39393e8212efe18530c329a10ef7a
6327c7bhttps://github.com/microsoft/TypeScript/pull/45923/commits/6327c7b7dcd39393e8212efe18530c329a10ef7a
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 24, 2021 https://github.com/microsoft/TypeScript/pull/45923#ref-issue-1006789342
Design Meeting Notes, 9/24/2021 #46050 https://github.com/microsoft/TypeScript/issues/46050
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 24, 2021https://github.com/microsoft/TypeScript/pull/45923#issuecomment-926952488
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/45923
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Sep 28, 2021 https://github.com/microsoft/TypeScript/pull/45923#pullrequestreview-764855434
View reviewed changes https://github.com/microsoft/TypeScript/pull/45923/files/6327c7b7dcd39393e8212efe18530c329a10ef7a
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
8d5c197https://github.com/microsoft/TypeScript/commit/8d5c197f995a1d71a6150f8295a4844995cd3719
Sep 28, 2021https://github.com/microsoft/TypeScript/pull/45923#event-5370059902
https://github.com/Andarist
Mateusz Burzyński (Andarist)https://github.com/Andarist
Feb 2, 2024 https://github.com/microsoft/TypeScript/pull/45923#ref-issue-2113705264
mapped type with remapped keys unexpectedly widens type #57265 https://github.com/microsoft/TypeScript/issues/57265
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/45923#event-20417446270
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F45923
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/45923/files/6327c7b7dcd39393e8212efe18530c329a10ef7a
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/45923
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
keyof loses known keys when remapping an object type with a symbol key to remove a string index signature https://github.com/microsoft/TypeScript/issues/45825
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/45923
https://github.com/weswigham
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.