René's URL Explorer Experiment


Title: Fix bad line number assertion in `ScriptInfo.positionToLineOffset` by elibarzilay · Pull Request #44746 · microsoft/TypeScript · GitHub

Open Graph Title: Fix bad line number assertion in `ScriptInfo.positionToLineOffset` by elibarzilay · Pull Request #44746 · microsoft/TypeScript

X Title: Fix bad line number assertion in `ScriptInfo.positionToLineOffset` by elibarzilay · Pull Request #44746 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix bad line number assertion in `ScriptInfo.positionToLineOffset` by elibarzilay · Pull Request #44746 · microsoft/TypeScript

Open Graph Description: This is the line number side of ecddf84 (from #21924, fixing #21818). But the code is slightly improved for both cases: instead of testing that leaf is defined, check whether lineCount is zero, and...

X Description: This is the line number side of ecddf84 (from #21924, fixing #21818). But the code is slightly improved for both cases: instead of testing that leaf is defined, check whether lineCount is zero, and...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/44746

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:20bece83-87d6-8417-f5f8-e0cc7f4ae7e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87F8:B9E9B:994050:CF579B:6A60147F
html-safe-nonced93bda0531c871f8c349d89efd039bc1c8abf23ce7710341d4bdc0f6e6e37aaf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0Y4OkI5RTlCOjk5NDA1MDpDRjU3OUI6NkE2MDE0N0YiLCJ2aXNpdG9yX2lkIjoiNjY0NjU5NTY3NjI4MDk4NDcwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4c606ebef10fc944f60d673a30cd0aaf4236543e5be7918ffb94de7166b6a29
hovercard-subject-tagpull_request:678085589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/44746/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20a3fea6216d3454751ad7462c0da195f6c09375323fa3d2f3d3a174a7782a09/microsoft/TypeScript/pull/44746
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20a3fea6216d3454751ad7462c0da195f6c09375323fa3d2f3d3a174a7782a09/microsoft/TypeScript/pull/44746
og:image:altThis is the line number side of ecddf84 (from #21924, fixing #21818). But the code is slightly improved for both cases: instead of testing that leaf is defined, check whether lineCount is zero, and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelibarzilay
hostnamegithub.com
expected-hostnamegithub.com
None399e662401f6b9a532ecd80b305d17b9efadd864681448a290ab2901b98f288a
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f4d68ce236d24a2cd682f94ef8bd8537c09d73d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/44746#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44746
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44746
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/44746
Reloadhttps://github.com/microsoft/TypeScript/pull/44746
Reloadhttps://github.com/microsoft/TypeScript/pull/44746
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 30 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
elibarzilayhttps://github.com/elibarzilay
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
elibarzilay:44518https://github.com/elibarzilay/TypeScript/tree/44518
Conversationhttps://github.com/microsoft/TypeScript/pull/44746
Commits1 (1)https://github.com/microsoft/TypeScript/pull/44746/commits
Checkshttps://github.com/microsoft/TypeScript/pull/44746/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/44746/files
Fix bad line number assertion in ScriptInfo.positionToLineOffsethttps://github.com/microsoft/TypeScript/pull/44746#top
elibarzilayhttps://github.com/elibarzilay
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
elibarzilay:44518https://github.com/elibarzilay/TypeScript/tree/44518
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 25, 2021https://github.com/microsoft/TypeScript/pull/44746#issue-930384360
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
ecddf84https://github.com/microsoft/TypeScript/commit/ecddf8468fae73208126f2bc5aba4c39ef1e0875
#21924https://github.com/microsoft/TypeScript/pull/21924
#21818https://github.com/microsoft/TypeScript/issues/21818
#21924https://github.com/microsoft/TypeScript/pull/21924
#44518https://github.com/microsoft/TypeScript/issues/44518
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
amcaseyhttps://github.com/amcasey
sheetalkamathttps://github.com/sheetalkamat
June 25, 2021 17:52https://github.com/microsoft/TypeScript/pull/44746#event-4941299466
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
elibarzilayhttps://github.com/elibarzilay
Jun 25, 2021https://github.com/microsoft/TypeScript/pull/44746#event-4941299830
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Jun 25, 2021https://github.com/microsoft/TypeScript/pull/44746#event-4941299863
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 25, 2021https://github.com/microsoft/TypeScript/pull/44746#issuecomment-868736179
@amcaseyhttps://github.com/amcasey
#21924https://github.com/microsoft/TypeScript/pull/21924
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Jun 28, 2021 https://github.com/microsoft/TypeScript/pull/44746#pullrequestreview-694203861
View reviewed changes https://github.com/microsoft/TypeScript/pull/44746/files
src/server/scriptVersionCache.tshttps://github.com/microsoft/TypeScript/pull/44746/files#diff-937b0753d2ae76b40934519ca05034703cf7abcdec9cf4e0b60c47949bb890f9
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Jun 28, 2021 https://github.com/microsoft/TypeScript/pull/44746#pullrequestreview-694213884
View reviewed changes https://github.com/microsoft/TypeScript/pull/44746/files
src/server/scriptVersionCache.tshttps://github.com/microsoft/TypeScript/pull/44746/files#diff-937b0753d2ae76b40934519ca05034703cf7abcdec9cf4e0b60c47949bb890f9
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
src/server/scriptVersionCache.tshttps://github.com/microsoft/TypeScript/pull/44746/files#diff-937b0753d2ae76b40934519ca05034703cf7abcdec9cf4e0b60c47949bb890f9
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
src/server/scriptVersionCache.tshttps://github.com/microsoft/TypeScript/pull/44746/files#diff-937b0753d2ae76b40934519ca05034703cf7abcdec9cf4e0b60c47949bb890f9
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
force-pushedhttps://github.com/microsoft/TypeScript/compare/2fd3cd996687e21bebbc81c9475a165ec40c60f8..86872faead80a6e12defa4f7ad2b9b64bd7f5b8d
2fd3cd9https://github.com/microsoft/TypeScript/commit/2fd3cd996687e21bebbc81c9475a165ec40c60f8
86872fahttps://github.com/microsoft/TypeScript/commit/86872faead80a6e12defa4f7ad2b9b64bd7f5b8d
Compare https://github.com/microsoft/TypeScript/compare/2fd3cd996687e21bebbc81c9475a165ec40c60f8..86872faead80a6e12defa4f7ad2b9b64bd7f5b8d
June 28, 2021 18:30https://github.com/microsoft/TypeScript/pull/44746#event-4949117528
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 28, 2021https://github.com/microsoft/TypeScript/pull/44746#issuecomment-869921294
@amcaseyhttps://github.com/amcasey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Jun 28, 2021https://github.com/microsoft/TypeScript/pull/44746#issuecomment-870106858
@elibarzilayhttps://github.com/elibarzilay
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 29, 2021https://github.com/microsoft/TypeScript/pull/44746#issuecomment-870146125
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
Fix bad line number assertion in ScriptInfo.positionToLineOffsethttps://github.com/microsoft/TypeScript/pull/44746/commits/2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
2891e45https://github.com/microsoft/TypeScript/pull/44746/commits/2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
ecddf84https://github.com/elibarzilay/TypeScript/commit/ecddf8468fae73208126f2bc5aba4c39ef1e0875
microsoft#21924https://github.com/microsoft/TypeScript/pull/21924
microsoft#21818https://github.com/microsoft/TypeScript/issues/21818
microsoft#21924https://github.com/microsoft/TypeScript/pull/21924
microsoft#44518https://github.com/microsoft/TypeScript/issues/44518
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
force-pushedhttps://github.com/microsoft/TypeScript/compare/86872faead80a6e12defa4f7ad2b9b64bd7f5b8d..2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
86872fahttps://github.com/microsoft/TypeScript/commit/86872faead80a6e12defa4f7ad2b9b64bd7f5b8d
2891e45https://github.com/microsoft/TypeScript/commit/2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
Compare https://github.com/microsoft/TypeScript/compare/86872faead80a6e12defa4f7ad2b9b64bd7f5b8d..2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
June 29, 2021 05:48https://github.com/microsoft/TypeScript/pull/44746#event-4951229981
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 29, 2021https://github.com/microsoft/TypeScript/pull/44746#event-4951231204
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
Jun 29, 2021https://github.com/microsoft/TypeScript/pull/44746#issuecomment-870326931
@amcaseyhttps://github.com/amcasey
#21924https://github.com/microsoft/TypeScript/pull/21924
#21924https://github.com/microsoft/TypeScript/pull/21924
#21818https://github.com/microsoft/TypeScript/issues/21818
#44518https://github.com/microsoft/TypeScript/issues/44518
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Jun 29, 2021 https://github.com/microsoft/TypeScript/pull/44746#pullrequestreview-695236686
View reviewed changes https://github.com/microsoft/TypeScript/pull/44746/files/2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
amcaseyhttps://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/44746#pullrequestreview-695236686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
f47ddbchttps://github.com/microsoft/TypeScript/commit/f47ddbc3b0c6421c38b18e56f8da88434a473c8d
Jun 29, 2021https://github.com/microsoft/TypeScript/pull/44746#event-4955324899
https://github.com/elibarzilay
elibarzilayhttps://github.com/elibarzilay
June 29, 2021 18:13https://github.com/microsoft/TypeScript/pull/44746#event-4955325124
https://github.com/sandersn
sandersnhttps://github.com/sandersn
Oct 30, 2024 https://github.com/microsoft/TypeScript/pull/44746#ref-pullrequest-2625044285
Fix a crash in an anonymous buffer that copilot is writing to. #60377 https://github.com/microsoft/TypeScript/pull/60377
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/44746#event-20417419241
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44746
https://github.com/sheetalkamat
sheetalkamat https://github.com/sheetalkamat
https://github.com/amcasey
amcasey https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/44746/files/2891e45dd0be4bd08acc66e5cc42983c9a7e8c94
https://github.com/elibarzilay
elibarzilay https://github.com/elibarzilay
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
TypeScript Server Error (4.3.2): False expression: Expected line to be non-zero https://github.com/microsoft/TypeScript/issues/44518
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44746
https://github.com/elibarzilay
https://github.com/amcasey
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.