René's URL Explorer Experiment


Title: Fix logic for determining whether to simplify keyof on mapped types by ahejlsberg · Pull Request #44042 · microsoft/TypeScript · GitHub

Open Graph Title: Fix logic for determining whether to simplify keyof on mapped types by ahejlsberg · Pull Request #44042 · microsoft/TypeScript

X Title: Fix logic for determining whether to simplify keyof on mapped types by ahejlsberg · Pull Request #44042 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix logic for determining whether to simplify keyof on mapped types by ahejlsberg · Pull Request #44042 · microsoft/TypeScript

Open Graph Description: Fixes #44019.

X Description: Fixes #44019.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/44042

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:47911e65-a54a-d3d7-7dc4-30afa5ff245d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE956:2C4BED:36323D2:44DE957:6B01E759
html-safe-nonce065d4ad17621156caa5d1be987aa13322981240ecb6c7da3ed02b1a94cd45107
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU2OjJDNEJFRDozNjMyM0QyOjQ0REU5NTc6NkIwMUU3NTkiLCJ2aXNpdG9yX2lkIjoiMjQ0Mzk3NDgwNzEzMDMzNTA2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc61cfcb7b720ce8053d48945e7da7bdfdebf62ec7206725c544cfe94386bf828
hovercard-subject-tagpull_request:641895754
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/44042/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20609719730754a1817f851742e987e3bfae8d58a18c3de4eedc080369b4413a/microsoft/TypeScript/pull/44042
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20609719730754a1817f851742e987e3bfae8d58a18c3de4eedc080369b4413a/microsoft/TypeScript/pull/44042
og:image:altFixes #44019.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/44042#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44042
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44042
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/44042
Reloadhttps://github.com/microsoft/TypeScript/pull/44042
Reloadhttps://github.com/microsoft/TypeScript/pull/44042
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix44019https://github.com/microsoft/TypeScript/tree/fix44019
Conversationhttps://github.com/microsoft/TypeScript/pull/44042
Commits7 (7)https://github.com/microsoft/TypeScript/pull/44042/commits
Checkshttps://github.com/microsoft/TypeScript/pull/44042/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/44042/files
Fix logic for determining whether to simplify keyof on mapped typeshttps://github.com/microsoft/TypeScript/pull/44042#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix44019https://github.com/microsoft/TypeScript/tree/fix44019
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 11, 2021https://github.com/microsoft/TypeScript/pull/44042#issue-888722276
#44019https://github.com/microsoft/TypeScript/issues/44019
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 11, 2021 14:13https://github.com/microsoft/TypeScript/pull/44042#commits-pushed-9f721e4
https://github.com/ahejlsberg
Fix logic for determining whether to simplify keyof on mapped typeshttps://github.com/microsoft/TypeScript/pull/44042/commits/9f721e4a15686f7440cbf907e16544019278fa20
9f721e4https://github.com/microsoft/TypeScript/pull/44042/commits/9f721e4a15686f7440cbf907e16544019278fa20
https://github.com/ahejlsberg
Add regression testhttps://github.com/microsoft/TypeScript/pull/44042/commits/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7
d1a7108https://github.com/microsoft/TypeScript/pull/44042/commits/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 11, 2021https://github.com/microsoft/TypeScript/pull/44042#event-4731685709
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
May 11, 2021https://github.com/microsoft/TypeScript/pull/44042#event-4731685817
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Wesley Wigham (weswigham)https://github.com/weswigham
May 11, 2021 21:28https://github.com/microsoft/TypeScript/pull/44042#event-4731691101
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 12, 2021 https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-657345404
View reviewed changes https://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
May 12, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r630626788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 16, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r633110393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634623301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
May 12, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r630627722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634623958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
May 12, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r630628801
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 16, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r633110637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634626089
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 14, 2021https://github.com/microsoft/TypeScript/pull/44042#issuecomment-841285903
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/markw65
markw65https://github.com/markw65
May 16, 2021 https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-660447951
View reviewed changes https://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
markw65https://github.com/markw65
May 16, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r633110254
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634626370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
markw65https://github.com/markw65
May 16, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r633110393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
markw65https://github.com/markw65
May 16, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r633110637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 18, 2021 07:10https://github.com/microsoft/TypeScript/pull/44042#commits-pushed-2486dad
https://github.com/ahejlsberg
Merge branch 'master' into fix44019https://github.com/microsoft/TypeScript/pull/44042/commits/2486dadc7523800c123be675353085b4b8cb8a2f
2486dadhttps://github.com/microsoft/TypeScript/pull/44042/commits/2486dadc7523800c123be675353085b4b8cb8a2f
https://github.com/ahejlsberg
Improve hasDistributiveNameType checkhttps://github.com/microsoft/TypeScript/pull/44042/commits/879753cda7c782c3416609d0a7651f02307c91da
879753chttps://github.com/microsoft/TypeScript/pull/44042/commits/879753cda7c782c3416609d0a7651f02307c91da
https://github.com/ahejlsberg
Add more testshttps://github.com/microsoft/TypeScript/pull/44042/commits/772e7166f03881839009582e22fea8ea1c930ce4
772e716https://github.com/microsoft/TypeScript/pull/44042/commits/772e7166f03881839009582e22fea8ea1c930ce4
https://github.com/markw65
markw65https://github.com/markw65
May 18, 2021 https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-662543596
View reviewed changes https://github.com/microsoft/TypeScript/pull/44042/files/772e7166f03881839009582e22fea8ea1c930ce4
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/772e7166f03881839009582e22fea8ea1c930ce4#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
markw65https://github.com/markw65
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634725306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
background commenthttps://github.com/microsoft/TypeScript/pull/44042#issuecomment-841285903
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r635331415
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
another test casehttps://www.typescriptlang.org/play#code/C4TwDgpgBA0hIHsBmBZAhmSATAPAFQBooBVAPigF4oBreZKAbygG1YoBLAOxrqSjyhoAzj0R8AFA2YAFDtxiCReGQF0oEAB7AInLCOJQA-GwBcUThABuEAE4qzwGwFcIAXwCUUe-2Yw1rgG4AWAAoLm0bJDQAY2gURlCoQTMAIwQEABsINE5gkKSUs04nAFsU2zzXUKQnTmjgdgRuJHENMzgxdEwIXBQiNMzszlJPBkSoGwhgJxtuDUrq8QAiFKX3AKA
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r635492508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r635549902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/44042/files/772e7166f03881839009582e22fea8ea1c930ce4#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
markw65https://github.com/markw65
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634740662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 18, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r634750240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Here's a full test casehttps://www.typescriptlang.org/play#code/C4TwDgpgBAIglgZ2AHgKoBooDVMHVMAaAfFALxSpQQAewEAdgCYLZQD8UuUAXFAQNwBYAFChIUANIQQAewBmAWQCGYSI2QAVTKhLkA1tPlQA3lADakqHHpQDsuVA1QlLeEmQSqtBswrtHZhIAujxQ9BAAbhAATpgagUGYEpjhUdEkQbzxwVAAvkLC1nTRckoAxtAKJiJQzrwARjIyADYQSvQFtfW89ACuALb1MQW5InK99GXAcDI2cgAU1KFS9sqqEOoKmABESttEAJTVwrXREMC90TbUI2Pz2-XbB-xAA
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
markw65https://github.com/markw65
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r635493638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#discussion_r635550251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/markw65
markw65https://github.com/markw65
May 19, 2021 https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-663580072
View reviewed changes https://github.com/microsoft/TypeScript/pull/44042/files/772e7166f03881839009582e22fea8ea1c930ce4
markw65https://github.com/markw65
https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-663580072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021 13:07https://github.com/microsoft/TypeScript/pull/44042#commits-pushed-007940c
https://github.com/ahejlsberg
Address code review feedbackhttps://github.com/microsoft/TypeScript/pull/44042/commits/007940c1d0fb5a1452303dfeef3541a0b86bbf45
007940chttps://github.com/microsoft/TypeScript/pull/44042/commits/007940c1d0fb5a1452303dfeef3541a0b86bbf45
https://github.com/ahejlsberg
Add more testshttps://github.com/microsoft/TypeScript/pull/44042/commits/a9a00e86b2df1c3acc9c8b0b1f3ae7802f6d6153
a9a00e8https://github.com/microsoft/TypeScript/pull/44042/commits/a9a00e86b2df1c3acc9c8b0b1f3ae7802f6d6153
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#issuecomment-844437131
markw65https://github.com/markw65
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
May 19, 2021 https://github.com/microsoft/TypeScript/pull/44042#pullrequestreview-663639128
View reviewed changes https://github.com/microsoft/TypeScript/pull/44042/files/a9a00e86b2df1c3acc9c8b0b1f3ae7802f6d6153
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
73736d9https://github.com/microsoft/TypeScript/commit/73736d9b84ba5f621b269df38f0ee2dd3bb413fd
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#event-4769172051
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021 20:43https://github.com/microsoft/TypeScript/pull/44042#event-4769172475
https://github.com/markw65
markw65https://github.com/markw65
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#issuecomment-844532615
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 19, 2021https://github.com/microsoft/TypeScript/pull/44042#issuecomment-844547981
markw65https://github.com/markw65
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/markw65
markw65https://github.com/markw65
May 20, 2021https://github.com/microsoft/TypeScript/pull/44042#issuecomment-844628438
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 25, 2021 https://github.com/microsoft/TypeScript/pull/44042#ref-issue-901499285
Design Meeting Notes, 5/19/2021 #44256 https://github.com/microsoft/TypeScript/issues/44256
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/44042#event-20417403445
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F44042
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/44042/files/d1a7108f4e915bf80604eeccfc8ab30e7e2140e7
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/44042/files/a9a00e86b2df1c3acc9c8b0b1f3ae7802f6d6153
https://github.com/markw65
markw65 https://github.com/markw65
https://github.com/microsoft/TypeScript/pull/44042/files/772e7166f03881839009582e22fea8ea1c930ce4
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
ConditionalRoot.isDistributive is buggy https://github.com/microsoft/TypeScript/issues/44019
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/44042
https://github.com/ahejlsberg
https://github.com/markw65
https://github.com/weswigham
https://github.com/RyanCavanaugh
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.