René's URL Explorer Experiment


Title: Relax requirements on index signatures to 'any' when a type also contains a string index signature to 'any' by DanielRosenwasser · Pull Request #43065 · microsoft/TypeScript · GitHub

Open Graph Title: Relax requirements on index signatures to 'any' when a type also contains a string index signature to 'any' by DanielRosenwasser · Pull Request #43065 · microsoft/TypeScript

X Title: Relax requirements on index signatures to 'any' when a type also contains a string index signature to 'any' by DanielRosenwasser · Pull Request #43065 · microsoft/TypeScript

Description: Fixes #43064 When checking compatibility between two types, TypeScript should not require a corresponding source index signature if the target side index signature maps to any and the target side has a string index signature that maps to any. So an index signature like in { [x: number]: any } is still required of a source type, but neither index signature in { [x: number]: any, [x: string]: any; } should be required; however, the number index signature in { [x: number]: number, [x: string]: any; } should always be required because the number index signature doesn't map to any. TL;DR: Given type SomeObject = { hello: string, world: number }: ✅ SomeObject -> { [x: string]: any } ✅ SomeObject -> { [x: string]: any, [x: number]: any } ❌ SomeObject -> { [x: number]: any } ❌ SomeObject -> { [x: string]: any, [x: number]: string }

Open Graph Description: Fixes #43064 When checking compatibility between two types, TypeScript should not require a corresponding source index signature if the target side index signature maps to any and the target side ...

X Description: Fixes #43064 When checking compatibility between two types, TypeScript should not require a corresponding source index signature if the target side index signature maps to any and the target side ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/43065

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3c637d06-614a-f5a1-e774-6d4a4515e8fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0C4:B21B9:36D7BA:4A7083:6AEDB381
html-safe-nonce9ce7007c6ea49f02069c340140c53fe9897182e29a82435ff274276e32368ba0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEM0OkIyMUI5OjM2RDdCQTo0QTcwODM6NkFFREIzODEiLCJ2aXNpdG9yX2lkIjoiNzkwNjUwNDIwNjM1NTExNjkyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace27138a4b1d0c1dcc1de31eb37da5615f4a609bb205901a14d3ee62c79a92e51
hovercard-subject-tagpull_request:584235068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
twitter:imagehttps://avatars.githubusercontent.com/u/972891?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/972891?s=400&v=4
og:image:altFixes #43064 When checking compatibility between two types, TypeScript should not require a corresponding source index signature if the target side index signature maps to any and the target side ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee40242599af5e7da0f281843dec7492c322688d4a48caeea85f9fb8e41c8ea53
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89cbf2bb52a24fc179bf5925abba0ba574b262ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F43065%2Fcommits%2Fbca691de049426ef73311791cdfd5789241b294d
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F43065%2Fcommits%2Fbca691de049426ef73311791cdfd5789241b294d
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Reloadhttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Reloadhttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests299 (299)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
alwaysBeHappyWithStringIndexSignatureshttps://github.com/microsoft/TypeScript/tree/alwaysBeHappyWithStringIndexSignatures
Conversation 9 https://github.com/microsoft/TypeScript/pull/43065
Commits 4 https://github.com/microsoft/TypeScript/pull/43065/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/43065/checks
Files changed https://github.com/microsoft/TypeScript/pull/43065/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Relax requirements on index signatures to 'any' when a type also contains a string index signature to 'any' https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d#top
Show all changes 4 commits https://github.com/microsoft/TypeScript/pull/43065/files
b5fe2d7 Added test. DanielRosenwasser Mar 3, 2021 https://github.com/microsoft/TypeScript/pull/43065/commits/b5fe2d72f8f1c49c504fa7307e8eff8c53f74a31
9091969 Accepted baselines. DanielRosenwasser Mar 3, 2021 https://github.com/microsoft/TypeScript/pull/43065/commits/9091969cc50531ce2a6f1aae4491c77c0008c33b
bca691d Allow other index signatures to 'any' if there is a string index sign… DanielRosenwasser Mar 3, 2021 https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
bb8f30c Accepted baselines. DanielRosenwasser Mar 3, 2021 https://github.com/microsoft/TypeScript/pull/43065/commits/bb8f30c977b86ca9ff736c3436a0b5ff160bcb61
Clear filters https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
Prev https://github.com/microsoft/TypeScript/pull/43065/commits/9091969cc50531ce2a6f1aae4491c77c0008c33b
Next https://github.com/microsoft/TypeScript/pull/43065/commits/bb8f30c977b86ca9ff736c3436a0b5ff160bcb61
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d
https://github.com/DanielRosenwasser
DanielRosenwasserhttps://github.com/microsoft/TypeScript/commits?author=DanielRosenwasser
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/microsoft/TypeScript/blob/bca691de049426ef73311791cdfd5789241b294d/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/43065/commits/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/43065/commits/bca691de049426ef73311791cdfd5789241b294d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.