René's URL Explorer Experiment


Title: Baseline completions and signature help by sandersn · Pull Request #43049 · microsoft/TypeScript · GitHub

Open Graph Title: Baseline completions and signature help by sandersn · Pull Request #43049 · microsoft/TypeScript

X Title: Baseline completions and signature help by sandersn · Pull Request #43049 · microsoft/TypeScript

Description: Background: I need to update a lot of jsdoc tests since #41877 makes the jsdoc parse tree much more complete. This leads to a lot of painstaking, repetitive work updating fourslash tests. In this PR, I add baselining to completions and signature help, to match the baselining for quick info. I also changed the filename, which should really be the containing filename. Limitations I only changed the tests that I care about for #41877 because I wanted to have time to inspect the baselines for this change. And I haven't planned out a way to update the tests. Ideas are welcome. Quick info, signature help, smart selection and completions all use the same filename and are thus mutually exclusive in one test. Fourslash tests are mostly divided this way already, so I thought it was an acceptable limit. I had to split five or six existing, gigantic, horrible tests as a result.

Open Graph Description: Background: I need to update a lot of jsdoc tests since #41877 makes the jsdoc parse tree much more complete. This leads to a lot of painstaking, repetitive work updating fourslash tests. In this P...

X Description: Background: I need to update a lot of jsdoc tests since #41877 makes the jsdoc parse tree much more complete. This leads to a lot of painstaking, repetitive work updating fourslash tests. In this P...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/43049

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:215e13a3-b303-593c-8723-3d20ffe5ab09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8066:29A7C1:2E2A72:402F62:6AEDB2F2
html-safe-nonce28b7e5ca2a77424ee63d28ae3dd5eacc73bed4da1810d8a2e5a52e877b19a68b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDY2OjI5QTdDMToyRTJBNzI6NDAyRjYyOjZBRURCMkYyIiwidmlzaXRvcl9pZCI6IjMzMTU2NTM2OTI3NTU5MTU1MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacefec2bcf2c4784d11d2ad2f892ad442122a4450e8daba09dc49f0babc20b7afa
hovercard-subject-tagpull_request:583264253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
twitter:imagehttps://avatars.githubusercontent.com/u/293473?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293473?s=400&v=4
og:image:altBackground: I need to update a lot of jsdoc tests since #41877 makes the jsdoc parse tree much more complete. This leads to a lot of painstaking, repetitive work updating fourslash tests. In this P...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee40242599af5e7da0f281843dec7492c322688d4a48caeea85f9fb8e41c8ea53
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89cbf2bb52a24fc179bf5925abba0ba574b262ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F43049%2Fcommits%2F390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F43049%2Fcommits%2F390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Reloadhttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Reloadhttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests299 (299)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
baseline-completions-and-signaturehelphttps://github.com/microsoft/TypeScript/tree/baseline-completions-and-signaturehelp
Conversation 4 https://github.com/microsoft/TypeScript/pull/43049
Commits 11 https://github.com/microsoft/TypeScript/pull/43049/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/43049/checks
Files changed https://github.com/microsoft/TypeScript/pull/43049/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Baseline completions and signature help https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c#top
Show all changes 11 commits https://github.com/microsoft/TypeScript/pull/43049/files
bff6bdd Initial implementation+first big transitions sandersn Feb 25, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/bff6bddda0b989107a1e8e673f7415555a8d68c2
934d44a Merge branch 'master' into baseline-completions-and-signaturehelp sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/934d44a8ff34124d8bee45e9d9473f14674570e9
c7542c5 about 10 more sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/c7542c5de2605970711c9cc428d0dcb0ad727568
57fd347 Merge branch 'master' into baseline-completions-and-signaturehelp sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/57fd347abdb689fc5c038254ea424e5e255a06c8
df54432 Change baseline filename + more baselines sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/df54432941d5755ffbb6ce8db5ac3e3f671809ac
6695f67 fix lint sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/6695f6707472b575cd883e55e1f34a69aef1a5cc
23caafc Remove unused/incorrectly named fourslash baselines sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/23caafc63f7d14f3999d21927bb08b9c5992d51c
ed8f7fa fix incorrectly updated baselines sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/ed8f7fa7073f6c24d990695a4a11e8b5fcc08867
cddd249 dedupe non-unique filenames sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/cddd249800d104eedad4bcc74401739e68b23bda
e756a1a Add names to marker baselines sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/e756a1a5975f479ea547871da01f4e52b1f096ce
390cf2c Fix semicolon lint sandersn Mar 2, 2021 https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Clear filters https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
Prev https://github.com/microsoft/TypeScript/pull/43049/commits/e756a1a5975f479ea547871da01f4e52b1f096ce
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c
https://github.com/sandersn
sandersnhttps://github.com/microsoft/TypeScript/commits?author=sandersn
src/harness/fourslashImpl.tshttps://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b
View file https://github.com/microsoft/TypeScript/blob/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c/src/harness/fourslashImpl.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/43049/commits/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b
https://github.com/microsoft/TypeScript/pull/43049/commits/390cf2cdfc88fc596f74cbcb1db6ef7168ea823c#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.