| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2e1c7cb-455f-87de-56d8-4ba18bb7aac7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB92:2454CC:9610C9:C05052:6B00EFC4 |
| html-safe-nonce | d6fd35b0a544c2998a3aefecd1e1b27500d3a8fae47d9a9fd492a9355e8774f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjkyOjI0NTRDQzo5NjEwQzk6QzA1MDUyOjZCMDBFRkM0IiwidmlzaXRvcl9pZCI6Ijg3NjI1NjE0MzI2MzkzMDM2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 41cdb47363e75a68a33c54b6baf80474dc6d2e53a3f5eaba5a1e09516b69d11d |
| hovercard-subject-tag | pull_request:580940778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/42986/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e0563fb7f65f91c39d0bd104721d7321c87139940ec5d6373047a05eed602957/microsoft/TypeScript/pull/42986 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0563fb7f65f91c39d0bd104721d7321c87139940ec5d6373047a05eed602957/microsoft/TypeScript/pull/42986 |
| og:image:alt | Static Private Class Elements
This PR implements the TC39 Stage 3 Static Class features which introduce private identifier static class elements (fields/methods/accessors).
Fixes: #42985
Dependenci... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dragomirtitian |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/42986#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F42986 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F42986 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/42986 |
| Reload | https://github.com/microsoft/TypeScript/pull/42986 |
| Reload | https://github.com/microsoft/TypeScript/pull/42986 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| bloomberg:es-private-static-fields-methods-and-accessors | https://github.com/bloomberg/TypeScript/tree/es-private-static-fields-methods-and-accessors |
| Conversation | https://github.com/microsoft/TypeScript/pull/42986 |
| Commits60 (60) | https://github.com/microsoft/TypeScript/pull/42986/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/42986/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/42986/files |
| Implement Static Private Class Elements | https://github.com/microsoft/TypeScript/pull/42986#top |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| bloomberg:es-private-static-fields-methods-and-accessors | https://github.com/bloomberg/TypeScript/tree/es-private-static-fields-methods-and-accessors |
|
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Feb 26, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issue-817449779 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| TC39 Stage 3 Static Class features | https://tc39.es/proposal-static-class-features/ |
| #42985 | https://github.com/microsoft/TypeScript/issues/42985 |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| PR | https://github.com/microsoft/TypeScript/pull/42458 |
| https://tc39.es/proposal-static-class-features/ | https://tc39.es/proposal-static-class-features/ |
| v84 | https://www.chromestatus.com/feature/5700509656678400 |
| upstream support behind a flag | https://trac.webkit.org/changeset/273107/webkit |
| support in v81 behind a flag | https://bugzilla.mozilla.org/show_bug.cgi?id=1659134 |
| 7.1 | https://babeljs.io/blog/2018/09/17/7.1.0#private-static-fields-stage-3 |
| 7.4 | https://babeljs.io/blog/2019/03/19/7.4.0#static-private-methods-9446httpsgithubcombabelbabelpull9446 |
| 7.6 | https://babeljs.io/blog/2019/09/05/7.6.0#private-static-accessors-getters-and-setters-10217httpsgithubcombabelbabelpull10217 |
| Using a set/get accessor causes a runtime error if the descriptor is not yet initialized babel/babel#12905 | https://github.com/babel/babel/issues/12905 |
| Confusing error when static private field is accessed before declaration. babel/babel#12904 | https://github.com/babel/babel/issues/12904 |
| Titian Cernicova-Dragomir (@dragomirtitian) | https://github.com/dragomirtitian |
| Kubilay Kahveci (@mkubilayk) | https://github.com/mkubilayk |
| Joey Watts (@joeywatts) | https://github.com/joeywatts |
| Rob Palmer (@robpalme) | https://github.com/robpalme |
| Ashley Claymore (@acutmore) | https://github.com/acutmore |
| here | https://github.com/microsoft/TypeScript/issues/41788#issuecomment-739325461 |
| a pre-existing issue | https://github.com/microsoft/TypeScript/issues/36267 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| February 3, 2021 18:44 | https://github.com/microsoft/TypeScript/pull/42986#commits-pushed-e3a3fb8 |
|
| https://github.com/dragomirtitian |
| Added support for private identifier methods. | https://github.com/microsoft/TypeScript/pull/42986/commits/e3a3fb8eb25160923ab87960d357cf67869d16b1 |
| e3a3fb8 | https://github.com/microsoft/TypeScript/pull/42986/commits/e3a3fb8eb25160923ab87960d357cf67869d16b1 |
|
| https://github.com/dragomirtitian |
| Added tests for private methods. | https://github.com/microsoft/TypeScript/pull/42986/commits/4ab27a2bc511066cf5cf20a62bc834bd29fa560a |
| 4ab27a2 | https://github.com/microsoft/TypeScript/pull/42986/commits/4ab27a2bc511066cf5cf20a62bc834bd29fa560a |
|
| https://github.com/dragomirtitian |
| Added check to only not allow private name method signatures in anyth… | https://github.com/microsoft/TypeScript/pull/42986/commits/6977b9fa819a23b7a079e1dbb137b30556798621 |
| 6977b9f | https://github.com/microsoft/TypeScript/pull/42986/commits/6977b9fa819a23b7a079e1dbb137b30556798621 |
|
| https://github.com/dragomirtitian |
| Added private accessors tests | https://github.com/microsoft/TypeScript/pull/42986/commits/bc8c07e497254f70dd861adb06c6572c674b6eac |
| bc8c07e | https://github.com/microsoft/TypeScript/pull/42986/commits/bc8c07e497254f70dd861adb06c6572c674b6eac |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Transform private methods | https://github.com/microsoft/TypeScript/pull/42986/commits/2760ed830b9e6d649eb380e6c59cd04d3f1c9a09 |
| 2760ed8 | https://github.com/microsoft/TypeScript/pull/42986/commits/2760ed830b9e6d649eb380e6c59cd04d3f1c9a09 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Rename shouldTransformPrivateFields | https://github.com/microsoft/TypeScript/pull/42986/commits/04af85d4730b3939ce63e400a5feaf4d9f47ddaa |
| 04af85d | https://github.com/microsoft/TypeScript/pull/42986/commits/04af85d4730b3939ce63e400a5feaf4d9f47ddaa |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Accept baseline | https://github.com/microsoft/TypeScript/pull/42986/commits/f048d721a0f2e3aca56fe150cc798a35f8dbcaaa |
| f048d72 | https://github.com/microsoft/TypeScript/pull/42986/commits/f048d721a0f2e3aca56fe150cc798a35f8dbcaaa |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Use a single WeakSet for brand-check | https://github.com/microsoft/TypeScript/pull/42986/commits/f8cfb8175b86527d70c17ac78aaf578f6b5131ef |
| f8cfb81 | https://github.com/microsoft/TypeScript/pull/42986/commits/f8cfb8175b86527d70c17ac78aaf578f6b5131ef |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Accept baseline | https://github.com/microsoft/TypeScript/pull/42986/commits/4aa4c3b29a47eb6f54be57baa0b813f2d549db70 |
| 4aa4c3b | https://github.com/microsoft/TypeScript/pull/42986/commits/4aa4c3b29a47eb6f54be57baa0b813f2d549db70 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Add a test for using private methods in static field initializers | https://github.com/microsoft/TypeScript/pull/42986/commits/0ac12711a50ec5422d8db0edf49346f14636f9af |
| 0ac1271 | https://github.com/microsoft/TypeScript/pull/42986/commits/0ac12711a50ec5422d8db0edf49346f14636f9af |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Add breaking checker test | https://github.com/microsoft/TypeScript/pull/42986/commits/7da5bd99e0f4d138b10c47b495c44eddc333ca43 |
| 7da5bd9 | https://github.com/microsoft/TypeScript/pull/42986/commits/7da5bd99e0f4d138b10c47b495c44eddc333ca43 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Add to instances once per-instance | https://github.com/microsoft/TypeScript/pull/42986/commits/e133f602fbbb8286351d1843d885b143cf335da3 |
| e133f60 | https://github.com/microsoft/TypeScript/pull/42986/commits/e133f602fbbb8286351d1843d885b143cf335da3 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Accept baseline | https://github.com/microsoft/TypeScript/pull/42986/commits/aa5dd8a5600a69086cf99b78fcae4691b6e17fe5 |
| aa5dd8a | https://github.com/microsoft/TypeScript/pull/42986/commits/aa5dd8a5600a69086cf99b78fcae4691b6e17fe5 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: evaluate receiver and rhs expressions before throwing on readonl… | https://github.com/microsoft/TypeScript/pull/42986/commits/a3889a778213b352cf7456d2cc5a21d59f4193fb |
| a3889a7 | https://github.com/microsoft/TypeScript/pull/42986/commits/a3889a778213b352cf7456d2cc5a21d59f4193fb |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Add a test for evaluating rhs before readonly assignment | https://github.com/microsoft/TypeScript/pull/42986/commits/8952caa32f42af226608b195ddb6a8421920eff2 |
| 8952caa | https://github.com/microsoft/TypeScript/pull/42986/commits/8952caa32f42af226608b195ddb6a8421920eff2 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Transpile private accessors | https://github.com/microsoft/TypeScript/pull/42986/commits/dee87bb6a0e8ea0181de4f44f0dc08ab2f309029 |
| dee87bb | https://github.com/microsoft/TypeScript/pull/42986/commits/dee87bb6a0e8ea0181de4f44f0dc08ab2f309029 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| Accept baseline | https://github.com/microsoft/TypeScript/pull/42986/commits/aec7e9bd4b1a4f4bcbdca5e250e9a3fb9f334513 |
| aec7e9b | https://github.com/microsoft/TypeScript/pull/42986/commits/aec7e9bd4b1a4f4bcbdca5e250e9a3fb9f334513 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: handle readonly/writeonly accessors | https://github.com/microsoft/TypeScript/pull/42986/commits/f3bbf0f6f7e4e0121df3d03ee8b10c6ad83d7408 |
| f3bbf0f | https://github.com/microsoft/TypeScript/pull/42986/commits/f3bbf0f6f7e4e0121df3d03ee8b10c6ad83d7408 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| accept baseline | https://github.com/microsoft/TypeScript/pull/42986/commits/a1b59cd4fb4649ee00581cc3a8f28d2fe9625055 |
| a1b59cd | https://github.com/microsoft/TypeScript/pull/42986/commits/a1b59cd4fb4649ee00581cc3a8f28d2fe9625055 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| add a test for private setter without a getter | https://github.com/microsoft/TypeScript/pull/42986/commits/6b74498c02cd4296f51c02cb448114438dc14b37 |
| 6b74498 | https://github.com/microsoft/TypeScript/pull/42986/commits/6b74498c02cd4296f51c02cb448114438dc14b37 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: getAllUnscopedEmitHelpers | https://github.com/microsoft/TypeScript/pull/42986/commits/d51f6cd70168b703cc93256a173d205cf5a9edc5 |
| d51f6cd | https://github.com/microsoft/TypeScript/pull/42986/commits/d51f6cd70168b703cc93256a173d205cf5a9edc5 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: better handling of duplicate names | https://github.com/microsoft/TypeScript/pull/42986/commits/c1757708a563456e329e8fda7bfecee68f6b75a9 |
| c175770 | https://github.com/microsoft/TypeScript/pull/42986/commits/c1757708a563456e329e8fda7bfecee68f6b75a9 |
|
| https://github.com/dragomirtitian |
| Fixed wrong error message for private methods in class expressions. | https://github.com/microsoft/TypeScript/pull/42986/commits/4301af504c646161d32c7d1571e46fa4b43a049c |
| 4301af5 | https://github.com/microsoft/TypeScript/pull/42986/commits/4301af504c646161d32c7d1571e46fa4b43a049c |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| change error message | https://github.com/microsoft/TypeScript/pull/42986/commits/3a056b251814227d59bb0e722512537e7a33c2fc |
| 3a056b2 | https://github.com/microsoft/TypeScript/pull/42986/commits/3a056b251814227d59bb0e722512537e7a33c2fc |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| add a test for async private methods with a higher target | https://github.com/microsoft/TypeScript/pull/42986/commits/95df2d14285cb89a6d9b086d03625022ab1f5dbd |
| 95df2d1 | https://github.com/microsoft/TypeScript/pull/42986/commits/95df2d14285cb89a6d9b086d03625022ab1f5dbd |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: setter assignment returns rhs value | https://github.com/microsoft/TypeScript/pull/42986/commits/590124e22528b7f43b33a59738a241b2aa66ac1b |
| 590124e | https://github.com/microsoft/TypeScript/pull/42986/commits/590124e22528b7f43b33a59738a241b2aa66ac1b |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| add a test for setter assignment return value | https://github.com/microsoft/TypeScript/pull/42986/commits/219ea8340f510034bdbfc161c880616a87197da7 |
| 219ea83 | https://github.com/microsoft/TypeScript/pull/42986/commits/219ea8340f510034bdbfc161c880616a87197da7 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| fix: handle duplicate accessors | https://github.com/microsoft/TypeScript/pull/42986/commits/25da8caf53ce241a61d1b876fa8c857a966b86b2 |
| 25da8ca | https://github.com/microsoft/TypeScript/pull/42986/commits/25da8caf53ce241a61d1b876fa8c857a966b86b2 |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| add tests for duplicate accessors | https://github.com/microsoft/TypeScript/pull/42986/commits/a2228bed99f5d96cae93d1f1e8c423dab09fa5df |
| a2228be | https://github.com/microsoft/TypeScript/pull/42986/commits/a2228bed99f5d96cae93d1f1e8c423dab09fa5df |
|
| https://github.com/mkubilayk |
|
| https://github.com/dragomirtitian |
| docs: add missing parameter docs | https://github.com/microsoft/TypeScript/pull/42986/commits/ff4f73785e0e03c197bf373a4a43337b6c7ed274 |
| ff4f737 | https://github.com/microsoft/TypeScript/pull/42986/commits/ff4f73785e0e03c197bf373a4a43337b6c7ed274 |
|
| https://github.com/mkubilayk |
| Merge remote-tracking branch 'upstream/master' into es-private-method… | https://github.com/microsoft/TypeScript/pull/42986/commits/c9240586b1b9ab449fc38f330a26fe061f738e08 |
| c924058 | https://github.com/microsoft/TypeScript/pull/42986/commits/c9240586b1b9ab449fc38f330a26fe061f738e08 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Mar 2, 2021
| https://github.com/microsoft/TypeScript/pull/42986#pullrequestreview-601460106 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791 |
| src/compiler/diagnosticMessages.json | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r585289864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Mar 2, 2021
| https://github.com/microsoft/TypeScript/pull/42986#pullrequestreview-601460483 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| tests/baselines/reference/privateNameDuplicateField.errors.txt | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-46297a14077b26dcc6b3fd21a0b856a09038be11a8ac870854895d3ed4c7357c |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r585293435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r585554160 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/42986/files/7e7b0b18a906fd94a62cb8de038276b338f0b791#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r585295542 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Mar 3, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r586561623 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-788880822 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
|
| https://github.com/mkubilayk |
| Merge remote-tracking branch 'upstream/master' into es-private-method… | https://github.com/microsoft/TypeScript/pull/42986/commits/e65116f7df1f7ea0bbad9a5bfddcda0885569259 |
| e65116f | https://github.com/microsoft/TypeScript/pull/42986/commits/e65116f7df1f7ea0bbad9a5bfddcda0885569259 |
| https://github.com/ExE-Boss |
| ExE Boss (ExE-Boss) | https://github.com/ExE-Boss |
| Mar 2, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-789083642 |
| Titian Cernicova-Dragomir (@dragomirtitian) | https://github.com/dragomirtitian |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| March 3, 2021 18:40 | https://github.com/microsoft/TypeScript/pull/42986#commits-pushed-4748c87 |
|
| https://github.com/dragomirtitian |
| Fixed code review issues. | https://github.com/microsoft/TypeScript/pull/42986/commits/4748c870fb5ee24a6b71f2678937c9d2f0fd37bc |
| 4748c87 | https://github.com/microsoft/TypeScript/pull/42986/commits/4748c870fb5ee24a6b71f2678937c9d2f0fd37bc |
|
| https://github.com/dragomirtitian |
| Merge branch 'es-private-methods-and-accessors' into es-private-stati… | https://github.com/microsoft/TypeScript/pull/42986/commits/09a5aae904e1581eb3cd2ef5cb461448ddee505c |
| 09a5aae | https://github.com/microsoft/TypeScript/pull/42986/commits/09a5aae904e1581eb3cd2ef5cb461448ddee505c |
|
| https://github.com/dragomirtitian |
| Fixed code review issues for private class elements. | https://github.com/microsoft/TypeScript/pull/42986/commits/497e47ff03e65a2ba7a0e852ab38a49c999bbdb2 |
| 497e47f | https://github.com/microsoft/TypeScript/pull/42986/commits/497e47ff03e65a2ba7a0e852ab38a49c999bbdb2 |
|
Referencing this from a static class field
#36267
| https://github.com/microsoft/TypeScript/issues/36267 |
|
Await in static field initializer
#43099
| https://github.com/microsoft/TypeScript/issues/43099 |
|
Add support for class static block
#43092
| https://github.com/microsoft/TypeScript/pull/43092 |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| March 8, 2021 15:23 | https://github.com/microsoft/TypeScript/pull/42986#commits-pushed-294cc48 |
|
| https://github.com/dragomirtitian |
| Fixes class shadowing when checking access to a private static class … | https://github.com/microsoft/TypeScript/pull/42986/commits/294cc48f5e93ea061a911e134d091a7cf9b64e15 |
| 294cc48 | https://github.com/microsoft/TypeScript/pull/42986/commits/294cc48f5e93ea061a911e134d091a7cf9b64e15 |
|
| https://github.com/dragomirtitian |
| Merge remote-tracking branch 'remotes/origin/master' into es-private-… | https://github.com/microsoft/TypeScript/pull/42986/commits/027bdb32a1bcec8ce37d83a5c181a5b270c57b67 |
| 027bdb3 | https://github.com/microsoft/TypeScript/pull/42986/commits/027bdb32a1bcec8ce37d83a5c181a5b270c57b67 |
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| March 8, 2021 13:57 | https://github.com/microsoft/TypeScript/pull/42986#event-4421407596 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Armando Aguirre (armanio123) | https://github.com/armanio123 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| March 9, 2021 01:45 | https://github.com/microsoft/TypeScript/pull/42986#event-4424615575 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Mar 9, 2021 | https://github.com/microsoft/TypeScript/pull/42986#event-4424616018 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Mar 9, 2021 | https://github.com/microsoft/TypeScript/pull/42986#event-4424616062 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Mar 9, 2021 | https://github.com/microsoft/TypeScript/pull/42986#event-4424616186 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Mar 16, 2021
| https://github.com/microsoft/TypeScript/pull/42986#ref-pullrequest-792070424 |
|
ES private class elements
#42458
| https://github.com/microsoft/TypeScript/pull/42458 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Mar 16, 2021
| https://github.com/microsoft/TypeScript/pull/42986#pullrequestreview-612765415 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/42986/files/027bdb32a1bcec8ce37d83a5c181a5b270c57b67 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/microsoft/TypeScript/pull/42986#pullrequestreview-612765415 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| src/compiler/factory/emitHelpers.ts | https://github.com/microsoft/TypeScript/pull/42986/files/027bdb32a1bcec8ce37d83a5c181a5b270c57b67#diff-6a5661b0dc0a7bf7ffcccace3c70e45ad01cff20ac54ff9c3948a3720bea463e |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Mar 16, 2021 | https://github.com/microsoft/TypeScript/pull/42986#discussion_r594784929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Mar 16, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-799872314 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Mar 16, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-800665941 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://gist.github.com/rbuckton/02e3e9f13e4405184a1e4cfe2da69634 | https://gist.github.com/rbuckton/02e3e9f13e4405184a1e4cfe2da69634 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/mkubilayk |
| Kubilay Kahveci (mkubilayk) | https://github.com/mkubilayk |
| Mar 17, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-800841084 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| #42485 | https://github.com/microsoft/TypeScript/pull/42485 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Mar 17, 2021 | https://github.com/microsoft/TypeScript/pull/42986#issuecomment-801137378 |
| #42458 | https://github.com/microsoft/TypeScript/pull/42458 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| Mar 17, 2021 | https://github.com/microsoft/TypeScript/pull/42986#event-4470649390 |
| https://github.com/dragomirtitian |
| Titian Cernicova-Dragomir (dragomirtitian) | https://github.com/dragomirtitian |
| November 17, 2023 15:56 | https://github.com/microsoft/TypeScript/pull/42986#event-10996158323 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/42986#event-20324789957 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F42986 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/armanio123 |
|
Armando Aguirre (armanio123)
| https://github.com/armanio123 |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/microsoft/TypeScript/pull/42986/files/027bdb32a1bcec8ce37d83a5c181a5b270c57b67 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Static Private Class Elements
| https://github.com/microsoft/TypeScript/issues/42985 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/42986 |
|
| https://github.com/dragomirtitian |
|
| https://github.com/Kingwl |
|
| https://github.com/ExE-Boss |
|
| https://github.com/rbuckton |
|
| https://github.com/mkubilayk |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |