René's URL Explorer Experiment


Title: Gh 41788 incorrect output for esprivate with nested class in esnext by dragomirtitian · Pull Request #42663 · microsoft/TypeScript · GitHub

Open Graph Title: Gh 41788 incorrect output for esprivate with nested class in esnext by dragomirtitian · Pull Request #42663 · microsoft/TypeScript

X Title: Gh 41788 incorrect output for esprivate with nested class in esnext by dragomirtitian · Pull Request #42663 · microsoft/TypeScript

Description: Fixes #41788 Fixed as described in comment If target:esnext,then useDefineForClassFields: true will now be the default. If target:esnext, useDefineForClassFields: true we emit correct code so no further action is needed (ex) If target:esnext, useDefineForClassFields: false and we encounter a usage of a #private field in a static member we emit an error like "You can't do this, change useDefineForClassFields: true, or target an earlier version of ES."

Open Graph Description: Fixes #41788 Fixed as described in comment If target:esnext,then useDefineForClassFields: true will now be the default. If target:esnext, useDefineForClassFields: true we emit correct code so no ...

X Description: Fixes #41788 Fixed as described in comment If target:esnext,then useDefineForClassFields: true will now be the default. If target:esnext, useDefineForClassFields: true we emit correct code so no ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/42663

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:2700a774-8ee1-98b5-76fa-1c30d2a92652
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84B4:66C72:25F153:34EBC8:6AEDAFB0
html-safe-nonceb9dfd1a8f7d424cb7b7f96782ab30a3899f12a420cb09757657c8e190d1c164c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEI0OjY2QzcyOjI1RjE1MzozNEVCQzg6NkFFREFGQjAiLCJ2aXNpdG9yX2lkIjoiNzg2NTcyMjgwNzk0NTU4Mzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ef209c9a19112974c2dedc77fe106481a8ecdd7e1f29355ac96ec7c5bae1699
hovercard-subject-tagpull_request:568191831
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
twitter:imagehttps://avatars.githubusercontent.com/u/8193316?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8193316?s=400&v=4
og:image:altFixes #41788 Fixed as described in comment If target:esnext,then useDefineForClassFields: true will now be the default. If target:esnext, useDefineForClassFields: true we emit correct code so no ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee40242599af5e7da0f281843dec7492c322688d4a48caeea85f9fb8e41c8ea53
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89cbf2bb52a24fc179bf5925abba0ba574b262ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F42663%2Fcommits%2F78090999da4e4544fc7cb8fcfe1a1ef903f819dc
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F42663%2Fcommits%2F78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Reloadhttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Reloadhttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests299 (299)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
bloomberg:GH-41788-incorrect-output-for-esprivate-with-nested-class-in-esnexthttps://github.com/bloomberg/TypeScript/tree/GH-41788-incorrect-output-for-esprivate-with-nested-class-in-esnext
Conversation 11 https://github.com/microsoft/TypeScript/pull/42663
Commits 7 https://github.com/microsoft/TypeScript/pull/42663/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/42663/checks
Files changed https://github.com/microsoft/TypeScript/pull/42663/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Gh 41788 incorrect output for esprivate with nested class in esnext https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#top
Show all changes 7 commits https://github.com/microsoft/TypeScript/pull/42663/files
dc5d50e If target:esnext,then useDefineForClassFields: true will now be the d… dragomirtitian Feb 4, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/dc5d50e3d37b37a2ff848205b8e9af655ed0d6e3
7809099 Added error if a private identifier is used in a static a initializer… dragomirtitian Feb 4, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
b3021b2 Added test for new useDefineForClassFields default and error message. dragomirtitian Feb 5, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/b3021b276fb7b6c6f86b31bdd09c6ad9c6c9d603
ce875d4 Fixed tests after changing the default of useDefineForClassFields to … dragomirtitian Feb 5, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/ce875d46b79dd20faa1fa9dcb06be4e75b4ae850
d1f480f Fixed code review suggestions. dragomirtitian Feb 5, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/d1f480f114c390f3d3890776de290ef4f39e78c8
a29bcb0 Updated error message. dragomirtitian Feb 25, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/a29bcb0948d003750309118c3631ed4743ee0779
dc0a347 Added missing static check for the containing property. Fixed other c… dragomirtitian Apr 5, 2021 https://github.com/microsoft/TypeScript/pull/42663/commits/dc0a3470dde9d84076249963f0d270b9da7e9532
Clear filters https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
checker.ts https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
diagnosticMessages.json https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
Prev https://github.com/microsoft/TypeScript/pull/42663/commits/dc5d50e3d37b37a2ff848205b8e9af655ed0d6e3
Next https://github.com/microsoft/TypeScript/pull/42663/commits/b3021b276fb7b6c6f86b31bdd09c6ad9c6c9d603
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc
https://github.com/dragomirtitian
dragomirtitianhttps://github.com/microsoft/TypeScript/commits?author=dragomirtitian
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/bloomberg/TypeScript/blob/78090999da4e4544fc7cb8fcfe1a1ef903f819dc/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/42663/commits/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/diagnosticMessages.jsonhttps://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
View file https://github.com/bloomberg/TypeScript/blob/78090999da4e4544fc7cb8fcfe1a1ef903f819dc/src/compiler/diagnosticMessages.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/42663/commits/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
https://github.com/microsoft/TypeScript/pull/42663/commits/78090999da4e4544fc7cb8fcfe1a1ef903f819dc#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.