René's URL Explorer Experiment


Title: Include all properties from the mapped modifier type when calculating… by weswigham · Pull Request #41976 · microsoft/TypeScript · GitHub

Open Graph Title: Include all properties from the mapped modifier type when calculating… by weswigham · Pull Request #41976 · microsoft/TypeScript

X Title: Include all properties from the mapped modifier type when calculating… by weswigham · Pull Request #41976 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Include all properties from the mapped modifier type when calculating… by weswigham · Pull Request #41976 · microsoft/TypeScript

Open Graph Description: … index types for mapped types with name types. Previously, when only inspecting the constraint, we'd miss the mapping for any properties which subtype reduced with the constraint. When we retu...

X Description: … index types for mapped types with name types. Previously, when only inspecting the constraint, we'd miss the mapping for any properties which subtype reduced with the constraint. When we ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/41976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6147b22-1063-3dfe-0624-31bd171724b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE72C:19F84C:2C27277:38219B5:6B019D74
html-safe-noncec1e771e1a57f8fe91781f2a3c536aeae85de9670de61340a93a0558e1d37a8f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzJDOjE5Rjg0QzoyQzI3Mjc3OjM4MjE5QjU6NkIwMTlENzQiLCJ2aXNpdG9yX2lkIjoiMTQ2MjMyNjEwNTY4Mjg0NTA0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac91b226ded0a8af0bdd8e28425d742654fd65e73f472df3dcf1dbc24060e7d705
hovercard-subject-tagpull_request:540709216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/41976/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f3011f506d204c42f2c508e744e81845b00ad352eebf6c9e7449305b6aef63a8/microsoft/TypeScript/pull/41976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f3011f506d204c42f2c508e744e81845b00ad352eebf6c9e7449305b6aef63a8/microsoft/TypeScript/pull/41976
og:image:alt… index types for mapped types with name types. Previously, when only inspecting the constraint, we'd miss the mapping for any properties which subtype reduced with the constraint. When we retu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/41976#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41976
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41976
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/41976
Reloadhttps://github.com/microsoft/TypeScript/pull/41976
Reloadhttps://github.com/microsoft/TypeScript/pull/41976
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:include-modifier-index-propshttps://github.com/weswigham/TypeScript/tree/include-modifier-index-props
Conversationhttps://github.com/microsoft/TypeScript/pull/41976
Commits2 (2)https://github.com/microsoft/TypeScript/pull/41976/commits
Checkshttps://github.com/microsoft/TypeScript/pull/41976/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/41976/files
Include all properties from the mapped modifier type when calculating…https://github.com/microsoft/TypeScript/pull/41976#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:include-modifier-index-propshttps://github.com/weswigham/TypeScript/tree/include-modifier-index-props
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issue-768190276
#41966https://github.com/microsoft/TypeScript/issues/41966
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/weswigham
Include all properties from the mapped modifier type when calculating…https://github.com/microsoft/TypeScript/pull/41976/commits/597a9c6ec439c57da5dfa4ab7cc2691eae555678
597a9c6https://github.com/microsoft/TypeScript/pull/41976/commits/597a9c6ec439c57da5dfa4ab7cc2691eae555678
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Andrew Branch (andrewbranch)https://github.com/andrewbranch
December 15, 2020 20:52https://github.com/microsoft/TypeScript/pull/41976#event-4116598784
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#event-4116599177
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#event-4116599253
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745560890
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745560919
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (@weswigham)https://github.com/weswigham
597a9c6https://github.com/microsoft/TypeScript/commit/597a9c6ec439c57da5dfa4ab7cc2691eae555678
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=91215
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745560920
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (@weswigham)https://github.com/weswigham
597a9c6https://github.com/microsoft/TypeScript/commit/597a9c6ec439c57da5dfa4ab7cc2691eae555678
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=91214
The results are in!https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745586796
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745560923
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (@weswigham)https://github.com/weswigham
597a9c6https://github.com/microsoft/TypeScript/commit/597a9c6ec439c57da5dfa4ab7cc2691eae555678
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=91216
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745567622
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745567643
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
597a9c6https://github.com/microsoft/TypeScript/commit/597a9c6ec439c57da5dfa4ab7cc2691eae555678
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=91217
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745586796
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020 https://github.com/microsoft/TypeScript/pull/41976#ref-pullrequest-768235089
🤖 User test baselines have changed for include-modifier-index-props typescript-bot/TypeScript#116 https://github.com/typescript-bot/TypeScript/pull/116
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745590568
PR with the baseline diff from masterhttps://github.com/typescript-bot/TypeScript/pull/116
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 15, 2020https://github.com/microsoft/TypeScript/pull/41976#issuecomment-745634275
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 13, 2021 https://github.com/microsoft/TypeScript/pull/41976#pullrequestreview-567748711
View reviewed changes https://github.com/microsoft/TypeScript/pull/41976/files/597a9c6ec439c57da5dfa4ab7cc2691eae555678
tests/baselines/reference/computedTypesKeyofNoIndexSignatureType.typeshttps://github.com/microsoft/TypeScript/pull/41976/files/597a9c6ec439c57da5dfa4ab7cc2691eae555678#diff-eb98351632f8622d44e94ee83acefb2349a39e74ee06c66716bc7f398ec7bf8a
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 13, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r556950942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 13, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r556951969
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 13, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r556953222
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 14, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r557602406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 14, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r557651148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 14, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r557725041
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 27, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r565628753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 27, 2021https://github.com/microsoft/TypeScript/pull/41976#discussion_r565634804
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 27, 2021 https://github.com/microsoft/TypeScript/pull/41976#pullrequestreview-577762186
View reviewed changes https://github.com/microsoft/TypeScript/pull/41976/files/597a9c6ec439c57da5dfa4ab7cc2691eae555678
https://github.com/weswigham
Merge branch 'master' into include-modifier-index-propshttps://github.com/microsoft/TypeScript/pull/41976/commits/335a4e39372d7885d3d1337f3badfa5903c7df70
335a4e3https://github.com/microsoft/TypeScript/pull/41976/commits/335a4e39372d7885d3d1337f3badfa5903c7df70
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
203a5cehttps://github.com/microsoft/TypeScript/commit/203a5ce78f1d9a378e8312e32956973f8334af8b
Jan 27, 2021https://github.com/microsoft/TypeScript/pull/41976#event-4258055508
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
January 27, 2021 21:32https://github.com/microsoft/TypeScript/pull/41976#event-4258055792
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 27, 2021 https://github.com/microsoft/TypeScript/pull/41976#ref-pullrequest-795491762
Use homomorphic templated type for Omit #42524 https://github.com/microsoft/TypeScript/pull/42524
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 17, 2021 https://github.com/microsoft/TypeScript/pull/41976#ref-pullrequest-998791548
keyof should always include remapped keys #45923 https://github.com/microsoft/TypeScript/pull/45923
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/41976#event-20417355481
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41976
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/41976/files/597a9c6ec439c57da5dfa4ab7cc2691eae555678
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
Using keyof with key remapping to exclude index signatures doesn't return known keys https://github.com/microsoft/TypeScript/issues/41966
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41976
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/RyanCavanaugh
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.