René's URL Explorer Experiment


Title: addImplementationSuccessElaboration admits declarations with no symbol by weswigham · Pull Request #41758 · microsoft/TypeScript · GitHub

Open Graph Title: addImplementationSuccessElaboration admits declarations with no symbol by weswigham · Pull Request #41758 · microsoft/TypeScript

X Title: addImplementationSuccessElaboration admits declarations with no symbol by weswigham · Pull Request #41758 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - addImplementationSuccessElaboration admits declarations with no symbol by weswigham · Pull Request #41758 · microsoft/TypeScript

Open Graph Description: shakes fist Our imprecise type of Declaration.symbol leads to a bug yet again! Fixes #41616

X Description: shakes fist Our imprecise type of Declaration.symbol leads to a bug yet again! Fixes #41616

Opengraph URL: https://github.com/microsoft/TypeScript/pull/41758

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7f231239-0953-e176-3f5f-7298280724a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BF8:311640:29F1BD4:3556C9C:6B01A9DF
html-safe-noncec04c833f9b08827d552451f743a7b9602ffce2a408557e9ca1728d24992c7152
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkY4OjMxMTY0MDoyOUYxQkQ0OjM1NTZDOUM6NkIwMUE5REYiLCJ2aXNpdG9yX2lkIjoiNTg3NjExODY3ODgzNjEyNjM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8f0b674a20520ec8cb405b0e00cd55524ece1100c8b78a3da93b62206a8135e3
hovercard-subject-tagpull_request:530472875
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/41758/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41758
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41758
og:image:altshakes fist Our imprecise type of Declaration.symbol leads to a bug yet again! Fixes #41616
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/41758#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41758
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41758
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/41758
Reloadhttps://github.com/microsoft/TypeScript/pull/41758
Reloadhttps://github.com/microsoft/TypeScript/pull/41758
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:fix-implementation-elaboration-crashhttps://github.com/weswigham/TypeScript/tree/fix-implementation-elaboration-crash
Conversationhttps://github.com/microsoft/TypeScript/pull/41758
Commits1 (1)https://github.com/microsoft/TypeScript/pull/41758/commits
Checkshttps://github.com/microsoft/TypeScript/pull/41758/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/41758/files
addImplementationSuccessElaboration admits declarations with no symbolhttps://github.com/microsoft/TypeScript/pull/41758#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:fix-implementation-elaboration-crashhttps://github.com/weswigham/TypeScript/tree/fix-implementation-elaboration-crash
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#issue-754601271
#41616https://github.com/microsoft/TypeScript/issues/41616
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/weswigham
addImplementationSuccessElaboration admits declarations with no symbolhttps://github.com/microsoft/TypeScript/pull/41758/commits/0d61b143cbba18a635d5b4db77467058dca19bf2
0d61b14https://github.com/microsoft/TypeScript/pull/41758/commits/0d61b143cbba18a635d5b4db77467058dca19bf2
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 1, 2020 17:50https://github.com/microsoft/TypeScript/pull/41758#event-4058478755
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#event-4058479645
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#event-4058479718
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Dec 1, 2020 https://github.com/microsoft/TypeScript/pull/41758#pullrequestreview-542248615
View reviewed changes https://github.com/microsoft/TypeScript/pull/41758/files/0d61b143cbba18a635d5b4db77467058dca19bf2
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-736794744
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-736794790
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
Wesley Wigham (@weswigham)https://github.com/weswigham
0d61b14https://github.com/microsoft/TypeScript/commit/0d61b143cbba18a635d5b4db77467058dca19bf2
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=90078
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
2a3f550https://github.com/microsoft/TypeScript/commit/2a3f5508eca2b12c8b677b5966c66e4a282c1e47
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#event-4059050369
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-736797301
Wesley Wigham (@weswigham)https://github.com/weswigham
You can check the log herehttps://typescript.visualstudio.com/TypeScript/_build/index?buildId=90078&_a=summary
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-commit-07d56fb
https://github.com/weswigham
addImplementationSuccessElaboration admits declarations with no symbol (https://github.com/weswigham/TypeScript/commit/07d56fb01d7937d78611388b1fca9a0deea1b8a5
07d56fbhttps://github.com/weswigham/TypeScript/commit/07d56fb01d7937d78611388b1fca9a0deea1b8a5
microsoft#41758https://github.com/microsoft/TypeScript/pull/41758
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-pullrequest-754728820
Port #41758 into release-4.1 - addImplementationSuccessElaboration admits declarations with no symbol #41763 https://github.com/microsoft/TypeScript/pull/41763
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 7, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-740199817
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 7, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-740199875
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
Wesley Wigham (@weswigham)https://github.com/weswigham
0d61b14https://github.com/microsoft/TypeScript/commit/0d61b143cbba18a635d5b4db77467058dca19bf2
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=90570
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 7, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-pullrequest-758878142
🤖 Pick PR #41758 (addImplementationSuccessElaboration...) into release-4.1 #41862 https://github.com/microsoft/TypeScript/pull/41862
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 7, 2020https://github.com/microsoft/TypeScript/pull/41758#issuecomment-740201952
Wesley Wigham (@weswigham)https://github.com/weswigham
#41862https://github.com/microsoft/TypeScript/pull/41862
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 7, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-commit-ca7fe57
https://github.com/weswigham
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/ca7fe573794f240f2a0972a183f87acab5aa0b5f
microsoft#41758https://github.com/microsoft/TypeScript/pull/41758
into release-4.1https://github.com/typescript-bot/TypeScript/commit/ca7fe573794f240f2a0972a183f87acab5aa0b5f
ca7fe57https://github.com/typescript-bot/TypeScript/commit/ca7fe573794f240f2a0972a183f87acab5aa0b5f
0d61b14https://github.com/typescript-bot/TypeScript/commit/0d61b143cbba18a635d5b4db77467058dca19bf2
https://github.com/remcohaszing
Remco Haszing (remcohaszing)https://github.com/remcohaszing
Dec 9, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-issue-747788587
Generic React HOC: TypeError: Cannot read property 'declarations' of undefined #41616 https://github.com/microsoft/TypeScript/issues/41616
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 9, 2020 https://github.com/microsoft/TypeScript/pull/41758#ref-commit-1e9518c
https://github.com/weswigham
Cherry-pick PRhttps://github.com/microsoft/TypeScript/commit/1e9518cb3531704145c038b469cbe38e3368e023
#41758https://github.com/microsoft/TypeScript/pull/41758
into release-4.1 (https://github.com/microsoft/TypeScript/commit/1e9518cb3531704145c038b469cbe38e3368e023
#41862https://github.com/microsoft/TypeScript/pull/41862
)https://github.com/microsoft/TypeScript/commit/1e9518cb3531704145c038b469cbe38e3368e023
1e9518chttps://github.com/microsoft/TypeScript/commit/1e9518cb3531704145c038b469cbe38e3368e023
0d61b14https://github.com/microsoft/TypeScript/commit/0d61b143cbba18a635d5b4db77467058dca19bf2
https://github.com/apps/dependabot
dependabothttps://github.com/apps/dependabot
Mar 14, 2021 https://github.com/microsoft/TypeScript/pull/41758#ref-pullrequest-831071852
Bump typescript from 4.0.7 to 4.1.5 in /frontend DhruvGheewala/Decoder#122 https://github.com/DhruvGheewala/Decoder/pull/122
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/41758#event-20417070035
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41758
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/41758/files/0d61b143cbba18a635d5b4db77467058dca19bf2
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Generic React HOC: TypeError: Cannot read property 'declarations' of undefined https://github.com/microsoft/TypeScript/issues/41616
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41758
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.