| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:165f6c5a-1c1f-c563-ec23-4125b34fdcc5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D16E:34DB8F:2428236:305B037:6B01A386 |
| html-safe-nonce | a0162e11ab26e13c96884be8df5dff5e4aeee62584a5ac6a3ad386d0246709ca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTZFOjM0REI4RjoyNDI4MjM2OjMwNUIwMzc6NkIwMUEzODYiLCJ2aXNpdG9yX2lkIjoiNTQwNTA2OTU2MzMwMzkyODcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ae9d3b7068a437416ed207548904ec47b84e26cd63a2e41c2372a93c482f828f |
| hovercard-subject-tag | pull_request:530454633 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/41757/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41757 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41757 |
| og:image:alt | And, perhaps more importantly, fixes a crash caused by the interaction of the module or system transformers and the new jsx transforms discovered along the way (in the same test case).
Fixes #41754 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | weswigham |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/41757#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/41757 |
| Reload | https://github.com/microsoft/TypeScript/pull/41757 |
| Reload | https://github.com/microsoft/TypeScript/pull/41757 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| weswigham:fix-jsx-preserve-comment-emit | https://github.com/weswigham/TypeScript/tree/fix-jsx-preserve-comment-emit |
| Conversation | https://github.com/microsoft/TypeScript/pull/41757 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/41757/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/41757/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/41757/files |
| Under jsx: preserve, actually preserve expressions which contain only comments | https://github.com/microsoft/TypeScript/pull/41757#top |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| weswigham:fix-jsx-preserve-comment-emit | https://github.com/weswigham/TypeScript/tree/fix-jsx-preserve-comment-emit |
|
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#issue-754578631 |
| #41754 | https://github.com/microsoft/TypeScript/issues/41754 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
|
| https://github.com/weswigham |
| Under jsx: preserve, actually preserve expressions which contain only… | https://github.com/microsoft/TypeScript/pull/41757/commits/b35a401f65d62bca1d506a6f03e46139abae222c |
| b35a401 | https://github.com/microsoft/TypeScript/pull/41757/commits/b35a401f65d62bca1d506a6f03e46139abae222c |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| December 1, 2020 17:17 | https://github.com/microsoft/TypeScript/pull/41757#event-4058336296 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#event-4058337348 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#event-4058337408 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Dec 1, 2020
| https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-542128994 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r533588266 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Dec 2, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r534522013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 2, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r534532694 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Dec 1, 2020
| https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-542134362 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c |
| src/compiler/transformers/module/module.ts | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r533592476 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 1, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r533599813 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| This comment | https://github.com/microsoft/TypeScript/issues/41616#issuecomment-735690427 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Dec 2, 2020
| https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-543283756 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-543283756 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=preserve,module=commonjs).js | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-296b67b97ebcdf8c1ae199dcc6a42e76dc705a140a14b90eda6d92f710c29046 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Dec 2, 2020 | https://github.com/microsoft/TypeScript/pull/41757#discussion_r534522013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| tests/cases/compiler/commentsOnJSXExpressionsArePreserved.tsx | https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-41c626c1b9e41af254a4847b3340781046d75e9472002959a568dd0d0a0f9235 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Dec 8, 2020 | https://github.com/microsoft/TypeScript/pull/41757#event-4086558469 |
|
| https://github.com/weswigham |
| Even better best effort comment preservation in JSX comments | https://github.com/microsoft/TypeScript/pull/41757/commits/d1db247fa281935707a097a6eb1b1524d508773a |
| d1db247 | https://github.com/microsoft/TypeScript/pull/41757/commits/d1db247fa281935707a097a6eb1b1524d508773a |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| force-pushed | https://github.com/microsoft/TypeScript/compare/e358fc907c453763485ae5886b64a9f76e39545b..d1db247fa281935707a097a6eb1b1524d508773a |
| e358fc9 | https://github.com/microsoft/TypeScript/commit/e358fc907c453763485ae5886b64a9f76e39545b |
| d1db247 | https://github.com/microsoft/TypeScript/commit/d1db247fa281935707a097a6eb1b1524d508773a |
|
Compare
| https://github.com/microsoft/TypeScript/compare/e358fc907c453763485ae5886b64a9f76e39545b..d1db247fa281935707a097a6eb1b1524d508773a |
| December 8, 2020 20:16 | https://github.com/microsoft/TypeScript/pull/41757#event-4086575957 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 8, 2020 | https://github.com/microsoft/TypeScript/pull/41757#issuecomment-740969028 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Dec 8, 2020 | https://github.com/microsoft/TypeScript/pull/41757#issuecomment-740969110 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| d1db247 | https://github.com/microsoft/TypeScript/commit/d1db247fa281935707a097a6eb1b1524d508773a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=90684 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741093740 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Dec 8, 2020 | https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741093740 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Dec 8, 2020 | https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741155916 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Dec 18, 2020
| https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-555670375 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/41757/files/d1db247fa281935707a097a6eb1b1524d508773a |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| c3ff0d4 | https://github.com/microsoft/TypeScript/commit/c3ff0d4c17da17d5a08033dab5f4b6fc9c3e9f4e |
| Dec 18, 2020 | https://github.com/microsoft/TypeScript/pull/41757#event-4131222959 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/41757#event-20417070000 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/41757/files/d1db247fa281935707a097a6eb1b1524d508773a |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
PR Backlog
| https://github.com/orgs/microsoft/projects/1252 |
|
Comments within JSX Expressions are not preserved
| https://github.com/microsoft/TypeScript/issues/41754 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/41757 |
|
| https://github.com/weswigham |
|
| https://github.com/typescript-bot |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |