René's URL Explorer Experiment


Title: Under jsx: preserve, actually preserve expressions which contain only comments by weswigham · Pull Request #41757 · microsoft/TypeScript · GitHub

Open Graph Title: Under jsx: preserve, actually preserve expressions which contain only comments by weswigham · Pull Request #41757 · microsoft/TypeScript

X Title: Under jsx: preserve, actually preserve expressions which contain only comments by weswigham · Pull Request #41757 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Under jsx: preserve, actually preserve expressions which contain only comments by weswigham · Pull Request #41757 · microsoft/TypeScript

Open Graph Description: And, perhaps more importantly, fixes a crash caused by the interaction of the module or system transformers and the new jsx transforms discovered along the way (in the same test case). Fixes #41754

X Description: And, perhaps more importantly, fixes a crash caused by the interaction of the module or system transformers and the new jsx transforms discovered along the way (in the same test case). Fixes #41754

Opengraph URL: https://github.com/microsoft/TypeScript/pull/41757

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:165f6c5a-1c1f-c563-ec23-4125b34fdcc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD16E:34DB8F:2428236:305B037:6B01A386
html-safe-noncea0162e11ab26e13c96884be8df5dff5e4aeee62584a5ac6a3ad386d0246709ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTZFOjM0REI4RjoyNDI4MjM2OjMwNUIwMzc6NkIwMUEzODYiLCJ2aXNpdG9yX2lkIjoiNTQwNTA2OTU2MzMwMzkyODcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacae9d3b7068a437416ed207548904ec47b84e26cd63a2e41c2372a93c482f828f
hovercard-subject-tagpull_request:530454633
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/41757/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41757
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc2894d43c1ee80f642c247ef8882f0481c0a6bd4a0f4c49d1bfd0e6da7473f3/microsoft/TypeScript/pull/41757
og:image:altAnd, perhaps more importantly, fixes a crash caused by the interaction of the module or system transformers and the new jsx transforms discovered along the way (in the same test case). Fixes #41754
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/41757#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/41757
Reloadhttps://github.com/microsoft/TypeScript/pull/41757
Reloadhttps://github.com/microsoft/TypeScript/pull/41757
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:fix-jsx-preserve-comment-emithttps://github.com/weswigham/TypeScript/tree/fix-jsx-preserve-comment-emit
Conversationhttps://github.com/microsoft/TypeScript/pull/41757
Commits2 (2)https://github.com/microsoft/TypeScript/pull/41757/commits
Checkshttps://github.com/microsoft/TypeScript/pull/41757/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/41757/files
Under jsx: preserve, actually preserve expressions which contain only commentshttps://github.com/microsoft/TypeScript/pull/41757#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:fix-jsx-preserve-comment-emithttps://github.com/weswigham/TypeScript/tree/fix-jsx-preserve-comment-emit
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#issue-754578631
#41754https://github.com/microsoft/TypeScript/issues/41754
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/weswigham
Under jsx: preserve, actually preserve expressions which contain only…https://github.com/microsoft/TypeScript/pull/41757/commits/b35a401f65d62bca1d506a6f03e46139abae222c
b35a401https://github.com/microsoft/TypeScript/pull/41757/commits/b35a401f65d62bca1d506a6f03e46139abae222c
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Ron Buckton (rbuckton)https://github.com/rbuckton
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 1, 2020 17:17https://github.com/microsoft/TypeScript/pull/41757#event-4058336296
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#event-4058337348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#event-4058337408
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020 https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-542128994
View reviewed changes https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r533588266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 2, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r534522013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 2, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r534532694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020 https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-542134362
View reviewed changes https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r533592476
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 1, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r533599813
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
This commenthttps://github.com/microsoft/TypeScript/issues/41616#issuecomment-735690427
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 2, 2020 https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-543283756
View reviewed changes https://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-543283756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=preserve,module=commonjs).jshttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-296b67b97ebcdf8c1ae199dcc6a42e76dc705a140a14b90eda6d92f710c29046
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 2, 2020https://github.com/microsoft/TypeScript/pull/41757#discussion_r534522013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
tests/cases/compiler/commentsOnJSXExpressionsArePreserved.tsxhttps://github.com/microsoft/TypeScript/pull/41757/files/b35a401f65d62bca1d506a6f03e46139abae222c#diff-41c626c1b9e41af254a4847b3340781046d75e9472002959a568dd0d0a0f9235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Dec 8, 2020https://github.com/microsoft/TypeScript/pull/41757#event-4086558469
https://github.com/weswigham
Even better best effort comment preservation in JSX commentshttps://github.com/microsoft/TypeScript/pull/41757/commits/d1db247fa281935707a097a6eb1b1524d508773a
d1db247https://github.com/microsoft/TypeScript/pull/41757/commits/d1db247fa281935707a097a6eb1b1524d508773a
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/e358fc907c453763485ae5886b64a9f76e39545b..d1db247fa281935707a097a6eb1b1524d508773a
e358fc9https://github.com/microsoft/TypeScript/commit/e358fc907c453763485ae5886b64a9f76e39545b
d1db247https://github.com/microsoft/TypeScript/commit/d1db247fa281935707a097a6eb1b1524d508773a
Compare https://github.com/microsoft/TypeScript/compare/e358fc907c453763485ae5886b64a9f76e39545b..d1db247fa281935707a097a6eb1b1524d508773a
December 8, 2020 20:16https://github.com/microsoft/TypeScript/pull/41757#event-4086575957
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 8, 2020https://github.com/microsoft/TypeScript/pull/41757#issuecomment-740969028
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 8, 2020https://github.com/microsoft/TypeScript/pull/41757#issuecomment-740969110
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
Wesley Wigham (@weswigham)https://github.com/weswigham
d1db247https://github.com/microsoft/TypeScript/commit/d1db247fa281935707a097a6eb1b1524d508773a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=90684
The results are in!https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741093740
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 8, 2020https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741093740
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 8, 2020https://github.com/microsoft/TypeScript/pull/41757#issuecomment-741155916
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 18, 2020 https://github.com/microsoft/TypeScript/pull/41757#pullrequestreview-555670375
View reviewed changes https://github.com/microsoft/TypeScript/pull/41757/files/d1db247fa281935707a097a6eb1b1524d508773a
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
c3ff0d4https://github.com/microsoft/TypeScript/commit/c3ff0d4c17da17d5a08033dab5f4b6fc9c3e9f4e
Dec 18, 2020https://github.com/microsoft/TypeScript/pull/41757#event-4131222959
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/41757#event-20417070000
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F41757
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/41757/files/d1db247fa281935707a097a6eb1b1524d508773a
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
Comments within JSX Expressions are not preserved https://github.com/microsoft/TypeScript/issues/41754
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/41757
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.