| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6a4e41e6-25d7-eac7-707e-eda948c9fcee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4EC:2E3FEE:9AAE5B:C5374C:6B00EFA7 |
| html-safe-nonce | 7b79136a72d00d62a430af873bc47797b694211db1f792d1731abe4c8a436630 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEVDOjJFM0ZFRTo5QUFFNUI6QzUzNzRDOjZCMDBFRkE3IiwidmlzaXRvcl9pZCI6IjExNDY2Mzg3NjM4MTY5NzIyMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2165b7efda03a8cb2cdbeb1dd1d06e408f2f7af6d3d56c9651d7b13e2ec8908b |
| hovercard-subject-tag | pull_request:41740650 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/4174/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/83bdb15197e5cb76250649da632a3afb6fb38ae4683069e498049f58276305ab/microsoft/TypeScript/pull/4174 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/83bdb15197e5cb76250649da632a3afb6fb38ae4683069e498049f58276305ab/microsoft/TypeScript/pull/4174 |
| og:image:alt | Fixes #2341.
Changes:
1 - Allows private, protected and public accessibilities on constructors.
2 - Disallows classes with private constructors from being extended.
3 - Now throws an error on const... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AbubakerB |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/4174#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/4174 |
| Reload | https://github.com/microsoft/TypeScript/pull/4174 |
| Reload | https://github.com/microsoft/TypeScript/pull/4174 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| Conversation | https://github.com/microsoft/TypeScript/pull/4174 |
| Commits14 (14) | https://github.com/microsoft/TypeScript/pull/4174/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/4174/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/4174/files |
| Allow visibility on constructors | https://github.com/microsoft/TypeScript/pull/4174#top |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
|
| https://github.com/AbubakerB |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Aug 6, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issue-99326410 |
| #2341 | https://github.com/microsoft/TypeScript/issues/2341 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| August 6, 2015 00:48 | https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-708f423 |
|
| https://github.com/AbubakerB |
| Fixes issue | https://github.com/microsoft/TypeScript/pull/4174/commits/708f4233e256a96c59d5336d94076e91fe28db97 |
| #2341 | https://github.com/microsoft/TypeScript/issues/2341 |
| 708f423 | https://github.com/microsoft/TypeScript/pull/4174/commits/708f4233e256a96c59d5336d94076e91fe28db97 |
|
| https://github.com/AbubakerB |
| Add tests for issue | https://github.com/microsoft/TypeScript/pull/4174/commits/9dfa9c72edd4aa40fada47fb9deb992b29a77303 |
| #2341 | https://github.com/microsoft/TypeScript/issues/2341 |
| 9dfa9c7 | https://github.com/microsoft/TypeScript/pull/4174/commits/9dfa9c72edd4aa40fada47fb9deb992b29a77303 |
|
| https://github.com/AbubakerB |
| Accept baselines | https://github.com/microsoft/TypeScript/pull/4174/commits/6d01766acd2aeeac59b0ff936d954a9459a9c770 |
| 6d01766 | https://github.com/microsoft/TypeScript/pull/4174/commits/6d01766acd2aeeac59b0ff936d954a9459a9c770 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
| Aug 6, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-128191710 |
| Abubaker Bashir (@AbubakerB) | https://github.com/AbubakerB |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-signed
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-signed |
| Aug 6, 2015 | https://github.com/microsoft/TypeScript/pull/4174#event-374802426 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Aug 6, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-128535797 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| August 12, 2015 00:13 | https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-7105a41 |
|
| https://github.com/AbubakerB |
| Add check on construct signature and relevant test cases. | https://github.com/microsoft/TypeScript/pull/4174/commits/7105a41016d630c3b8436de901bfad662d7c0b02 |
| 7105a41 | https://github.com/microsoft/TypeScript/pull/4174/commits/7105a41016d630c3b8436de901bfad662d7c0b02 |
|
| https://github.com/AbubakerB |
| Refactor constructor call visibility check | https://github.com/microsoft/TypeScript/pull/4174/commits/51bf39598ce38ea422de127c2cc6384a8a92ccdd |
| 51bf395 | https://github.com/microsoft/TypeScript/pull/4174/commits/51bf39598ce38ea422de127c2cc6384a8a92ccdd |
|
| https://github.com/AbubakerB |
| Clean ups! | https://github.com/microsoft/TypeScript/pull/4174/commits/c87c3c5eba68b3e349affb3d1571b951d4e478d2 |
| c87c3c5 | https://github.com/microsoft/TypeScript/pull/4174/commits/c87c3c5eba68b3e349affb3d1571b951d4e478d2 |
|
| https://github.com/AbubakerB |
| null check and only check signature visibility on Construct Kind. | https://github.com/microsoft/TypeScript/pull/4174/commits/f66e66da35b93d305fa78c468ea850d2816f83d1 |
| f66e66d | https://github.com/microsoft/TypeScript/pull/4174/commits/f66e66da35b93d305fa78c468ea850d2816f83d1 |
|
| https://github.com/AbubakerB |
| Accept baselines | https://github.com/microsoft/TypeScript/pull/4174/commits/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb |
| 5421ac8 | https://github.com/microsoft/TypeScript/pull/4174/commits/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb |
| https://github.com/AbubakerB |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Aug 12, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-130121958 |
| Ryan Cavanaugh (@RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.com/AbubakerB |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Sep 10, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139169425 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Sep 13, 2015
| https://github.com/microsoft/TypeScript/pull/4174#discussion-diff-39344958 |
| View reviewed changes
| https://github.com/microsoft/TypeScript/pull/4174/files/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/4174/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 13, 2015 | https://github.com/microsoft/TypeScript/pull/4174#discussion_r39344958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Sep 14, 2015 | https://github.com/microsoft/TypeScript/pull/4174#discussion_r39451133 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 13, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847026 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 13, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847104 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 13, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847133 |
| Abubaker Bashir (@AbubakerB) | https://github.com/AbubakerB |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Mohamed Hegazy (@mhegazy) | https://github.com/mhegazy |
| Vladimir Matveev (@vladima) | https://github.com/vladima |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| September 14, 2015 22:34 | https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-ffec744 |
|
| https://github.com/AbubakerB |
| Addressed CR feedback | https://github.com/microsoft/TypeScript/pull/4174/commits/ffec744c0ba1898bedbe3402e998755c22d13530 |
| ffec744 | https://github.com/microsoft/TypeScript/pull/4174/commits/ffec744c0ba1898bedbe3402e998755c22d13530 |
|
| https://github.com/AbubakerB |
| Changed error message for mismatching ctor signature | https://github.com/microsoft/TypeScript/pull/4174/commits/0e8ecbd94c8036b95ff2bbc5d744bfc33b25740e |
| 0e8ecbd | https://github.com/microsoft/TypeScript/pull/4174/commits/0e8ecbd94c8036b95ff2bbc5d744bfc33b25740e |
|
| https://github.com/AbubakerB |
| Addressed test PR feedback. | https://github.com/microsoft/TypeScript/pull/4174/commits/3732fcdbf12a2e7279f19b85b462a7ccec010f67 |
| 3732fcd | https://github.com/microsoft/TypeScript/pull/4174/commits/3732fcdbf12a2e7279f19b85b462a7ccec010f67 |
|
| https://github.com/AbubakerB |
| Accepted new baselines | https://github.com/microsoft/TypeScript/pull/4174/commits/f2d3b2939fbb650e9ec86370a089c1dfc201c11d |
| f2d3b29 | https://github.com/microsoft/TypeScript/pull/4174/commits/f2d3b2939fbb650e9ec86370a089c1dfc201c11d |
| https://github.com/AbubakerB |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Sep 14, 2015 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-140213780 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Sep 15, 2015
| https://github.com/microsoft/TypeScript/pull/4174#discussion-diff-39471300 |
| View reviewed changes
| https://github.com/microsoft/TypeScript/pull/4174/files/f2d3b2939fbb650e9ec86370a089c1dfc201c11d#diff-2db54e2e4b813dce2ab635ac33faf67cbad55448a795e1b6550b271064fac0d1 |
| tests/baselines/reference/classConstructorAccessibility.errors.txt | https://github.com/microsoft/TypeScript/pull/4174/files#diff-2db54e2e4b813dce2ab635ac33faf67cbad55448a795e1b6550b271064fac0d1 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 15, 2015 | https://github.com/microsoft/TypeScript/pull/4174#discussion_r39471300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| Sep 15, 2015 | https://github.com/microsoft/TypeScript/pull/4174#discussion_r39563631 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Abubaker Bashir (AbubakerB) | https://github.com/AbubakerB |
| September 15, 2015 21:51 | https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-35fceb9 |
|
| https://github.com/AbubakerB |
| Addressed PR feedback - Amended diagnostic messages | https://github.com/microsoft/TypeScript/pull/4174/commits/35fceb959b3e21f0817bf3c5047769b0de8e02db |
| 35fceb9 | https://github.com/microsoft/TypeScript/pull/4174/commits/35fceb959b3e21f0817bf3c5047769b0de8e02db |
|
| https://github.com/AbubakerB |
| Accept baselines | https://github.com/microsoft/TypeScript/pull/4174/commits/f6d8a0cb154a88bb1f5b9fd1c072d5c3141c2688 |
| f6d8a0c | https://github.com/microsoft/TypeScript/pull/4174/commits/f6d8a0cb154a88bb1f5b9fd1c072d5c3141c2688 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Jan 25, 2016 | https://github.com/microsoft/TypeScript/pull/4174#issuecomment-174588919 |
| Abubaker Bashir (@AbubakerB) | https://github.com/AbubakerB |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/4174 |
|
| https://github.com/AbubakerB |
|
| https://github.com/msftclas |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |