René's URL Explorer Experiment


Title: Allow visibility on constructors by AbubakerB · Pull Request #4174 · microsoft/TypeScript · GitHub

Open Graph Title: Allow visibility on constructors by AbubakerB · Pull Request #4174 · microsoft/TypeScript

X Title: Allow visibility on constructors by AbubakerB · Pull Request #4174 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Allow visibility on constructors by AbubakerB · Pull Request #4174 · microsoft/TypeScript

Open Graph Description: Fixes #2341. Changes: 1 - Allows private, protected and public accessibilities on constructors. 2 - Disallows classes with private constructors from being extended. 3 - Now throws an error on const...

X Description: Fixes #2341. Changes: 1 - Allows private, protected and public accessibilities on constructors. 2 - Disallows classes with private constructors from being extended. 3 - Now throws an error on const...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/4174

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6a4e41e6-25d7-eac7-707e-eda948c9fcee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4EC:2E3FEE:9AAE5B:C5374C:6B00EFA7
html-safe-nonce7b79136a72d00d62a430af873bc47797b694211db1f792d1731abe4c8a436630
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEVDOjJFM0ZFRTo5QUFFNUI6QzUzNzRDOjZCMDBFRkE3IiwidmlzaXRvcl9pZCI6IjExNDY2Mzg3NjM4MTY5NzIyMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2165b7efda03a8cb2cdbeb1dd1d06e408f2f7af6d3d56c9651d7b13e2ec8908b
hovercard-subject-tagpull_request:41740650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/4174/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/83bdb15197e5cb76250649da632a3afb6fb38ae4683069e498049f58276305ab/microsoft/TypeScript/pull/4174
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/83bdb15197e5cb76250649da632a3afb6fb38ae4683069e498049f58276305ab/microsoft/TypeScript/pull/4174
og:image:altFixes #2341. Changes: 1 - Allows private, protected and public accessibilities on constructors. 2 - Disallows classes with private constructors from being extended. 3 - Now throws an error on const...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAbubakerB
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/4174#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/4174
Reloadhttps://github.com/microsoft/TypeScript/pull/4174
Reloadhttps://github.com/microsoft/TypeScript/pull/4174
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
Conversationhttps://github.com/microsoft/TypeScript/pull/4174
Commits14 (14)https://github.com/microsoft/TypeScript/pull/4174/commits
Checkshttps://github.com/microsoft/TypeScript/pull/4174/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/4174/files
Allow visibility on constructorshttps://github.com/microsoft/TypeScript/pull/4174#top
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
https://github.com/AbubakerB
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Aug 6, 2015https://github.com/microsoft/TypeScript/pull/4174#issue-99326410
#2341https://github.com/microsoft/TypeScript/issues/2341
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
August 6, 2015 00:48https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-708f423
https://github.com/AbubakerB
Fixes issuehttps://github.com/microsoft/TypeScript/pull/4174/commits/708f4233e256a96c59d5336d94076e91fe28db97
#2341https://github.com/microsoft/TypeScript/issues/2341
708f423https://github.com/microsoft/TypeScript/pull/4174/commits/708f4233e256a96c59d5336d94076e91fe28db97
https://github.com/AbubakerB
Add tests for issuehttps://github.com/microsoft/TypeScript/pull/4174/commits/9dfa9c72edd4aa40fada47fb9deb992b29a77303
#2341https://github.com/microsoft/TypeScript/issues/2341
9dfa9c7https://github.com/microsoft/TypeScript/pull/4174/commits/9dfa9c72edd4aa40fada47fb9deb992b29a77303
https://github.com/AbubakerB
Accept baselineshttps://github.com/microsoft/TypeScript/pull/4174/commits/6d01766acd2aeeac59b0ff936d954a9459a9c770
6d01766https://github.com/microsoft/TypeScript/pull/4174/commits/6d01766acd2aeeac59b0ff936d954a9459a9c770
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
Aug 6, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-128191710
Abubaker Bashir (@AbubakerB)https://github.com/AbubakerB
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-signed
Aug 6, 2015https://github.com/microsoft/TypeScript/pull/4174#event-374802426
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Aug 6, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-128535797
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
August 12, 2015 00:13https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-7105a41
https://github.com/AbubakerB
Add check on construct signature and relevant test cases.https://github.com/microsoft/TypeScript/pull/4174/commits/7105a41016d630c3b8436de901bfad662d7c0b02
7105a41https://github.com/microsoft/TypeScript/pull/4174/commits/7105a41016d630c3b8436de901bfad662d7c0b02
https://github.com/AbubakerB
Refactor constructor call visibility checkhttps://github.com/microsoft/TypeScript/pull/4174/commits/51bf39598ce38ea422de127c2cc6384a8a92ccdd
51bf395https://github.com/microsoft/TypeScript/pull/4174/commits/51bf39598ce38ea422de127c2cc6384a8a92ccdd
https://github.com/AbubakerB
Clean ups!https://github.com/microsoft/TypeScript/pull/4174/commits/c87c3c5eba68b3e349affb3d1571b951d4e478d2
c87c3c5https://github.com/microsoft/TypeScript/pull/4174/commits/c87c3c5eba68b3e349affb3d1571b951d4e478d2
https://github.com/AbubakerB
null check and only check signature visibility on Construct Kind.https://github.com/microsoft/TypeScript/pull/4174/commits/f66e66da35b93d305fa78c468ea850d2816f83d1
f66e66dhttps://github.com/microsoft/TypeScript/pull/4174/commits/f66e66da35b93d305fa78c468ea850d2816f83d1
https://github.com/AbubakerB
Accept baselineshttps://github.com/microsoft/TypeScript/pull/4174/commits/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb
5421ac8https://github.com/microsoft/TypeScript/pull/4174/commits/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb
https://github.com/AbubakerB
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Aug 12, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-130121958
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/AbubakerB
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Sep 10, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139169425
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
DanielRosenwasserhttps://github.com/DanielRosenwasser
Sep 13, 2015 https://github.com/microsoft/TypeScript/pull/4174#discussion-diff-39344958
View reviewed changes https://github.com/microsoft/TypeScript/pull/4174/files/5421ac83e5f2f0f97c44b86f2d81c840cb4adfcb#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/4174/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 13, 2015https://github.com/microsoft/TypeScript/pull/4174#discussion_r39344958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Sep 14, 2015https://github.com/microsoft/TypeScript/pull/4174#discussion_r39451133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 13, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847026
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 13, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847104
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 13, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-139847133
Abubaker Bashir (@AbubakerB)https://github.com/AbubakerB
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
September 14, 2015 22:34https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-ffec744
https://github.com/AbubakerB
Addressed CR feedbackhttps://github.com/microsoft/TypeScript/pull/4174/commits/ffec744c0ba1898bedbe3402e998755c22d13530
ffec744https://github.com/microsoft/TypeScript/pull/4174/commits/ffec744c0ba1898bedbe3402e998755c22d13530
https://github.com/AbubakerB
Changed error message for mismatching ctor signaturehttps://github.com/microsoft/TypeScript/pull/4174/commits/0e8ecbd94c8036b95ff2bbc5d744bfc33b25740e
0e8ecbdhttps://github.com/microsoft/TypeScript/pull/4174/commits/0e8ecbd94c8036b95ff2bbc5d744bfc33b25740e
https://github.com/AbubakerB
Addressed test PR feedback.https://github.com/microsoft/TypeScript/pull/4174/commits/3732fcdbf12a2e7279f19b85b462a7ccec010f67
3732fcdhttps://github.com/microsoft/TypeScript/pull/4174/commits/3732fcdbf12a2e7279f19b85b462a7ccec010f67
https://github.com/AbubakerB
Accepted new baselineshttps://github.com/microsoft/TypeScript/pull/4174/commits/f2d3b2939fbb650e9ec86370a089c1dfc201c11d
f2d3b29https://github.com/microsoft/TypeScript/pull/4174/commits/f2d3b2939fbb650e9ec86370a089c1dfc201c11d
https://github.com/AbubakerB
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Sep 14, 2015https://github.com/microsoft/TypeScript/pull/4174#issuecomment-140213780
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
DanielRosenwasserhttps://github.com/DanielRosenwasser
Sep 15, 2015 https://github.com/microsoft/TypeScript/pull/4174#discussion-diff-39471300
View reviewed changes https://github.com/microsoft/TypeScript/pull/4174/files/f2d3b2939fbb650e9ec86370a089c1dfc201c11d#diff-2db54e2e4b813dce2ab635ac33faf67cbad55448a795e1b6550b271064fac0d1
tests/baselines/reference/classConstructorAccessibility.errors.txthttps://github.com/microsoft/TypeScript/pull/4174/files#diff-2db54e2e4b813dce2ab635ac33faf67cbad55448a795e1b6550b271064fac0d1
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 15, 2015https://github.com/microsoft/TypeScript/pull/4174#discussion_r39471300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
Sep 15, 2015https://github.com/microsoft/TypeScript/pull/4174#discussion_r39563631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Abubaker Bashir (AbubakerB)https://github.com/AbubakerB
September 15, 2015 21:51https://github.com/microsoft/TypeScript/pull/4174#commits-pushed-35fceb9
https://github.com/AbubakerB
Addressed PR feedback - Amended diagnostic messageshttps://github.com/microsoft/TypeScript/pull/4174/commits/35fceb959b3e21f0817bf3c5047769b0de8e02db
35fceb9https://github.com/microsoft/TypeScript/pull/4174/commits/35fceb959b3e21f0817bf3c5047769b0de8e02db
https://github.com/AbubakerB
Accept baselineshttps://github.com/microsoft/TypeScript/pull/4174/commits/f6d8a0cb154a88bb1f5b9fd1c072d5c3141c2688
f6d8a0chttps://github.com/microsoft/TypeScript/pull/4174/commits/f6d8a0cb154a88bb1f5b9fd1c072d5c3141c2688
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jan 25, 2016https://github.com/microsoft/TypeScript/pull/4174#issuecomment-174588919
Abubaker Bashir (@AbubakerB)https://github.com/AbubakerB
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F4174
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/4174
https://github.com/AbubakerB
https://github.com/msftclas
https://github.com/RyanCavanaugh
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.