René's URL Explorer Experiment


Title: Alias for commonjs require in JS by sandersn · Pull Request #39770 · microsoft/TypeScript · GitHub

Open Graph Title: Alias for commonjs require in JS by sandersn · Pull Request #39770 · microsoft/TypeScript

X Title: Alias for commonjs require in JS by sandersn · Pull Request #39770 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Alias for commonjs require in JS by sandersn · Pull Request #39770 · microsoft/TypeScript

Open Graph Description: This PR binds commonjs const x = require('y') statements the same way as TS import x = require('y'): as an alias. This improves the consistency of JS, and should fix a number of bug...

X Description: This PR binds commonjs const x = require('y') statements the same way as TS import x = require('y'): as an alias. This improves the consistency of JS, and should fix...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/39770

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c744fc1d-265a-1284-85ff-d834d1de5ab9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9028:2E7EBB:2974FC8:346CCD8:6B019AFF
html-safe-nonce2684f778eaeb15aa85eef5d33de2c3fe37a9d835d8cc7028978695954f4837f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDI4OjJFN0VCQjoyOTc0RkM4OjM0NkNDRDg6NkIwMTlBRkYiLCJ2aXNpdG9yX2lkIjoiODE5NDM2Nzg3MzkwNTQzMzM0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9dc6ea806857e8ff877f2698859b4f3e8e68ec0ba8a96ee7034150a3861024b5
hovercard-subject-tagpull_request:457314079
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/39770/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50786ce691e0068efae68b86f27065fa1c75e1adcd54f9647308531cff379234/microsoft/TypeScript/pull/39770
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50786ce691e0068efae68b86f27065fa1c75e1adcd54f9647308531cff379234/microsoft/TypeScript/pull/39770
og:image:altThis PR binds commonjs const x = require('y') statements the same way as TS import x = require('y'): as an alias. This improves the consistency of JS, and should fix a number of bug...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/39770#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/39770
Reloadhttps://github.com/microsoft/TypeScript/pull/39770
Reloadhttps://github.com/microsoft/TypeScript/pull/39770
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
alias-for-requirehttps://github.com/microsoft/TypeScript/tree/alias-for-require
Conversationhttps://github.com/microsoft/TypeScript/pull/39770
Commits39 (39)https://github.com/microsoft/TypeScript/pull/39770/commits
Checkshttps://github.com/microsoft/TypeScript/pull/39770/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/39770/files
Alias for commonjs require in JShttps://github.com/microsoft/TypeScript/pull/39770#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
alias-for-requirehttps://github.com/microsoft/TypeScript/tree/alias-for-require
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#issue-666477609
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
#38379https://github.com/microsoft/TypeScript/issues/38379
#37000https://github.com/microsoft/TypeScript/issues/37000
#25533https://github.com/microsoft/TypeScript/issues/25533
Generating Type Definitions from Javascript is blocked by requiring private name #37832https://github.com/microsoft/TypeScript/issues/37832
Go to definition shows Node require statement as definition #39895https://github.com/microsoft/TypeScript/issues/39895
JSDOC @type tag crashes with simple export #36830https://github.com/microsoft/TypeScript/issues/36830
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
July 8, 2020 17:00https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-4f9ccd0
https://github.com/sandersn
First attempt at aliases for requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/4f9ccd0e5f447fd2022307f5c722686b978f4973
4f9ccd0https://github.com/microsoft/TypeScript/pull/39770/commits/4f9ccd0e5f447fd2022307f5c722686b978f4973
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/d6923878ecdaef8c2cab843e99df147bf087a85a
d692387https://github.com/microsoft/TypeScript/pull/39770/commits/d6923878ecdaef8c2cab843e99df147bf087a85a
https://github.com/sandersn
test+initial support for const x=requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/277d52ad2d738ec75495006d3c77e67db17e6c55
277d52ahttps://github.com/microsoft/TypeScript/pull/39770/commits/277d52ad2d738ec75495006d3c77e67db17e6c55
https://github.com/sandersn
1st round of baseline improvementshttps://github.com/microsoft/TypeScript/pull/39770/commits/bcdc2e4a97263b1aedafc4f325bb7003f8065095
bcdc2e4https://github.com/microsoft/TypeScript/pull/39770/commits/bcdc2e4a97263b1aedafc4f325bb7003f8065095
https://github.com/sandersn
2nd round of baseline updateshttps://github.com/microsoft/TypeScript/pull/39770/commits/20aa6ed7eb4a60371acb5daf61b36e80d4c73b70
20aa6edhttps://github.com/microsoft/TypeScript/pull/39770/commits/20aa6ed7eb4a60371acb5daf61b36e80d4c73b70
https://github.com/sandersn
support property access after requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/f21370778c200fde6fa10787833097770d076e05
f213707https://github.com/microsoft/TypeScript/pull/39770/commits/f21370778c200fde6fa10787833097770d076e05
https://github.com/sandersn
checkhttps://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d
@typehttps://github.com/type
tag on requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d
122babdhttps://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/f32ec4ef39ec75238826fdee73db051d55d2806c
f32ec4ehttps://github.com/microsoft/TypeScript/pull/39770/commits/f32ec4ef39ec75238826fdee73db051d55d2806c
https://github.com/sandersn
forbid expando missing namespaces on aliaseshttps://github.com/microsoft/TypeScript/pull/39770/commits/e1e32af9e7f686f2cdd1dfd8e9d51fa3abeb2583
e1e32afhttps://github.com/microsoft/TypeScript/pull/39770/commits/e1e32af9e7f686f2cdd1dfd8e9d51fa3abeb2583
#39558https://github.com/microsoft/TypeScript/pull/39558
https://github.com/sandersn
accept error baselines that are good, actuallyhttps://github.com/microsoft/TypeScript/pull/39770/commits/4ddb3d08c7c2a8ef1503d973d2d04360e90273d9
4ddb3d0https://github.com/microsoft/TypeScript/pull/39770/commits/4ddb3d08c7c2a8ef1503d973d2d04360e90273d9
https://github.com/sandersn
Scribbling on d.ts emit codehttps://github.com/microsoft/TypeScript/pull/39770/commits/58a0b651b00876e0a854f24c29a3fb4f86e0353e
58a0b65https://github.com/microsoft/TypeScript/pull/39770/commits/58a0b651b00876e0a854f24c29a3fb4f86e0353e
https://github.com/sandersn
use getSpecifierForModuleSymbolhttps://github.com/microsoft/TypeScript/pull/39770/commits/d885b67acb8cadffbb40313124afa2a635a94d94
d885b67https://github.com/microsoft/TypeScript/pull/39770/commits/d885b67acb8cadffbb40313124afa2a635a94d94
https://github.com/sandersn
hideous hack for module.exports of aliaseshttps://github.com/microsoft/TypeScript/pull/39770/commits/5a0b092e4f8ee9beb46c779764a8d9d0fcddd0d6
5a0b092https://github.com/microsoft/TypeScript/pull/39770/commits/5a0b092e4f8ee9beb46c779764a8d9d0fcddd0d6
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/64c8c8662c8297b54fe3835ea755f6e144729952
64c8c86https://github.com/microsoft/TypeScript/pull/39770/commits/64c8c8662c8297b54fe3835ea755f6e144729952
https://github.com/sandersn
Fix module.exports.x --> export list emithttps://github.com/microsoft/TypeScript/pull/39770/commits/55a13b76364bd941715d24c632af746743480f67
55a13b7https://github.com/microsoft/TypeScript/pull/39770/commits/55a13b76364bd941715d24c632af746743480f67
https://github.com/sandersn
fix isLocalImport predicatehttps://github.com/microsoft/TypeScript/pull/39770/commits/7ce7c8cc7bedf952744d7347a7a99537f736a8e4
7ce7c8chttps://github.com/microsoft/TypeScript/pull/39770/commits/7ce7c8cc7bedf952744d7347a7a99537f736a8e4
https://github.com/sandersn
require only creates aliases in JShttps://github.com/microsoft/TypeScript/pull/39770/commits/ca5a57bd7aaf480ff916155331486dc6c55faaf8
ca5a57bhttps://github.com/microsoft/TypeScript/pull/39770/commits/ca5a57bd7aaf480ff916155331486dc6c55faaf8
https://github.com/sandersn
re-handle json importshttps://github.com/microsoft/TypeScript/pull/39770/commits/e9a355de57283d8e0bbd22043c4383edd7a5df52
e9a355dhttps://github.com/microsoft/TypeScript/pull/39770/commits/e9a355de57283d8e0bbd22043c4383edd7a5df52
https://github.com/sandersn
update fourslash baselinehttps://github.com/microsoft/TypeScript/pull/39770/commits/febcf0e326d716982ed499ea3bf0856d5a24ef2b
febcf0ehttps://github.com/microsoft/TypeScript/pull/39770/commits/febcf0e326d716982ed499ea3bf0856d5a24ef2b
https://github.com/sandersn
Cleanup in the checkerhttps://github.com/microsoft/TypeScript/pull/39770/commits/3ee9b6fe18388c8df296fff107df86e82ad98aa1
3ee9b6fhttps://github.com/microsoft/TypeScript/pull/39770/commits/3ee9b6fe18388c8df296fff107df86e82ad98aa1
https://github.com/sandersn
Function for getting module name from require callhttps://github.com/microsoft/TypeScript/pull/39770/commits/a671b454f4c86dd0aa65a695d8203e7ac39e30bc
a671b45https://github.com/microsoft/TypeScript/pull/39770/commits/a671b454f4c86dd0aa65a695d8203e7ac39e30bc
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/6dfbec3581878df4bf6cc09a013fb504f1706348
6dfbec3https://github.com/microsoft/TypeScript/pull/39770/commits/6dfbec3581878df4bf6cc09a013fb504f1706348
https://github.com/sandersn
First round of cleanup plus a new testhttps://github.com/microsoft/TypeScript/pull/39770/commits/0c922773a779dd6320dc8982e83fad91f900b9d6
0c92277https://github.com/microsoft/TypeScript/pull/39770/commits/0c922773a779dd6320dc8982e83fad91f900b9d6
https://github.com/sandersn
more small cleanuphttps://github.com/microsoft/TypeScript/pull/39770/commits/dee056103bd760c3343ec30264890b785fbd7c7b
dee0561https://github.com/microsoft/TypeScript/pull/39770/commits/dee056103bd760c3343ec30264890b785fbd7c7b
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#event-3590997774
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#event-3590997816
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020 https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-456010124
View reviewed changes https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r461068753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r461068971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r461073618
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 27, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r461074029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
Wesley Wigham (weswigham)https://github.com/weswigham
July 27, 2020 18:08https://github.com/microsoft/TypeScript/pull/39770#event-3591042270
https://github.com/elibarzilay
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
Aug 4, 2020 https://github.com/microsoft/TypeScript/pull/39770#ref-issue-497638002
jsdoc @enum with import/export #33575 https://github.com/microsoft/TypeScript/issues/33575
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/0694890011d5e117e662c3e7951b66601421d994
0694890https://github.com/microsoft/TypeScript/pull/39770/commits/0694890011d5e117e662c3e7951b66601421d994
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 11, 2020https://github.com/microsoft/TypeScript/pull/39770#issuecomment-672050646
#39818https://github.com/microsoft/TypeScript/pull/39818
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 11, 2020 https://github.com/microsoft/TypeScript/pull/39770#ref-issue-672479038
Go to definition shows Node require statement as definition #39895 https://github.com/microsoft/TypeScript/issues/39895
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 11, 2020 10:19https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-781bec2
https://github.com/sandersn
Code review comments, plus remove unneeded codehttps://github.com/microsoft/TypeScript/pull/39770/commits/781bec2c6a9c429079ebc32a90ebf41ac328ea8d
781bec2https://github.com/microsoft/TypeScript/pull/39770/commits/781bec2c6a9c429079ebc32a90ebf41ac328ea8d
https://github.com/sandersn
find all refs workshttps://github.com/microsoft/TypeScript/pull/39770/commits/2bfeeebb668f9bd108a9b7104c88b7bd76c1a26a
2bfeeebhttps://github.com/microsoft/TypeScript/pull/39770/commits/2bfeeebb668f9bd108a9b7104c88b7bd76c1a26a
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/0ba0d90da682f58a729e153ec8c5c8e7e10d8859
0ba0d90https://github.com/microsoft/TypeScript/pull/39770/commits/0ba0d90da682f58a729e153ec8c5c8e7e10d8859
https://github.com/sandersn
remove old ad-hoc codehttps://github.com/microsoft/TypeScript/pull/39770/commits/62e5b18749e8e85e4a59c5d16840ae6258a3b496
62e5b18https://github.com/microsoft/TypeScript/pull/39770/commits/62e5b18749e8e85e4a59c5d16840ae6258a3b496
https://github.com/sandersn
make it clear that old behaviour is not that correcthttps://github.com/microsoft/TypeScript/pull/39770/commits/2679b03609d080cab5b33ac437868449730a5add
2679b03https://github.com/microsoft/TypeScript/pull/39770/commits/2679b03609d080cab5b33ac437868449730a5add
https://github.com/sandersn
update api baselineshttps://github.com/microsoft/TypeScript/pull/39770/commits/03fb2d4f62d4148160663a66f861c635644b300a
03fb2d4https://github.com/microsoft/TypeScript/pull/39770/commits/03fb2d4f62d4148160663a66f861c635644b300a
https://github.com/sandersn
remove outdated commenthttps://github.com/microsoft/TypeScript/pull/39770/commits/7aeb306be64fa95523d3059a1ead00987f0750aa
7aeb306https://github.com/microsoft/TypeScript/pull/39770/commits/7aeb306be64fa95523d3059a1ead00987f0750aa
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020 https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-466950319
View reviewed changes https://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r470093393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/services/goToDefinition.tshttps://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a#diff-c42b4849ce43f3bc3fcbaec7e64a0cf93c78c61af0d499406a5dd295daf9a053
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r470094673
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
tests/cases/fourslash/goToDefinitionJsModuleNameAtImportName.tshttps://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-a9bfde6dcaf73317750b441a7cbfcb91997604e6af670a996e9b9e9da78914be
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r470101000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#issuecomment-673598263
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 13, 2020 https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-467129498
View reviewed changes https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-467129498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r470252869
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#discussion_r470254248
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/d2c0b3c66af7b2c8341e67c6be8307530fa44c62
d2c0b3chttps://github.com/microsoft/TypeScript/pull/39770/commits/d2c0b3c66af7b2c8341e67c6be8307530fa44c62
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 13, 2020https://github.com/microsoft/TypeScript/pull/39770#issuecomment-673726846
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 17, 2020 10:54https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-9d2ce87
https://github.com/sandersn
Merge branch 'master' into alias-for-requirehttps://github.com/microsoft/TypeScript/pull/39770/commits/9d2ce87bdcb7371904a06fb9e404d9d92ec58641
9d2ce87https://github.com/microsoft/TypeScript/pull/39770/commits/9d2ce87bdcb7371904a06fb9e404d9d92ec58641
https://github.com/sandersn
PR feedbackhttps://github.com/microsoft/TypeScript/pull/39770/commits/283a520f197256be06996a3a202a76de4f6b7706
283a520https://github.com/microsoft/TypeScript/pull/39770/commits/283a520f197256be06996a3a202a76de4f6b7706
https://github.com/sandersn
add a fail-case test (which passes!)https://github.com/microsoft/TypeScript/pull/39770/commits/6c7897e4d227ce492dedd2e7966d7d7a1aac18b5
6c7897ehttps://github.com/microsoft/TypeScript/pull/39770/commits/6c7897e4d227ce492dedd2e7966d7d7a1aac18b5
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
c3d41bbhttps://github.com/microsoft/TypeScript/commit/c3d41bbb735f1103352a92a0c0159f46055219c3
Aug 17, 2020https://github.com/microsoft/TypeScript/pull/39770#event-3663601338
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 17, 2020 21:00https://github.com/microsoft/TypeScript/pull/39770#event-3663601659
JSDOC @type tag crashes with simple export #36830 https://github.com/microsoft/TypeScript/issues/36830
Stop an infinite loop when using an exported JSDoc function as a type #38332 https://github.com/microsoft/TypeScript/pull/38332
https://github.com/JoostK
Joost Koehoorn (JoostK)https://github.com/JoostK
Nov 6, 2020 https://github.com/microsoft/TypeScript/pull/39770#ref-pullrequest-736530507
Support TypeScript 4.1 angular/angular#39571 https://github.com/angular/angular/pull/39571
https://github.com/a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk)https://github.com/a-tarasyuk
Nov 24, 2020 https://github.com/microsoft/TypeScript/pull/39770#ref-issue-748101438
TS >=4.1: Cannot assign because it is not a variable (require does not work with let anymore) #41628 https://github.com/microsoft/TypeScript/issues/41628
TS 4.1.2 Cannot find name 'FieldValue' (solved in 4.2) #41629 https://github.com/microsoft/TypeScript/issues/41629
[JS] accessing nested namespaces from require() with destructuring leads to an error #41699 https://github.com/microsoft/TypeScript/issues/41699
const/let variables with require() initializer are not correctly block-scoped #41697 https://github.com/microsoft/TypeScript/issues/41697
https://github.com/Derugon
Adrien LESÉNÉCHAL (Derugon)https://github.com/Derugon
Apr 4, 2025 https://github.com/microsoft/TypeScript/pull/39770#ref-issue-2971816849
JavaScript file: Shadowing require still behaves like the global one #61528 https://github.com/microsoft/TypeScript/issues/61528
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/39770#event-20417003807
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa
https://github.com/elibarzilay
Eli Barzilay (elibarzilay) https://github.com/elibarzilay
https://github.com/microsoft/TypeScript/pull/39770/files/a841988281a375281d5b93c5997e2b0403e60862
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Backlog Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
In JS, assertions imported via commonjs have bogus error https://github.com/microsoft/TypeScript/issues/38379
JS binding should create real aliases for module.exports https://github.com/microsoft/TypeScript/issues/37000
const x = require("m") should create an alias symbol https://github.com/microsoft/TypeScript/issues/25533
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39770
https://github.com/sandersn
https://github.com/elibarzilay
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.