| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c744fc1d-265a-1284-85ff-d834d1de5ab9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9028:2E7EBB:2974FC8:346CCD8:6B019AFF |
| html-safe-nonce | 2684f778eaeb15aa85eef5d33de2c3fe37a9d835d8cc7028978695954f4837f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDI4OjJFN0VCQjoyOTc0RkM4OjM0NkNDRDg6NkIwMTlBRkYiLCJ2aXNpdG9yX2lkIjoiODE5NDM2Nzg3MzkwNTQzMzM0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9dc6ea806857e8ff877f2698859b4f3e8e68ec0ba8a96ee7034150a3861024b5 |
| hovercard-subject-tag | pull_request:457314079 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/39770/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/50786ce691e0068efae68b86f27065fa1c75e1adcd54f9647308531cff379234/microsoft/TypeScript/pull/39770 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/50786ce691e0068efae68b86f27065fa1c75e1adcd54f9647308531cff379234/microsoft/TypeScript/pull/39770 |
| og:image:alt | This PR binds commonjs const x = require('y') statements the same way as TS import x = require('y'): as an alias. This improves the consistency of JS, and should fix a number of bug... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/39770#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/39770 |
| Reload | https://github.com/microsoft/TypeScript/pull/39770 |
| Reload | https://github.com/microsoft/TypeScript/pull/39770 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| alias-for-require | https://github.com/microsoft/TypeScript/tree/alias-for-require |
| Conversation | https://github.com/microsoft/TypeScript/pull/39770 |
| Commits39 (39) | https://github.com/microsoft/TypeScript/pull/39770/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/39770/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/39770/files |
| Alias for commonjs require in JS | https://github.com/microsoft/TypeScript/pull/39770#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| alias-for-require | https://github.com/microsoft/TypeScript/tree/alias-for-require |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#issue-666477609 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| #38379 | https://github.com/microsoft/TypeScript/issues/38379 |
| #37000 | https://github.com/microsoft/TypeScript/issues/37000 |
| #25533 | https://github.com/microsoft/TypeScript/issues/25533 |
| Generating Type Definitions from Javascript is blocked by requiring private name #37832 | https://github.com/microsoft/TypeScript/issues/37832 |
| Go to definition shows Node require statement as definition #39895 | https://github.com/microsoft/TypeScript/issues/39895 |
| JSDOC @type tag crashes with simple export #36830 | https://github.com/microsoft/TypeScript/issues/36830 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| July 8, 2020 17:00 | https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-4f9ccd0 |
|
| https://github.com/sandersn |
| First attempt at aliases for require | https://github.com/microsoft/TypeScript/pull/39770/commits/4f9ccd0e5f447fd2022307f5c722686b978f4973 |
| 4f9ccd0 | https://github.com/microsoft/TypeScript/pull/39770/commits/4f9ccd0e5f447fd2022307f5c722686b978f4973 |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/d6923878ecdaef8c2cab843e99df147bf087a85a |
| d692387 | https://github.com/microsoft/TypeScript/pull/39770/commits/d6923878ecdaef8c2cab843e99df147bf087a85a |
|
| https://github.com/sandersn |
| test+initial support for const x=require | https://github.com/microsoft/TypeScript/pull/39770/commits/277d52ad2d738ec75495006d3c77e67db17e6c55 |
| 277d52a | https://github.com/microsoft/TypeScript/pull/39770/commits/277d52ad2d738ec75495006d3c77e67db17e6c55 |
|
| https://github.com/sandersn |
| 1st round of baseline improvements | https://github.com/microsoft/TypeScript/pull/39770/commits/bcdc2e4a97263b1aedafc4f325bb7003f8065095 |
| bcdc2e4 | https://github.com/microsoft/TypeScript/pull/39770/commits/bcdc2e4a97263b1aedafc4f325bb7003f8065095 |
|
| https://github.com/sandersn |
| 2nd round of baseline updates | https://github.com/microsoft/TypeScript/pull/39770/commits/20aa6ed7eb4a60371acb5daf61b36e80d4c73b70 |
| 20aa6ed | https://github.com/microsoft/TypeScript/pull/39770/commits/20aa6ed7eb4a60371acb5daf61b36e80d4c73b70 |
|
| https://github.com/sandersn |
| support property access after require | https://github.com/microsoft/TypeScript/pull/39770/commits/f21370778c200fde6fa10787833097770d076e05 |
| f213707 | https://github.com/microsoft/TypeScript/pull/39770/commits/f21370778c200fde6fa10787833097770d076e05 |
|
| https://github.com/sandersn |
| check | https://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d |
| @type | https://github.com/type |
| tag on require | https://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d |
| 122babd | https://github.com/microsoft/TypeScript/pull/39770/commits/122babdcf2d11793ed001f79b9baf7143d6f596d |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/f32ec4ef39ec75238826fdee73db051d55d2806c |
| f32ec4e | https://github.com/microsoft/TypeScript/pull/39770/commits/f32ec4ef39ec75238826fdee73db051d55d2806c |
|
| https://github.com/sandersn |
| forbid expando missing namespaces on aliases | https://github.com/microsoft/TypeScript/pull/39770/commits/e1e32af9e7f686f2cdd1dfd8e9d51fa3abeb2583 |
| e1e32af | https://github.com/microsoft/TypeScript/pull/39770/commits/e1e32af9e7f686f2cdd1dfd8e9d51fa3abeb2583 |
| #39558 | https://github.com/microsoft/TypeScript/pull/39558 |
|
| https://github.com/sandersn |
| accept error baselines that are good, actually | https://github.com/microsoft/TypeScript/pull/39770/commits/4ddb3d08c7c2a8ef1503d973d2d04360e90273d9 |
| 4ddb3d0 | https://github.com/microsoft/TypeScript/pull/39770/commits/4ddb3d08c7c2a8ef1503d973d2d04360e90273d9 |
|
| https://github.com/sandersn |
| Scribbling on d.ts emit code | https://github.com/microsoft/TypeScript/pull/39770/commits/58a0b651b00876e0a854f24c29a3fb4f86e0353e |
| 58a0b65 | https://github.com/microsoft/TypeScript/pull/39770/commits/58a0b651b00876e0a854f24c29a3fb4f86e0353e |
|
| https://github.com/sandersn |
| use getSpecifierForModuleSymbol | https://github.com/microsoft/TypeScript/pull/39770/commits/d885b67acb8cadffbb40313124afa2a635a94d94 |
| d885b67 | https://github.com/microsoft/TypeScript/pull/39770/commits/d885b67acb8cadffbb40313124afa2a635a94d94 |
|
| https://github.com/sandersn |
| hideous hack for module.exports of aliases | https://github.com/microsoft/TypeScript/pull/39770/commits/5a0b092e4f8ee9beb46c779764a8d9d0fcddd0d6 |
| 5a0b092 | https://github.com/microsoft/TypeScript/pull/39770/commits/5a0b092e4f8ee9beb46c779764a8d9d0fcddd0d6 |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/64c8c8662c8297b54fe3835ea755f6e144729952 |
| 64c8c86 | https://github.com/microsoft/TypeScript/pull/39770/commits/64c8c8662c8297b54fe3835ea755f6e144729952 |
|
| https://github.com/sandersn |
| Fix module.exports.x --> export list emit | https://github.com/microsoft/TypeScript/pull/39770/commits/55a13b76364bd941715d24c632af746743480f67 |
| 55a13b7 | https://github.com/microsoft/TypeScript/pull/39770/commits/55a13b76364bd941715d24c632af746743480f67 |
|
| https://github.com/sandersn |
| fix isLocalImport predicate | https://github.com/microsoft/TypeScript/pull/39770/commits/7ce7c8cc7bedf952744d7347a7a99537f736a8e4 |
| 7ce7c8c | https://github.com/microsoft/TypeScript/pull/39770/commits/7ce7c8cc7bedf952744d7347a7a99537f736a8e4 |
|
| https://github.com/sandersn |
| require only creates aliases in JS | https://github.com/microsoft/TypeScript/pull/39770/commits/ca5a57bd7aaf480ff916155331486dc6c55faaf8 |
| ca5a57b | https://github.com/microsoft/TypeScript/pull/39770/commits/ca5a57bd7aaf480ff916155331486dc6c55faaf8 |
|
| https://github.com/sandersn |
| re-handle json imports | https://github.com/microsoft/TypeScript/pull/39770/commits/e9a355de57283d8e0bbd22043c4383edd7a5df52 |
| e9a355d | https://github.com/microsoft/TypeScript/pull/39770/commits/e9a355de57283d8e0bbd22043c4383edd7a5df52 |
|
| https://github.com/sandersn |
| update fourslash baseline | https://github.com/microsoft/TypeScript/pull/39770/commits/febcf0e326d716982ed499ea3bf0856d5a24ef2b |
| febcf0e | https://github.com/microsoft/TypeScript/pull/39770/commits/febcf0e326d716982ed499ea3bf0856d5a24ef2b |
|
| https://github.com/sandersn |
| Cleanup in the checker | https://github.com/microsoft/TypeScript/pull/39770/commits/3ee9b6fe18388c8df296fff107df86e82ad98aa1 |
| 3ee9b6f | https://github.com/microsoft/TypeScript/pull/39770/commits/3ee9b6fe18388c8df296fff107df86e82ad98aa1 |
|
| https://github.com/sandersn |
| Function for getting module name from require call | https://github.com/microsoft/TypeScript/pull/39770/commits/a671b454f4c86dd0aa65a695d8203e7ac39e30bc |
| a671b45 | https://github.com/microsoft/TypeScript/pull/39770/commits/a671b454f4c86dd0aa65a695d8203e7ac39e30bc |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/6dfbec3581878df4bf6cc09a013fb504f1706348 |
| 6dfbec3 | https://github.com/microsoft/TypeScript/pull/39770/commits/6dfbec3581878df4bf6cc09a013fb504f1706348 |
|
| https://github.com/sandersn |
| First round of cleanup plus a new test | https://github.com/microsoft/TypeScript/pull/39770/commits/0c922773a779dd6320dc8982e83fad91f900b9d6 |
| 0c92277 | https://github.com/microsoft/TypeScript/pull/39770/commits/0c922773a779dd6320dc8982e83fad91f900b9d6 |
|
| https://github.com/sandersn |
| more small cleanup | https://github.com/microsoft/TypeScript/pull/39770/commits/dee056103bd760c3343ec30264890b785fbd7c7b |
| dee0561 | https://github.com/microsoft/TypeScript/pull/39770/commits/dee056103bd760c3343ec30264890b785fbd7c7b |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#event-3590997774 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#event-3590997816 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Jul 27, 2020
| https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-456010124 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r461068753 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r461068971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r461073618 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/dee056103bd760c3343ec30264890b785fbd7c7b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jul 27, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r461074029 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Eli Barzilay (elibarzilay) | https://github.com/elibarzilay |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| July 27, 2020 18:08 | https://github.com/microsoft/TypeScript/pull/39770#event-3591042270 |
| https://github.com/elibarzilay |
| Eli Barzilay (elibarzilay) | https://github.com/elibarzilay |
|
Aug 4, 2020
| https://github.com/microsoft/TypeScript/pull/39770#ref-issue-497638002 |
|
jsdoc @enum with import/export
#33575
| https://github.com/microsoft/TypeScript/issues/33575 |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/0694890011d5e117e662c3e7951b66601421d994 |
| 0694890 | https://github.com/microsoft/TypeScript/pull/39770/commits/0694890011d5e117e662c3e7951b66601421d994 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 11, 2020 | https://github.com/microsoft/TypeScript/pull/39770#issuecomment-672050646 |
| #39818 | https://github.com/microsoft/TypeScript/pull/39818 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 11, 2020
| https://github.com/microsoft/TypeScript/pull/39770#ref-issue-672479038 |
|
Go to definition shows Node require statement as definition
#39895
| https://github.com/microsoft/TypeScript/issues/39895 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 11, 2020 10:19 | https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-781bec2 |
|
| https://github.com/sandersn |
| Code review comments, plus remove unneeded code | https://github.com/microsoft/TypeScript/pull/39770/commits/781bec2c6a9c429079ebc32a90ebf41ac328ea8d |
| 781bec2 | https://github.com/microsoft/TypeScript/pull/39770/commits/781bec2c6a9c429079ebc32a90ebf41ac328ea8d |
|
| https://github.com/sandersn |
| find all refs works | https://github.com/microsoft/TypeScript/pull/39770/commits/2bfeeebb668f9bd108a9b7104c88b7bd76c1a26a |
| 2bfeeeb | https://github.com/microsoft/TypeScript/pull/39770/commits/2bfeeebb668f9bd108a9b7104c88b7bd76c1a26a |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/0ba0d90da682f58a729e153ec8c5c8e7e10d8859 |
| 0ba0d90 | https://github.com/microsoft/TypeScript/pull/39770/commits/0ba0d90da682f58a729e153ec8c5c8e7e10d8859 |
|
| https://github.com/sandersn |
| remove old ad-hoc code | https://github.com/microsoft/TypeScript/pull/39770/commits/62e5b18749e8e85e4a59c5d16840ae6258a3b496 |
| 62e5b18 | https://github.com/microsoft/TypeScript/pull/39770/commits/62e5b18749e8e85e4a59c5d16840ae6258a3b496 |
|
| https://github.com/sandersn |
| make it clear that old behaviour is not that correct | https://github.com/microsoft/TypeScript/pull/39770/commits/2679b03609d080cab5b33ac437868449730a5add |
| 2679b03 | https://github.com/microsoft/TypeScript/pull/39770/commits/2679b03609d080cab5b33ac437868449730a5add |
|
| https://github.com/sandersn |
| update api baselines | https://github.com/microsoft/TypeScript/pull/39770/commits/03fb2d4f62d4148160663a66f861c635644b300a |
| 03fb2d4 | https://github.com/microsoft/TypeScript/pull/39770/commits/03fb2d4f62d4148160663a66f861c635644b300a |
|
| https://github.com/sandersn |
| remove outdated comment | https://github.com/microsoft/TypeScript/pull/39770/commits/7aeb306be64fa95523d3059a1ead00987f0750aa |
| 7aeb306 | https://github.com/microsoft/TypeScript/pull/39770/commits/7aeb306be64fa95523d3059a1ead00987f0750aa |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 13, 2020
| https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-466950319 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r470093393 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/services/goToDefinition.ts | https://github.com/microsoft/TypeScript/pull/39770/files/03fb2d4f62d4148160663a66f861c635644b300a#diff-c42b4849ce43f3bc3fcbaec7e64a0cf93c78c61af0d499406a5dd295daf9a053 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r470094673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| tests/cases/fourslash/goToDefinitionJsModuleNameAtImportName.ts | https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-a9bfde6dcaf73317750b441a7cbfcb91997604e6af670a996e9b9e9da78914be |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r470101000 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#issuecomment-673598263 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Aug 13, 2020
| https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-467129498 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| https://github.com/microsoft/TypeScript/pull/39770#pullrequestreview-467129498 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r470252869 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#discussion_r470254248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/d2c0b3c66af7b2c8341e67c6be8307530fa44c62 |
| d2c0b3c | https://github.com/microsoft/TypeScript/pull/39770/commits/d2c0b3c66af7b2c8341e67c6be8307530fa44c62 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 13, 2020 | https://github.com/microsoft/TypeScript/pull/39770#issuecomment-673726846 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 17, 2020 10:54 | https://github.com/microsoft/TypeScript/pull/39770#commits-pushed-9d2ce87 |
|
| https://github.com/sandersn |
| Merge branch 'master' into alias-for-require | https://github.com/microsoft/TypeScript/pull/39770/commits/9d2ce87bdcb7371904a06fb9e404d9d92ec58641 |
| 9d2ce87 | https://github.com/microsoft/TypeScript/pull/39770/commits/9d2ce87bdcb7371904a06fb9e404d9d92ec58641 |
|
| https://github.com/sandersn |
| PR feedback | https://github.com/microsoft/TypeScript/pull/39770/commits/283a520f197256be06996a3a202a76de4f6b7706 |
| 283a520 | https://github.com/microsoft/TypeScript/pull/39770/commits/283a520f197256be06996a3a202a76de4f6b7706 |
|
| https://github.com/sandersn |
| add a fail-case test (which passes!) | https://github.com/microsoft/TypeScript/pull/39770/commits/6c7897e4d227ce492dedd2e7966d7d7a1aac18b5 |
| 6c7897e | https://github.com/microsoft/TypeScript/pull/39770/commits/6c7897e4d227ce492dedd2e7966d7d7a1aac18b5 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| c3d41bb | https://github.com/microsoft/TypeScript/commit/c3d41bbb735f1103352a92a0c0159f46055219c3 |
| Aug 17, 2020 | https://github.com/microsoft/TypeScript/pull/39770#event-3663601338 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 17, 2020 21:00 | https://github.com/microsoft/TypeScript/pull/39770#event-3663601659 |
|
JSDOC @type tag crashes with simple export
#36830
| https://github.com/microsoft/TypeScript/issues/36830 |
|
Stop an infinite loop when using an exported JSDoc function as a type
#38332
| https://github.com/microsoft/TypeScript/pull/38332 |
| https://github.com/JoostK |
| Joost Koehoorn (JoostK) | https://github.com/JoostK |
|
Nov 6, 2020
| https://github.com/microsoft/TypeScript/pull/39770#ref-pullrequest-736530507 |
|
Support TypeScript 4.1
angular/angular#39571
| https://github.com/angular/angular/pull/39571 |
| https://github.com/a-tarasyuk |
| Oleksandr Tarasiuk (a-tarasyuk) | https://github.com/a-tarasyuk |
|
Nov 24, 2020
| https://github.com/microsoft/TypeScript/pull/39770#ref-issue-748101438 |
|
TS >=4.1: Cannot assign because it is not a variable (require does not work with let anymore)
#41628
| https://github.com/microsoft/TypeScript/issues/41628 |
|
TS 4.1.2 Cannot find name 'FieldValue' (solved in 4.2)
#41629
| https://github.com/microsoft/TypeScript/issues/41629 |
|
[JS] accessing nested namespaces from require() with destructuring leads to an error
#41699
| https://github.com/microsoft/TypeScript/issues/41699 |
|
const/let variables with require() initializer are not correctly block-scoped
#41697
| https://github.com/microsoft/TypeScript/issues/41697 |
| https://github.com/Derugon |
| Adrien LESÉNÉCHAL (Derugon) | https://github.com/Derugon |
|
Apr 4, 2025
| https://github.com/microsoft/TypeScript/pull/39770#ref-issue-2971816849 |
|
JavaScript file: Shadowing require still behaves like the global one
#61528
| https://github.com/microsoft/TypeScript/issues/61528 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/39770#event-20417003807 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39770 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/39770/files/7aeb306be64fa95523d3059a1ead00987f0750aa |
|
| https://github.com/elibarzilay |
|
Eli Barzilay (elibarzilay)
| https://github.com/elibarzilay |
|
| https://github.com/microsoft/TypeScript/pull/39770/files/a841988281a375281d5b93c5997e2b0403e60862 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Backlog Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
In JS, assertions imported via commonjs have bogus error
| https://github.com/microsoft/TypeScript/issues/38379 |
|
JS binding should create real aliases for module.exports
| https://github.com/microsoft/TypeScript/issues/37000 |
|
const x = require("m") should create an alias symbol
| https://github.com/microsoft/TypeScript/issues/25533 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/39770 |
|
| https://github.com/sandersn |
|
| https://github.com/elibarzilay |
|
| https://github.com/weswigham |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |