René's URL Explorer Experiment


Title: Disallow merging for default export declarations by DanielRosenwasser · Pull Request #3973 · microsoft/TypeScript · GitHub

Open Graph Title: Disallow merging for default export declarations by DanielRosenwasser · Pull Request #3973 · microsoft/TypeScript

X Title: Disallow merging for default export declarations by DanielRosenwasser · Pull Request #3973 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Disallow merging for default export declarations by DanielRosenwasser · Pull Request #3973 · microsoft/TypeScript

Open Graph Description: Fixes #3095. With this change, the following code will now cause an error: export default function Foo() { } export namespace Foo { export var x = 10; } The idea is that the namespace cannot o...

X Description: Fixes #3095. With this change, the following code will now cause an error: export default function Foo() { } export namespace Foo { export var x = 10; } The idea is that the namespace cannot o...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/3973

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eb5b661b-d7db-5f83-91d1-efecf5d8912a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85A4:2652DC:2558D3B:2F9625E:6B017A78
html-safe-nonce5b43e3b1dcd6cf8fc785c6d203b460c58dd5e0d721cf770e96923558812e7e45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUE0OjI2NTJEQzoyNTU4RDNCOjJGOTYyNUU6NkIwMTdBNzgiLCJ2aXNpdG9yX2lkIjoiODU3Nzc5ODg2NzM0NzY2NzU3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38b608c5275aee1bd760937f1f23a46b1031c168eb5fc66ca6e1a462556646e3
hovercard-subject-tagpull_request:40521619
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/3973/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c3cf3cb29dc40b3b7fa0a26ed6a962eaca99017f6caf76105e75a977122b84d/microsoft/TypeScript/pull/3973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c3cf3cb29dc40b3b7fa0a26ed6a962eaca99017f6caf76105e75a977122b84d/microsoft/TypeScript/pull/3973
og:image:altFixes #3095. With this change, the following code will now cause an error: export default function Foo() { } export namespace Foo { export var x = 10; } The idea is that the namespace cannot o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/3973#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3973
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3973
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/3973
Reloadhttps://github.com/microsoft/TypeScript/pull/3973
Reloadhttps://github.com/microsoft/TypeScript/pull/3973
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
disallowDefaultExportDeclMerginghttps://github.com/microsoft/TypeScript/tree/disallowDefaultExportDeclMerging
Conversationhttps://github.com/microsoft/TypeScript/pull/3973
Commits23 (23)https://github.com/microsoft/TypeScript/pull/3973/commits
Checkshttps://github.com/microsoft/TypeScript/pull/3973/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/3973/files
Disallow merging for default export declarationshttps://github.com/microsoft/TypeScript/pull/3973#top
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
disallowDefaultExportDeclMerginghttps://github.com/microsoft/TypeScript/tree/disallowDefaultExportDeclMerging
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 22, 2015https://github.com/microsoft/TypeScript/pull/3973#issue-96450512
#3095https://github.com/microsoft/TypeScript/issues/3095
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3973
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
July 15, 2015 17:38https://github.com/microsoft/TypeScript/pull/3973#commits-pushed-e2c1696
https://github.com/DanielRosenwasser
Added tests.https://github.com/microsoft/TypeScript/pull/3973/commits/e2c16962f3308c852918edcb125b118aa0f37160
e2c1696https://github.com/microsoft/TypeScript/pull/3973/commits/e2c16962f3308c852918edcb125b118aa0f37160
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/17593bf444f7a5b7843e71b02798008dd578c7b5
17593bfhttps://github.com/microsoft/TypeScript/pull/3973/commits/17593bf444f7a5b7843e71b02798008dd578c7b5
https://github.com/DanielRosenwasser
Removed baselines Ryan forgot to remove.https://github.com/microsoft/TypeScript/pull/3973/commits/b403da3ea22aecd722d4225b5618e24710e0ce98
b403da3https://github.com/microsoft/TypeScript/pull/3973/commits/b403da3ea22aecd722d4225b5618e24710e0ce98
https://github.com/DanielRosenwasser
Minor cleanup.https://github.com/microsoft/TypeScript/pull/3973/commits/3e2928926ecfa92e9b0f9d256b1e045a0bae2f38
3e29289https://github.com/microsoft/TypeScript/pull/3973/commits/3e2928926ecfa92e9b0f9d256b1e045a0bae2f38
https://github.com/DanielRosenwasser
Added single quotes around the declaration name in an error.https://github.com/microsoft/TypeScript/pull/3973/commits/89398e640dda9eeebe79a2e78751b10eb49c1dfd
89398e6https://github.com/microsoft/TypeScript/pull/3973/commits/89398e640dda9eeebe79a2e78751b10eb49c1dfd
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/d0fb339666c2f2c615987f40da8f55c8265dc38a
d0fb339https://github.com/microsoft/TypeScript/pull/3973/commits/d0fb339666c2f2c615987f40da8f55c8265dc38a
https://github.com/DanielRosenwasser
Renamed tests.https://github.com/microsoft/TypeScript/pull/3973/commits/90f3153eac46609f6fe5711f9201eca273548711
90f3153https://github.com/microsoft/TypeScript/pull/3973/commits/90f3153eac46609f6fe5711f9201eca273548711
https://github.com/DanielRosenwasser
Renamed/accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/a38dec0cdf7d90638e97ef0b0de3b5fa40805c9e
a38dec0https://github.com/microsoft/TypeScript/pull/3973/commits/a38dec0cdf7d90638e97ef0b0de3b5fa40805c9e
https://github.com/DanielRosenwasser
Added another test.https://github.com/microsoft/TypeScript/pull/3973/commits/f631a201403e3a6928fac4d0072f8651d5dc8601
f631a20https://github.com/microsoft/TypeScript/pull/3973/commits/f631a201403e3a6928fac4d0072f8651d5dc8601
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/7e464458f8035aba05666f639df6fb5adc6572a2
7e46445https://github.com/microsoft/TypeScript/pull/3973/commits/7e464458f8035aba05666f639df6fb5adc6572a2
https://github.com/DanielRosenwasser
Take default export spaces into account when checking merged declarat…https://github.com/microsoft/TypeScript/pull/3973/commits/8d5d73eb9191ffa25875eecabf3d922e63d484eb
8d5d73ehttps://github.com/microsoft/TypeScript/pull/3973/commits/8d5d73eb9191ffa25875eecabf3d922e63d484eb
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/be44bc651c45d31c080323b14b5f3ed77118b1b1
be44bc6https://github.com/microsoft/TypeScript/pull/3973/commits/be44bc651c45d31c080323b14b5f3ed77118b1b1
https://github.com/DanielRosenwasser
Add suggestion to error message.https://github.com/microsoft/TypeScript/pull/3973/commits/18e36b898c3904985a117cab8533241fd6bad4c7
18e36b8https://github.com/microsoft/TypeScript/pull/3973/commits/18e36b898c3904985a117cab8533241fd6bad4c7
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/beff65191f6e3a8538c4d81878a7c2454be59b4f
beff651https://github.com/microsoft/TypeScript/pull/3973/commits/beff65191f6e3a8538c4d81878a7c2454be59b4f
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jul 22, 2015https://github.com/microsoft/TypeScript/pull/3973#event-361780350
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Jul 22, 2015https://github.com/microsoft/TypeScript/pull/3973#event-361781148
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
July 22, 2015 12:01https://github.com/microsoft/TypeScript/pull/3973#commits-pushed-ae68352
https://github.com/DanielRosenwasser
Merge remote-tracking branch 'origin/master' into disallowDefaultExpo…https://github.com/microsoft/TypeScript/pull/3973/commits/ae68352805fccf57bf59cf62e174cc8abf39745d
ae68352https://github.com/microsoft/TypeScript/pull/3973/commits/ae68352805fccf57bf59cf62e174cc8abf39745d
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/0f828ca91b75b79c391aeda9c5f494d70db5937f
0f828cahttps://github.com/microsoft/TypeScript/pull/3973/commits/0f828ca91b75b79c391aeda9c5f494d70db5937f
JsonFreemanhttps://github.com/JsonFreeman
Jul 25, 2015 https://github.com/microsoft/TypeScript/pull/3973#discussion-diff-35476455
View reviewed changes https://github.com/microsoft/TypeScript/pull/3973/files/0f828ca91b75b79c391aeda9c5f494d70db5937f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/3973/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Jul 25, 2015https://github.com/microsoft/TypeScript/pull/3973#discussion_r35476455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3973
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Jul 25, 2015https://github.com/microsoft/TypeScript/pull/3973#issuecomment-124775827
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3973
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 27, 2015 https://github.com/microsoft/TypeScript/pull/3973#ref-issue-95317520
Compiler gives unhelpful error messages in the presence of multiple default exports #3886 https://github.com/microsoft/TypeScript/issues/3886
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
July 27, 2015 10:12https://github.com/microsoft/TypeScript/pull/3973#commits-pushed-cf801ef
https://github.com/DanielRosenwasser
Added test.https://github.com/microsoft/TypeScript/pull/3973/commits/cf801efb20ab0b1045350280febc297177fbfc65
cf801efhttps://github.com/microsoft/TypeScript/pull/3973/commits/cf801efb20ab0b1045350280febc297177fbfc65
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/b84e4071a543254a0c6980489eb48dc834497f00
b84e407https://github.com/microsoft/TypeScript/pull/3973/commits/b84e4071a543254a0c6980489eb48dc834497f00
https://github.com/DanielRosenwasser
Addressed CR feedback.https://github.com/microsoft/TypeScript/pull/3973/commits/bad5919fa88246556e8380aecee51c9937226800
bad5919https://github.com/microsoft/TypeScript/pull/3973/commits/bad5919fa88246556e8380aecee51c9937226800
https://github.com/DanielRosenwasser
space -> spaceshttps://github.com/microsoft/TypeScript/pull/3973/commits/a8f0491d62af9fadcb6c5ac4f6319e992febfe29
a8f0491https://github.com/microsoft/TypeScript/pull/3973/commits/a8f0491d62af9fadcb6c5ac4f6319e992febfe29
https://github.com/DanielRosenwasser
Added a test.https://github.com/microsoft/TypeScript/pull/3973/commits/92902011ce09d0059d04cf7e6a7cd804b46aa895
9290201https://github.com/microsoft/TypeScript/pull/3973/commits/92902011ce09d0059d04cf7e6a7cd804b46aa895
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
July 27, 2015 11:45https://github.com/microsoft/TypeScript/pull/3973#commits-pushed-157235f
https://github.com/DanielRosenwasser
Fixed test message.https://github.com/microsoft/TypeScript/pull/3973/commits/157235f5dab788663a78a28f1279859ea3cd69a6
157235fhttps://github.com/microsoft/TypeScript/pull/3973/commits/157235f5dab788663a78a28f1279859ea3cd69a6
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/3973/commits/28ce0a1a84eb5d46d05269e2cb0377eb91d2a755
28ce0a1https://github.com/microsoft/TypeScript/pull/3973/commits/28ce0a1a84eb5d46d05269e2cb0377eb91d2a755
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 27, 2015 https://github.com/microsoft/TypeScript/pull/3973#ref-commit-4f507a6
https://github.com/DanielRosenwasser
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/4f507a6b7e8c7f428f6b71c3880dcf24df3967ce
#3973https://github.com/microsoft/TypeScript/pull/3973
from Microsoft/disallowDefaultExportDeclMerginghttps://github.com/microsoft/TypeScript/commit/4f507a6b7e8c7f428f6b71c3880dcf24df3967ce
4f507a6https://github.com/microsoft/TypeScript/commit/4f507a6b7e8c7f428f6b71c3880dcf24df3967ce
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
4f507a6https://github.com/microsoft/TypeScript/commit/4f507a6b7e8c7f428f6b71c3880dcf24df3967ce
Jul 27, 2015https://github.com/microsoft/TypeScript/pull/3973#event-366424042
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
July 27, 2015 19:03https://github.com/microsoft/TypeScript/pull/3973#event-366424089
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/3973#event-1689607173
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3973
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3973
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3973
https://github.com/DanielRosenwasser
https://github.com/JsonFreeman
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.